Commit Graph

49 Commits

Author SHA1 Message Date
karen jirak
18f43fb971 Adding SWarningOrErrorBox styling to the error message for selecting an unusable path in the asset dialog.
#jira UE-161443
#rb lauren.barnes
#preflight 632389d70049d467abc4da86

[CL 22038911 by karen jirak in ue5-main branch]
2022-09-15 17:28:30 -04:00
robert millar
5516f8d0d4 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for editor support classes for content browser code.

#jira UE-161932
#rb jason.stasik,jamie.dale
#preflight 631bd2a0d31788ea3ac03570

[CL 21935588 by robert millar in ue5-main branch]
2022-09-10 00:02:37 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Matt Kuhlenschmidt
aef1e008b4 Fix up use cases of specifying "PrimaryButton" style directly. Replaced instances with SPrimaryButton
#preflight 612d40b9423a8f00013c5b92

[CL 17457077 by Matt Kuhlenschmidt in ue5-main branch]
2021-09-08 08:29:01 -04:00
aurel cordonnier
dc856801cd Merge from Release-Engine-Test @ 17059716 to UE5/Main
This represents UE4/Main @ 17030256 and Dev-PerfTest @ 17029914

[CL 17060422 by aurel cordonnier in ue5-main branch]
2021-08-04 17:46:20 -04:00
aurel cordonnier
e0ad4e25df Merge from Release-Engine-Test @ 16624776 to UE5/Main
This represents UE4/Main @ 16579691 and Dev-PerfTest @ 16579576

[CL 16625248 by aurel cordonnier in ue5-main branch]
2021-06-10 13:13:24 -04:00
aurel cordonnier
8eebe8841f Merge UE5/RET @ 16305968 to UE5/Main
This represents UE4/Main @ 16261013 and Dev-PerfTest @ 16259937

[CL 16306996 by aurel cordonnier in ue5-main branch]
2021-05-12 18:10:03 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
Tim Smith
4c3942091b Fixing PVS 7.7 Issues:
warning V547: Expression 'XYZ' is always true/false.

#rb trivial
#jira UE-91644

[CL 15054368 by Tim Smith in ue5-main branch]
2021-01-12 16:15:34 -04:00
geoff evans
0fad8a1a6d Batch up dispatch of files and folders to Explorer/Finder/File Manager into groups of 10
Unify ContentBrowser "Explore" / "Show in Explorer" logic across several user endpoints

#jira UETOOL-2325
#rb brandon.schaefer,francis.hurteau

[CL 14423933 by geoff evans in ue5-main branch]
2020-10-05 16:10:14 -04:00
Matt Kuhlenschmidt
0d3c28f946 Fix up save layout dialog. Updated styles and cut off buttons
[CL 14110182 by Matt Kuhlenschmidt in ue5-main branch]
2020-08-13 21:18:57 -04:00
Louise Rasmussen
7d5ba11734 Updated AssetPicker and Save Dialogs
#rb matt.kuhlenschmidt

[CL 13983635 by Louise Rasmussen in ue5-main branch]
2020-07-30 19:42:24 -04:00
daren cheng
5cc5ce7e53 Fix save file dialog clipping.
#jira UE-94492
#rb brooke.hubert, matt.kuhlenschmidt, louise.rasmussen

[CL 13869734 by daren cheng in ue5-main branch]
2020-07-15 20:43:37 -04:00
daren cheng
ecc59df111 Fix save file dialog clipping.
#jira UE-94492
#rb brooke.hubert, matt.kuhlenschmidt, louise.rasmussen

[CL 13866794 by daren cheng in ue5-main branch]
2020-07-15 16:38:54 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
Chris Gagnon
346a4b05ea Copy up from Dev-Editor @10681378
#rb none

[CL 10837446 by Chris Gagnon in Dev-Tools-Staging branch]
2019-12-19 18:07:47 -05:00
sebastien lussier
d40f39241b #jira UE-84316
Crash overriding merge destination with asset of different type
#rb patrick.enfedaque

#ROBOMERGE-SOURCE: CL 10198862 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v588-10112492)

[CL 10198887 by sebastien lussier in Main branch]
2019-11-14 10:38:32 -05:00
simon tourangeau
5ecedcab2d Path Selection Window
When user selects target path for exporting or saving, we need to refresh content from server. So we add OnPathSelected event to FSharedAssetDialogConfig and SAssetDialog.
Changed files: IContentBrowserSingleton.h, SAssetDialog.h, SAssetDialog.cpp.

GPumpingMessages
When files and folders are deleted or created by user, we want to save these changes to server. So we monitor such changes through IAssetRegistry. But we need to determine whether it�s triggered by user. So we add GPumpingMessages, a global flag indicating that application is processing Windows messages. Which means it�s triggered by user input.
Another possible choice is adding delegates. But this requires more changes and is less general.
Changed files: CoreGlobals.h, CoreGlobals.cpp, WindowsPlatformApplicationMisc.cpp.

Mesh Editor Small Fix
Fix an issue where vertex colors in Toolbar didn't work in 4.22.
Changed file is SStaticMeshEditorViewport.cpp.

#jira UE-78897

PR #6121: Editor changes for NVIDIA USD plugin

#rb chris.gagnon
#lockdown nick.penwarden

#ROBOMERGE-SOURCE: CL 8042071 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v399-8035122)

[CL 8042138 by simon tourangeau in Main branch]
2019-08-14 16:18:58 -04:00
Chris Gagnon
1dd3e0189f Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
#rb none

[CL 4730305 by Chris Gagnon in Dev-Editor branch]
2019-01-15 18:47:22 -05:00
Matt Kuhlenschmidt
27eb482873 Changed the current implementation of FindWidgetWindow as it is generally unsafe to call when arranging slate widgets would be illegal (modal dialogs, other threads). GeneratePathToWidget can still be used to get the parent window and the full path.
FindWidgetWindow no longer returns a path and uses parent pointers to find the parent window safely and more efficently.

#rb chris.gagnon, nick.darnell

[CL 4680301 by Matt Kuhlenschmidt in Dev-Editor branch]
2019-01-03 18:03:41 -05:00