Commit Graph

30 Commits

Author SHA1 Message Date
patrick enfedaque
ff9b96647f Uncontrolled Changelist: Optimization
- OnStateChanged sets a dirty flag, SaveState is performed on End of frame if needed.

#rb luc.eygasier, richard.malo
#preflight 63457ad3e76c1171e7f1a5a3
#rnx

[CL 22467213 by patrick enfedaque in ue5-main branch]
2022-10-11 18:30:44 -04:00
rex hill
dde95823ae Add insights scope to a function that requires optimization
#preflight skip

[CL 22424987 by rex hill in ue5-main branch]
2022-10-09 23:37:46 -04:00
patrick enfedaque
377869bfc1 Uncontrolled Changelist: deleted files support
- Deleted files will show up in the Uncontrolled Changelists when a Source Control provider is selected
- Deleted files won't show up if SCC is disabled but will still be tracked in case SCC is renabled

#jira UE-164493
#rb luc.eygasier
#preflight 633af0bcba39998ce83121b4

[CL 22322389 by patrick enfedaque in ue5-main branch]
2022-10-03 20:43:35 -04:00
patrick enfedaque
4e1dff0b87 Fix unsaved writable files appearing in Uncontrolled Changelist
- Files are now added to the reconcile list when marked writable
- They are later on added to the UC when they are saved (if they still are not checked out)

#rb luc.eygasier
#preflight 6336cfa7c37844870a040e20

[CL 22272829 by patrick enfedaque in ue5-main branch]
2022-09-30 12:24:14 -04:00
rex hill
fd010712d1 Fix UncontrolledChangelists warnings seen for cooked assets
#preflight 6331c24e0d6a7155ba356e3b
#rb luc.eygasier

[CL 22203037 by rex hill in ue5-main branch]
2022-09-27 06:54:18 -04:00
luc eygasier
abfd119ea2 Enabled Uncontrolled Changelists by default.
Adds setting to disable uncontrolled changelists.

#rb Patrick.Laflamme
#jira UE-163064
#preflight 6328649b8c3def91aa6d9576
#changelist validated

[CL 22086935 by luc eygasier in ue5-main branch]
2022-09-19 21:54:38 -04:00
luc eygasier
96f1950f5a Adds new uncontrolled changelist option to "Move Files To..." dialog.
#preflight 63284d978131e92d659351bf
#rb Patrick.Laflamme

#changelist validated

[CL 22084693 by luc eygasier in ue5-main branch]
2022-09-19 19:50:22 -04:00
luc eygasier
92a1bc7f30 Adds support for multiple uncontrolled changelists
* Add creation of new uncontrolled changelists
* Add modification of uncontrolled changelists description
* Add uncontrolled changelists deletion

#preflight 6318ebec980179553e9254aa
#jira UE-163065
#rb Patrick.Laflamme

[CL 21892780 by luc eygasier in ue5-main branch]
2022-09-08 09:19:01 -04:00
luc eygasier
1dcadd2e97 Moves FUncontrolledChangelist::Name to FUncontrolledChangelistState::Description.
#rb Patrick.Laflamme
#preflight 6318ac73f448dc6e585d5fbd
#jira UE-163065

[CL 21864892 by luc eygasier in ue5-main branch]
2022-09-07 18:11:16 -04:00
luc eygasier
c4dec1008a Adds Source Control File Dialog.
Displays source control file dialog when checkouting files is impossible during conversion from Uncontrolled Changelist to Changelist.

#preflight 630f740ce352708d444276e0
#rb Patrick.Laflamme

[CL 21727336 by luc eygasier in ue5-main branch]
2022-08-31 16:14:08 -04:00
luc eygasier
0cda7fc8ed Modifies revert operations in source control window to also reload packages.
Adds Source Control Helper method to perform a modular source control operation and reload the concerned packages

#rb Patrick.Enfedaque
#preflight 62fd4e63e64b1a510937890b
#changelist validated

[CL 21444877 by luc eygasier in ue5-main branch]
2022-08-18 13:03:11 -04:00
patrick enfedaque
74fd7a10b8 Uncontrolled Changelist: Make sure background task is completed on module shutdown
#jira UE-160847
#rb richard.malo, jeanfrancois.dube
#preflight 62f68bca185b21882a9438d3

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 21359248 via CL 21359468 via CL 21359507
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21362286 by patrick enfedaque in ue5-main branch]
2022-08-12 15:52:47 -04:00
luc eygasier
f431296a8a Changes reverting UncontrolledChangelist new assets to also delete them.
#rb Patrick.Enfedaque
#preflight 62f56afaad3bd8ad642e2a79

#ROBOMERGE-AUTHOR: luc.eygasier
#ROBOMERGE-SOURCE: CL 21354458 via CL 21354491 via CL 21354503
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21356205 by luc eygasier in ue5-main branch]
2022-08-12 11:43:42 -04:00
patrick enfedaque
b1948f9827 Uncontrolled Changelist: Filter out /Tmp assets + Procedural/Auto saves
#rb jeanfrancois.dube, luc.eygasier
#preflight 62f53a8cb66d5d9313a35714

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 21342544 via CL 21342580 via CL 21342599
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21345594 by patrick enfedaque in ue5-main branch]
2022-08-11 17:19:27 -04:00
patrick enfedaque
29c089706b Uncontrolled Changelist
-Startup scan is now a background task (Saves 1min15 editor startup time on projects with lots of assets)
-Wait on startup task with dialog on reconcile if it isn't finished
-Don't allow changing module enabled state past startup (CVar read at startup only)

#rb richard.malo, jeanfrancois.dube
#preflight 62f4eeb5b66d5d9313960f4e

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 21338280 via CL 21339224 via CL 21339734
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21341653 by patrick enfedaque in ue5-main branch]
2022-08-11 14:46:56 -04:00
bob tellez
4242d39647 #UE Add an IsEnabled check before doing very expensive GetAssets call during startup in UncontrolledChangelistsModule
[FYI] luc.eygasier

#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 21332948 via CL 21332954 via CL 21332959
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21333089 by bob tellez in ue5-main branch]
2022-08-11 01:55:37 -04:00
luc eygasier
4d284a4bc9 Fixes adding newfiles to Uncontrolled Changelist offline mode when Source Control is disabled.
Fixes Deleted new assets staying in Uncontrolled Changelist.

#rb Patrick.Enfedaque
#preflight 62d9608f3122bf80aefecd30

#changelist validated

#ROBOMERGE-AUTHOR: luc.eygasier
#ROBOMERGE-SOURCE: CL 21267809 via CL 21267821 via CL 21267830
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21269698 by luc eygasier in ue5-main branch]
2022-08-08 11:50:31 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
luc eygasier
5395c37c90 Adds mark for delete files support for Uncontrolled Changelist
#rb JeanFrancois.Dube
#jira UE-140467
#preflight 61f93d89c54b18c42dd34922

#changelist validated

#ROBOMERGE-AUTHOR: luc.eygasier
#ROBOMERGE-SOURCE: CL 18807689 in //UE5/Release-5.0/... via CL 18809249 via CL 18822255
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823271 by luc eygasier in ue5-main branch]
2022-02-02 05:30:58 -05:00
matija kecman
c77447d771 UnrealEd: Fix warning complaining about GetLocalFullPath being called on FPackagePath with an unspecified header extension for a path that does not exist on disk. Partially addresses jira UE-137902
Warnings were generated when converting brushes to static meshes, creating geometry collections from static meshes in fracture mode and one instance also occured while loading assets on QAGame startup

#rnx
#rb matt.peters, luc.eygasier
#jira UE-137902
#preflight 61ee7d55ef289ffc6ddfd1ed

#ROBOMERGE-AUTHOR: matija.kecman
#ROBOMERGE-SOURCE: CL 18706982 in //UE5/Release-5.0/... via CL 18706989 via CL 18707053
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18707056 by matija kecman in ue5-main branch]
2022-01-24 06:32:49 -05:00
luc eygasier
947fa7bf12 Prevent saved file to be added to PackagesNotToPromptAnyMore when added to UncontrolledChangelist.
Allows save window to be displayed again if a file is reverted in UncontrolledChangelist.

#jira UE-136350
#rb Sebastien.Lussier
#robomerge Release-5.0

#changelist validated

[CL 18431729 by luc eygasier in ue5-main branch]
2021-12-10 12:39:11 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
luc eygasier
6b48cf46da Removes abusive Uncontrolled Changelist warning. Replaced by display log when loading performed as expected.
#rb Sebastien.Lussier
#jira UE-131858, UE-131040

#changelist validated

#ROBOMERGE-AUTHOR: luc.eygasier
#ROBOMERGE-SOURCE: CL 17884337 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v883-17842818)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0

[CL 17884356 by luc eygasier in ue5-release-engine-test branch]
2021-10-21 09:53:24 -04:00
luc eygasier
9f354adce4 Use AssetRegistry to add writable files to Reconcile cache.
Adds UncontrolledChangelistValidator, reconciling writable assets, warning the user if new uncontrolled changes are found during changelist validation

#rb Sebastien.Lussier
#preflight 60d0965a367e6700013a0083

#changelist validated

#ROBOMERGE-SOURCE: CL 16728469 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16728483 by luc eygasier in ue5-release-engine-test branch]
2021-06-21 11:05:22 -04:00