Commit Graph

26 Commits

Author SHA1 Message Date
bryan sefcik
0beee50b45 Updated ../Engine/Source/Developer/... to inline gen.cpp files
Before:
Total CPU Time: 53783.640625 s
Total time in Parallel executor: 558.66 seconds
After:
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

#jira

[CL 22173145 by bryan sefcik in ue5-main branch]
2022-09-24 13:31:25 -04:00
sara schvartzman
a1bb1a3ecb Control Rig: Once a pin of a template node is resolved, it will add a preferred type
#jira UE-162227
#rb benoit.gadreau
#preflight 6317346e7b21ad1e0a144b72

[CL 21818154 by sara schvartzman in ue5-main branch]
2022-09-06 11:24:29 -04:00
jack cai
70bc5b69f4 RigVMRegistry: Added support for user defined type addition and removal
Important notes:
1. We should now use TypeUtils::GetUniqueStructName  instead of struct->getstructcppname for type names used by the registry since user defined struct need to have unique names generated for them

2. We should be aware that we can have invalid permutations in templates when types are deleted, so make sure you check for typeindex != INDEX_NONE when looping over permutations

#jira UE-152930
#rb Sara.schvartzman, Benoit.gadreau, Halfdan.Ingvarsson
#preflight https://horde.devtools.epicgames.com/job/6310c6992a5406d810d5a0e8

[CL 21754534 by jack cai in ue5-main branch]
2022-09-01 23:33:24 -04:00
sara schvartzman
a2cc0342af Control Rig: Fix crash when collapsing to function
#jira UE-161884
#rb jack.cai, benoit.gadreau
#preflight 630791f0db333fb7699d36d9

[CL 21590323 by sara schvartzman in ue5-main branch]
2022-08-26 11:02:53 -04:00
sara schvartzman
50bd048f4a Control Rig: Fix deprecated template permutations loading correctly
#rb jack.cai
#preflight 6304a9db0061f895d012388b

[CL 21512202 by sara schvartzman in ue5-main branch]
2022-08-23 13:08:34 -04:00
sara schvartzman
759ade463a Control Rig: Adding aggregates for template nodes
#jira UE-147512
#rb helge.mathee
#preflight 62d459d499514be7eb2920a4

[CL 21143858 by sara schvartzman in ue5-main branch]
2022-07-18 04:44:55 -04:00
sara schvartzman
eec59437e9 Control Rig: Collapse nodes with templates
#jira UE-146929
#rb helge.mathee
#preflight 62ced5dbd00f3c208e47c183

[CL 21089290 by sara schvartzman in ue5-main branch]
2022-07-14 06:53:37 -04:00
Helge Mathee
8b0318e6bc RigVM: Dispatch Factory Support
* Moved TypeIndex from int32 to typedef for easier debugging
* Implemented Dispatch Factory
* Factories stored under registry
* FindFunction to invoke dispatch
* Runtime Type checking on the memory handle
* Implemented dispatch rigvm node
* Unit testing for numeric add test both for low level + controller layer

#rb sara.schvartzman
#jira UE-157794
#preflight https://horde.devtools.epicgames.com/job/62c4541b2f31b87c6c89360a

[CL 20942948 by Helge Mathee in ue5-main branch]
2022-07-05 11:39:15 -04:00
Helge Mathee
3d20407084 RigVM: Refactor template type system to rely on integers rather than string comparisons
* Switching the FRigVMTemplateArgumentType to be backed up by FName instead of FString for faster comparison
* Adding a "Types" storage under the RigVMRegistry of all of the known supported types
* Have the FRigVMTemplateArgument refer to type indices rather than full type structures
* Have the resolval comparison code rely on comparing type indices rather than type structures
* Store relationship between the bool and the TArray<bool> type as an array / element lookup within the registry - to avoid string operations when doing lookups from element to array to 2 dimensional array for a type.
* The preferred types list on the template node is now stored as pairs of argument name and type index <FName, int32> rather than FString.
* Also we no longer support all types for the untyped nodes (such as reroute, select, if etc) - but instead we support all user defined types (non-native structs and enums) as well as all types ever used as a template argument. The reasoning here is that supporting a type that's not used by any node is pointless. This reduced the type set from 9876 to 237.

#rb halfdan.ingvarsson
#jira na
#preflight https://horde.devtools.epicgames.com/job/62b9c666ba62f4498a345be2

[CL 20861728 by Helge Mathee in ue5-main branch]
2022-06-28 13:41:23 -04:00
Helge Mathee
555783edcb Control Rig / RigVM: Improve asset loading performance
- Overall Loading time went from 21.439 seconds to 7.521 seconds
 - Improved Postload from 6.643 seconds to 0.915 seconds
 - Improved InitControlRigEditor from 13.422 seconds to 4.842 seconds

#jira UE-155783
#rb benoit.gadreau
#preflight https://horde.devtools.epicgames.com/job/62b2fe202c753858830d4b11

[CL 20773015 by Helge Mathee in ue5-main branch]
2022-06-22 08:37:48 -04:00
Helge Mathee
36d23803d4 RigVM: Allow access to custom widget also on template pins + use quotes correctly for template default arguments
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/62a1a7542875eb3c61751609

[CL 20573126 by Helge Mathee in ue5-main branch]
2022-06-09 05:58:28 -04:00
sara schvartzman
4f7e433c98 Control Rig: Change FRigVMTemplate to USTRUCT
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629f59a2233ae0a8f8f6bc99

[CL 20538399 by sara schvartzman in ue5-main branch]
2022-06-07 11:01:59 -04:00
sara schvartzman
936679001d Control Rig: Fix some templates not resolving
#jira UE-155584 UE-155585
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629e151d5d78bd7cf191426b

[CL 20534522 by sara schvartzman in ue5-main branch]
2022-06-07 04:43:09 -04:00
sara schvartzman
6c0d38da89 Control Rig: Performance improvements on template nodes
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6283a58a730e8423d1256bf5

[CL 20258899 by sara schvartzman in ue5-main branch]
2022-05-18 06:43:26 -04:00
sara schvartzman
1bce442c08 Control Rig: Fix hanging of editor when adding/breaking links
#jira UE-151849
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627e3843830b40b66830915e

[CL 20179303 by sara schvartzman in ue5-main branch]
2022-05-13 07:10:24 -04:00
sara schvartzman
f7578148a8 Control Rig: Test recompute all filtered permutations on templates
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627b8348b60dee4a43a104f9

[CL 20135765 by sara schvartzman in ue5-main branch]
2022-05-11 05:46:12 -04:00
sara schvartzman
7b95068ced Control Rig: Fix recompute filtered permutations from links
#jira UE-151485
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627a6684fc07e0a9b4feb804

[CL 20122135 by sara schvartzman in ue5-main branch]
2022-05-10 09:29:27 -04:00
sara schvartzman
3c79ac0833 Control Rig: Fix crash when opening certain rigs
#jira UE-151396
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62794bba822bdc69f023d4ff

[CL 20106925 by sara schvartzman in ue5-main branch]
2022-05-09 14:13:48 -04:00
sara schvartzman
ed571628f5 Control Rig: Filtered permutations for template nodes
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62769cbe75268b4ace10dc69

[CL 20101111 by sara schvartzman in ue5-main branch]
2022-05-09 07:34:28 -04:00
sara schvartzman
f15b37dbb1 RigVM: If, select and array nodes to inherit template node
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6260454fde50cd99bbaf6781

[CL 19848071 by sara schvartzman in ue5-main branch]
2022-04-21 09:10:19 -04:00
Helge Mathee
fcb5444cf0 RigVM: Allow template arguments to support both array and single values if needed
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/625ff6da35680893eef3bdf1

[CL 19830136 by Helge Mathee in ue5-main branch]
2022-04-20 10:28:28 -04:00
Helge Mathee
324bb1ec00 RigVM: Reroute to inherit template node
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/625fc59035680893eee448a1

[CL 19826939 by Helge Mathee in ue5-main branch]
2022-04-20 05:02:39 -04:00
Helge Mathee
1475be6205 RigVM: Change inheritance order - make UnitNode inherit from TemplateNode
Also implement a way to register external / auxiliary templates to the registry + unit test

#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/625847a0946114248dbaa7d9

[CL 19806894 by Helge Mathee in ue5-main branch]
2022-04-19 08:39:16 -04:00
Helge Mathee
f2e78ce183 Control Rig: Allow display name for pins on template nodes
#rb benoit.gadreau
#jira UE-146002
#preflight https://horde.devtools.epicgames.com/job/62330e3a7b5cb40768aa66e9

[CL 19418897 by Helge Mathee in ue5-main branch]
2022-03-17 07:20:36 -04:00
Helge Mathee
63e119a364 Control Rig: Further template node workflows
Implemented unresolve as well as re-resolve node on already typed pins
Added UI in contextual menu to re-type pins

#rb sara.schvartzman
#jira UE-125892
#preflight https://horde.devtools.epicgames.com/job/622f488f505788e09ffffbe4

[CL 19372564 by Helge Mathee in ue5-main branch]
2022-03-14 10:19:31 -04:00