Commit Graph

144 Commits

Author SHA1 Message Date
nick darnell
9e765542af Editor - Fixing an ASan bug in the category paths, need to declare them statically so that the compiler doesn't free the list too early.
Editor - Upgrading the Texture AssetTypeActions to be AssetDefinitions.

#jira UE-169989
#jira UE-165574

[CL 23121796 by nick darnell in ue5-main branch]
2022-11-14 13:18:14 -05:00
nick darnell
e85b0cd48c AssetDefinition - This is the seed of a long term replacement of IAssetTypeActions. IAssetTypeActions is woefully inadiquit now. It puts a lot of functionality in one place, which wouldn't be a terrible thing, except for the GetActions, and some of the menu stuff being built into this class. We need to make an effort to not have to load every single asset just to open the context menu you have selected, to-wit, a previous CL made it so that summoning the menu no longer *Had* to load the assets, however several remaining issues remained with the Blueprint Utility Actions, and the fact that we don't "KNOW" if we need to call GetActions for an asset. We could introduce a replacement in the class, but that would just get inherited, causing other issues. So instead the parallel UObject based AssetDefinition now exists. In large part it will probably be very similar to the other one, but several things in it probably need to chnage. For now there is a bridging concept in the form of the AssetDefinitionAssetTypeProxy.
Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.

AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.

#jira UE-165574
#preflight 636c0ec4d0174259cca85e37

[CL 23083536 by nick darnell in ue5-main branch]
2022-11-10 13:13:41 -05:00
bob tellez
635e0d776e [Backout] - CL23068129 and 23069638
[FYI] Nick.Darnell
Original CL Desc
-----------------------------------------------------------------
AssetDefinition - This is the seed of a long term replacement of IAssetTypeActions.  IAssetTypeActions is woefully inadiquit now.  It puts a lot of functionality in one place, which wouldn't be a terrible thing, except for the GetActions, and some of the menu stuff being built into this class.  We need to make an effort to not have to load every single asset just to open the context menu you have selected, to-wit, a previous CL made it so that summoning the menu no longer *Had* to load the assets, however several remaining issues remained with the Blueprint Utility Actions, and the fact that we don't "KNOW" if we need to call GetActions for an asset.  We could introduce a replacement in the class, but that would just get inherited, causing other issues.  So instead the parallel UObject based AssetDefinition now exists.  In large part it will probably be very similar to the other one, but several things in it probably need to chnage.  For now there is a bridging concept in the form of the AssetDefinitionAssetTypeProxy.

Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.

AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.

#jira UE-165574
#preflight 636c0ec4d0174259cca85e37

[CL 23072024 by bob tellez in ue5-main branch]
2022-11-10 01:18:44 -05:00
nick darnell
fd6f4a29b1 AssetDefinition - This is the seed of a long term replacement of IAssetTypeActions. IAssetTypeActions is woefully inadiquit now. It puts a lot of functionality in one place, which wouldn't be a terrible thing, except for the GetActions, and some of the menu stuff being built into this class. We need to make an effort to not have to load every single asset just to open the context menu you have selected, to-wit, a previous CL made it so that summoning the menu no longer *Had* to load the assets, however several remaining issues remained with the Blueprint Utility Actions, and the fact that we don't "KNOW" if we need to call GetActions for an asset. We could introduce a replacement in the class, but that would just get inherited, causing other issues. So instead the parallel UObject based AssetDefinition now exists. In large part it will probably be very similar to the other one, but several things in it probably need to chnage. For now there is a bridging concept in the form of the AssetDefinitionAssetTypeProxy.
Several amounts of effort went into the newer design of UAssetDefinition to make it easier to change over time, more things are structs now for input and output so additional parameters can be added.

AssetDefinition module is an editor module instead of being a developer module.
AssetDefinition does not include a myraid of things it shouldn't such as the blueprint module and UnrealEd.

#jira UE-165574
#preflight 636c0ec4d0174259cca85e37
[REVIEW]

[CL 23072002 by nick darnell in ue5-main branch]
2022-11-10 01:17:07 -05:00
jared cotton
5550406045 Fix for errors in https://horde.devtools.epicgames.com/job/635beeaae24ac41a63dee15a being caused in UE5-Main
#preflight none

[CL 22835905 by jared cotton in ue5-main branch]
2022-10-28 15:39:01 -04:00
jared cotton
db9180da10 Re-submission of 'view' method for AssetEditing (aware of merge issues that will arise in 23.00 and ready to resolve. Also ready with fix for issue that will arise when CL hits /Fortnite-Main in GLTFProxyAssetActions.h)
#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf

Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.

The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.

[CL 22823595 by jared cotton in ue5-main branch]
2022-10-28 00:33:58 -04:00
bob tellez
3dec1bb8cb [Backout] - CL22782944
[FYI] jared.cotton
Original CL Desc
-----------------------------------------------------------------
Addition of 'view' method to AssetTypeActions

#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf

Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.

The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.

[CL 22803476 by bob tellez in ue5-main branch]
2022-10-26 23:17:50 -04:00
jared cotton
a53b15247b Addition of 'view' method to AssetTypeActions
#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf

Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.

The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.

[CL 22803451 by jared cotton in ue5-main branch]
2022-10-26 23:16:25 -04:00
julien stjean
3991bcb36d Reworked the migration tool so that it support moving assets inside of a plugin.
Added a global event for when some package are migrated. This can be used for hotfixes and as extension point for systems to react or add stuff to the migration.

Other changes that were required for the new migration:
Level streaming is now aware that the world might be part of a instanced package. When it validate that file for the streamed world exist it will use the path from the package linker of the world package.
The level postload function now prefer to use the Instancing Context package remapping from its linker to determine where it should load some of its external UActorFolder.
The StringTableEditorModule was modified to be able to properly react to the migration.

This change will still require some change in a future release to reduce its memory usage.

#rb Francis.Hurteau
#jira UE-162943, UE-161367, UE-161364, UE-161359, UE-161357, UE-161355, UE-161354, UE-145342
#preflight 6358419f2e6690262abbce83
#lockdown jeanmichel.dignard

[CL 22798574 by julien stjean in ue5-main branch]
2022-10-26 19:11:52 -04:00
rob gay
18e887e937 [MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f

[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
dave belanger
eeebef1f13 Add a notification severity filter param on AdvancedCopyPackages
#rb Lauren.Barnes
#preflight 6351b572e6096564af21eefa

[CL 22710448 by dave belanger in ue5-main branch]
2022-10-22 07:10:37 -04:00
marc audy
927adb79be Correct deprecation versions
#preflight trivial
#rnx

[CL 22573046 by marc audy in ue5-main branch]
2022-10-17 15:13:35 -04:00
nick darnell
f6672c7be8 Editor - Renable HasActions, since I'm working on a different replacement, I might as well clear build errors.
[CL 22549057 by nick darnell in ue5-main branch]
2022-10-15 13:03:50 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
jerome delattre
6fe7b052f1 Expose Asset Migration command to scripting
#preflight 63373ca15c2225fe5f898171
#jira UE-165706
#rb Julien.StJean

[CL 22284188 by jerome delattre in ue5-main branch]
2022-09-30 19:23:32 -04:00
robert millar
e6857190f2 Updating collection manager interface to use FSoftObjectPath for the paths of assets and objects rather than FName.
#jira UE-161932
#rb julien.stjean
#preflight https://horde.devtools.epicgames.com/job/6324e773f258fccf98de78cf

[CL 22064625 by robert millar in ue5-main branch]
2022-09-16 20:57:34 -04:00
bryan sefcik
a3dddc6630 Pass 1 on Developer include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e281694758d0bf2ea1399

[CL 21960082 by bryan sefcik in ue5-main branch]
2022-09-11 18:32:18 -04:00
robert millar
5516f8d0d4 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for editor support classes for content browser code.

#jira UE-161932
#rb jason.stasik,jamie.dale
#preflight 631bd2a0d31788ea3ac03570

[CL 21935588 by robert millar in ue5-main branch]
2022-09-10 00:02:37 -04:00
jordan hoffmann
64f957e8cb [Feature] Blueprints - Extract Details View of BP Diff tool and set the Fidd Override for UDataAsset types for this tool
#jira UE-159258
#rb ben.hoffman
#preflight 63091ea4133e67151eb8c727

[CL 21597140 by jordan hoffmann in ue5-main branch]
2022-08-26 15:50:23 -04:00
jason stasik
924bcaca0d Fix invalid enum forward declaration on linux by including .h instead
#rb none

#ROBOMERGE-OWNER: devin.doucette
#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 21401840 via CL 21404982 via CL 21404999 via CL 21405011
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21407190 by jason stasik in ue5-main branch]
2022-08-16 12:38:32 -04:00
jason stasik
54e2ea3049 Additional menu filtering for BP-based factories
#rb david.hibbitts,rex.hill
#preflight 62fabf17086f90bbc4069ec9

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 21398192 via CL 21401380 via CL 21401443 via CL 21401480
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v975-21357124)

[CL 21406926 by jason stasik in ue5-main branch]
2022-08-16 12:29:41 -04:00
jay nakai
2aa0133963 Adjustments to allow easier advanced copy customization
* SetPackageThatInitiatedCopy() is now called before any customization steps to fix issue with inconsistent values in PackageThatInitiatedCopy. Notably that PackageThatInitiatedCopy could be the name of the previous package initiator during some method calls if the same advanced copy customization was re-used during the editor lifetime
* Made UAdvancedCopyCustomization::GetARFilter() virtual so customization have an opportunity to define additional filtering

#rb Lauren.Barnes

#ROBOMERGE-AUTHOR: jay.nakai
#ROBOMERGE-SOURCE: CL 21293857 via CL 21293920 via CL 21293937
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21297704 by jay nakai in ue5-main branch]
2022-08-09 16:34:05 -04:00
jamie dale
1cac2e67c1 Fixed incorrect cook path length for plugins mounted from outside of the engine/project directory, and removed a bunch of temporary FString instances
#preflight 62d89ca4110da0f944819d32
#rb Jason.Stasik
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21199916 via CL 21200683 via CL 21200747 via CL 21200772
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21202831 by jamie dale in ue5-main branch]
2022-07-21 12:27:36 -04:00
aditya ravichandran
ef0cf7de98 Remove the categories from the Asset Type Actions for Blueprint Generated Classes, so that it doesn't show up as a filter in the Content Browser/Reference Viewer
#rb Lauren.Barnes
#preflight 62c839a7f671e8d2facf69a8

#ROBOMERGE-OWNER: aditya.ravichandran
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 21008574 via CL 21009217 via CL 21009495 via CL 21009608
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21023681 by aditya ravichandran in ue5-main branch]
2022-07-09 14:00:59 -04:00
aditya ravichandran
a6ad8c6bdf IAssetTypeActions: Add a function to get the FTopLevelAssetPath
#rb julien.stjean
#preflight 629e44eb41542e8cf67b2049

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20526581 via CL 20527738 via CL 20527856
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20529892 by aditya ravichandran in ue5-main branch]
2022-06-06 18:58:43 -04:00