Commit Graph

93 Commits

Author SHA1 Message Date
jeremie roy
f35d69d139 Improve time for opening remote control preset in huge maps or when it has a lot of exposed properties
Significantly improve OnObjectPropertyChanged callback time
Fix hang when recompiling materials
Add traces

#jira IRON-319 IRON-320
#rb simon.therriault
#preflight 636a56a87c2b505190989f19

[CL 23026939 by jeremie roy in ue5-main branch]
2022-11-08 08:32:24 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
justin marcus
7bf1ba442a [Backout] - CL22822857
Change WebRemoteControlInternalUtils.cpp to use WIDECHAR
[FYI] aurel.cordonnier
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL22811007
[FYI] Justin.Marcus
Original CL Desc
-----------------------------------------------------------------
Fix JSON Reader UTF8 parsing.
Add ability to use JSON Reader with a string view.
Add explicit UTF8 smoke tests.
Change uses of TJsonReader<UCS2CHAR> to TJsonReader<WIDECHAR> since TStringBuilder<UCS2CHAR> doesn't compile.
Change uses of TJsonReader<char> to TJsonReader<UTF8CHAR>.  There isn't much use for TJsonReader<char> as ASCII is a subset of UTF8 so TJsonReader<UTF8CHAR> is always preferable.
#rb [at]Steve.Robb
#preflight https://horde.devtools.epicgames.com/job/635980ead86d91ca2cfabc77

[CL 22835909 by justin marcus in ue5-main branch]
2022-10-28 15:39:05 -04:00
elliot colp
0c4c73e53c [RemoteControl] Let user choose whether to force a property's edit conditions on when exposed remotely
#jira UE-168012
#rb Alejandro.Arango
#lockdown alejandro.arango
#preflight 63531801777a77c4407dfae1

[CL 22712190 by elliot colp in ue5-main branch]
2022-10-22 15:36:14 -04:00
elliot colp
4d1ca51eb2 [EpicStageApp] Fix interactive changes to nested colors failing to propagate
#jira UE-167827
#rb Alejandro.Arango
#lockdown alejandro.arango
#preflight 6351e811e6096564af312710

[CL 22705205 by elliot colp in ue5-main branch]
2022-10-21 19:52:37 -04:00
jeremie roy
126c07a04c Fix regression in remote control where class filters don't work anymore
#jira UE-165715
#rb simon.therriault
#lockdown alejandro.arango
#preflight 634d971d6543aa1c1a7cbc05

[CL 22634678 by jeremie roy in ue5-main branch]
2022-10-19 15:10:25 -04:00
jeremie roy
dfd0510861 Fix desync between preset properties when entering/exiting multi user
#jira UE-166996 UE-166987
#rb geoffrey.douglas
#lockdown alejandro.arango
#preflight 63499afe204d7f312bbc6552

[CL 22546717 by jeremie roy in ue5-main branch]
2022-10-14 22:18:37 -04:00
patrick gross
5ed2801963 Remote Control Logic - WebAPI Extension for RC Logc Controllers
Adds the required Callbacks and missing Routes for the WebApp, so that it can control the VirtualProperties/Controllers.
Following changes have been made:
- Add OnAdded/OnChanged/OnRemoved/OnRenamed Callback for Controllers
- Add Websocket Messages from those Callbacks to the Server
- Add Metadata Callbacks and implementation of imoprtant information such as "Widget" Metadata
- Fix up existing calls to Deserializer to work for structs
- Renaming VirtualProperty Calls/Methods within the Preset to Controllers

#rb paul.vincent
#rb venugopalan.sreedha
#rb simon.therriault
#rb amir.keren
#jira UE-163264
#preflight 633b5446b12b8af5fd015430

[CL 22324865 by patrick gross in ue5-main branch]
2022-10-03 22:03:22 -04:00
robert millar
594cc63712 Remove use of deprecated field.
#rb none
#jira UE-161932
#preflight 632b5f66b4515b7e2278c56a

[CL 22140178 by robert millar in ue5-main branch]
2022-09-22 14:00:24 -04:00
elliot colp
33c85ce6b0 [RemoteControl] Fix crash when client disconnects mid-transaction
#jira UE-164256
#rb Alejandro.Arango
#preflight 6328971eea1c94f4c5e694cb

[CL 22087065 by elliot colp in ue5-main branch]
2022-09-19 21:58:05 -04:00
robert millar
e6857190f2 Updating collection manager interface to use FSoftObjectPath for the paths of assets and objects rather than FName.
#jira UE-161932
#rb julien.stjean
#preflight https://horde.devtools.epicgames.com/job/6324e773f258fccf98de78cf

[CL 22064625 by robert millar in ue5-main branch]
2022-09-16 20:57:34 -04:00
elliot colp
5e6549713e [EpicStageApp] Disable Stage App beacon unless the WebSocket server is running
#jira UE-163343
#rb Alejandro.Arango
#preflight 632229798838676d1057c6b3

[CL 22018644 by elliot colp in ue5-main branch]
2022-09-14 18:22:36 -04:00
Elliot Colp
c6e87912b4 [EpicStageApp] Fix stage app failing to control nDisplay nodes when connected directly
#jira UE-161370
#rb Alejandro.Arango, Jeremie.Roy
#preflight 6308f989987e7155b1add7b1
#preflight 630911ffed56f9e6dbe3c7f4

[CL 21596518 by Elliot Colp in ue5-main branch]
2022-08-26 15:25:15 -04:00
Zousar Shaker
3f4252aa56 ObjectPtr upgrade for engine plugins used from UnrealEditor -allmodules. Automated upgrade process.
#rb none
#preflight 62fe7f270601ad0504910c30

[CL 21447894 by Zousar Shaker in ue5-main branch]
2022-08-18 15:08:49 -04:00
Elliot Colp
f4dbabd0b8 [EpicStageApp][WebRemoteControl] Fix cases where a transaction could be cancelled but fail to report to subscribers
#jira UE-156394
#rb Alejandro.Arango
#preflight 62fd28b087319bacfb16607e

[CL 21427682 by Elliot Colp in ue5-main branch]
2022-08-17 13:48:28 -04:00
jamie dale
a84ca6fb32 Moved some object-centric transaction APIs out of Core and into CoreUObject
The following types have moved to ITransactionObjectAnnotation.h:
- ITransactionObjectAnnotation

The following types have moved to TransactionObjectEvent.h:
- FTransactionObjectDeltaChange
- ETransactionObjectEventType
- FTransactionObjectEvent
- FTransactionDiff

#preflight 62f141b7086f90bbc473f631, 62f1351a904c243122f5eacd
#rb Francis.Hurteau, Rex.Hill

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 21272390 via CL 21285937 via CL 21285973 via CL 21286088
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21290425 by jamie dale in ue5-main branch]
2022-08-09 12:16:06 -04:00
steve robb
4cafa69f6a Misc direct FTCHARToUTF8_Convert usage replaced with StringCast or FPlatformString.
#rb devin.doucette
#jira UE-132142
#preflight 62bf8c181c0b75879792c9b5

#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20925918 via CL 20925919 via CL 20925920
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20926016 by steve robb in ue5-main branch]
2022-07-02 09:05:41 -04:00
steve robb
1b2a6972d9 Undo //Fortnite/Main/... changelist 20912148
#rb none

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20912525 via CL 20912560 via CL 20912561
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20913042 by steve robb in ue5-main branch]
2022-07-01 07:49:36 -04:00
steve robb
39ffa82638 Direct FTCHARToUTF8_Convert usage deprecated and replaced with StringCast or FPlatformString.
#rb devin.doucette
#jira UE-132142
#preflight 62bd92d71c0b758797185071

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20912148 via CL 20912242 via CL 20912250
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20913038 by steve robb in ue5-main branch]
2022-07-01 07:49:22 -04:00
jeremie roy
1f790162e2 Change check to ensure until we can reproduce
#rb simon.therriault
#preflight 62b0b7aede510ae06e5decec
#jira UE-156554

[CL 20756619 by jeremie roy in ue5-main branch]
2022-06-21 09:27:48 -04:00
Matt Chapman
d617dced5e Missing include added.
#jira UE-156993
#rb trivial
#preflight 62ac96205d5264997e1d6a03
#preflight 62ac96205d5264997e1d6a03

[CL 20703742 by Matt Chapman in ue5-main branch]
2022-06-17 11:11:12 -04:00
evan kinney
b125fd52fe optionally fail to get a valid HttpRouter if we fail to bind/start listening on the given port, modify callers to request this behavior if it's clear they expected it to behave this way, and allow listener sockets to reuse addresses/ports when binding
#rnx
#rb brian.bekich, jake.champlin

#ROBOMERGE-AUTHOR: evan.kinney
#ROBOMERGE-SOURCE: CL 20695650 via CL 20695677 via CL 20695883 via CL 20695924
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v968-20684695)

[CL 20697322 by evan kinney in ue5-main branch]
2022-06-16 19:07:59 -04:00
Matt Chapman
cd4cfcd8d0 Static analysis issue with Engine/Plugins/VirtualProduction/RemoteControl/Source/WebRemoteControl/Private/WebSocketMessageHandler.cpp
#jira UE-156841
#rb Simon.Therriault
#preflight 62ab41eb5c69124c40841018
#preflight 62ab41eb5c69124c40841018

[CL 20687951 by Matt Chapman in ue5-main branch]
2022-06-16 11:32:10 -04:00
Matt Chapman
f891d6366e Update to allow remote control presets to exist within other assets and toolkit hosts (not level editor.)
#jira none
#rb jeremie.roy
#preflight 62aa4871da0af39a475a0b65

[CL 20677397 by Matt Chapman in ue5-main branch]
2022-06-15 17:50:19 -04:00
Denys Dubinin
9f5ce23bde [UE-156705] Quality of Life upgrades for Logic UI
Featuring:

* Rename Controller [UE-156717] - Provides ability to rename Controllers via API support and Rename UI command.

* Controllers Table - header & resizing support

~~~

[Rename Controller]

Functional notes:
* Provides rename via F2 key (UI command). Rename via RMB Context Menu wiill be part of a subsequent CL.
* Web API has been updated in this CL to support using the user-friendly Controller name (renamed by users as desired) rather than the internal proprety name (which is currently immutable, see impl notes below)

Impl notes:
* Added a new property DisplayName to VirtualProperty class to support specifiying user frienedly Controller Names.
* I deemed this preferrable to modifying the underlying PropertyBag description because that approach will reallocate memory for all the Controllers each time the user tries to rename even just one. This is due to the way PropertyBag is designed (each collection of properties is conidered as a unique type with a specific hash value.The entire set is reallocated if any modification is made to the property bag).

[Controllers Table]
* Used Header Rows for automatic resizing
* Preferred over using manual splitter (as in EP list), no issues noted thusfar
#preflight 62a9e27962552c58ff1a3401

[CL 20669482 by Denys Dubinin in ue5-main branch]
2022-06-15 10:11:39 -04:00