Commit Graph

157 Commits

Author SHA1 Message Date
joe kirchoff
e737e995f1 UnrealEditor: Handle private includes from so the path isn't rooted in the module parent. This should be cleaned up to not require including private headers in public files.
#rnx
#rb Bryan.Sefcik
#preflight 6372dad7232e3d12cb8f12b7

[CL 23148562 by joe kirchoff in ue5-main branch]
2022-11-15 19:54:38 -05:00
henrik karlsson
5298cc8120 Non-unity/pch compile fixes when building UnrealEditor linux
#rb none
#preflight skipped

[CL 22794114 by henrik karlsson in ue5-main branch]
2022-10-26 17:49:37 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
trystan binkley-jone
8e1ba6b350 nDisplay: Replaced placeholder icons with final icons for a variety of UI elements in the light card editor
#jira UE-165619
#rb Patrick.Hardy
#preflight 633764bda852bd922c61dc82

[CL 22285213 by trystan binkley-jone in ue5-main branch]
2022-09-30 20:30:45 -04:00
patrick hardy
d01acd86c2 nDisplay: Fix occasional crash when selecting components in the blueprint editor.
#jira UE-163938
#rb trystan.binkley-Jone
#preflight 6334c1f3ee7b13756dd262ae

[CL 22240806 by patrick hardy in ue5-main branch]
2022-09-28 22:33:13 -04:00
trystan binkley-jone
010aa31210 nDisplay: Added and moved the Name property of the per-viewport and per-node color grading groups to the top of the details panel
#jira UE-164746
#rb Patrick.Hardy
#preflight 63320e87b20e73a09859d802

[CL 22203035 by trystan binkley-jone in ue5-main branch]
2022-09-27 06:54:00 -04:00
andrey yamashev
85c7fab127 nDisplay: rendering latency for media + fix for backbuffer capture
#jira UE-156401
#rb Alejandro.Arango, Simon.Therriault
#preflight 632c89f1671a1a24b511cff2

[CL 22151110 by andrey yamashev in ue5-main branch]
2022-09-22 22:19:27 -04:00
Zousar Shaker
b7bac5d97c ObjectPtr macro cleanup pass using search+replace.
#rb none
#preflight 6312aefef448dc6e58dc274e

[CL 21773340 by Zousar Shaker in ue5-main branch]
2022-09-02 21:52:41 -04:00
nick darnell
8c6dccfce9 Core - Making some improvements to TObjectPtr, introducing some templating utilities so that we can better template match TObjectPtr vs UObject* pointers so that a single templated function can work for either.
Core - Added support for assigning a TObjectPtr<T> to a TScriptInterface just like you'd expect from a raw Object*.

Actor - Making a version of GetComponents that will work for TObjectPtr collections.  Additionally fixed several places in the engine where we're forcing the template parameter instead of allowing it to be determined automatically - which forced me to leave one of the GetComponent implementations, but I think we aught to remove it. e.g.

Don't Do

TArray<UPrimitiveComponent*> PrimComponents;
Actor->GetComponents<UPrimitiveComponent>(PrimComponents);

Do

TArray<UPrimitiveComponent*> PrimComponents;
Actor->GetComponents(PrimComponents);

Slate - Introducing support for collections of TObjectPtr<T>'s being used as source lists for the STableView.

#preflight 630f7af8e54ec9d581b03d65
[REVIEW] [at]Marc.Audy, [at]Steve.Robb, [at]Zousar.Shaker

[CL 21727328 by nick darnell in ue5-main branch]
2022-08-31 16:13:49 -04:00
Alejandro Arango
5a96b2e9a6 nDisplay: Removed old lightcard blueprints from place actors menu.
This should avoid users mistakenly using the old light cards which are not supported in the icvfx operator panel.

#rb
#jira
#preflight 630ea23c556fc14dce7f57a8

[CL 21713175 by Alejandro Arango in ue5-main branch]
2022-08-30 19:54:52 -04:00
trystan binkley-Jone
6f743db730 nDisplay: Added new drawer mode to the color grading drawer that displays a list of additional, customized properties from the selected items
#jira UE-161968
#rb Patrick.Hardy
#preflight 630cff81501b64ba331a25b6

[CL 21683884 by trystan binkley-Jone in ue5-main branch]
2022-08-29 14:08:37 -04:00
trystan binkley-Jone
20f3d03979 nDispaly: Added the color grading drawer to the nDisplay operator menu, which displays a list of color gradable objects relative to the active nDispaly stage actor, and displays the color grading properties and color wheels of the selected object.
#jira UE-159062, UE-159063
#rb Patrick.Hardy
#preflight 62fef6949835a27d8d7f6a46

[CL 21453812 by trystan binkley-Jone in ue5-main branch]
2022-08-18 22:46:55 -04:00
Zousar Shaker
3f4252aa56 ObjectPtr upgrade for engine plugins used from UnrealEditor -allmodules. Automated upgrade process.
#rb none
#preflight 62fe7f270601ad0504910c30

[CL 21447894 by Zousar Shaker in ue5-main branch]
2022-08-18 15:08:49 -04:00
Zousar Shaker
dd86f26e20 Callsite upgrade pass for TObjectPtr use on plugins used when building UnrealEditor with "-allmodules" for Linux.
#rb none
#preflight 62fc7796830482fd82ff56b9

[CL 21421394 by Zousar Shaker in ue5-main branch]
2022-08-17 01:23:09 -04:00
Zousar Shaker
da1254fd35 Callsite upgrade pass for TObjectPtr use on plugins used when building UnrealEditor with "-allmodules".
#rb none
#preflight 62daee42ac71f3a225b744f9

[CL 21226921 by Zousar Shaker in ue5-main branch]
2022-07-22 15:06:06 -04:00
fabian giesen
7d8781778c Deprecate TVector2 operator <, >, <=, >=
2D vectors are not canonically ordered and having these operators results in very unfortunate interactions with generic code. In particular FMath::{Min,Max,Abs} on TVector2s compile but do not behave as one would expect.

Add explicit comparison methods as a replacement and deprecate uses of TVector2 overloaded relational operators since it's confusing and error-prone. Fix existing uses to avoid deprecation warnings. Several of these fixes are behavioral changes to fix what I am reasonably certain are bugs in the existing code - in particular, uses of FMath::{Min,Max,Abs} on TVector2s that almost certainly actually want TVector2::{Min,Max,GetAbs} instead.

#rb charles.bloom,jeff.roberts
#preflight 62d70a6547779a730aaac04b

#ROBOMERGE-AUTHOR: fabian.giesen
#ROBOMERGE-SOURCE: CL 21168341 via CL 21173069 via CL 21173193
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21192034 by fabian giesen in ue5-main branch]
2022-07-20 18:23:11 -04:00
Patrick Hardy
2f8843b9f5 nDisplay: Fix crash on config editor open. Result of changes in 21085991 allowing customization on CreateSingleProperty.
#jira none
#rb trivial
#preflight 62d0a7e3af68cd745b24e498

[CL 21101403 by Patrick Hardy in ue5-main branch]
2022-07-14 19:51:32 -04:00
Patrick Hardy
95d0198888 nDisplay: Sanitize cluster and viewport names to uobject friendly names. This prevents crashes when spaces or special characters are added.
#jira UE-157901
#rb trystan.binkley-Jone
#preflight 62c4bbea2f2d046918a921a8

[CL 20952293 by Patrick Hardy in ue5-main branch]
2022-07-05 19:07:15 -04:00
Andrey Yamashev
e161a15e38 nDisplay: media configuration fix (no in-cluster media sharing for viewports and backbuffers)
#jira none
#rb none
#fyi Alejandro.Arango
#preflight 62b23b08e9509b62d9268cd8

[CL 20794394 by Andrey Yamashev in ue5-main branch]
2022-06-23 10:24:44 -04:00
ben hoffman
a85b684ca2 Enable the InputKey and InputAxis deprecations on the EditorViewportClient
#jira UE-156743
#rb justin.hare
#rnx
#preflight 62b22d17ac40ebe4eb99efb7

[CL 20774014 by ben hoffman in ue5-main branch]
2022-06-22 10:11:01 -04:00
Andrey Yamashev
034af2d2df nDisplay: media integration
#jira UE-149068, UE-149069, UE-149070
#rb Alejandro.Arango, Simon.Therriault
#preflight 62b0c4b02405b4ac9e73b2af

[CL 20756317 by Andrey Yamashev in ue5-main branch]
2022-06-21 09:06:37 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Patrick Hardy
ddb6de15dc nDisplay: Fix crash on package reload. Fix possible crash when shutting down the editor and unregistering section categories.
#jira UE-150558
#rb trystan.binkley-Jone
#preflight 6283e7bbf536779152ca5ab3

[CL 20248203 by Patrick Hardy in ue5-main branch]
2022-05-17 14:37:59 -04:00
Andrey Yamashev
7485e121e4 nDisplay: removed public 'Interfaces' folder for better file structuring before extending the API (DisplayClusterConfigurator)
[preparation before media integration and UE-145807]

#jira none
#rb none
#preflight 627d9de6332e182a5853521f
#swarm https://p4-swarm.epicgames.net/reviews/20174552
#fyi Patrick.Hardy

[CL 20174869 by Andrey Yamashev in ue5-main branch]
2022-05-12 20:51:32 -04:00
lauren barnes
4b82e918fa Replacing legacy EditorStyle calls with AppStyle
#rb header and class name replacement

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20078276 via CL 20078825
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106316 by lauren barnes in ue5-main branch]
2022-05-09 13:51:26 -04:00