Commit Graph

120 Commits

Author SHA1 Message Date
mikko mononen
1deae510ba World condition fixes
- Fixed SmartObject test linking with World Conditions
- Corrected the handling of empty world conditions (checks or no errors)
- Added tests for empty conditions and failing activation

#jira UE-170467 FORT-540539
#preflight 637b3991fa348e84805ca372

[CL 23218783 by mikko mononen in ue5-main branch]
2022-11-21 05:17:25 -05:00
halfdan ingvarsson
387230d623 Fix mac build. Missing dependency on WorldConditions from SmartObjectsTestSuite.
#jira none
#rnx
#preflight 63770fa9fa348e848099579d

[CL 23189867 by halfdan ingvarsson in ue5-main branch]
2022-11-18 00:03:06 -05:00
mikko mononen
924b989973 SmartObject: World conditions for SmartObject slot precondition
#rb Mieszko.Zielinski Luciano.Ferraro
#preflight 6375ef0b1c114bec053ccbe7
#preflight 6375fe028f4cb2e4dc8c4e4c

[CL 23174492 by mikko mononen in ue5-main branch]
2022-11-17 07:44:24 -05:00
joe pribele
ed7566be21 removing PRAGMA_DISABLE_OPTIMIZATION
#preflight 6372b7d60c74adb48b4a847f

[CL 23127658 by joe pribele in ue5-main branch]
2022-11-14 17:04:03 -05:00
joe pribele
0926a226cf removed PRAGMA_DISABLE_OPTIMZATIONS that appear to be left in by accident
#rb zousar.shaker
#preflight 636c1c6f7c2b50519028f593

[CL 23063526 by joe pribele in ue5-main branch]
2022-11-09 16:47:19 -05:00
Mieszko Zielinski
f446fa6e92 Added asset name to error logging reported by USmartObjectDefinition::Validate
#jira UE-168001
#review-23049802
#preflight 636b6c96f56cab38c766e8e2

[CL 23050127 by Mieszko Zielinski in ue5-main branch]
2022-11-09 05:03:26 -05:00
mieszko zielinski
528c391411 SmartObject unit testing fix.
The fix involved an extensive rework of how the testing environment is being set up, to limit loaded UWorld's influence on the results, and in turn limit how tests affect SmartObjectSubsystem instantiated for the current world.

#preflight 6368c59e63037c1026540f38

[CL 23010255 by mieszko zielinski in ue5-main branch]
2022-11-07 09:57:31 -05:00
luciano ferraro
14d7728762 Filter out disabled slots in the USmartObjectSubsystem::FindSlots
[REVIEW] [at]Mikko.Mononen
[FYI] Loic.Devaux, Josselin.Francois, Phil.Cole, wojciech.madry, Parker.Linn
#preflight 6364fc4af233f06a12c69cb2

[CL 22987809 by luciano ferraro in ue5-main branch]
2022-11-04 11:28:57 -04:00
mikko mononen
1bc7452c79 Gameplay Interaction: Set Slot Enabled task
- added task to enable and disabled slots
- visualize disabled slots in Smart Object editor

#rb Luciano.Ferraro
#preflight 6364e3364b0e01486a464fa5

[CL 22985540 by mikko mononen in ue5-main branch]
2022-11-04 09:18:52 -04:00
mikko mononen
b151705d6d SmartObject: fix default init of FSmartObjectEventData
#rb trivial
#preflight 6364ce784b0e01486a41f6fb

[CL 22983631 by mikko mononen in ue5-main branch]
2022-11-04 06:56:55 -04:00
mieszko zielinski
c00e84ad1b Made SmartObjectDefinition verification a bit more automatic so that we can reliably check that.
#preflight 6364cc11de2c4dbb5d87c777

[CL 22983630 by mieszko zielinski in ue5-main branch]
2022-11-04 06:56:50 -04:00
mieszko zielinski
83d06d726d Added an early out in registering misconfigured SmartObjects.
There was a loophole that would partly register smart objects that did have a SmartObjectDefinition asset set, but the asset was not valid itself, and it resulted in failing an ensure while cleaning up the whole system on world end.

#preflight 63640e3fdc30a4ce961be2d1

[CL 22982893 by mieszko zielinski in ue5-main branch]
2022-11-04 03:35:03 -04:00
mikko mononen
64b51e4e53 SmartObjects: Fix nullptr access bug found by static analysis
#rb trivial
#preflight 63636fec1a32af63a82bddea

[CL 22959044 by mikko mononen in ue5-main branch]
2022-11-03 14:21:36 -04:00
mikko mononen
ee05371fda SmartObjects: Add missing StructUtils editor depedency.
#rb trivial
#preflight 63621873522c8f7ab31a3bdc

[CL 22918359 by mikko mononen in ue5-main branch]
2022-11-02 11:58:24 -04:00
mikko mononen
11a0cdcb85 SmartObjects: Static analyzer fixes.
#rb Mieszko.Zielinski
#preflight 63621df29160784fc3f37a7a

[CL 22918351 by mikko mononen in ue5-main branch]
2022-11-02 11:58:09 -04:00
mikko mononen
cd79b83417 Fix non-unity compile of SmartObjectVisualizationContext
#rb trivial
#preflight 63610f56397c7af8965aa074

[CL 22888717 by mikko mononen in ue5-main branch]
2022-11-01 15:11:30 -04:00
mikko mononen
c06beb8571 SmartObject improvements
- Fixed hashing when adding shared fragment for smart object slot definition
- Added per slot Runtime Tags
- Added common event handling for Smart Object and Slot changes and events
- Added annotations, which are slot definition data that has visualization
- Added linked slot annotation which allows behavior reuse on slots
- Added editor only ID for each slot so that they can be identified during edits
- Added SmartObject slot reference type that can be used to reference other slots in the Smart Object
- Changed Smart Object bDisable to bEnabled
- Added separate enabled state for slots
- Changed Smart Object disable to send an event, not forcefully unclaim
- Added more visualization support for Smart Object editor (canvas, visualize annotations)
- Changed Smart Object editor to use the commonly transform for slots
- Remove Smart Object Component instance from the asset editor as it was not needed

#rb Stephen.Holmes
#preflight 6360f0cf63608aee36e01ba5

[CL 22888712 by mikko mononen in ue5-main branch]
2022-11-01 15:11:25 -04:00
luciano ferraro
18797d83c8 Fixed issue with slot data being shared between all slots instead of being unique per slot
#jira
[REVIEW] [at]Mikko.Mononen
[FYI] Loic.Devaux, Josselin.Francois, Phil.Cole, wojciech.madry, Parker.Linn
#preflight 635fd220ae6840072df52074

[CL 22875405 by luciano ferraro in ue5-main branch]
2022-10-31 20:00:30 -04:00
mieszko zielinski
9c7b392aa9 Fine-tuned smart object removal code to catch a no-repro USmartObjectSubsystem::CleanupRuntime issue
#preflight 6358ccb1767e539ccaa2563b

[CL 22799298 by mieszko zielinski in ue5-main branch]
2022-10-26 19:34:40 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
Robb Surridge
610c467639 Update vendor links for built-in plugins to use secure protocol.
#jira UE-166823
#rb lauren.barnes
#preflight 6352b20b7261e565c476ec3b

[CL 22690089 by Robb Surridge in ue5-main branch]
2022-10-21 11:04:07 -04:00
mikko mononen
99543a3dc3 Update StateTree, GameplayStateTree, and SmartObject plugins to production ready.
#rb julien.marchand
#jira UE-166617
#lockdown julien.marchand
#preflight skip

[CL 22539523 by mikko mononen in ue5-main branch]
2022-10-14 19:03:11 -04:00
mieszko zielinski
142e0f52d3 Fixed SmartObjectSystem crashing when trying to register a SmartObjectComponent without a SmartObjectDefinition set
#preflight 6345a3c3cc615cdcf70b0b1b
#preflight 63466ab5fa31324bb124ec12

[CL 22497634 by mieszko zielinski in ue5-main branch]
2022-10-13 02:49:16 -04:00
mieszko zielinski
cad6e9df0c Made a change to how we treat persistent-level placed SmartObjects that are not contained by the level's SmartObjectCollection
Also changed collection building to only include SOComponents in the persistent or the "always loaded" levels

#preflight 6343da651d5e6dbf75839ead

[CL 22431195 by mieszko zielinski in ue5-main branch]
2022-10-10 12:00:30 -04:00
mieszko zielinski
5794e912bd A kind of a guess-fix to SmartObjectSubsystem::RemoveRuntimeInstanceFromSimulation failing an ensure while called as part of USmartObjectSubsystem::CleanupRuntime.
#preflight 6336e42ab34118b9b4a0261c

[CL 22276176 by mieszko zielinski in ue5-main branch]
2022-09-30 14:29:22 -04:00