Commit Graph

313 Commits

Author SHA1 Message Date
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
henrik karlsson
4a36cfe8ff Moved operator== to be hidden friend instead of put directly in global namespace
Moved GetTypeHash function to be hidden friend instead of put directly in global namespace.

Note that the function/operator needs to be fully inlined in the type or placed in the cpp. If the function is added as friend but then implemented outside the type then hidden friend optimization won't work.

This should improve compile time somewhat according to msvc devs.

#rb Steve.Robb
#preflight 6360b7052b5338aceb26471b

[CL 22889837 by henrik karlsson in ue5-main branch]
2022-11-01 15:50:27 -04:00
rob gay
9548b0ee1a [MetaSounds] Fix for ensure when naming an input with "/". Forbid use of analyzer '/' in MetaSound member names & don't bloat FName table with attempted renamed members
#rb helen.yang
#jira UE-168051
#preflight

[CL 22786989 by rob gay in ue5-main branch]
2022-10-26 15:28:20 -04:00
rob gay
18e887e937 [MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f

[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
rob gay
1c23483e19 [MetaSound Editor]
- Pin inspector/inspector & reroute interaction fixes
- Trivial fix for dirtying assets on MetaSound sync
#rb helen.yang
[REVIEW] helen.yang
#rnx
#jira UE-167241,UE-167477
#preflight 634e2f89820aa0c1931f5079

[CL 22604480 by rob gay in ue5-main branch]
2022-10-18 13:07:17 -04:00
buzz burrowes
b28cd36c94 A few little tweaks to Metasound "core" to help with Harmonix metasound work
[REVIEW] [at]aaron.mcleran [at]phil.popp
#preflight 63458281394d5f8ebafc0b8b

[CL 22547802 by buzz burrowes in ue5-main branch]
2022-10-15 02:11:45 -04:00
phil popp
07800695cd Replace use of FSoftObjectPath with UPROPERTY for dependent metasound assets.
#jira UE-156087
#rb rob.gay
#preflight 634841dffd22d1fbde5d7d73

[CL 22512918 by phil popp in ue5-main branch]
2022-10-13 17:38:11 -04:00
rob gay
d46c6dfa56 [Metasounds] Inputs not constructing TInputReceiverOperators intermittently causing parameter transmission to fail
#rb phil.popp
[REVIEW] phil.popp
#rnx
#jira UE-166767
#preflight 63472185663dafe41641788b

[CL 22489111 by rob gay in ue5-main branch]
2022-10-12 20:05:22 -04:00
phil popp
25b5881f1c Remove 5.0 channel format from MetaSoundSource and MetaSound WavePlayer node.
#jira UE-161170, UE-161172
#rnx
#preflight 63460236b757820b7aa1fdd2
#rb helen.yang

[CL 22482360 by phil popp in ue5-main branch]
2022-10-12 14:07:25 -04:00
rob gay
84771db13f Remove input receive node injection by implementing receive implementation within non-ctor input node operator
#rb phil.popp
[REVIEW] phil.popp
#rnx
#jira UE-166569
#preflight 63445c0f360ee7edea15afdb

[CL 22437484 by rob gay in ue5-main branch]
2022-10-10 15:44:28 -04:00
rob gay
0a1401644a Remove AnalyzerAddress from MetaSound Editor UX/auto-node registration
#rb helen.yang
[REVIEW] helen.yang
#jira UE-165926
#rnx
#preflight 63445019e94bf5d35ebd356f

[CL 22436806 by rob gay in ue5-main branch]
2022-10-10 15:21:30 -04:00
phil popp
a0c1e0840f Fix naming of metasound array node input
#jira UE-160926
#rb helen.yang
#preflight 633714be0d2b0d7bd8a415d4

[CL 22279846 by phil popp in ue5-main branch]
2022-09-30 16:23:15 -04:00
phil popp
aad06f1be7 Metasound DSP fixes around ADSR and triggers
- Updated logic on trigger delay node
- Updated logic for signalling that metasound generator is done
- Added ability to clear out selection of triggers
- Fixed ADSR situation when attack is zero.
#jira UE-162042
#rb Rob.Gay
#preflight 633714925c2225fe5f7ade1f

[CL 22279780 by phil popp in ue5-main branch]
2022-09-30 16:18:48 -04:00
rob gay
08f64dc10a [MetaSounds] Param loop virtualization fixes
- Split default param transmitter to SoundCueTransmitter & ParameterTransmitterBase to avoid generating transmitters for SoundBase child classes that don't support/require one (ex. SoundWaves)
- Move param transmitter to sharedptrs to avoid a bunch of unnecessary copy/clone logic when virtualizing loops
- Remove DefaultParameters field on ActiveSound in favor of shared impl in FParameterTransmitterBase that caches current state of parameters
- Fix for move that clears out active sound's current parameters when sound could have multiple wave instances that need said parameters
#rb phil.popp
#jira UE-164898
#preflight 6334a0a1ee7b13756dcd20ea

[CL 22240385 by rob gay in ue5-main branch]
2022-09-28 22:19:31 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
phil popp
881a7f949e Fix for ensure on metasound audio tests accessing missing variable
#jira UE-164804
#rb trivial
#preflight 632ccc932c7bc831f8f1526f

[CL 22151098 by phil popp in ue5-main branch]
2022-09-22 22:19:02 -04:00
rob gay
3edfbbaa76 Fix null deref static analysis warning
#rb trivial
#jira none
#rnx
#preflight skip

[CL 22146897 by rob gay in ue5-main branch]
2022-09-22 18:02:34 -04:00
phil popp
fbe2bf4faa Adding graph name to warning log for metasound array nodes
#jira UE-159860
#preflight 632b95eab4515b7e22905d7d

[CL 22142966 by phil popp in ue5-main branch]
2022-09-22 15:30:27 -04:00
rob gay
9dbc0c6693 [MetaSounds] Editor Graph Syncronization Upgrade
- Move synchronize/details panel flag to more generic ModifyContext
- Do not use MarkAsGarbage as means of enforcing not to show object in details panel to avoid leaving objects in invalid state if undo called. Check ed graph membership instead
- Get rid of leaky namechanged delegates
    - Allows for migration to isolated synchronization in the future
    - Removes conflation of having to synchronize and update views when modifying frontend document
    - Decouples concept of a specific view to update from generic frontend graph modifications
#rb helen.yang
#jira UE-151448
#preflight 632b7afdc7791417aa44126f

[CL 22142063 by rob gay in ue5-main branch]
2022-09-22 15:02:24 -04:00
phil popp
1cd4208860 Make MetaSound parameter error logs into warnings
Add log warning when constructor input value is ignored on runnign instance.
#jira UE-162285
#rb Rob.gay
#preflight 632b4cf72c7bc831f867d2c1

[CL 22121048 by phil popp in ue5-main branch]
2022-09-21 15:42:38 -04:00
rob gay
57d0be3dd2 Missing recursive call to reset sync state in prior CL
#rb trivial
#jira none
#preflight 6323a1805f55ba280ed12b0f

[CL 22042427 by rob gay in ue5-main branch]
2022-09-15 20:11:13 -04:00
rob gay
31435d69a5 Fix bug with synchronization not being completed prior to validation for referenced MetaSound graphs
TLBSRA (Too long but still read anyway)
This was due to validation moving to recursive behavior but sync not to support bubbling up referenced errors/warnings in 5.1.  This resulted in missing members after interface transforms are applied and potentially hitting ensures in validation.
...
But wait there's more!!! Synchronization on tick is now more efficient as it doesn't attempt to resynchronize/validate references already synchronized/validated in prior pass in same frame due to referencing graph needing to sync

#rb helen.yang
#rnx
#jira UE-162586
#preflight 63223e6c29254beccbf06119

[CL 22019580 by rob gay in ue5-main branch]
2022-09-14 18:49:46 -04:00
rob gay
e6a69d94c8 Set invalid controller's default access type to unset
#rb trivial
#jira none
#rnx
#preflight skip

[CL 21997854 by rob gay in ue5-main branch]
2022-09-13 21:51:42 -04:00
rob gay
7c89cca430 Fix missing rerouted implicit accessor behavior causing various bugs with constructor pins
#rb helen.yang
#rnx
#jira UE-163090
#preflight 6320d96829254beccb80dc36

[CL 21997851 by rob gay in ue5-main branch]
2022-09-13 21:51:22 -04:00