Commit Graph

208 Commits

Author SHA1 Message Date
phil popp
afb10dfdc7 Fix for metasound failing to play when soundwave loading behavior improperly overriden
#rb Max.Hayes
#preflight 63768904947d2d19ed0205b0

[CL 23183911 by phil popp in ue5-main branch]
2022-11-17 16:36:26 -05:00
Matt Peters
007584827b Metasounds: Fix missing dependencies during EditorDomain save of Metasound objects by shifting WaitUntilAsyncLoadReferencedAssetsComplete to earlier in PreSave, and by extending it to recursively wait for all transitive dependencies.
This fixes EditorDomain saves because they occur immediately after load of the package so waiting for async dependencies to load is required.
#jira UE-170378
#rb Phil.Popp
#rnx
#preflight 63766ddcb1509f1cc3fce67c

[CL 23178540 by Matt Peters in ue5-main branch]
2022-11-17 12:31:19 -05:00
nicholas howe
373ad2a12c Metasound Audio Bus Writer Node
Adds a metasound node that sends its audio input to an audio bus.
Modifies the audio mixer interface to support the node.

FMixerSourceManager::StartAudioBus no longer sets bIsPlaying to false on sources that use an audio bus when the audio bus starts.
FMixerAudioBus::MixBuffer mixes its patch inputs into its MixedSourceData buffer, so that the patch input data is available when CopyCurrentBuffer is used to retrieve the mix.

[REVIEW] [at]aaron.mcleran [at]buzz.burrowes [at]phil.popp
#preflight 6372639c5368a3230a4ed041

[CL 23123823 by nicholas howe in ue5-main branch]
2022-11-14 14:44:30 -05:00
rob gay
18e887e937 [MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f

[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
alfaroh corneyiii
4762921ab0 Fix crashes in Audio Bus Reader node when no Audio Bus is given
#jira UE-167439
#rb max.hayes
#preflight 634f080e773a16f49d2748d4
#lockdown nick.whiting

[CL 22632998 by alfaroh corneyiii in ue5-main branch]
2022-10-19 14:33:15 -04:00
bryan sefcik
117472780d Fixed include paths.
#jira
#preflight 634ee62fe746026e48eb077e

[CL 22621687 by bryan sefcik in ue5-main branch]
2022-10-19 06:39:08 -04:00
phil popp
dd90eb211a Replace use of FSoftObjectPath with UPROPERTY for dependent metasound assets.
#rb rob.gay
#preflight 634d5ea05f008d633fa5bc99

[CL 22568002 by phil popp in ue5-main branch]
2022-10-17 12:46:38 -04:00
phil popp
b5438f5ef5 Fix for CDO attempting to access MetaSound asset manager
#rnx
#jira UE-167130
#preflight 63487af4f622f6c4bbe1675e

[CL 22526957 by phil popp in ue5-main branch]
2022-10-14 10:55:37 -04:00
phil popp
07800695cd Replace use of FSoftObjectPath with UPROPERTY for dependent metasound assets.
#jira UE-156087
#rb rob.gay
#preflight 634841dffd22d1fbde5d7d73

[CL 22512918 by phil popp in ue5-main branch]
2022-10-13 17:38:11 -04:00
sondra moyls
b0598a048e - Fix for off by one on looping Sound Waves in MetaSounds
- Fixed typo in Nearly Finished tooltip
#jira UE-160453
#preflight 6340b297090af7205c2a1a35
#rb phil.popp

[CL 22488819 by sondra moyls in ue5-main branch]
2022-10-12 19:51:02 -04:00
phil popp
25b5881f1c Remove 5.0 channel format from MetaSoundSource and MetaSound WavePlayer node.
#jira UE-161170, UE-161172
#rnx
#preflight 63460236b757820b7aa1fdd2
#rb helen.yang

[CL 22482360 by phil popp in ue5-main branch]
2022-10-12 14:07:25 -04:00
rob gay
84771db13f Remove input receive node injection by implementing receive implementation within non-ctor input node operator
#rb phil.popp
[REVIEW] phil.popp
#rnx
#jira UE-166569
#preflight 63445c0f360ee7edea15afdb

[CL 22437484 by rob gay in ue5-main branch]
2022-10-10 15:44:28 -04:00
rob gay
4717e1f676 [MetaSounds] Fix sync not working in wavetable sampler.
- Minor clean-up & description updates
- Make sync advanced pin
#rb
#jira UE-160918
#rnx
#preflight 633629a02f447ea8dc330b41

[CL 22271333 by rob gay in ue5-main branch]
2022-09-30 11:18:31 -04:00
rob gay
08f64dc10a [MetaSounds] Param loop virtualization fixes
- Split default param transmitter to SoundCueTransmitter & ParameterTransmitterBase to avoid generating transmitters for SoundBase child classes that don't support/require one (ex. SoundWaves)
- Move param transmitter to sharedptrs to avoid a bunch of unnecessary copy/clone logic when virtualizing loops
- Remove DefaultParameters field on ActiveSound in favor of shared impl in FParameterTransmitterBase that caches current state of parameters
- Fix for move that clears out active sound's current parameters when sound could have multiple wave instances that need said parameters
#rb phil.popp
#jira UE-164898
#preflight 6334a0a1ee7b13756dcd20ea

[CL 22240385 by rob gay in ue5-main branch]
2022-09-28 22:19:31 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
phil popp
2e184292d0 Fix for inconsistent metasound wave seek functionality
#jira UE-141007
#rb Max.Hayes
#preflight 6331d34ed747fe52c8ac4344

[CL 22191815 by phil popp in ue5-main branch]
2022-09-26 15:21:29 -04:00
phil popp
1cd4208860 Make MetaSound parameter error logs into warnings
Add log warning when constructor input value is ignored on runnign instance.
#jira UE-162285
#rb Rob.gay
#preflight 632b4cf72c7bc831f867d2c1

[CL 22121048 by phil popp in ue5-main branch]
2022-09-21 15:42:38 -04:00
rob gay
31435d69a5 Fix bug with synchronization not being completed prior to validation for referenced MetaSound graphs
TLBSRA (Too long but still read anyway)
This was due to validation moving to recursive behavior but sync not to support bubbling up referenced errors/warnings in 5.1.  This resulted in missing members after interface transforms are applied and potentially hitting ensures in validation.
...
But wait there's more!!! Synchronization on tick is now more efficient as it doesn't attempt to resynchronize/validate references already synchronized/validated in prior pass in same frame due to referencing graph needing to sync

#rb helen.yang
#rnx
#jira UE-162586
#preflight 63223e6c29254beccbf06119

[CL 22019580 by rob gay in ue5-main branch]
2022-09-14 18:49:46 -04:00
robert millar
aa6e458004 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for Metasound.

#jira UE-161932
#rb none
#preflight https://horde.devtools.epicgames.com/job/631f7da6a9331c69c3aa4ac5

[CL 21976387 by robert millar in ue5-main branch]
2022-09-12 19:52:49 -04:00
helen yang
d14412ac5b Rename MetaSound cvars for consistency, fix typos
#jira none
#rb trivial
#preflight 630d758d556fc14dce5ad10c

[CL 21707153 by helen yang in ue5-main branch]
2022-08-30 15:11:11 -04:00
Rob Gay
25826b9069 Summer Cleaning
- Rename MetasoundArchetype Source file to MetasoundFrontendInterface
- Move MetaSound interface files to subdirectory.
- Break out document versioning transforms to own impl/header
#rb todo
#rnx
#jira none
#preflight 62fed263200ff87e07d77340

[CL 21458865 by Rob Gay in ue5-main branch]
2022-08-19 12:14:31 -04:00
phil popp
5fc6f172c9 [MetaSound] Allow Constructor pin to be set from BP
#rb Rob.Gay
#jira UE-153913
#preflight 62fe6e68f7404b55a3fd49f9

[CL 21445924 by phil popp in ue5-main branch]
2022-08-18 13:55:13 -04:00
anna lantz
19aa2b8ac1 Adding tags to MetaSound nodes
#jira UE-157173
#rb Rob Gay
#preflight 62fd50f5830482fd822493e8

[CL 21431230 by anna lantz in ue5-main branch]
2022-08-17 16:42:56 -04:00
Rob Gay
6227019354 Tooltip fix
#rb trivial
#rnx
#preflight skip
#jira none

[CL 21417015 by Rob Gay in ue5-main branch]
2022-08-16 19:21:52 -04:00