Commit Graph

846 Commits

Author SHA1 Message Date
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
phil popp
afb10dfdc7 Fix for metasound failing to play when soundwave loading behavior improperly overriden
#rb Max.Hayes
#preflight 63768904947d2d19ed0205b0

[CL 23183911 by phil popp in ue5-main branch]
2022-11-17 16:36:26 -05:00
Matt Peters
007584827b Metasounds: Fix missing dependencies during EditorDomain save of Metasound objects by shifting WaitUntilAsyncLoadReferencedAssetsComplete to earlier in PreSave, and by extending it to recursively wait for all transitive dependencies.
This fixes EditorDomain saves because they occur immediately after load of the package so waiting for async dependencies to load is required.
#jira UE-170378
#rb Phil.Popp
#rnx
#preflight 63766ddcb1509f1cc3fce67c

[CL 23178540 by Matt Peters in ue5-main branch]
2022-11-17 12:31:19 -05:00
nicholas howe
373ad2a12c Metasound Audio Bus Writer Node
Adds a metasound node that sends its audio input to an audio bus.
Modifies the audio mixer interface to support the node.

FMixerSourceManager::StartAudioBus no longer sets bIsPlaying to false on sources that use an audio bus when the audio bus starts.
FMixerAudioBus::MixBuffer mixes its patch inputs into its MixedSourceData buffer, so that the patch input data is available when CopyCurrentBuffer is used to retrieve the mix.

[REVIEW] [at]aaron.mcleran [at]buzz.burrowes [at]phil.popp
#preflight 6372639c5368a3230a4ed041

[CL 23123823 by nicholas howe in ue5-main branch]
2022-11-14 14:44:30 -05:00
Rob Gay
25d3c6e253 Audio Dashboard Implementation Checkpoint
#rb helen.yang
#jira UE-168953
#preflight 636d4990a430c8fbeab100a3

[CL 23085100 by Rob Gay in ue5-main branch]
2022-11-10 14:15:27 -05:00
ryan challinor
813e7fb4e6 add "hard reset" capability to metasounds ADSR envelope node, to match recent "hard reset" functionality in AD node from 22886510
additionally, simplify implementation of AD node's hard reset functionality to retain ease.

#preflight 636a8be163037c102654f289

[CL 23041511 by ryan challinor in ue5-main branch]
2022-11-08 17:17:39 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
ryan challinor
a31df40ba0 metasounds switch-and-ramp node for smoothing out pops, and the ability for the AD envelope to hard reset (i.e., start from zero rather than the current value)
#preflight 63614311731604696a165511

[CL 22891022 by ryan challinor in ue5-main branch]
2022-11-01 16:34:43 -04:00
henrik karlsson
4a36cfe8ff Moved operator== to be hidden friend instead of put directly in global namespace
Moved GetTypeHash function to be hidden friend instead of put directly in global namespace.

Note that the function/operator needs to be fully inlined in the type or placed in the cpp. If the function is added as friend but then implemented outside the type then hidden friend optimization won't work.

This should improve compile time somewhat according to msvc devs.

#rb Steve.Robb
#preflight 6360b7052b5338aceb26471b

[CL 22889837 by henrik karlsson in ue5-main branch]
2022-11-01 15:50:27 -04:00
henrik karlsson
8f895fef35 Added includes needed after removing includes in headers
#preflight 6360b63e41625be270a6e464
#rb none

[CL 22888775 by henrik karlsson in ue5-main branch]
2022-11-01 15:14:15 -04:00
buzz burrowes
523b56c0ca Change result of applying an Attack and Release trigger on the same block sample index.
Prior to this change, attack triggers are ALWAYS processed before release triggers.

This change ONLY affects functionality when an attack trigger and release arrive at the same sample AND only if the ADSR is already tiggered. In this case the release trigger will now be processed before the attack trigger... stopping the currently triggered ADSR and then restarting it.

[REVIEW] [at]phil.popp [at]rob.gay [at]aaron.mcleran
#preflight 636023913734aafa28aa2e3c

[CL 22876432 by buzz burrowes in ue5-main branch]
2022-10-31 21:22:34 -04:00
henrik karlsson
4a5e13525d Fixed non-unity non-pch compile errors
#preflight skipped
#rb none

[CL 22788359 by henrik karlsson in ue5-main branch]
2022-10-26 16:22:34 -04:00
rob gay
9548b0ee1a [MetaSounds] Fix for ensure when naming an input with "/". Forbid use of analyzer '/' in MetaSound member names & don't bloat FName table with attempted renamed members
#rb helen.yang
#jira UE-168051
#preflight

[CL 22786989 by rob gay in ue5-main branch]
2022-10-26 15:28:20 -04:00
rob gay
18e887e937 [MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f

[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
helen yang
614fa56c85 Fix MetaSound input widget value not matching actual default value
#jira UE-168040
#rb rob.gay
#preflight 635547b40313c2497498ae78

#rnx

[CL 22779973 by helen yang in ue5-main branch]
2022-10-26 10:53:25 -04:00
helen yang
720fde6bdb Fix MetaSound edited graph member not selected after undo/redo
#jira UE-168037
#rb rob.gay
#preflight 63547ad73a547c3da3ce6cdd

#rnx

[CL 22779966 by helen yang in ue5-main branch]
2022-10-26 10:53:20 -04:00
helen yang
e45ee2fa99 Fix incorrect MetaSound constructor pin image caused by access type not being cached
#jira UE-168023
#rb rob.gay
#preflight 63534e339e14ee3c79c6365e

#rnx

[CL 22716094 by helen yang in ue5-main branch]
2022-10-23 20:35:40 -04:00
helen yang
4eacbb09ba Fix MetaSound preset inputs being incorrectly selected after edit, save, or play
#jira UE-168006
#rb phil.popp
#preflight 63531f863d41a4455ab9fa0b
#rnx

[CL 22712198 by helen yang in ue5-main branch]
2022-10-22 15:36:58 -04:00
rob gay
54827036cd Optimization pass on MetaSound SlatePanel/Node/Pins & add profiler events
#rb phil.popp helen.yang
[REVIEW] phil.popp helen.yang
#rnx
#jira UE-167866
#preflight 6352e2e7e6096564af816419

[CL 22711562 by rob gay in ue5-main branch]
2022-10-22 14:43:51 -04:00
helen yang
6341755a3f Static analysis fix for MetaSound node loctext being compiled out for non editor builds
#rb phil.popp
#jira none
#preflight 63508ce0c9559712ed2301d0

#rnx

[CL 22670276 by helen yang in ue5-main branch]
2022-10-20 16:38:58 -04:00
anna lantz
be286bb14c Fix for Limiter Distortion with non-zero attack times
#jira UE-157404
#rb alfaroh.corneyiii
#preflight 63506678c9559712ed1397de

[CL 22649064 by anna lantz in ue5-main branch]
2022-10-19 22:39:29 -04:00
helen yang
0f9445aed9 Fix undo/redo for MetaSound widgets and linear output for volume widgets
- Differentiate between normalized linear and audio linear value for volume output options

#jira UE-145790
#jira UE-155181
#rb phil.popp
#preflight 634f3778c569571da8a4ab2c
#rnx

[CL 22635724 by helen yang in ue5-main branch]
2022-10-19 15:34:44 -04:00
alfaroh corneyiii
4762921ab0 Fix crashes in Audio Bus Reader node when no Audio Bus is given
#jira UE-167439
#rb max.hayes
#preflight 634f080e773a16f49d2748d4
#lockdown nick.whiting

[CL 22632998 by alfaroh corneyiii in ue5-main branch]
2022-10-19 14:33:15 -04:00
helen yang
fe90ab6c47 MetaSound preset fixes: Update node descriptions for referencing graphs, remove variable header, prevent preset vertices from being renamed
#jira UE-144913
#jira UE-158433

#rb rob.gay
#preflight 634de597820aa0c193075786

[CL 22628259 by helen yang in ue5-main branch]
2022-10-19 12:32:23 -04:00