Commit Graph

101 Commits

Author SHA1 Message Date
brice criswell
937b6bd45a Dataflow : Remove unused toolkits
#rb none
#preflight 636c0458a550a2a759100149

[CL 23071865 by brice criswell in ue5-main branch]
2022-11-10 01:10:24 -05:00
henrik karlsson
b75f8273d9 Include removals
* GeometryCollectionComponent.h - Most files are related to the removal of includes in this file. Removed 7 headers
   - Moved GeometryCollectionDamagePropagationData in to its own file
   - Changed COPY_ON_WRITE_ATTRIBUTE to be set in a way so implementations can be placed in cpp file.
   - Moved some function implementations to cpp file
* Removed include in FieldSystemActor.h
* Removed include in FieldSystem.h
* Removed include in CommonUISettings.h


#preflight 636b325c376a9cd6a8818aae
#rb cedric.caillaud (for the actual changes, not additional includes and a couple include removals outside GeometryCollection)

[CL 23069399 by henrik karlsson in ue5-main branch]
2022-11-09 20:53:21 -05:00
brice criswell
34a671b274 Dataflow : Generic evaluation from DataflowEditor
- Allow dataflow to perform graph evaluations.
#rb none
[FYI] Cedric.Caillaud, Gustav.Melich
#preflight 636ad035843e6ac794e4f7a6

[CL 23049086 by brice criswell in ue5-main branch]
2022-11-09 02:18:51 -05:00
brice criswell
42a3cd1758 Dataflow : Proper Context type identification.
#rb none
#preflight 6365a3f4d308b70e6672df29

[CL 22999978 by brice criswell in ue5-main branch]
2022-11-04 22:38:02 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
Brice Criswell
d520c6913a GeometryCollectionEditor: Persistent dataflow context with invalidation.
#rb none
#preflight 634f8fedac48fa11ed1ce358

[CL 22618684 by Brice Criswell in ue5-main branch]
2022-10-19 01:58:50 -04:00
Brice Criswell
829e474cea Dataflow : Evaluation
- Formalized the caching timestamp with a struct wrapper.
#rb none
#preflight 634ee9121341cb8a2062dc6b

[CL 22606834 by Brice Criswell in ue5-main branch]
2022-10-18 14:29:38 -04:00
cedric caillaud
d10f14e49c Chaos : fix potential crash with generating geometry collection thumbnails
#rb trivial
#preflight none

[CL 22547832 by cedric caillaud in ue5-main branch]
2022-10-15 02:12:40 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
rex hill
6f5e038a59 Fix GeometryCollection slate icons missing from cooked editors
#preflight skip
[FYI] Michael.Lentine

[CL 22140330 by rex hill in ue5-main branch]
2022-09-22 14:03:41 -04:00
nick darnell
8c6dccfce9 Core - Making some improvements to TObjectPtr, introducing some templating utilities so that we can better template match TObjectPtr vs UObject* pointers so that a single templated function can work for either.
Core - Added support for assigning a TObjectPtr<T> to a TScriptInterface just like you'd expect from a raw Object*.

Actor - Making a version of GetComponents that will work for TObjectPtr collections.  Additionally fixed several places in the engine where we're forcing the template parameter instead of allowing it to be determined automatically - which forced me to leave one of the GetComponent implementations, but I think we aught to remove it. e.g.

Don't Do

TArray<UPrimitiveComponent*> PrimComponents;
Actor->GetComponents<UPrimitiveComponent>(PrimComponents);

Do

TArray<UPrimitiveComponent*> PrimComponents;
Actor->GetComponents(PrimComponents);

Slate - Introducing support for collections of TObjectPtr<T>'s being used as source lists for the STableView.

#preflight 630f7af8e54ec9d581b03d65
[REVIEW] [at]Marc.Audy, [at]Steve.Robb, [at]Zousar.Shaker

[CL 21727328 by nick darnell in ue5-main branch]
2022-08-31 16:13:49 -04:00
kriss gossart
0422ca7705 Skeletal Mesh - Replace the newly created GetSkeletalMesh function by GetSkeletalMeshAsset so it matches the setter SetSkeletalMeshAsset function (which itself couldn't be named SetSkeletalMesh due to the function already existing and doing something else).
#rb Josie.Yang
#preflight 62fa2afeae3edb54c979492e
#jira none

[CL 21385959 by kriss gossart in ue5-main branch]
2022-08-15 09:26:50 -04:00
Brice Criswell
e58a3499e0 Dataflow - Connections as UStruct
#rb none
#preflight 62acfb235c69124c40dbb3ea

[CL 20711897 by Brice Criswell in ue5-main branch]
2022-06-17 18:30:14 -04:00
Josie Yang
6b15506e58 Replace direct access to SkeletalMesh object from USkinnedMeshComponent with GetSkeletalMesh function
#rb kriss.gossart
#preflight 62aafc9ada0af39a4783930a

[CL 20686007 by Josie Yang in ue5-main branch]
2022-06-16 09:14:04 -04:00
Brice Criswell
ff1f9793c8 Dataflow : FContext CRT udpate
#rb none
#preflight 62a39bf0a76bc5b5cacd85a5

[CL 20601401 by Brice Criswell in ue5-main branch]
2022-06-10 16:06:26 -04:00
Brice Criswell
e6569adcc9 Dataflow : Support for FProperty on the FNode
#rb none
#fyi Ryan.Kautzman, Benn.Gallagher, Gustav.Melich, Cedric.Caillaud
#preflight 62a18ec1f73a01bd9811dad8

[CL 20572155 by Brice Criswell in ue5-main branch]
2022-06-09 02:36:29 -04:00
Brice Criswell
ed37b71c02 GeometryCollection : Structure change
- Moved AppendStaticMesh and AppendSkeletalMesh to the Engine level
- Moved the Node implementation into GeometryCollectionNodes within the plugin.
#rb trivial
#preflight 6298120a216be32a7627a7e0

[CL 20464135 by Brice Criswell in ue5-main branch]
2022-06-01 21:41:57 -04:00
Benn Gallagher
8757cb3641 Physics interface cleanup.
* Removed deprecated or dead code paths
* Simplified build system setup for physics support
* Deprecated build system flags and unsupported macros

#jira none
#rb Chris.Caulfield, Kriss.Gossart
#preflight 62963ec0fe779f23c8ea0c5e

[CL 20450744 by Benn Gallagher in ue5-main branch]
2022-06-01 06:59:18 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Brice Criswell
a21ff6e4af Dataflow - DragAndDrop support
#rb trivial
#preflight 62963373e62c873b96cc261d

[CL 20437873 by Brice Criswell in ue5-main branch]
2022-05-31 11:44:40 -04:00
Brice Criswell
eaf97b14d5 Dataflow - Add specialized GraphEdtior
#rb trivial
#preflight 6291243b1b686da53f3f15d6

[CL 20397858 by Brice Criswell in ue5-main branch]
2022-05-27 15:57:59 -04:00
Brice Criswell
266e38c598 GeometryCollection - Dataflow Editor
- Configure the dataflow asset editor for the geometry collection object. Currently requires the enabling the pvar (p.Chaos.GeometryCollection.DataflowEditor 1)
#rb Cedric.Caillaud, Jimmy.Andrews
#preflight 628fd5838c077c0d66238920
#preflight 628fdc9af622d972b5f45181
#preflight 629002b94f63120d8ef4914c

[CL 20387372 by Brice Criswell in ue5-main branch]
2022-05-26 19:00:40 -04:00
cedric caillaud
5ddbe667f4 Chaos destruction : allow import of collision shapes from static meshes when creating a geometry collection
#rb brice.criswell, ori.cohen
#jira none
#preflight 628dabdcaf7a2e956ba42d3d

[CL 20380362 by cedric caillaud in ue5-main branch]
2022-05-26 12:02:54 -04:00
cedric caillaud
a156b97f48 Chaos : harden manageArray Api for better detection of modification to the array
this is a step towards more automated recompoutation of some attributes dependent on others

#rb brice.criswell
#jira none
#preflight 627ae07e7e5f24d1ede8e730

[CL 20131611 by cedric caillaud in ue5-main branch]
2022-05-10 18:56:28 -04:00