Commit Graph

13 Commits

Author SHA1 Message Date
jamie dale
8e34ecadf6 Fixed ControlFlow TSharedFromThis deduction for derived types
struct Foo : public TSharedFromThis<Foo>
{
    // ...
};

struct Bar : public Foo
{
    // ...

    void Execute()
    {
        FControlFlow& ControlFlow = ...;
        ControlFlow.QueueStep(this, &Bar::DoStep);
    }

    void DoStep()
    {
    }
};

The QueueStep deduction would fail as it expects the type to be directly derived as TSharedFromThis<Bar> rather than indirectly via TSharedFromThis<Foo>

#preflight 636a7040dc30a4ce96a157a7
[FYI] Geoffrey.Wong
#rb Steve.Robb
#rnx

[CL 23039132 by jamie dale in ue5-main branch]
2022-11-08 16:02:15 -05:00
Robb Surridge
610c467639 Update vendor links for built-in plugins to use secure protocol.
#jira UE-166823
#rb lauren.barnes
#preflight 6352b20b7261e565c476ec3b

[CL 22690089 by Robb Surridge in ue5-main branch]
2022-10-21 11:04:07 -04:00
bryan sefcik
0eeac455e0 Pass 3 on cleaning up build.cs files.
#jira
#preflight 631b9c15d31788ea3ab0f27b

[CL 21935601 by bryan sefcik in ue5-main branch]
2022-09-10 00:02:58 -04:00
geoffrey wong
2e2dce4e11 Two crash fixes:
1) Calling AsShared() during the destructor a TSharedFromThis
2) Resetting ConcurrentFlows when there are nested ConcurrentFlows

[REVIEW] [at]marti.majo, [at]mickael.gilabert
#tests locally repro bug and verified fix

[CL 21723950 by geoffrey wong in ue5-main branch]
2022-08-31 13:27:24 -04:00
henrik karlsson
7f1ea8a80c [ControlFlows]
* Added support for TrackedActivity so we can visualize various control flow's state in the console window
* Changed verbose logging a little bit to skip name of task node when task has a proper name. Couldn't find a case where task node didn't have the name unnamed

#rb Devin.Doucette
#preflight 6303dfd2820001c02cc28cc4

[CL 21511693 by henrik karlsson in ue5-main branch]
2022-08-23 12:56:43 -04:00
geoffrey wong
e43c781d98 If the Concurrent Control Flow Task was never created, and cancel was called, we should just broadcast that the Control Flow Task was Cancelled
#ROBOMERGE-AUTHOR: geoffrey.wong
#ROBOMERGE-SOURCE: CL 21070492 via CL 21071376 via CL 21071433 via CL 21071489
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21079697 by geoffrey wong in ue5-main branch]
2022-07-13 16:27:20 -04:00
geoffrey wong
3fa491c112 Fix
#ROBOMERGE-AUTHOR: geoffrey.wong
#ROBOMERGE-SOURCE: CL 20809616 via CL 20809627 via CL 20809644 via CL 20809659
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20811486 by geoffrey wong in ue5-main branch]
2022-06-24 12:54:45 -04:00
geoffrey wong
e0ade3383f ControlFlow Expansion: ForkFlow
You can chain your flow with this lambda:

.ForkFlow([this](TSharedRef<FConcurrentControlFlows> ConcurrentFlows) {})

And that will allow you create multiple control flows to execute "at the same time" (still single-threaded).

The default continue behavior from the Fork is to wait until all concurrent flows have been [completed or cancelled]


#ROBOMERGE-AUTHOR: geoffrey.wong
#ROBOMERGE-SOURCE: CL 20809293 via CL 20809308 via CL 20809400 via CL 20809435
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20811474 by geoffrey wong in ue5-main branch]
2022-06-24 12:54:34 -04:00
geoffrey wong
273b489a33 Added new ensure messaging to help guide people on what to do.
#ROBOMERGE-AUTHOR: geoffrey.wong
#ROBOMERGE-SOURCE: CL 20385313 via CL 20385322 via CL 20385360 via CL 20385389
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20387491 by geoffrey wong in ue5-main branch]
2022-05-26 19:08:14 -04:00
nick darnell
866782cad7 ControlFlow - Add an accessor to get the debug name of the current step you're performing.
#jira UE-142177
[REVIEW] [at]Geoffrey.Wong
#preflight 6205668fb84973a2bb61dc4f
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 18943117 in //UE5/Release-5.0/... via CL 18943359 via CL 18943612
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18943924 by nick darnell in ue5-main branch]
2022-02-10 17:09:04 -05:00
geoffrey wong
f4f7f4c6e3 Added option so cancelled nodes in a flow queue do not cancel the parent flow
#ROBOMERGE-AUTHOR: geoffrey.wong
#ROBOMERGE-SOURCE: CL 18546700 via CL 18546718 via CL 18546738 via CL 18546754 via CL 18547613 via CL 18547676
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18547744 by geoffrey wong in ue5-release-engine-test branch]
2022-01-07 13:01:17 -05:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00