Commit Graph

555 Commits

Author SHA1 Message Date
Brandon Schaefer
4a75d0274c Update P4Utils to new dlls
#jira none
#rb Josh.Adams
#preflight none

[CL 23180068 by Brandon Schaefer in ue5-main branch]
2022-11-17 13:54:05 -05:00
VesCodes
8f9a2e08eb PR #9013: RoboMerge: Fix Slack API issues (Contributed by VesCodes)
[CL 23179164 by VesCodes in ue5-main branch]
2022-11-17 12:56:45 -05:00
marc audy
1918b5ac50 Fix previewing failing when bot has no alias
[CL 23120226 by marc audy in ue5-main branch]
2022-11-14 12:10:15 -05:00
marc audy
1804d924e7 Allow stomp in binary branch and delete cases
Text files will still fail due to the standard text file restrictions

Ping users with the locked files on exclusive check outs
Fix some exclusive checked out files not reporting (presumably those on edge servers?)

Fix channel IDs to be consistent when initial post and nagging when there are multi-step integrations that cause a blockage

Aliases now displayed on allbots page

Functional tests now use 2022.1 perforce server

[CL 23107523 by marc audy in ue5-main branch]
2022-11-11 18:24:48 -05:00
joe kirchoff
d6e0a648e6 Add CompileScore app to perforce
#rnx
#rb trivial
#jira UE-163049

[CL 23091646 by joe kirchoff in ue5-main branch]
2022-11-10 20:53:32 -05:00
paul chipchase
fc50254bb2 Add a P4V command to open up a the preflight page in a browser if there is a #preflight tag in a changelist description.
#rb Sebastian.Nordgren, Ryan.Hummer
#rnx
#preflight 636a63c063037c1026488d19

- We search the changelist description for '#preflight ???' and then open the appropriate page.
- If no tag is found we will display a message to the user via a modal dialog so that they are aware that no page will be opened.
- Refactored PreflightCommand.OpenUrl to be a public static method to avoid copy and pasting code.
- Refactored PreflightCommand.GetUrl to move the extraction of the Horde server address to a public static method to improve code re-use.
- The command will be added to P4 so that it can be used on pending and submitted changelists.

[CL 23050223 by paul chipchase in ue5-main branch]
2022-11-09 05:15:59 -05:00
paul chipchase
72e78c8b3a Add some .bat files to simplify development
#rb trivial

- The bat files can be used to uninstall the version of P4VUtils provided by UGS (to provide a blank slate for development) and then re-install that version when done.

[CL 23009814 by paul chipchase in ue5-main branch]
2022-11-07 09:09:00 -05:00
paul chipchase
4e94856e98 Display the final submitted changelist number as well as the original changelist number.
#rb Sebastian.Nordgren
#jira UE-155978
#preflight 63690858d0174259ccbd601c

- When this tool was written the p4 c# api did not return the submitted changelist number, so as a quick work around we just logged the original changelist number.
- Since the C# api was fixed and now returns the submitted changelist value we can log it.
- Changed the comments to show why we can have multiple records back.

[CL 23009761 by paul chipchase in ue5-main branch]
2022-11-07 09:00:12 -05:00
Ben Marsh
cab220dbe9 P4VUtils: Fix compilation errors due to using NET Core 3.1.
#preflight none
#fyi Paul.Chipchase

[CL 23009622 by Ben Marsh in ue5-main branch]
2022-11-07 08:28:12 -05:00
paul chipchase
fb2d8c2e36 Logging clean up pass
#rb trivial
#rnx
#preflight 6368efb063037c102686e1ea

- Prefixed all error logs with "Error: " as the p4v terminal does not support text colours so there was no way to tell info from an error.
- Reworded some logging info and added a few more linebreak to improve readability.

[CL 23009315 by paul chipchase in ue5-main branch]
2022-11-07 07:01:59 -05:00
paul chipchase
136758f62c Fixed an issue where P4VUtils was not correctly finding the precompiled binary version (PCB) of UnrealVirtualizationTool if needed.
#rb Sebastian.Nordgren
#jira UE-168878
#rnx
#preflight 6368dea2d0174259cc4bdfb1

- Previously we were checking the version of the tool (if found) and assuming that a promoted build meant a precompiled binary. Recent changed to our build farm means that this assumption no longer works and was preventing people who did not have source code synced from running the tool.
- The previous logic was to check if the editor was a PCB and if it was not then compile the code locally. So if a user downloaded PCB we would use them, up until they recompiled the editor locally at which point we'd change to compiling UnrealVirtualizationTool as well, which was an attempt to keep things in sync. However once we stopped detecting PCB properly, every editor was considered "locally built" meaning we had to build the tool and this would prevent users without source code (who could not build) from continuing.

- As a short term fix the logic has been changed. We now check to see if the UBT project can be found. If it can we assume the user has source code in which case we just build the tool. If we do not find the project we assume no source code and the user must be using PCB, so we try to use that.
- This does mean that a user with source code could get a mismatch in future, using the PCB editor with a locally built UnrealVirtualizationTool (that might have changes compared to the editor) but that case should be less common and less of a problem than our current issues.
- This logic change can be reverted once a method is deployed that will allow us to more reliably tell the difference between PCB exes and locally built.

[CL 23009202 by paul chipchase in ue5-main branch]
2022-11-07 06:30:26 -05:00
marc audy
89a7add03b Fix message when triager not specified
[CL 23003863 by marc audy in ue5-main branch]
2022-11-06 00:56:35 -04:00
james hopkin
f9dc042700 [robo] Copied over v2 docs
[CL 22990101 by james hopkin in ue5-main branch]
2022-11-04 13:06:06 -04:00
marc audy
cf20c30e5f Check for resolved conflicts at a node level instead of an edge level to clear out stale conflicts due to syntax errors or on edges that no longer exist.
Also strip on load very old conflicts that don't have all the expected persisted data

[CL 22971121 by marc audy in ue5-main branch]
2022-11-03 19:34:55 -04:00
marc audy
a812689f6d Fix nag notifications being able to be disabled
[CODEREVIEW] James.Hopkin

[CL 22942151 by marc audy in ue5-main branch]
2022-11-03 01:31:23 -04:00
marc audy
ce31434e74 Clear internal ugs url
[CL 22923816 by marc audy in ue5-main branch]
2022-11-02 15:12:16 -04:00
brian smith
dbb53bf726 Live Link VCAM 1.3.0 build 11.
[CL 22911050 by brian smith in ue5-main branch]
2022-11-02 08:01:55 -04:00
brian smith
7d8d8e73be Live Link VCAM v1.3.0 build 10 (release). Last localization.
[CL 22906837 by brian smith in ue5-main branch]
2022-11-02 04:49:01 -04:00
marc audy
0df8594f99 Fix node resolver not being used when there are edge properties
Reconsider errors to direct messages
Correct slack style on existing error messages
Display bot alias in the graph

[CL 22889461 by marc audy in ue5-main branch]
2022-11-01 15:39:25 -04:00
joe pribele
6c9a016275 [UnrealVS] changed TestAdapater to report durations
refactored projects to share files avoiding having to duplicate changes between VS2019 and VS022
added menu to improved discoverability of features
added option to use P4V diff instead of VS diff
#preflight 635c17593c0af539fd57079d

[CL 22833331 by joe pribele in ue5-main branch]
2022-10-28 14:15:27 -04:00
marc audy
0874edfa5b Protect against failure to look up user
[CODEREVIEW] James.Hopkin

[CL 22829217 by marc audy in ue5-main branch]
2022-10-28 11:38:19 -04:00
chris constantinescu
6e6801dd11 Cmake version 3.24 upgrade
#rnx
#preflight skip

[CL 22828061 by chris constantinescu in ue5-main branch]
2022-10-28 09:57:08 -04:00
marc audy
9f4b417320 Make Slack get consistent with post in that a call can specify that it canFail
Fix up dummy slack server to be able to deal with add user to channel flow
[CODEREVIEW] James.Hopkin

[CL 22823838 by marc audy in ue5-main branch]
2022-10-28 01:00:58 -04:00
marc audy
fb94238523 Store off the log before functional test cleans up
[FYI] James.Hopkin

[CL 22823824 by marc audy in ue5-main branch]
2022-10-28 00:59:12 -04:00
marc audy
76bebb9b57 Reorganize slack messages API to allow issuing slack messages from bots and begin shift away from email
Tag and invite owner when conflict is posted to channel
Nagging and triaging
Provide syntax and commit errors in channel
Shelf created notifications come via slack
Use slack to notify user of syntax error and commit error on reconsider

[CL 22823436 by marc audy in ue5-main branch]
2022-10-28 00:04:13 -04:00