Commit Graph

90 Commits

Author SHA1 Message Date
Marc Audy
aed1f9acc9 Fix CrashReporter shadow variables
#lockdown Zachary.EdgertonJones

[CL 2521930 by Marc Audy in Main branch]
2015-04-22 17:58:53 -04:00
Matthew Griffin
a5adc34677 Cleaned up Crash Reporter Rocket checks, changed some code so that it's the same for all build types.
#codereview jaroslaw.surowiec

[CL 2517564 by Matthew Griffin in Main branch]
2015-04-20 10:18:51 -04:00
Ben Marsh
fac4fb7069 Allow target rules to specify which build configuration doesn't have the -Platform-Configuration suffix appended to all binaries.
[CL 2509827 by Ben Marsh in Main branch]
2015-04-12 10:51:07 -04:00
PaulEremeeff
c9a246101e PR #1013: Fixing PVS-Studio warnings. (Contributed by PaulEremeeff)
Some files have been omitted and will be submitted with modified corrections

[CL 2505544 by Dan Oconnor in Main branch]
2015-04-08 14:46:25 -04:00
Marc Audy
b281cd2844 Fix deprecation warning in SCrashReportClient.cpp
#codereview Jaroslaw.Surowiec

[CL 2501461 by Marc Audy in Main branch]
2015-04-03 15:04:14 -04:00
Ben Marsh
0de65e95bd Deprecate bBuildAdditionalConsoleApplication from LinkEnvironment, and move it to UEBuildBinaryConfiguration instead - it's not actually used by anything that does linking; it's a higher level behavior. The default is now false, which mirrors the only use case we had for it (and removes a hack for checking UEBuildConfiguration.bBuildEditor).
[CL 2499917 by Ben Marsh in Main branch]
2015-04-02 11:09:01 -04:00
Wes Hunt
0cc1ffd8f4 CrashReporter now identifies itself to analytics as CrashReporter instead of looking like another engine run. #UE-12598
* AppID is CrashReporter.[Release|Dev]
* UserID matches what we use everywhere else.
* After discussing with Analytics, they are not using this data yet, but it was easier to fix up the AppID than remove.
#codereview:Jaroslaw.Surowiec

[CL 2493805 by Wes Hunt in Main branch]
2015-03-27 10:43:02 -04:00
Jaroslaw Surowiec
e8f455f2ea UE-12159 - Crash Report Client fails to restart project if the path has a space
[CL 2487330 by Jaroslaw Surowiec in Main branch]
2015-03-22 05:42:39 -04:00
Ben Marsh
ddf1fa6832 Remove bBuildRocket from GUBP_AlwaysBuildWithTools; doesn't seem to be needed any more (and if it is, we need to fix it in a way that doesn't make "rocket" distinctions)
[CL 2476687 by Ben Marsh in Main branch]
2015-03-12 08:29:35 -04:00
Jaroslaw Surowiec
ddd8da5163 CrashReportClient - Minor tweak
[CL 2469930 by Jaroslaw Surowiec in Main branch]
2015-03-05 05:43:59 -05:00
Saul Abreu
79a26091bf Fixed behavior on FString::ParseIntoArray (muliple delimiters overload) functionality to support optionally culling empty strings. Greatly simplified implementation logic. Output parameter now properly named and taken by reference.
#codereview Steve.Robb, Robert.Manuszewski

[CL 2466824 by Saul Abreu in Main branch]
2015-03-02 15:51:37 -05:00
Kellan Carr
189e1a7c6a cis fix
[CL 2466379 by Kellan Carr in Main branch]
2015-03-02 11:17:56 -05:00
Mark Satterthwaite
88751c6da8 Rewritten debug symbol handling for OS X to allow creation of dSYM bundles & symbol stripping of executables.
- The MacToolChain will emit dSYMs and strip executables when the UBT configuration enables bGeneratedSYMFile, just like iOS.
- Symbol stripping requires generating dSYMs to prevent creation of non-debuggable builds whose crash reports would be unresolvable.
- To avoid a dependency on the Private framework CoreSymbolication all symbols from that framework are loaded dynamically & can only be used within programs, not the game or the editor, as CoreSymbolication is incompatible with non-ANSI malloc implementations.
- Added an initial platform-agnostic API for querying debug symbol info, including a generic database format that can be queried on otherwise incompatible platforms.
- Added UnrealAtoS that emulates Apple's atos to resolve symbols using the generic database or the platform API (CoreSymbolication on OS X) which on OS X is used by the editor to gather symbol info for CodeView.
- Added DSymExporter which will export Apple debug symbol data from Mach-O binaries, including the payload within a .dSYM bundle, to the generic format so that the crash report server may one day read the data without needing a Mac to symbolicate reports.
- Initial SymbolDebugger & MinidumpDiagnostics support on OS X.
#codereview michael.trepka, Jaroslaw.Surowiec, lee.clark, peter.sauerbrei

[CL 2466299 by Mark Satterthwaite in Main branch]
2015-03-02 10:21:50 -05:00
Jaroslaw Surowiec
bfb5ca2663 CrashReportClient - Added basic configuration for the crash report receiver
[CL 2466181 by Jaroslaw Surowiec in Main branch]
2015-03-02 07:53:07 -05:00
Jaroslaw Surowiec
becbf48be1 CrashReportClient - Improved app shutting down
[CL 2462011 by Jaroslaw Surowiec in Main branch]
2015-02-26 07:14:56 -05:00
Jaroslaw Surowiec
081d654cc2 CrashReport - Logs are always uploaded, even for UE4 releases
[CL 2460279 by Jaroslaw Surowiec in Main branch]
2015-02-25 10:38:53 -05:00
Jaroslaw Surowiec
b97abcce8a CrashReport - Enabled writing a Diagnostics.txt to disk in UE4 release build, if a callstack is valid, it will sent to the server.
[CL 2460278 by Jaroslaw Surowiec in Main branch]
2015-02-25 10:38:35 -05:00
Richard TalbotWatkin
7ffafdf4d8 Tweaks to CrashReportClient.
#codereview Robert.Manuszewski, Jaroslaw.Surowiec

[CL 2446790 by Richard TalbotWatkin in Main branch]
2015-02-16 05:29:38 -05:00
Richard TalbotWatkin
be15b48730 Various crash reporter improvements: made scrollbars visible, added splitter between editable field and crash details, added "Send and Restart" button to restart the crashed application.
#jira UE-9295 - Reopen Editor from Crash Reporter
#jira UE-9164 - CrashReporter text field not sizeable
#jira UE-9163 - CrashReporter callstack textbox scrollbars invisible

[CL 2446754 by Richard TalbotWatkin in Main branch]
2015-02-16 04:50:29 -05:00
Jaroslaw Surowiec
eb9549c5be CrashReportClient - Tweaks to the UI (fixed scrollbars not visible)
[CL 2441647 by Jaroslaw Surowiec in Main branch]
2015-02-11 10:37:27 -05:00
Jaroslaw Surowiec
a25cace3cf Core - UE-9320 Mac crashes are not uploading to Crash Reporter
[CL 2441517 by Jaroslaw Surowiec in Main branch]
2015-02-11 09:23:31 -05:00
Jaroslaw Surowiec
487db9681e #CORE - UE-9320 Mac crashes are not uploading to Crash Reporter (added an option to override the stack size for threads created for the thread pool)
[CL 2437977 by Jaroslaw Surowiec in Main branch]
2015-02-09 09:56:11 -05:00
Jaroslaw Surowiec
d0d90114fb CrashReportClient - Tweaks to the UI
[CL 2429505 by Jaroslaw Surowiec in Main branch]
2015-02-03 04:14:46 -05:00
Jaroslaw Surowiec
b1e92d575e CrashReportClient - Tweaks to the UI
[CL 2427896 by Jaroslaw Surowiec in Main branch]
2015-02-02 04:12:57 -05:00
Jaroslaw Surowiec
e3a0e4877d CrashReportClient - Tweaks to the UI
[CL 2425312 by Jaroslaw Surowiec in Main branch]
2015-01-30 02:50:17 -05:00