#rnx
#rb none
#ROBOMERGE-SOURCE: CL 10869250 via CL 10869537 via CL 10869906
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870965 by ryan durand in Main branch]
============================
MAJOR FEATURES & CHANGES
============================
Change 3873906 by Dan.Oconnor
Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type
#jira UE-51726
Change 3873614 by Dan.Oconnor
Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled
#jira UE-51726
Change 3873428 by Ben.Zeigler
#jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget
Copy of 3873408
Change 3873083 by Ethan.Geller
[4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron
Change 3872714 by Dan.Oconnor
Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously
#jira UE-53840
Change 3872648 by Ben.Zeigler
#jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets
Copy of CL #3872636
Change 3872500 by Arne.Schober
Back out changelist 3870283
#jira UE-54838
Change 3872412 by Mark.Satterthwaite
Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles.
#jira UE-54853
Change 3872313 by Martin.Wilson
Add UI to Live Link Client to warn live link users about background performance throttling
#jira none
Change 3872272 by Martin.Wilson
Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance
#jira none
Change 3872238 by Mark.Satterthwaite
Duplicate CL #3871025
Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders.
#jira UE-54843
Change 3872087 by Yasiman.Ahsani
Adding Python, libdisasm, musl, and LSS licenses.
#JIRA n/a - adding licenses for new TPS
Change 3872037 by Ben.Marsh
BuildGraph: Add a task for compiling MSBuild projects.
#jira
Change 3871934 by Lina.Halper
#jira: UE-54703
Change 3871595 by Michael.Trepka
Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function
#jira UE-54830
Change 3870829 by Joe.Barnes
Fix unintentional change to PhysX libs used in Debug builds.
#jira ue-54817
Change 3870820 by Nick.Atamas
Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19)
#jira UE-54816
Change 3870755 by Chance.Ivey
Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas
Change 3870547 by Krzysztof.Narkowicz
Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel.
#jira UE-53640
Change 3870546 by Krzysztof.Narkowicz
Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path
#jira UE-54471
Change 3870284 by Ben.Zeigler
#jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time
Copy of CL #3870279
Change 3870283 by Arne.Schober
SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources)
Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary
#jira none
Change 3870098 by Ben.Marsh
Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly.
#jira UE-53855
Change 3870013 by Ben.Marsh
UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked.
#jira UE-54179
Change 3870010 by Ben.Marsh
UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window.
#jira
Change 3869814 by Ben.Marsh
UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported.
Also remove the RemoteRoot option, which was not used anywhere.
#jira
Change 3869786 by Martin.Wilson
Fix Live Link Remove Source button not working
#Jira UE-54652
Change 3869660 by Martin.Wilson
Fix missing message bus sources in the live link client (not repolling for new sources)
#Jira UE-54712
Change 3869659 by Guillaume.Abadie
Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame.
Credits for fixing the issue to Ron Radeztsk.
#jira UE-54780
Change 3869401 by Lauren.Ridge
Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent
#jira UE-51470
Change 3869384 by Brandon.Schaefer
Open the project in the explorer when NullSourceCodeAccess is done creating the project
#jira UE-54630
Change 3869308 by Ben.Marsh
PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337)
#jira UE-54568
Change 3869265 by Martin.Wilson
Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin
-Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory)
-Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have)
-rebuild binaries for Engine/Extras
#Jira UE-54643
Change 3869206 by Benn.Gallagher
Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application.
#jira UE-54116
Change 3869064 by Benn.Gallagher
Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function.
#jira UE-52557
Change 3869062 by Guillaume.Abadie
Fixes "dynamic resolution is not supported on this platform" warning message being always visible.
#jira UE-54655
Change 3868202 by Lauren.Ridge
Fix for assert on expanding vector param in layered material
#jira UE-54737
Change 3868161 by zak.parrish
Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639
Change 3867750 by Ethan.Geller
[4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron
Change 3867657 by Lauren.Ridge
Adding if with editor wrapper to new function
#jira cis fix
Change 3867646 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867340 by Lauren.Ridge
Fixes to Material Layers from 4.19 preview feedback
-Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings)
-Parent in function should be editable
-Enforce only two layers in a blend
-Mat layer should warn if it has incorrect output in the layer itself
-Enforce not being able to delete outputs
-Warn about creating a MAL node inside a function
#jira UETOOL-1312
Change 3867317 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867000 by Lauren.Ridge
Fix for folder favorites possibly becoming very large
#jira UE-54704
Change 3866892 by Martin.Wilson
Fix crash if clicking ok on message bus add source without having a source selected
#jira UE-54572
Change 3866391 by Matt.Kuhlenschmidt
Fix static analysis
#jira UE-53379
Change 3866241 by Ryan.Vance
#jira UE-54681
Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge.
Change 3866071 by Nick.Shin
UDN 412414
update HTMl5 readme file
#jira none
Change 3866005 by Max.Preussner
Messaging: Preventing dangling references when removing message subscribers
#jira UE-54680
Change 3865988 by Simon.Tourangeau
Fix static analysis warnings
#jira none
Change 3865895 by zachary.wilson
Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame.
#JIRA UE-29618
Change 3865469 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3865461 by Chris.Babcock
Add a wait for audio thread to pause audio on going to background
#jira UE-54301
#ue4
#android
Change 3865350 by Matt.Kuhlenschmidt
Fix issue where cascade emitter UI would disapper
#jira UE-53379
Change 3865336 by Arne.Schober
REL - Fix UE-52356 Bone Weight
#jira UE-52356
Change 3865257 by Ben.Marsh
Fix editor failing to load content-only projects when compiled in DebugGame.
#jira UE-54661
Change 3865238 by Simon.Tovey
Pulling Olaf's fix from 3832595 over to release
#tests EngineTests boots in vulkan
#JIRA UE-54394
Change 3865191 by Sorin.Gradinaru
UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format
#jira UE-54317
#Android
#4.19
From //Dev-Mobile/3863322
Change 3865190 by Sorin.Gradinaru
UE-54175 Selecting For Distribution no longer sets configuration to Shipping
#UE4
#4.19
#jira UE-54175
From //Dev-Mobile/3863371
"For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845)
Change 3865056 by Jamie.Dale
Fixed culture being incorrect when added via the Localization Dashboard
#jira none
Change 3864826 by Max.Preussner
WmfMedia: Added missing scope lock
#jira UE-54365
Change 3864055 by Aaron.McLeran
#jira UE-54213
Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects.
Change 3863775 by Andrew.Porter
MediaFrameworkTest: Removing Platform Media Source TVOS test content
#jira UE-29618
Change 3863714 by Dan.Oconnor
Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred
#jira UE-54634
Change 3863696 by Max.Chen
Sequencer: Fix crash open a new sequence while another is still active.
#jira UE-54620
#jira UE-54624
Change 3863638 by Dan.Oconnor
Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior
#jira UE-54193
Change 3863494 by Jamie.Dale
Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized
#jira UE-54345
Change 3863433 by Max.Preussner
MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets
tvOS currently reports itself as iOS, so it cannot have its own setting.
#jira UE-54559
Change 3863406 by Lauren.Ridge
Fix for a crash when filtering a dropdown with no set value
#jira UE-54631
Change 3863238 by Michael.Kirzinger
#jira UE-52730: Fix mac voip crash
Change 3862586 by Marc.Audy
Clean up rendering thread heartbeat checks that got mangled in various integrations
#jira
Change 3862247 by Guillaume.Abadie
Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel.
#jira UE-53830
Change 3862120 by Guillaume.Abadie
Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor.
#jira UE-51458
Change 3861363 by Jamie.Dale
Static analysis fixes
#jira none
Change 3861150 by Matt.Kuhlenschmidt
Fix static mesh editor displaying 0 for all stats on LODs > 0
#jira UE-53776
Change 3860990 by Dan.Oconnor
Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject
#jira UE-54551
Change 3860972 by Nick.Shin
HTML5 - detect "SyntaxError: " and do a forced reload
- an actual syntax error would be caught during compile time
- this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page
#jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit
Change 3860951 by Arne.Schober
Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer.
#jira UE-54587
Change 3860950 by tim.gautier
QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions
#jira UE-29618
Change 3860833 by Michael.Dupuis
#jira UE-54181: Repopulate the foliage list when existing simulate mode
Let the GC know that internal struct hold UObject ptr
Change 3860762 by Jamie.Dale
Ensure we invoke the correct version of Python from UBT
#jira UE-54345
Change 3860676 by Simon.Tourangeau
Remove DirectoryWatcher warning in output log
#jira UEENT-846
Change 3860598 by Lauren.Ridge
Fix for crash on opening new material instance
#jira UE-54589
Change 3860338 by Michael.Lentine
Integrate changes for fixing MorphTargets.
#jira 54398
Change 3860215 by Ben.Marsh
UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class.
#jira UE-54578
Change 3860186 by Matt.Kuhlenschmidt
Fix crash top 10 with the font editor shutting down and then a dpi event occuring
#jira UE-54543
Change 3859854 by Graeme.Thornton
PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed)
#jira UE-51289
Change 3859848 by Graeme.Thornton
Fix crypto.cs reading the wrong ini setting names for uasset encryption settings
#jira UE-54566
Change 3859684 by Ben.Marsh
PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey)
#jira UE-54392
Change 3859657 by Ben.Marsh
Fix FTransform being passed by value, causing alignment error when compiling for Win32.
#jira
Change 3859312 by nick.bullard
Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278
Still need to update menu to remove selection
#jira UE-50784
Change 3859278 by Nick.Bullard
Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well.
"This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only.
We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time."
#jira UE-50784
Change 3859124 by Dan.Oconnor
Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16
#jira UE-54468
Change 3859086 by Ryan.Vance
#jira UE-54470
We need to set the viewport in both cases.
Change 3859006 by Dan.Oconnor
Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class
#jira UE-54541
Change 3858990 by mason.seay
Cleaned up blueprints to remove compile errors
#jira UE-29618
Change 3858945 by Aaron.McLeran
#jira UE-54265
PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins)
Change 3858719 by Aaron.McLeran
#jira UE-54552 Fix for sample buffer reader
Change 3858647 by Ethan.Geller
PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel)
#jira UE-54407
Change 3858364 by Michael.Dupuis
#jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances.
Change 3858268 by Dan.Oconnor
Prevent postload logic running on REINST and SKEL classes
#jira UE-54531
Change 3858205 by Mitchell.Wilson
Removed particle looping from some emitters to resolve anim notify warnings.
#jira UE-53823
Change 3858148 by Lauren.Ridge
Changes based on Material Layer Feedback from previews
- (Temporary) Disabled being able to create a layer or blend in the asset dropdown
- Sections of the stack that have been disabled now inactivate that part of the UI
- Create Function Instance now indicates if you are making a layer or a blend
- Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead.
#jira UETOOL-1328
Change 3857933 by Michael.Dupuis
#jira UE-45854: Properly unregister callback when replacing foliage type with another one
Change 3857898 by Michael.Dupuis
#jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation
Change 3857878 by Max.Chen
Sequencer: Assign the sequence id after the template is compiled.
Copy from Dev-Sequencer
#jira UE-54462
Change 3857808 by Michael.Dupuis
#jira UE-54421: Prevent edition during Simulate when clicking on actor
Change 3857786 by Rolando.Caloca
UE4.19 - Fix recompute tangents and skin cache for OpenGL
#jira UE-42108
PR #3271
Change 3857549 by Lina.Halper
another jittering issue due to revision number change
clear the motion vector after compile
#jira: UE-53930
Change 3857439 by Lina.Halper
Clear motion vector when end of sequencer when in editor world
#jira:UE-54057
Change 3857384 by Graeme.Thornton
Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio
#jira UE-50020
Change 3856596 by Chris.Babcock
Fix ResonanceAudioApi Android library architecture filtering
#jira UE-54478
#ue4
#android
Change 3856449 by Michael.Dupuis
#jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design.
Change 3856415 by Dan.Oconnor
Fix regression when loading instances that have had their class deleted. Issue detected by static analysis
#jira UE-54467
Change 3856332 by Ben.Marsh
Resaving TP_HandheldARBP assets to fix version again.
#jira
Change 3856319 by Ben.Marsh
Back out changelist 3855588
Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0.
#jira UE-54472
Change 3856292 by Ben.Marsh
Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds.
#jira UE-54448
Change 3856190 by Martin.Wilson
Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too)
#jira UE-54266
Change 3856169 by Ben.Marsh
Tag XGEControlWorker.exe as a build product, so it's included in the binary distro.
#jira UE-54283
Change 3856123 by Chris.Babcock
Fix missing ARCore file
#jira UE-54453
#ue4
#android
Change 3856005 by Richard.Wallis
Clone of Dev-Rendering CL 3855993 - turn off FShaderCache.
#jira UE-52928
Change 3855961 by Jian.Ru
Copy 3855047 - fix DFAO Nan problem
#jira UE-54403
Change 3855811 by Martin.Wilson
Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018)
#jira none
Change 3855758 by Cosmin.Sulea
UE-53569 - tvOS does not package or launch-on
#jira UE-53569
Change 3855727 by Ben.Marsh
Resaving assets with a versioned build in the editor, to fix warnings building DDC.
#jira
Change 3855626 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep)
#jira UE-50979
Change 3855588 by Graeme.Thornton
Fix visual studio solution path being incorrect for content projects
#jira UE-50020
Change 3855283 by Ben.Marsh
Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor.
#jira
Change 3855009 by Chance.Ivey
Resaving with version number. #JIRA-54330 #rb none
Change 3854943 by Dan.Oconnor
Fix archetype lookup when searching hierarchy that has been partially reinstanced
#jira UE-53840
Change 3854882 by Ryan.Vance
#jira UE-54438
Removing vr related references to screen percentage.
Removing previously removed gvr screen percentage code that came back in an integration from google.
Change 3854806 by Mike.Beach
Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up.
#jira UE-54214
Change 3854680 by Chance.Ivey
Saving assets with version number#JIRA UE-54330 #rb none
Change 3854652 by Uriel.Doyon
Added a tooltip to the EV100 slider in the exposure menu.
Using game settings now disables the slider.
#jira UE-53945
Change 3854605 by Dan.Oconnor
Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't)
#jira UE-53954
Change 3854274 by Brandon.Schaefer
Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux
#jira UE-54302
#codeview Arciel.Rekman
Change 3854255 by Phillip.Kavan
Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties.
- Mirrored from //UE4/Dev-Framework (3853349).
#jira UE-53960
Change 3854177 by Ethan.Geller
#jira UE-54415 set EnabledByDefault to false for Resonance Audio
Change 3854123 by Ethan.Geller
#jira UE-54410 set AudioComponentID
Change 3853775 by Lauren.Ridge
Minor cleanup
#jira UE-54054
Change 3853772 by Lauren.Ridge
Don't create widgets when just testing if the selected widget is a replacement candidate
#jira UE-54054
Change 3853715 by Rolando.Caloca
UE4.19 - Fix for OpenGL overwriting texture units
#jira UE-54401
Change 3853655 by Ben.Marsh
Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders.
#jira
Change 3853535 by Ben.Marsh
Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release.
#jira
Change 3852583 by Nick.Atamas
Resaved assets so they don't produce DDC warnings.
#jira none
Change 3852552 by Uriel.Doyon
Fixed Pre-Exposure shader compilation and Temporal AA issue.
#jira UE-54276
Change 3852354 by Nick.Atamas
Hopefully fixes the static analysis warning from jira issue.
#jira UE-54332
Change 3852281 by Nick.Atamas
Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/...
#jira UE-54331
Change 3852274 by Simon.Tourangeau
Back out changelist 3851041 until Win7 issue is resolved.
#jira UE-54354
Change 3852208 by Jamie.Dale
Merging CL# 3821754 from //UE4/Dev-Enterprise
Class property conversion now goes through NativizeClass/PythonizeClass
This allows it to coerce from Python wrapped object types
#jira none
Change 3852202 by Jamie.Dale
More explicit handling of EngineDir for Python SDK
#jira UE-54345
Change 3851982 by Brandon.Schaefer
Workaround using a hardcoded path
#jira UE-54136
Change 3851748 by Michael.Dupuis
#jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions
Change 3851545 by Marc.Audy
Remove debugging code that slipped in
#jira none
Change 3851461 by Ben.Marsh
Fix #includes with backslashes from crashing UBT.
#jira UE-53996
Change 3851391 by Jamie.Dale
Updated Python to prefer our TPS SDK
#jira UE-54345
Change 3851372 by Jamie.Dale
Added bat file to copy the Python SDK into TPS
#jira UE-54345
Change 3851218 by Ben.Marsh
Add missing template to installed engine build.
#jira UE-54339
Change 3851117 by andrew.porter
QAGame: Removing duplicate map
#jira UE-29618
Change 3851041 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3850548 by Ben.Marsh
Add TP_HandheldARBP to installed engine build.
#jira
Change 3850424 by Ben.Zeigler
Fix reported memory for asset registry to be correct, extracted from a larger change
#jira none
Change 3850324 by Ryan.Vance
#jira UEVR-1050
Hook up the Rift dynamic res to the new IDynamicResolutionState framework
Change 3849819 by JeanLuc.Corenthin
Unhide Datasmith plugins in "regular" projects to allow easy project conversion
#jira UEENT-795
Change 3849302 by Martin.Wilson
Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation)
#jira none
Change 3849238 by Max.Chen
Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged.
#jira UE-54248
Change 3849211 by Michael.Dupuis
#jira UE-54181: Prevent foliage edition during PIE or simulate mode
#coderevire jack.porter
Change 3849123 by Benn.Gallagher
Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices
#jira UE-53741
Change 3849120 by Benn.Gallagher
Fixed crash adding empty materials to destructible meshes in the destructible mesh editor
#jira UE-53938
Change 3849047 by Jurre.deBaare
Move material baking out of experimental
#fix follow-up also remove the entry from experimental settings
#jira UE-52685
Change 3848808 by Michael.Dupuis
#jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now.
Fixed dynamic shadow code path issue vs static code path
Change 3848659 by Lina.Halper
Fix issue with animation resetting in the sequencer
#jira: UE-54047
Change 3848635 by Rolando.Caloca
UE4.19 - Fix static analysis
#jira UE-50449
Change 3848515 by Sorin.Gradinaru
Unshelved from pending changelist '3843541':
WebBrowser Android crash on 4.4.3
#jira UE-53247
#Android
#4.19
Crash on Android 4.x.x caused by a call to a Api Level 21 method
Change 3848514 by Jurre.deBaare
Moving over:
CL 3832173
"Failed to import Alembic files
#jira UE-53941
#fix Change Alembic thirdparty library setup
- Removed old unused library files
- Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path
- HDF5 is now build as a Dynamic library (which also enableds multi-threading)
- Added DLLs for HDF5 to build.cs file
CL 3838053
"Adding missing hdf5 dynamic libraries
Change 3848245 by Ben.Marsh
Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE.
#jira UE-54237
Change 3847300 by Phillip.Kavan
Fix shadowed local variable.
#jira UE-54141
Change 3846922 by Max.Preussner
ImgMedia: Fixed image media player never finished initialization if loading failed
Copied from Dev-Sequencer CL# 3846902
#jira UE-54247
Change 3846831 by Arciel.Rekman
Linux: only use lld for x86_64 (UE-54144).
- lld support for other architectures seems to not ready for prime time.
#jira UE-54144
Change 3846771 by Lauren.Ridge
Material window now uses the background color set in preview scene.
#jira UE-52215
Change 3846705 by Ben.Marsh
Fix batch file paths not being quoted correctly when run through XGE.
#jira
Change 3846550 by Lauren.Ridge
Toggling Show Background now updates the background as well
#jira UE-52250
Change 3846417 by Matt.Kuhlenschmidt
Fix crash resizing shootergame window
#jira UE-53137
Change 3846295 by Rolando.Caloca
UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android)
#jira UE-50449
Change 3846273 by tim.gautier
QAGame: Updating Material Layer test assets to include more Params
- Added temp assets, quicker repros for bugs
#jira UE-54176, UE-54165
Change 3846255 by Lauren.Ridge
Parameter tab is the primary tab for material instances
#jira UE-54092
Change 3846086 by Chris.Babcock
Add missing SecureHash.h include
#jira UE-54026
#PR #4417
#ue4
#android
Change 3846049 by Martin.Wilson
Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag)
#jira UE-54220
Change 3846033 by Martin.Wilson
Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself )
#Jira UE-54219
Change 3845991 by andrew.porter
QAGame: Updating bindings on activechannels sequencer test content
#jira UE-29618
Change 3845933 by Lauren.Ridge
Check for original material being valid
#jira UE-54166
Change 3845920 by Martin.Wilson
Optimized redundant key removal
#jira UE-51303
Change 3845812 by Matt.Kuhlenschmidt
Fix not being able to change BSP brush shape
#jira UE-53738
Change 3845790 by Martin.Wilson
Fix for assert failure when accumulating root motion in debug.
#jira UE-53955
Change 3845730 by JeanLuc.Corenthin
Fix build breakage
warning: resaved disc.uasset with 4.19.0 preview #1
failure: set the correct default mesh for AreaLightStruct.uasset
#jira none
Change 3845693 by Lina.Halper
Fix issue with previewing pose asset with curve data
#jira: UE-53967
Change 3845533 by Andrew.Rodham
Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects
#jira UE-54173
Change 3845472 by Thomas.Sarkanen
Prevented debug object selection dropdown from displaying objects with pending kill outers
#jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance
Change 3845401 by Yannick.Lange
Reverting thumbnail capture from viewport.
#jira UE-53775
#jira UE-53701
Change 3844693 by JeanMichel.Dignard
Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high.
#jira UEENT-632
Change 3844689 by JeanLuc.Corenthin
Update Datasmith content assets to latest
Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803
Updated assets with correct release version
Cleanup some paths on static meshes and texture
#jira UEENT-759
#jira UEENT-657
Change 3844571 by Martin.Wilson
Fix motion controller motion source pin still showing when pin is connected to something
#Jira UE-53236
Change 3844564 by Martin.Wilson
Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them
#Jira UE-54174
Change 3844545 by Jamie.Dale
No longer attempt to parse group separators for numeric inputs
This avoids some ambiguity when parsing numbers for languages such as German
#jira UE-54170
Change 3844221 by Nick.Shin
HTML5 - filter out "windows/super" keys - these are not used in UE4
- but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead...
#jira UE-54056 HTML5 crashes inside browser upon pressing windows key
Change 3843937 by JeanMichel.Dignard
Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin).
#jira UEENT-764
Change 3843929 by Peter.Sauerbrei
pull over fix for bad directory when copying launch images
#jira UE-53177
Change 3843658 by Thomas.Sarkanen
Text is red again in anim viewports
#jira UE-53224 - Colouring removed from "Animation is being edited" warning messages
Change 3843657 by Thomas.Sarkanen
Enable picking via Enter for details panel asset pickers
The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira.
#jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry
Change 3843120 by Dan.Oconnor
Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized
#jira UE-54009
Change 3842841 by Ben.Zeigler
#jira UE-50020
Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157
Change 3842582 by Lauren.Ridge
Guards against the widget passed to scrollwidgetintoview being null
#jira UE-54037
Change 3842575 by Max.Chen
Sequence Recorder: Stop recording if the preview window is destroyed.
#jira UE-49778
Change 3842551 by Michael.Dupuis
#jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk.
Change 3842371 by Max.Preussner
Media: Merged 4.19 fixes from Dev-Sequencer
CL 3807293 WmfMedia: Fixed YUY2 video format strides
CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together
CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource
CL 3804183 MediaAssets: Added missing lock in media sound component
CL 3831580 MfMedia: Media open events generated in same order as on other platforms
CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks
#jira UE-53532
#jira UE-53328
Change 3842356 by Max.Preussner
ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource
#jira UE-51631
Change 3842335 by Aaron.McLeran
#jira UE-54087
PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel)
Change 3842286 by Rolando.Caloca
UE4.19 - Fix for static analysis
- Glslang 1.0.65.1
#jira UE-54128
Change 3842222 by andrew.porter
QAGame: Updating framerate of EXR_Sequence
#jira UE-29618
Change 3842211 by Ben.Marsh
Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo().
#jira UE-54035
Change 3842163 by Cosmin.Sulea
UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured
#jira UE-53303
Change 3841770 by Max.Chen
Sequencer: Fix to allow keying of an arbitrarily deep property path.
#jira UE-54095
Change 3841758 by Max.Chen
Sequencer: Fix unbound possessable components when pasting spawnables.
#jira UE-54104
Change 3841415 by Lauren.Ridge
Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack
#jira UE-53942
Change 3841327 by Arciel.Rekman
Linux: fix Debug build (UE-53855)
- A workaround. UBT should be using proper PCH files instead.
#jira UE-53855
Change 3840975 by Rolando.Caloca
UE4.19 - Updated VulkanRHI
- Fixes for GPU frame time
- Fixes for CPU performance
#jira UE-50449
Change 3840838 by Michael.Dupuis
#jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash
Change 3840693 by Ben.Zeigler
#jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization
Copy of CL #3840692
Change 3840680 by Aaron.McLeran
Bringing fixes from Dev-AnimPhys to 4.19.
#jira UE-53903 crash on load with oculus audio and old audio engine
#jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine.
Change 3840663 by Rolando.Caloca
UE4.19 - Fix for layout ensure on HMD projects on Vulkan
#jira UE-50265
Change 3840577 by Rolando.Caloca
UE4.19 - Fix for CPUs with more than 16 cores
#jira UE-53434
Change 3840551 by andrew.porter
QAGame: Setting Allow Bindings from Asset to false
#jira UE-29618
Change 3840491 by Ben.Zeigler
#jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing
Copy of CL #3840489
Change 3840297 by Max.Chen
Sequencer: Fix copy/paste crash for lights
#jira UE-54084
Change 3840284 by Michael.Dupuis
#jira UE-53053: Was having a mismatch between the remove reorder and the actual remove
Change 3840215 by Sorin.Gradinaru
Unshelved from pending changelist '3812852':
UE-53550 Level doesn't render on Lenovo 939
UE-53592 Assertion right after rendering scene on Lenovo S939
#jira UE-53550
#jira UE-53592
#4.19
#Android
UE-53550
Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices
The problem was that the shader compiler complains about code lines before the #extension directives.
Placeholder // end extensions in the original shader code - to be replaced with round() functions
UE-53592
Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread
Change 3840048 by Michael.Dupuis
#jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate
Change 3840005 by Richard.Wallis
Clone of CL 3835252
Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook.
Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook.
Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin.
#jira UE-53815
Change 3839968 by Michael.Dupuis
#jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date
Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing
##codereview jack.porter
Change 3839924 by Richard.Wallis
Clone of CL 3838093
Fix for rewind / seek bugs in AvfMediaPlayer.
- Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need.
- Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either.
- SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only.
#jira UE-54019, UE-53027
Change 3839321 by andrew.porter
QAGame: Adding missing bookmark to QA-Sequencer_Blending
#jira UE-29618
Change 3839286 by Marcus.Wassmer
Duplicate CL: 3823296
#jira UE-52784
Change 3839229 by Brandon.Schaefer
Fix audio clean up crash when exiting PIE
#jira UE-54050
#review-3839109 @Arciel.Rekman, @Aaron.McLeran
Change 3839223 by andrew.porter
QAGame: Rebinding pointlight actor to sequences
#jira UE-29618
Change 3839098 by andrew.porter
QAGame: Fixing missing sequencer blending test content
#jira UE-29618
Change 3838919 by Mike.Erwin
glTF: binary format's BIN chunk is not necessarily right after the JSON chunk.
Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177
Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first.
#jira UE-50695
Change 3838909 by Mike.Erwin
glTF: base64 decoding of data buffers and images
Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data.
#jira UE-50695
Change 3838812 by Uriel.Doyon
Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming.
#jira none
Change 3838773 by Lauren.Ridge
Fixing material layer filters
#jira UE-54064
Change 3838748 by Michael.Trepka
Fixed EngineTest runtime warning caused by CL 3838626
#jira UE-53893
Change 3838730 by Max.Chen
Sequencer: Add notification when the blend type is changed.
#jira UE-54046
Change 3838626 by Michael.Trepka
Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released.
#jira UE-53893
Change 3838392 by Arciel.Rekman
Fix assert on a policy removal (UE-54042).
- Applying Gil's safe fix which just sweeps the problem under the rug.
#jira UE-54042
Change 3838162 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
#jira UE-54040
(Edigrating 3819174 to Release-4.19)
Change 3838156 by Rolando.Caloca
UE4.19 - Support for Vulkan devices that have no cached memory type
#jira UE-54039
Change 3838096 by Brandon.Schaefer
Set sound to unfocused volume multiplier if not focused
#jira UE-51327
#review-3835736 arciel.rekman
Change 3838087 by Brandon.Schaefer
Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides
#jira UE-53901
#review-3838088 arciel.rekman
Change 3837072 by Phillip.Kavan
Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18.
- Mirrored from //UE4/Dev-Framework (3836768).
#jira UE-53908
Change 3837071 by Phillip.Kavan
Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled.
- Mirrored from //UE4/Dev-Framework (3835944, 3835965).
#jira UE-42614
Change 3837070 by Phillip.Kavan
#4202 - Blueprint nativization bug fixes (PR).
- Mirrored from //UE4/Dev-Framework (3830562, 3832292).
#jira UE-52188
Change 3836507 by Ryan.Vance
#jira UE-53992
Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions.
Change 3836390 by Dan.Oconnor
Fix failure to resolve archetype when using the compilation manager
#jira UE-53840
Change 3836251 by Ryan.Vance
#jira UE-53992
Change 3835852 by Mark.Satterthwaite
Fix tessellation shaders in Metal with Manual Vertex Fetch enabled:
- The control points idnex buffer shouldn't collide with anything else.
- We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures.
#jira UE-53851
Change 3835802 by JeanMichel.Dignard
UBT changes for Enterprise deployment
- Allow building enterprise against an installed engine version
- Added enterprise to the cleanup process if its not installed
#jira UEENT-748
Change 3835625 by Bogdan.Vasilache
UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning
#jira UE-50257
Change 3833649 by Mike.Beach
Enabling debug layer when multiview is enabled.
#jira UE-49954
Change 3833525 by Ethan.Geller
Fix copyright in ActiveSound.cpp #jira none #rb none
Change 3642649 by Stewart.Lynch
Renamed loctext key to stop it clashing with an existing entry
#jira UE-49432
Change 3644762 by Stewart.Lynch
LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv.
* removed CheckSize arg from OnLowLevelFree
* show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch.
* minor optimization in LLMMap::GetMaxIndex - cache Mask value
* added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv.
* added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time.
* renamed Binned stats to FMemory to make it more general
* added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed.
* added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing
* fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type.
* Trackers now maintain totals for each enum tag
* tracking of Texture and mesh allocation on Windows D3D11 & D3D12
Change 3651334 by Joe.Barnes
Fix misspelled function name.
#jira 39441
#3016
Change 3653857 by Ben.Woodhouse
Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/...
Change 3656553 by Joe.Barnes
Add path for SCS_DeviceDepth.
Change 3662703 by Ben.Woodhouse
Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...:
[FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism
- Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame.
- Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe.
- r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency.
Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup.
A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index.
In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread.
[~] Unified platform specific sync interval CVars into one: rhi.SyncInterval
- 1 == 60Hz
- 2 == 30Hz
- 3 == 20Hz
Change 3675239 by Keith.Judge
Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit.
#jira UE-50626
Change 3676709 by Ben.Woodhouse
Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/...
Change 3689712 by Ben.Woodhouse
Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/...
Change 3701778 by Ben.Woodhouse
Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/...
Change 3677043 by Ben.Woodhouse
From StewartL:
I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336
Change 3726532 by Luke.Thatcher
[CONSOLE] [~] Enable XGE shader compilation by default.
- Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently.
Change 3726554 by Luke.Thatcher
[CONSOLE] [+] Improved Scoped Named Events
- Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings.
- Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out.
- Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings.
Change 3751378 by Ben.Woodhouse
Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/...
Change 3751812 by Ben.Woodhouse
Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/...
Change 3728571 by Luke.Thatcher
[CONSOLE] [!] Drop another XGE controller warning to log.
Change 3747150 by Joe.Barnes
Add AuthoringToolHelper.bat file to installed build copy list.
Change 3768585 by Ben.Woodhouse
Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/...
Change 3772333 by Ben.Woodhouse
Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/...
Change 3786872 by Ben.Woodhouse
Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/...
Change 3787279 by Luke.Thatcher
[CONSOLE] [~] Unified present threshold CVars.
- CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom.
- Platform implementations will be checked in shortly.
Change 3787445 by Luke.Thatcher
[CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console
Original CLs
- 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds.
- 3712693 - Fix for crash on startup in new frame syncing.
- 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off).
Change 3788417 by Ben.Woodhouse
Duplicate from FN CL 3712515
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3807818 by Ben.Woodhouse
Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/...
Change 3818577 by Ben.Woodhouse
Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/...
Change 3821198 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/...
Change 3821519 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/...
#robomerge none
Change 3813513 by Ben.Woodhouse
CSV profiler refactor+ bug fix
- Move the CSV profiler to core, so we can use it in modules other than engine
- Profiler no longer enqueues RT commands - this is handled by a new core delegate type
- Make begin/end requests more robust, enqueued via a command queue and processed in order
- Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated
- Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures
- Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now
- Fix longstanding bug in first frame renderthread time in the engine
Change 3814039 by Ben.Woodhouse
More Csvprofiler improvements
- Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data
- Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types
Change 3814041 by Ben.Woodhouse
Integrate as edit CL 3796390 from Fortnite/Main:
Fix CsvProfiler not compiling in shipping for now
Change 3814229 by Ben.Woodhouse
Integrate + refactor of CL 3792591 to reduce complexity and fix bugs
Original changelist description:
CSV profiler improvements:
- The CSV profiler is now always compiled in on the server
- The CSV profiler can now handle both int32 and float stats
- In BeginCapture, the function can take additional arguments for some customization of filenames
Fixes to the above:
- Remove FCustomValue class
- Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together)
- FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value)
- FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical
- Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride
Change 3814242 by Ben.Woodhouse
Disable CSV unit stats on the dedicated server
Change 3817339 by Ben.Woodhouse
Duplicate from 3816641: CSV profiler improvements
- Added a low-pri processing thread to compress raw timing data into a much more efficient format
- Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB
- Processing time : 0.1ms per frame
- Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat
- Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class
- Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data
- Reduced #include dependencies for CSVProfiler.h
- Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity
- Added a simple test harness
Change 3817582 by Ben.Woodhouse
Fix android compile warning
Change 3823242 by Ben.Woodhouse
Integrate as edit from Fortnite/Main 3820067:
Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock.
Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says:
// This function should be used with caution.
// It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should
// not treat it as such.
// E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called.
Change 3823840 by Ben.Woodhouse
Edigrate from 3823816
Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen
Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored.
Change 3827787 by Ben.Woodhouse
Integrate-as-edit CL 3820678 from Fortnite/Main
Allow the CSV Profiler to be compiled in to shipping dedicated server builds
Change 3827842 by Ben.Woodhouse
Integrate-as-edit CL 3827079 from Fortnite/Main
CSV profiler category support
Change 3827918 by Luke.Thatcher
[CONSOLE] [!] Fix compile error in CSV custom stats.
Change 3827964 by Luke.Thatcher
[CONSOLE] [!] Fix inverted logic and spelling of boolean.
- Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool.
Change 3831661 by Ben.Woodhouse
Integrate-as-edit CL 3830630 from Fortnite/Main
Fix CSVProfiler assert in dev builds on XB1
Change 3860300 by Joe.Barnes
Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels.
Change 3860347 by Joe.Barnes
Delete existing SourceConfigFile before allocating a new one to prevent them leaking.
Change 3860348 by Joe.Barnes
Completely encapsulate GetLLMAlloc() in #ifdef.
Change 3861772 by Ben.Woodhouse
Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes
Change 3861774 by Ben.Woodhouse
Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW):
D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled.
Change 3862214 by Ben.Woodhouse
Integrate-as-edit CL 3859637 from Fortnite/Main
Dynamic resolution console tweaks
- Dynamic resolution high level switch driven by a cvar instead of code
- Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability
- Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds
Change 3863919 by Ben.Woodhouse
[Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639
Change 3864347 by Ben.Woodhouse
Fix the editor build. This will need a proper fix before 4.19 ships.
#lockdown Nick.Penwarden
#rb none
[CL 3913399 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3233612 on 2016/12/13 by Ben.Marsh
UGS: Fix cases where precompiled binaries are submitted for a content change.
Change 3235584 on 2016/12/14 by Ben.Marsh
UBT: Deprecate the overridable TargetRules.ShouldUseSharedBuildEnvironment() function; targets should specify which build environment to use by setting the BuildEnvironment field in their constructor instead.
Change 3235741 on 2016/12/14 by Ben.Marsh
UBT: Deprecate the SetupBinaries() callback on the TargetRules class. Instead of overriding this, targets may override their launch module through the "LaunchModuleName" property in their constructor, and add extra modules to the "ExtraModuleNames" field on the TargetRules object itself.
Change 3238176 on 2016/12/16 by Ben.Marsh
UBT: New XML config file parser. Now reads once at startup and can be applied to instanced objects rather than global fields, and caches parsed output in a binary form for quicker initialization on subsequent runs.
Change 3238249 on 2016/12/16 by Ben.Marsh
UBT: Add attribute-driven command line parser.
Change 3238462 on 2016/12/16 by Ben.Marsh
UBT: Include the Platform, Configuration and Architecture on the TargetRules. Add a constructor which takes the TargetInfo object and deprecate the parameterless one; these fields are currently initialized before invoking the constructor in RulesAssembly.
Change 3238564 on 2016/12/16 by Ben.Marsh
UBT: Deprecate the ModuleRules constructor which takes a TargetInfo argument. Replace it with a read-only wrapper around the target rules instead, so target-specific configuration options can be read without needing to access global static variables. Also require that it's passed to the base class constructor.
Change 3239919 on 2016/12/19 by Ben.Marsh
UBT: Remove the "PreferredSubPlatform" property. This is only used for Windows XP support, which is being retired anyway. Having the target define its own architecture is an awkward contractiction to maintain support for, since the target rules are constructed after the architecture already has been determined.
Change 3240061 on 2016/12/19 by Ben.Marsh
UBT: Remove ThirdPartyHeaderFinder. I don't think anything is using this any more.
Change 3240175 on 2016/12/19 by Ben.Marsh
UBT: Add the target name and project file location to the target rules.
Change 3240490 on 2016/12/19 by Ben.Marsh
UAT: Remove Mac staging code that requires UAT to compile and construct .target.cs files when packaging, to check bUseSteam and bUseCEF3 flags. libsteam_api.dylib is now staged at build time by adding it as a bundle resource, CEF3 is already marked as a runtime dependency by CEF3.build.cs, and UnrealCEFSubProcess.app is already marked as a runtime dependency from WebBrowser.build.cs.
Change 3240717 on 2016/12/20 by Ben.Marsh
UAT: Allow configuring UAT to run as if on a build machine by passing the -buildmachine argument on the command line.
Change 3240718 on 2016/12/20 by Ben.Marsh
UAT: Remove target-specific properties that are no longer used by staging (bUsesSlate, bUsesCEF3, etc...). This stuff should all be handled inside UBT.
Change 3241002 on 2016/12/20 by Ben.Marsh
UBT: Move most target configuration settings from UEBuildConfiguration to TargetRules. This encapsulates target specific settings that will allow instancing multiple targets in the future. To facilitate migration of settings to their new location, "UEBuildConfiguration" is now a property that returns the current target rules instance.
Change 3241027 on 2016/12/20 by Ben.Marsh
Only copy the Steamworks dylib into the app bundle for monolithic builds. For all other times, just add it as a runtime dependency.
Change 3241055 on 2016/12/20 by Ben.Marsh
UBT: Only store a ReadOnlyTargetRules object on the instanced build target; finalize the configuration before it's instantiated.
Change 3241156 on 2016/12/20 by Ben.Marsh
Update SwarmInterface.csproj to .NET framework 4.5, to match what all other C# tools are using.
Change 3241205 on 2016/12/20 by Ben.Marsh
Replace all uses of TargetRules.TargetType with TargetType.
Change 3241881 on 2016/12/21 by Ben.Marsh
UBT: Remove project file information from UEBuildContext base class. As configurable properties are moved on to the TargetRules object, it will no longer be a dependency to instantiate the platform with this path.
Change 3241895 on 2016/12/21 by Ben.Marsh
UBT: Remove toolchain support for Windows XP.
Change 3241908 on 2016/12/21 by Ben.Marsh
UBT: Move settings for windows targets into a WindowsTargetRules class, which is exposed for targets to modify via the TargetRules.WindowsPlatform field.
Change 3242835 on 2016/12/22 by Ben.Marsh
UBT: Fix multiple binaries being created if plugins specify module names more than once. MfMedia.uplugin has MfMediaFactory listed twice.
Change 3242837 on 2016/12/22 by Ben.Marsh
Change UE4EditorServices to include MacSystemIncludes rather than Cocoa.h directly; causes FVector to be defined incorrectly in non-unity builds.
Change 3242923 on 2016/12/22 by Ben.Marsh
Build: Fixes for conforming incremental workspaces:
* P4 have table is now reset before deleting all the files. This prevents Perforce being out of sync if the delete fails for some reason.
* Incremental workspaces are skipped when running a clean operation, because they do not have a workspace capture file (causing a full re-sync, always). The "P4 Clean" option is still effective for cleaning these workspaces.
Change 3242961 on 2016/12/22 by Ben.Marsh
UBT: Move entry points from PreBuildSync() and PostBuildSync() from UEToolChain to UEBuildPlatform, and make the original toolchain versions static. These functions are already at odds with the rest of the data flow within UBT because they rely on global state cached outside the toolchain instance, making assumptions that UBT is only ever going to be invoked with one target that's constructed in the same run and that nothing is being cached (eg. UBT makefiles). Moving them onto UEBuildPlatform simplifies the toolchain lifecycle for other platforms without leaving Mac and IOS any more limited than they were before.
Change 3242981 on 2016/12/22 by Ben.Marsh
UBT: Remove symbol server handling code into UAT's platform library, since it's never needed from inside UBT.
Change 3242999 on 2016/12/22 by Ben.Marsh
UBT: Remove the StripSymbols() function from the UEToolChain base class. This functionality is only required by UAT, so it's better suited to being exposed through UAT's modular platform classes.
Change 3243022 on 2016/12/22 by Ben.Marsh
UBT: Require an instance of the target rules to be able to construct a toolchain in UBT. This will allow configuring toolchain-specific options from the target, using reflection from config files, and the command line.
Change 3243083 on 2016/12/22 by Ben.Marsh
UBT: Move settings for the Windows compiler version to use onto the Windows-specific target rules.
Change 3243090 on 2016/12/22 by Ben.Marsh
UBT: Change the third party paths in UEBuildConfiguration to constants. Changing these would not work.
Change 3243423 on 2016/12/23 by Ben.Marsh
UBT: Move a lot of settings from BuildConfiguration to TargetRules. This allows different targets to have different settings, naturally, and moves converts argument parsing and config to be driven by attributes.
Change 3243516 on 2016/12/23 by Ben.Marsh
UBT: Remove the ValidateUEBuildConfiguration callback, which is no longer used. (XGE settings validation occurs in XGE.cs)
Change 3244020 on 2016/12/28 by Ben.Marsh
UBT: Remove the BaseIntermediatePath static property. Precursor to removing RelativeEnginePath and IntermediateFolder properties.
Change 3244074 on 2016/12/28 by Ben.Marsh
UBT: Remove the RelativeEnginePath variable from BuildConfiguration. UnrealBuildTool.EngineDirectory gives the absolute path, and can be used to construct a relative path when necessary.
Change 3244076 on 2016/12/28 by Ben.Marsh
UBT: Remove BuildConfiguration.BaseIntermediateFolder; just use a fixed directory everywhere instead.
Change 3244083 on 2016/12/28 by Ben.Marsh
UBT: Replace FileReference and DirectoryReference instance methods for manipulating files and directories with static methods, to mirror the System.IO.File and System.IO.Directory classes.
Change 3244441 on 2016/12/31 by Ben.Marsh
UBT: Remove code to force PDBs when building with no debug info under XGE. Verified described symptoms (that it causes PCH generation to be serialized) no longer occur.
Change 3244687 on 2017/01/03 by Matthew.Griffin
Changed Exception to use FirstInclude.IncludeName as PrecompiledHeaderIncludeFilename can be null when this occurs
Change 3246112 on 2017/01/04 by Ben.Marsh
UBT: Fix UHT failures building some targets with the -useprecompiled option, due to differences in the order that circularly dependent modules are parsed. Precompiled binaries are now kept in the regular AppBinaries list, but are excluded from the build at the last minute. Also change some checks from IsEngineInstalled() to bUsePrecompiled, to prevent headers being overwritten when running in a non-installed precompiled build.
Change 3246223 on 2017/01/04 by Ben.Marsh
UBT: Prevent version manifests being overridden if a file is not being built as part of the target.
Change 3246387 on 2017/01/04 by Ben.Marsh
UBT: Remove BuildConfiguration settings for UnrealCodeAnalyzer. This tool isn't used at the moment, but it's configured using global variables accessed from all over the UBT codebase, making it difficult to refactor the build options into an instanced object. If we bring this tool back from the dead in the future, it should be possible to implement it using the exported JSON target definition or the XGE manifest, similarly to how IncludeTool uses it.
Change 3247004 on 2017/01/04 by Ben.Marsh
UBT: Simplify the logic for cleaning targets in UBT. Now uses FileReference/DirectoryReference objects everywhere, doesn't require the compile/link environment, and does all the checking to avoid deleting precompiled binaries in one place.
Change 3247250 on 2017/01/04 by Ben.Marsh
UBT: Prevent precompiled binaries being added to the list of app binaries twice.
Change 3247594 on 2017/01/05 by Ben.Marsh
Build: Run sample and template editors on the same agents as the other incremental builds. Remove ProtoStar, which does not have any non-precompiled editor target to build.
Change 3247763 on 2017/01/05 by Ben.Marsh
UBT: Allow the toolchain to update the list of build products for each module linked into a binary. Allows Mac to add dylibs and bundle resources specified per-module without having to construct a link environment and try to link them.
Change 3247775 on 2017/01/05 by Ben.Marsh
UBT: Instance the target compile and link environments when they are required during building, and don't persist them on the UEBuildTarget instance.
Change 3247811 on 2017/01/05 by Ben.Marsh
EC: Add a batch file for testing postp filters.
Change 3247839 on 2017/01/05 by Ben.Marsh
EC: Include the name of the file being compiled when parsing MSVC errors and warnings.
Change 3248101 on 2017/01/05 by Ben.Marsh
UBT: Fix Android support for force included headers.
Change 3248533 on 2017/01/05 by Ben.Marsh
PR #3097: UBT project supports optional platforms (Contributed by PrimalJohnScott)
Change 3249205 on 2017/01/06 by Ben.Marsh
UAT: Fix ParseTaggedP4Output throwing an exception if the same key name is specified more than once. This can happen when parsing the output from "P4 INFO", where multiple brokers are present.
Change 3249249 on 2017/01/06 by Ben.Marsh
UBT: Check for the existance of AndroidManifest.xml within extracted AAR directories, rather than just checking for the existance of the directory itself. Perforce does not remove empty directories when cleaning a workspace unless the rmdir option is on the workspace, so this can cause incremental build failures to fail on build machines.
Change 3249486 on 2017/01/06 by Ben.Marsh
UBT: Use relative paths in unity files when compiling for Mac/IOS, rather than generating a separate local/remote version of the file for gathering include dependencies. Absolute paths are only used to work around the way that MSVC concatenates paths internally; we don't hit the same problems when checking dependencies.
Change 3249736 on 2017/01/06 by Ben.Marsh
UBT: Rename CPPEnvironment to CppCompileEnvironment, and remove the separate CPPEnvironmentConfiguration object. All settings are now stored directly on the CppCompileEnvironment object.
Change 3250179 on 2017/01/07 by Ben.Marsh
Fix creating installed build when root directory contains a space in the name.
Change 3250181 on 2017/01/07 by Ben.Marsh
UBT: Remove some esoteric (and unused, AFAIK) options for orthogonally building different platforms.
Change 3250223 on 2017/01/07 by Ben.Marsh
UBT: Merge the LinkEnvironment and LinkEnvironmentConfiguration classes together.
Change 3250233 on 2017/01/07 by Ben.Marsh
UGS: Allow specifying a workspace-specific sync filter, which is applied on top of the standard filter. Also fix filter being cleared if the cancel button is pressed, and help text being stripped out.
Change 3250241 on 2017/01/07 by Ben.Marsh
UBT: Move the options for specifying additional Android architectures to target onto an Android-specific object on the TargetRules.
Change 3250400 on 2017/01/08 by Ben.Marsh
UBT: Move executor config settings onto the executor instances.
Change 3257708 on 2017/01/13 by Ben.Marsh
UBT: Remove the ThirdPartySourceDirectory constant; there are many places which hard-code or assume this location anyway, and it's not going to change.
Change 3260535 on 2017/01/17 by Ben.Marsh
Add an optional "RequiredSubmittedChange" setting to EC settings files. Allows a scheduled job to run even if there have been no code changes submitted. Test with the utilization capture job.
Change 3260875 on 2017/01/17 by Ben.Marsh
EC: Fix workspaces getting out of sync wrt. newly added files when jobs are aborted during a sync. In such cases, the P4 have table indicates the new files have been synced locally, but the workspace is forced back to a state before it had them due to the capture file. When a following sync tries to add them again, P4 believes the workspace already has them synced.
To work around this, we now write an additional file to the root folder of a workspace containing the last CL that was captured, and sync back to it before doing the reconcile.
Change 3261724 on 2017/01/18 by Ben.Marsh
Allow filtering job types from the list view in EC. Hide the utilization capture job by default. Also set up notifications for the utilization capture job.
Change 3261756 on 2017/01/18 by Ben.Marsh
IncludeTool: Prevent matching a full enum declaration as a forward declaration.
Change 3261932 on 2017/01/18 by Ben.Marsh
EC: Add support for specifying days of the week in schedules. The following syntaxes are supported:
"Monday, Tuesday and Wednesday at 10:30"
"Daily except Sunday and Wednesday at 14:30"
Also tweak display of dates relative to now to handle dates/times in the future, and include the date when specifying a day name.
#jira UEB-729
Change 3262676 on 2017/01/18 by Ben.Marsh
UBT: Split UBTMakefile into its own file. (From PR #3106)
Change 3263893 on 2017/01/19 by Ben.Marsh
UBT: Stop exporting platform classes from UBT, as well as all the referenced classes that have to be made public as a result. Any platform-specific functionality that needs to be shared with UAT is now exposed through wrappers in separate public classes, eg. WindowsExports.cs, IOSExports.cs, etc...
Change 3264291 on 2017/01/19 by Ben.Marsh
UBT: Fix errors generating documentation in UBT, and enable it by default. Will catch more errors with new code being added. Originally in PR #3106, but redone due to conflicts.
Change 3264534 on 2017/01/19 by Ben.Marsh
UBT: Include plugin config files in generated projects.
Change 3264571 on 2017/01/19 by Ben.Marsh
UBT: Prevent overwriting .modules files if nothing has changed. On builders, it's common to build multiple editors in the same workspace, and changing the last modified timestamp causes BuildGraph to fail due to tampered files.
Change 3265745 on 2017/01/20 by Ben.Marsh
UGS: Automatically open UGS when running the launcher for a second time, rather than prompting to close the original instance.
Change 3265777 on 2017/01/20 by Ben.Marsh
UGS: Automatically close and reopen when UGS is re-ran with the shift key held down to switch into unstable mode.
Change 3268314 on 2017/01/23 by Ben.Marsh
UBT: Make sure version manifests are stable by sorting the list of build products, so they are only touched if the contents have really changed.
Change 3269601 on 2017/01/24 by Ben.Marsh
UBT: Fix symbol files being added to manifest for some platforms even though debug info is disabled.
Change 3269607 on 2017/01/24 by Ben.Marsh
UBT: Fix bug where UBT would need to be invoked when switching between two editors sharing the same engine binaries on Mac. The location of the .modules file cannot be guessed on Mac by looking in the same directory as the primary output executable because it's an .app bundle, and the actual modules are nested several directories below that.
Change 3269608 on 2017/01/24 by Ben.Marsh
UBT: Fix additional files copied into the app bundle always being updated on Mac. Now uses rsync --checksum to make sure only modified files are updated.
Change 3271062 on 2017/01/24 by Ben.Marsh
UBT: Fixes for bugs detected by PVS Studio (PR #3161)
Change 3272421 on 2017/01/25 by Ben.Marsh
Fix commends regarding DDC in BaseEngine.ini
#jira UE-41076
Change 3272810 on 2017/01/25 by Ben.Marsh
Fix VS2017 being displayed as 'Visual Studio 15' in the Windows target settings panel.
Change 3272935 on 2017/01/25 by Ben.Marsh
Fix Metal errors launching on Mac due to use of OSX environment settings before they are initialized. Toolchain settings are now constructed on demand in a separate class, for Mac, iOS and TVOS.
Change 3274167 on 2017/01/26 by Ben.Marsh
Fix resource files not being compiled in installed builds on Windows. Was causing metadata not to be embedded into executables.
#jira UE-36457
Change 3275557 on 2017/01/27 by Ben.Marsh
Expand checks for propagation of restricted folder names to include source files, and to ensure that each restricted folder is represented in the output. Also improve messaging to show the dependency chain leading to a restricted folder being referenced, and which folder it is.
Change 3275628 on 2017/01/27 by Ben.Marsh
UBT: Splitting configuration files into one class per-file.
Change 3276784 on 2017/01/29 by Ben.Marsh
Add an authoritative list of confidential folder names, and expose it through global BuildGraph properties ($(RestrictedFolderNames) and $(RestrictedFolderFilter)). Also switch existing scripts to use it.
Change 3276792 on 2017/01/29 by Ben.Marsh
UBT: Use UE4CSharp.prog files to indicate which projects should be included in the solution without having to hard-code a list of them in UBT.
Change 3277263 on 2017/01/30 by Ben.Marsh
IncludeTool: Merging various fixes.
* Fix warnings about #include directives after first code block from parsing monolithic headers.
* Fix exception on startup if the intermediate directory does not already exist.
* Add a special case for ignoring missing header guards from MonolithicHeaderBoilerplate.h, rather than marking it as an inline header. Marking it as inline prevents parsing include directives, which results in including CoreTypes.h from the wrong location.
* Create job objects for spawned compiler instances to prevent them trying allocating more memory than the system can spare.
* Remove (unused) code which makes assumptions about files ending with "Classes.h".
* Add a verbose per-file output log to aid with debugging.
* Negate the MakeStandalone command line option, which was added to allow tweaking forward declarations in already optimized files, so the optimized output does not have missing headers by default.
* Fix missing headers when creating standalone files, due to incorrect list of previous files being passed in to the OutputFile constructor. Now passes the original list of included files, not the output list.
* Fix initial header for a cpp file sometimes being removed. Forcibly including a header at the start of the file does not use the normal pathway for spidering through includes, so a second include of the same file was being generated. Any includes of that header were being forced into output, and the earlier include was then removed due to being redundant.
* Prevent forward declaring enums which have to be parsed by UHT. UHT relies on includes to determine a parse order, and will fail if the enum definition has not been parsed first.
* Use a relative path for private includes in the same module if there are any. Fixes some incorrect paths, and makes it clearer that we're doing something we shouldn't.
Change 3277307 on 2017/01/30 by Ben.Marsh
UBT: Fix private PCHs not using correct header. Causes custom definitions to be excluded from the command line.
[CL 3278101 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3121996 on 2016/09/12 by Ben.Marsh
Add support for Visual Studio 2017 (aka "15"; assuming consistent naming with other versions until final name is announced).
* Compiler, STL implementation and CRT are binary compatible with VS2015 (see https://blogs.msdn.microsoft.com/vcblog/2016/08/24/c1417-features-and-stl-fixes-in-vs-15-preview-4/), so no new third-party libraries needed so far. WindowsPlatform.GetVisualStudioCompilerVersionName() returns "2015" as a result.
* Default compiler for compiling and generating project files is still VS 2015 for now. Pass -2017 on the command line to GenerateProjectFiles.bat to generate VS2017 projects. Projects generated for VS2017 will use the 2017 compiler by default.
* Visual Studio source code accessor can talk to VS 2017 instances.
* Added a VS2017 configuration for UnrealVS, and added precompiled vsix package.
* Switched GetVSComnTools to check the SOFTWARE\Microsoft\VisualStudio\SxS\VS7 registry key rather than the individual product install registry key. "15" doesn't seem to have it's own "InstallDir" key, but this system seems to work for all versions of Visual Studio (including previous releases of VS Express).
* Removed ATL dependency from VisualStudioSourceCodeAccessor. It's not installed with VS by default any more, and is only used for a couple of smart pointer classes.
Tested running the editor and packaging TP_Flying for Win64. Packaging from the editor still defaults to using the 2015 compiler, so ConfigureToolchain() needs to be overriden from the .target.cs file if multiple Visual Studio versions are installed.
Change 3189363 on 2016/11/07 by Ben.Marsh
Consolidate functionality for determining the path to MSBuild.exe to use for compiling UE4 tools into a single batch file (GetMSBuildToolPath) and fix "Clean" not working on PS4 due to include/library paths being set to something by the Visual Studio environment.
Change 3210598 on 2016/11/27 by Ben.Marsh
UBT: Prevent the name of each file compiled being output twice on XboxOne. Compiler already outputs this string; the action doesn't need to.
Change 3210601 on 2016/11/27 by Ben.Marsh
PR #2967: Add silent version of switch game version (Contributed by EricLeeFriedman)
Change 3210602 on 2016/11/27 by Ben.Marsh
PR #2964: GitDependencies shouldn't try to clean up working directory files that are excluded or ignored (Contributed by joelmcginnis)
Change 3210605 on 2016/11/27 by Ben.Marsh
UGS: Add a warning when syncing latest would remove changes that have been authored locally. Typically happens when working with precompiled binaries.
Change 3211656 on 2016/11/28 by Ben.Marsh
UBT: Move ModuleRules and TargetRules into their own file.
Change 3211797 on 2016/11/28 by Ben.Marsh
UBT: Remove utility functions from TargetRules for checking different classes of target types. Moving TargetRules to be data-only.
Change 3211833 on 2016/11/28 by Ben.Marsh
UBT: Remove overridable configuration name from target rules. This feature is not used anywhere.
Change 3211859 on 2016/11/28 by Ben.Marsh
UBT: Deprecate the GetGeneratedCodeVersion() callback in favor of a member variable instead.
Change 3211942 on 2016/11/28 by Ben.Marsh
UBT: Remove legacy code which tries to change the output paths for console binaries. Output paths for monolithic binaries are always in the project folder now.
Change 3215333 on 2016/11/30 by Ben.Marsh
UBT: Replace the GetSupportedPlatforms() callback on TargetRules with a SupportedPlatforms attribute. Since a TargetRules object can only be instantiated with an actual platform, it doesn't make sense for it to be an instance method.
Change 3215482 on 2016/11/30 by Ben.Marsh
UBT: Remove the GetSupportedConfigurations() callback on the TargetRules class. A configuration is required to construct a TargetRules instance, so it doesn't make sense to need to call an instance method to find out which configurations are supported.
Change 3215743 on 2016/11/30 by Ben.Marsh
UBT: Deprecate the TargetRules.ShouldCompileMonolithic() function: this function requires access to the global command line to operate correctly, which prevents creating target-specific instances, and does not use the platform/configuration passed into the TargetRules constructor.
Rather than being a callback, the LinkType field can now be set to TargetLinkType.Modular or TargetLinkType.Monolithic from the constructor as appropriate. The default value (TargetLinkType.Default) results in the default link type for the target type being used. Parsing of the command-line overrides is now done when building the TargetDescriptor.
Change 3215778 on 2016/11/30 by Ben.Marsh
UBT: Mark overrides of the TargetRules.GetModulesToPrecompile method as obsolete.
Change 3217681 on 2016/12/01 by Ben.Marsh
UAT: Prevent UE4Build deleting .modules files when running with the -Clean argument; these files are artifacts generated by UBT itself, not by the exported XGE script.
Change 3217723 on 2016/12/01 by Ben.Marsh
UBT: Run pre- and post-build steps for all plugins that are being built, not just those that are enabled.
Change 3217930 on 2016/12/01 by Ben.Marsh
UGS: Add a perforce settings window, allowing users to set optional values for tuning Perforce performance on unreliable connections.
Change 3218762 on 2016/12/02 by Ben.Marsh
Enable warnings whenever an undefined macro is used in a constant expression inside an #if or #elif directive, and fix existing violations.
Change 3219161 on 2016/12/02 by Ben.Marsh
Core: Use the directory containing the current module to derive the UE4 base directory, rather than the executable directory. Allows UE4 to be hosted by a process in a different directory.
Change 3219197 on 2016/12/02 by Ben.Marsh
Core: When loading a DLL from disk, convert any relative paths to absolute before calling LoadLibrary. The OS resolves these paths relative to the directory containing the process executable -- not the working directory -- so paths need to be absolute to allow UE4 to be hosted by a process elsewhere.
Change 3219209 on 2016/12/02 by Ben.Marsh
Replace some calls to LoadLibrary() with FPlatformProcess::GetDllHandle(). The UE4 function makes sure that relative paths are resolved relative to the correct base directory, which is important when the host executable is not in Engine/Binaries/Win64.
Change 3219610 on 2016/12/02 by Ben.Marsh
Add the -q (quiet) option to the Mac unzip command, since it's creating too much log output to be useful.
Change 3219731 on 2016/12/02 by Ben.Marsh
UBT: Add option to disable IWYU checks regarding the use of monolithic headers (Engine.h, UnrealEd.h, etc...) and including the matching header for a cpp file first. bEnforceIWYU can be set to false in UEBuildConfiguration or on a per-module basis in the module rules.
Change 3220796 on 2016/12/04 by Ben.Marsh
Remove PrepForUATPackageOrDeploy from the UEBuildDeploy base class. It never has to be accessed through the base class anyway.
Change 3220825 on 2016/12/04 by Ben.Marsh
UBT: Change all executors to derive from a common base class (ActionExecutor).
Change 3220834 on 2016/12/04 by Ben.Marsh
UBT: Remove the global CommandLineContains() function.
Change 3222706 on 2016/12/05 by Ben.Marsh
Merging CL 3221949 from //UE4/Release-4.14: Fixes to code analysis template causing problems with stock install of VS2017.
Change 3222712 on 2016/12/05 by Ben.Marsh
Merging CL 3222021 from //UE4/Release-4.14: Change detection of MSBuild.exe path to match GetMSBuildPath.bat
Change 3223628 on 2016/12/06 by Ben.Marsh
Merging CL 3223369 from 4.14 branch: Use the same logic as GetMsBuildPath.bat inside FDesktopPlatformBase to determine path to MSBuild.exe
Change 3223817 on 2016/12/06 by Ben.Marsh
Remove non-ANSI characters from source files. Compiler/P4 support is patchy for this, and we want to avoid failing prey to different codepages resulting in different interpretations of the source text.
Change 3224046 on 2016/12/06 by Ben.Marsh
Remove the need for the iOS/TVOS deployment instances to have an IOSPlatformContext instance. The only dependency between the two -- a call to GetRequiredCapabilities() -- is now implemented by querying the INI file for the supported architectures when neeeded.
Change 3224792 on 2016/12/07 by Ben.Marsh
UBT: Touch PCH wrapper files whenever the file they include is newer rather than writing the timestamp for the included file into it as a comment. Allows use of ccache and similar tools.
Change 3225212 on 2016/12/07 by Ben.Marsh
UBT: Move settings required for deployment into the UEBuildDeployTarget class, allowing them to be serialized to and from a file the intermediate directory without having to construct a phony UEBuildTarget to deploy.
Deployment is now performed by a method on UEBuildPlatform, rather than having to create a UEBuildPlatformContext and using that to create a UEBuildDeploy object.
The -prepfordeploy UBT invocation from UAT, previously done by the per-platform PostBuildTarget() callback when building with XGE, is replaced by running UBT with a path to the serialized UEBuildDeployTarget object, and can be done in a platform agnostic manner.
Change 3226310 on 2016/12/07 by Ben.Marsh
PR #3015: Fixes wrong VSC++ flags being passed for .c files (Contributed by badlogic)
Change 3228273 on 2016/12/08 by Ben.Marsh
Update copyright notices for QAGame.
Change 3229166 on 2016/12/09 by Ben.Marsh
UBT: Rewritten config file parser. No longer requires hard-coded list of sections to be parsed, but parses them on demand. Measured 2x faster read speeds (largely due to eliminating construction of temporary string objects when parsing each line, to trim whitespace and so on). Also includes an attribute-driven parser, which allows reading named config values for marked up fields in an object.
Change 3230601 on 2016/12/12 by Ben.Marsh
Swarm: Change Swarm AgentInterface to target .NET framework 4.5, to remove dependency on having 4.0 framework installed.
Change 3230737 on 2016/12/12 by Ben.Marsh
UAT: Stop UE4Build deriving from CommandUtils. Confusing pattern, and causes problems trying to access instance variables that are only set for build commands.
Change 3230751 on 2016/12/12 by Ben.Marsh
UAT: Move ParseParam*() functions which use the instanced parameter list from CommandUtils to BuildCommand, since that's the only thing that it's instanced for.
Change 3230804 on 2016/12/12 by Ben.Marsh
UBT: Add the IsPromotedBuild flag to Build.version, and only set the bFormalBuild flag in UBT if it's set. This allows UGS users to avoid having to compile separate RC files for each output binary.
Change 3230831 on 2016/12/12 by Ben.Marsh
UGS: Warn when trying to switch streams if files are checked out.
Change 3231281 on 2016/12/12 by Chad.Garyet
Fixing a bug where .modules files were getting put into receipts with their absolute path instead of their relative one
Change 3231496 on 2016/12/12 by Ben.Marsh
Disable code analysis in CrashReportProcess; causes warnings when compiled with VS2015.
Change 3231979 on 2016/12/12 by Ben.Marsh
UBT: Suppress LNK4221 when generating import libraries. This can happen often when generating import libraries separately to linking.
Change 3232619 on 2016/12/13 by Ben.Marsh
Fix "#pragma once in main file" errors on Mac, which are occurring in //UE4/Main.
[CL 3232653 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3129636 on 2016/09/17 by Ben.Marsh
UBT: Add a "-nolink" option which allows compiling object files without linking them into an executable. Useful for non-unity builds, which take a very long time to link or fail on some platforms due to command lines being too long, PDB file having too many records, etc...
Change 3129825 on 2016/09/18 by Ben.Marsh
UBT: Don't force Linux to build in unity; it seems to build fine without.
Change 3129965 on 2016/09/19 by Matthew.Griffin
Duplicating CL#3129960 from Release-4.13
Exclude NetworkProfiler when building CS tools for Linux
Change 3130653 on 2016/09/19 by Ben.Marsh
UHT: Fix missing "Error:" prefix in output log, causing messages to be ignored for failure emails.
Change 3130662 on 2016/09/19 by Ben.Marsh
EC: Prevent UHT failures from being reported twice, and remove the need for special case to show UHT summary output.
Change 3131956 on 2016/09/20 by Matthew.Griffin
Addtional fixes for compiling Editor as a monolithic executable
Change so monolithic editor is output to Project Binaries directory
Removed duplicated ReturnContainerIndexFromChannelName function
Only check for out of date modules for non monolithic editor
Don't define GIsGameAgnosticExe or PER_MODULE_BOILERPLATE for monolithic editor, done elsewhere
Correct IMPLEMENT_MODULE for QuadricMeshReduction and AudioCapture modules
Change 3132112 on 2016/09/20 by Ben.Marsh
Docs: Remove reference to UBT environment variables from configuration docs.
Change 3132815 on 2016/09/20 by Ben.Marsh
AutomationTool: Delete GUBP. Everything now uses BuildGraph!
Change 3132871 on 2016/09/20 by Ben.Marsh
UBT: Remove GUBP callbacks from TargetRules instances.
Change 3132987 on 2016/09/20 by Ben.Marsh
Allow public distribution of the compiled SimplygonMeshUtilities binaries.
Change 3133974 on 2016/09/21 by Ben.Marsh
Allow public distribution of the SimplygonSwarm module. Requires a separate Simplygon DLL (still in a NotForLicensees folder) to function correctly.
Change 3137228 on 2016/09/22 by Ben.Marsh
UAT: Merging fix to parallel executor on Linux from 4.13 branch.
Change 3139783 on 2016/09/26 by Matthew.Griffin
Fixed Xbox support for Installed Builds
Corrected typo in Xbox+PS4 filter creation and added XboxOnePackageNameUtil.exe
Added Xbox versions of ThirdParty libs that hadn't been specified until now
Change 3141721 on 2016/09/27 by Ben.Marsh
Remove declaration of circular references between FbxAutomationTestBuilder and LevelEditor; causes LevelEditor to be built differently if plugin is enabled, which results in shared build products being invalidated by switching between games.
Change 3141789 on 2016/09/27 by Ben.Marsh
UBT: Retain the ".suppressed" part of output file names when building import libraries for circularly referenced modules.
Change 3141805 on 2016/09/27 by Ben.Marsh
UBT: Allow reusing build ids in version manifests as long as we aren't modifying any engine binaries (building more or fewer is permitted), and merge manifests together if possible. Allows building the entire solution through Visual Studio, when some projects may build more modules than another.
Change 3141980 on 2016/09/27 by Ben.Marsh
EC: Include a "Steps to Reproduce" section in failure emails, which gives the command line to run to execute the step.
Change 3143996 on 2016/09/28 by Ben.Marsh
BuildGraph: Fix exported job steps having dependencies on nodes behind triggers, causing jobs to never terminate.
Change 3144696 on 2016/09/29 by Matthew.Griffin
Adding -NoSharedPCH to NonUnity build steps and split them into separate nodes for UE4Editor and UE4Game
Fixed redefinition of __WINDOWS_DS__
Change 3144931 on 2016/09/29 by Ben.Marsh
Core: Changes to search paths for DLL loading.
* The default binaries directory is now added to the list of search paths. Normally LoadLibrary finds these without needing to preload them, but plugins can change the global search paths by calling SetDefaultDllDirectories().
* Only the top entry of the DLL directory stack is searched. There is typically only one directory here anyway, but the intent is more consistent with the operation of SetDllDirectory().
* Resolved import paths are converted to absolute, so the resulting calls to LoadLibrary will not be influenced by calls to SetDefaultDllDirectories() changing the base directory.
* Search paths aren't de-duplicated any more. They don't overlap in practice, and it's not expensive even if they do.
Change 3144932 on 2016/09/29 by Ben.Marsh
Vulkan: Only add vulkan-1.dll as a delay load dependency from the VulkanRHI module, otherwise it can be added to the linker command-line 20 or more times.
Change 3145011 on 2016/09/29 by Ben.Marsh
Core: Include the compatible changelist in version manifests, so local builds after syncing with UGS will have the correct compatible changelist numbers post-hotfix.
[CL 3146509 by Ben Marsh in Main branch]
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2835191 on 2016/01/19 by Nick.Whiting
Invert the y-axis on the SteamVR controllers to match the convention of the engine and the rest of the gamepads
#jira UE-22705
Change 2835686 on 2016/01/20 by Gareth.Martin
Fixed landscape material instances not being updated if holes are painted on a landscape that doesn't have the landscape visibility mask node in the material and then the visibility mask node is added to the material later.
#jira UE-18187
Change 2835767 on 2016/01/20 by Richard.Hinckley
#jira UE-25499 Added a cursor to TopDown template (C++ version) to match the BP version.
Change 2835772 on 2016/01/20 by Richard.Hinckley
#jira UE-25499 Adding the material asset for the C++ TopDown template's cursor.
Change 2835811 on 2016/01/20 by Taizyd.Korambayil
#jira UE-25699 Added Validity Checks in BP logic, unchecked CDO for Pixel Ship, to Fix Log Warnings
#jira UE-25704 Adjusted Matinee to happen at Box Location
#jira UE-25688 Adjusted Player Starts
#jira UE-25693 Adjusted Player Starts
Change 2835863 on 2016/01/20 by Gareth.Martin
Fixed crash in the landscape ramp and mirror tools if the streaming level containing the landscape is hidden (or possibly if the landscape actor is deleted)
#jira UE-24883
Change 2835889 on 2016/01/20 by Taizyd.Korambayil
#jira UE-25698 Enabled V-sync, also fixed up player Respawn Issue
Change 2835995 on 2016/01/20 by Jamie.Dale
The output log now hard-wraps lines to prevent long lines causing performance issues
#jira UE-24187
Change 2836052 on 2016/01/20 by Taizyd.Korambayil
#jira UE-25675 Added Blocking Volume to prevent Player from Falling off map
#jira UE-25676 Added Blocking Volumes so that the Player doesn't get stucl at awkward corners under the Bridge
Change 2836137 on 2016/01/20 by Chad.Taylor
Vehicle and VehicleAdv template content fixes for new VR camera
#jira UE-25507
Change 2836166 on 2016/01/20 by Gareth.Martin
Fixed hiding a streaming level containing a landscape causing the landscape editor to switch to the "New Landscape" tool instead of exiting
#jira UE-25093
Change 2836174 on 2016/01/20 by Chad.Taylor
IHeadMountedDisplay crash fix associated with accessing a dangling pointer.
#jira UE-25272
Change 2836179 on 2016/01/20 by Jamie.Dale
Optimized FShapedGlyphSequence reverse look-up
There's now a reverse look-up map of cluster indices to their glyph data in order to avoid brute force looping
#jira UE-24187
Change 2836286 on 2016/01/20 by Chris.Babcock
Update Qualcomm TextureConverter for OSX
#jira UE-22092
#ue4
#android
Change 2836328 on 2016/01/20 by Nick.Darnell
Fixing a problem with widget components crashing on destruction with the render commands to pre/post render for window render commands needing access to the policy, but it potentially being deleted. Inserting a NoOp command that keeps the shared ptr alive through the RHI render process.
#jira UE-25752
Change 2836342 on 2016/01/20 by Nick.Darnell
Depending on shutdown order, the Slate Renderer may go away, and then render data handles may not be collected correctly because they are trying to reference a pointer that's no longer valid and cause a crash on exit. The correct approach would be to have render handles actually have a pointer back to who owns them, in this case the RHI Resource Manager, which is still alive and well at this point in the pipeline. Then if the resource manager is collected, it forces all handles to get cleaned up correctly, or if the handles are collected first, they can be sure they've got a valid pointer back to the resource manager.
#jira UE-25753
Change 2836358 on 2016/01/20 by Taizyd.Korambayil
#jira UE-25710 Replaced Deprecated Nodes
Change 2836510 on 2016/01/20 by Taizyd.Korambayil
#jira UE-25718 Adjsuted BP to make pointer decal rotate in the direction of surface
Change 2836564 on 2016/01/20 by Taizyd.Korambayil
#jira UE-25716 Added bool to store last Moved Direction
Change 2836697 on 2016/01/20 by Taizyd.Korambayil
#jira UE-25740 Removed unused VR Nodes to remove Log errors on Mac
Change 2836725 on 2016/01/20 by Peter.Sauerbrei
workaround for thread race when trying to release the TargetDeviceService endpoint after an unclaim message is sent
#jira UE-25123
Change 2836782 on 2016/01/20 by Jamie.Dale
Added FTextLayout::AddLines
This is similar to AddLine, however it allows you to add multiple lines in a single call, thus avoiding the re-justification cost associated with each call to AddLine.
AddLine has also been changed to take the same structure type as AddLines (which takes an array of these structures), and the existing version of AddLine has been deprecated.
#jira UE-24187
Change 2836801 on 2016/01/20 by Jeff.Campeau
[CL 2857187 by Matthew Griffin in Main branch]
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720406 on 2015/10/07 by Aaron.McLeran
Audio optimization
Don't search for nearest listener if there's only 1 listener.
Change 2720411 on 2015/10/07 by Aaron.McLeran
Fixing HRTF spatialization code with recent changes to stereo spatialization.
HRTF emitter posiition doesn't need to be converted to XAudio2 coordinates.
Change 2723829 on 2015/10/09 by Mieszko.Zielinski
Fixed NavigationSystem trying to set label of newly spawned navigation data #UE4
UE-21880
Change 2723873 on 2015/10/09 by Mieszko.Zielinski
Fixed a bug in FNavAgentProperties::IsEquivalent resulting in failing the test for FNavAgentProperties instances having default AgentStepHeight value (-1) #UE4
UE-21977
Change 2724834 on 2015/10/12 by Ori.Cohen
PR #1634: Add PxVehicleDriveNW support to PhysXVehicleManager.cpp (Contributed by zeduk)
Change 2724850 on 2015/10/12 by Marc.Audy
Fix sound not restarting in matinee preview when jumping back along timeline after reaching end
#codereview Nick.Darnell
Change 2726499 on 2015/10/13 by Ori.Cohen
Fix edge case where sphyl length and radius are 0 and they are not properly clamped to 0.1
Change 2726689 on 2015/10/13 by Marc.Audy
Make UPackage::PackageFlags private
Add debugging for UE-21181 to try and track down when EditorWorld's PackageFlags are getting flagged as PlayInEditor
#codereview Mike.Fricker
Change 2726862 on 2015/10/13 by Lukasz.Furman
removed unused code from DetourNavMeshQuery
#ue4 UE-21988
Change 2726888 on 2015/10/13 by Lukasz.Furman
fixed observer abort: both mode in behavior tree's cone check decorator
#ue4 UE-19375
Change 2726913 on 2015/10/13 by Lukasz.Furman
navmesh raycast will use nearest poly containing ray origin instead of just closest one
#ue4 UE-19334
Change 2726920 on 2015/10/13 by Marc.Audy
Re-unify ULevelStreaming::GetWorldAssetPackageName and GetWorldAssetPackageFName
#codereview Dmitriy.Dyomin, Bob.Tellez
Change 2726931 on 2015/10/13 by Lukasz.Furman
fixed missing Tick event in aborting behavior tree tasks from abandoned subtree
#ue4 UE-21777
Change 2728093 on 2015/10/14 by Ori.Cohen
Fix edge case of sphyl scale take two. The previous approach did double scaling
Change 2728577 on 2015/10/14 by Mieszko.Zielinski
Improved navmesh labeling condition #UE4
Change suggested by github user
#rb Lukasz.Furman
Change 2728587 on 2015/10/14 by Lukasz.Furman
fixed crowd simulation for auto possessed pawns placed on level
#ue4
#rb Mieszko.Zielinski
Change 2728629 on 2015/10/14 by Lukasz.Furman
fixed influence of navmesh edges on crowd simulation near end of path
#ue4 UE-21380
#rb Mieszko.Zielinski
Change 2728678 on 2015/10/14 by Lukasz.Furman
added Z check to detour's crowd avoidance segment gathering
#ue4 UE-20889
#rb Mieszko.Zielinski
Change 2728745 on 2015/10/14 by Lukasz.Furman
fixed copy&paste operation in behavior tree's composite decorators subgraphs
#ue4 UE-18740
Change 2729276 on 2015/10/14 by Stan.Melax
ensure all actors get recreated with new collision shape specification.
this wasn't being done for a couple of editing methods.
todo: this should be merged into 4.10
#UE-20961
#rb ori.cohen
Change 2730709 on 2015/10/15 by Marc.Audy
Prevent memory corruption when an invalid controller ID is passed in to the forcefeedback channel functions
#rb Lina.Halper
Change 2733590 on 2015/10/19 by Benn.Gallagher
Fixed various crashes when using undo and redo while manipulating state machines UE 22088
Change 2735143 on 2015/10/20 by Lukasz.Furman
clearing behavior tree debugger's state when displayed subtree becomes inactive
#ue4
#rb Mieszko.Zielinski
Change 2735144 on 2015/10/20 by Lukasz.Furman
rebuilding behavior tree graph node order when node is being moved
#ue4
#rb Mieszko.Zielinski
Change 2735403 on 2015/10/20 by sebastian.kowalczyk
Integrated fix for issue UE-18594 "Gameplay Debugger is hijacking the Canvas" issue from 4.10 (2735391). Extended previous fix to care about OSX users - it's possible to configure shortcuts in engine config file now (little different ones for osx platform).
Change 2736406 on 2015/10/21 by sebastian.kowalczyk
Added new GameplayDebugger as a plugin. Old gameplay debugger is still here to keep backward compatibility but it's deprecated now. Current projects should be moved to use new plugin soon.
Change 2736436 on 2015/10/21 by sebastian.kowalczyk
Fixed crash in gameplay debugger with player set as debug target.
Change 2736437 on 2015/10/21 by sebastian.kowalczyk
Added visual indicator around selected pawn to fix FORT-10273 issue. (FN is not using new gd plugin yet).
Change 2736489 on 2015/10/21 by sebastian.kowalczyk
Hide internal and debug hud classes from drop down lists.
Change 2736504 on 2015/10/21 by sebastian.kowalczyk
Fix for UE-18548 "EnableGDT does not work correctly in PIE".
Change 2736529 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-18548 "EnableGDT does not work correctly in PIE"
Change 2736588 on 2015/10/21 by sebastian.kowalczyk
Removed old log visualizer classes.
Change 2736700 on 2015/10/21 by sebastian.kowalczyk
Fixed UE-19256 "Perception debug data doesn't get replicated by Gameplay Debuger" for old gameplay debugger module.
Change 2737180 on 2015/10/21 by Zak.Middleton
#ue4 - Fix UPrimitiveComponent::GetCollisionShape not correctly enforcing bounds limits.
#rb Aaron.Mcleran
#jira UE-22436
Change 2738084 on 2015/10/22 by sebastian.kowalczyk
Better indication of selected pawn for Gameplay Debugger.
Change 2738413 on 2015/10/22 by Marc.Audy
Disable duplication of worlds/maps via the content browser
#jira UE-22200
#rb James.Golding
Change 2739743 on 2015/10/23 by bruce.nesbit
UE-18707 - Issue with drawing material triangle on canvas #1387
Added DrawTriangleUsingVertexColor
Change 2739751 on 2015/10/23 by bruce.nesbit
Revised bShowDebugForReticleTarget should not be static #1539
Change 2739788 on 2015/10/23 by bruce.nesbit
Revised the 2 functions that used FTriangleRenderer::DrawTriangle to use FTriangleRenderer::DrawTriangleUsingVertexColor
Fixed compile error
Change 2739870 on 2015/10/23 by Marc.Audy
Avoid issues while detaching child components if OnAttachmentChange were to remove a sibling component itself.
#jira UE-22362
#rb Zak.Middleton
Change 2739882 on 2015/10/23 by sebastian.kowalczyk
Fix for UE-20901 "VisualLog redirections are broken after PIE finishes" issue.
Change 2740140 on 2015/10/23 by Marc.Audy
Ensure that components reregister tick functions after seamless travel
#jira UE-20892
#rb Zak.Middleton
Change 2740614 on 2015/10/23 by Ori.Cohen
Fix linker issues for people wanting to use physics lock lambdas
Change 2740674 on 2015/10/23 by Aaron.McLeran
Sound Focus Feature
Added new parameters to SoundAttenuation settings to allow audio to change behavior based on its angle to the listener
- Define the min/max azimuth angle to establish in-focus and non-focus regions
- Can scale the priority of a sound based on focus angle
- Can attenuate the volume of a sound based on focus angle
- Can scale the listener-emitter distance based on focus angle
- Distance scale is applied when determining max audible distance for USoundBase
- Can opt-out of focus effects for a sound at the USoundBase level
#rb Ryan.Vance
Change 2741542 on 2015/10/26 by Lukasz.Furman
lowered min value clamping in navigation filter properties
#ue4
#rb Mieszko.Zielinski
Change 2743227 on 2015/10/27 by Marc.Audy
Make ASceneCaptureCube subclassable outside of Engine module
#jira UE-22609
Make USceneCaptureComponentCube::UpdateContent callable outside of Engine module
#jira UE-22610
#rb Jeff.Farris
Change 2743255 on 2015/10/27 by Marc.Audy
Wrap FActorSpawnParameters class with deprecation warning disable pragma instead of hand implementing copy constructor
#rb Jeff.Farris
Change 2743729 on 2015/10/27 by Ori.Cohen
Fix case where we spawn and adjust location which gives us implicit velocity.
#codereview Stan.Melax
Change 2746135 on 2015/10/29 by sebastian.kowalczyk
Fixed UE-21668 "Saving log filters selected in LogVisualizer causes insane ini file sizes! And doesn't really work."
Change 2746437 on 2015/10/29 by Lukasz.Furman
pass on verifying behavior tree stack before accessing its elements
#ue4
#rb Mieszko.Zielinski
Change 2748028 on 2015/10/30 by sebastian.kowalczyk
Changed GameplayDebugger's console variable from gd.EQSOnHUD to ai.gd.EQSOnHUD" after suggestion with MieszkoZ.
Change 2748184 on 2015/10/30 by Aaron.McLeran
UE-22693 Fix for streaming bug
- 3rd decoded buffer in initial 3 buffers was not getting submitted to xaudio2 voice resulting in garbled/skipped audio.
- Wasn't able to repro the 'cannot read chunk' part of the bug
#rb ryan.vance
Change 2749255 on 2015/10/31 by sebastian.kowalczyk
Fixed ai.gd.EQSOnHUD console variable after rename from gd.EQSOnHUD.
Change 2749276 on 2015/10/31 by sebastian.kowalczyk
Added switch to toggle highlight of selected actor to GameplayDebugger.
Change 2749318 on 2015/10/31 by sebastian.kowalczyk
New Gameplay Debugger plugin can be used with old module simultaneously. It's best to configure different keyboard binding for plugin when using old module (it can be set in project settings, for new gameplay debugger plugin - when activated for project).
Change 2749337 on 2015/10/31 by sebastian.kowalczyk
Fixed GameplayDebugger compilation in shipping/test builds.
Change 2749376 on 2015/10/31 by sebastian.kowalczyk
Small clean-up in gameplay debugger class for BT.
Change 2749931 on 2015/11/02 by James.Golding
Add stats to ProcMeshComp
Change 2749932 on 2015/11/02 by James.Golding
Remove PhysicsThrusterComponent.h from Engine.h
Change 2749960 on 2015/11/02 by James.Golding
- Fix PS4 compile errors in ActiveSound.cpp
- Constructor order of FActiveSound
- Shadowed AudioComponent var in CheckOcclusion
#RB thomas.sarkanen
#codereview aaron.mcleran
Change 2749961 on 2015/11/02 by James.Golding
Fix PS4 compile errors in GameplayDebuggerBaseObject.cpp
- Shadowed DefaultContext function param, now just Context, which matches declaration
#RB thomas.sarkanen
#codereview sebastian.kowalczyk
Change 2750026 on 2015/11/02 by Thomas.Sarkanen
Anim Multithreading: thread-safety refactor
Segregated access to various parts of anim update data by spitting off a new proxy class (FAnimInstanceProxy) containing all data accessed in Update() and Evaluate() passes. Gated access to the proxy data on the game thread in a number of ways:
- Explicit access via GetValueOnGameThread() - this blocks on any existing task, completes and then allows control to return to the accessing function. This allows stuff like Blueprints to continue to operate as normal.
- Explicit access via GetValueOnAnyThread() - this ensures that in the limited set of circumstances we need this (Blueprint pure functions mostly) that conditions are met about concurrent access.
- Deprecating many APIs on UAnimInstance that should not be used (and in fact are not used at present, happily).
Derived classes of UAnimInstance can override the creation of the proxy class to create their own type. We do this for UAnimSingleNodeInstance etc.
Any API deprecation should continue to function - no functions have been removed yet. The only things that are not backwards-compatible are direct access to some public member variables for which there is no way to support (e.g. via references, for example UngroupedActivePlayerArrays).
Some APIs have been changed to more specifically represent the dependencies involved. For example TickAssetPlayerInstance() used to take a UAnimInstance*, only to use it to simply queue notifies. This has been deprecated and replaced with a new FNotifyQueue API. FNotifyQueue also uses a thread-safe FRandomStream instead of FMath::Rand.
Many changes are due to substituting accessor functions for direct variable access.
Removed 'service' tick group as we no longer need to segregate the running of our parallel update.
Anim nodes that need to do some game thread-side update should register for a pre-update callback delegate in the proxy. See FAnimNode_AnimDynamics for an example of this.
Moved UpdateActiveVertexAnims into FAnimRuntime so I can subsume some of the code that was in USkeletalMeshComponent::EvaluateAnimation into UAnimInstance (and hence keep the proxy access private).
#rb Martin.Wilson,Lina.Halper
#codereview Michael.Noland
Change 2750077 on 2015/11/02 by Marc.Audy
Expose UInputComponent::BindAction that supports WithKey delegate signature
Change 2751767 on 2015/11/03 by Thomas.Sarkanen
Added extra support to Anim Blueprint 'fast-path'
Added support for negated bools (value gets negated during copy).
Added support for copying from struct members (via break struct) and split struct pins.
Removed potentially troublesome references to BP-constructed UProperties, replacing them with the property FName. This adds some extra Initialize() overhead, but prevents various crash-on load issues (one when generating the class CRC). Added guard to prevent multiple initialization to save this more expensive work being done more often.
#rb Martin.Wilson
Change 2752158 on 2015/11/03 by Jeff.Farris
Fixed UGameplayStatics::SpawnEmitterAttached() to register the ParticleSystemComponent after it spawns.
#rb marc.audy
Change 2752159 on 2015/11/03 by Jeff.Farris
Improvements to camera lens effects to (EmitterCameraLensEffectBase)
- can now specify a transform to align the emitter with the camera
- exposed several key parameters to Blueprints
- ENGINE_API now applies to the entire class
#rb marc.audy
Change 2753454 on 2015/11/04 by Thomas.Sarkanen
Fixup deprecation warnings fallout from multithreaded update changes.
Fixed up use of AnimInstance in Vicon plugin.
Fixed up use of AnimInstance in slope warping node.
Un-deprecated some APIs to become warning free (these APIs are safe to call but just a 'bad idea if you want to do it right').
Also an extra API to allow for smoother transition: Allow custom allocation/deallocation (including using a proxy member struct) by providing an override point for proxy destruction.
#rb Martin.Wilson
Change 2754099 on 2015/11/04 by Ori.Cohen
Fix for task threads dropping stats (from Gil)
#rb Gil.Gribb
Change 2754449 on 2015/11/04 by Marc.Audy
Ensure that components created from an Actor's blueprint BeginPlay implementation get BeginPlay called on them and register their component ticks
#jira UE-20853
Reorganize some booleans to get better bit packing
#rb Jeff.Farris
#codereview Mieszko.Zielinski
Change 2754573 on 2015/11/04 by Aaron.McLeran
Fixing audio component PostLoad code to not set all LowPassFilterFrequency values to 0.0f
Change 2755345 on 2015/11/05 by Thomas.Sarkanen
Added deprecated constructors for various animation contexts
Allows existing code to compile if it creates its own contexts from UAnimInstance.
#rb James.Golding
Change 2755348 on 2015/11/05 by James.Golding
Add BP-exposed SetBoundsScale function to PrimitiveComponent
#RB thomas.sarkanen
Change 2755437 on 2015/11/05 by Marc.Audy
Fix compile errors
#codereview Thomas.Sarkanen, Mieszko.Zielinski, Aaron.McLeran
Change 2755982 on 2015/11/05 by Marc.Audy
Move HeaderParse changes for deprecation macro from Core
Fix world settings warning
Change 2756028 on 2015/11/05 by Marc.Audy
Fix shadow variable issue
Change 2756090 on 2015/11/05 by Ori.Cohen
Improve budget tool so that task threads are computed automatically.
#rb Gil.Gribb
Change 2756120 on 2015/11/05 by Mieszko.Zielinski
Fixed AIController::MoveTo not using DefaultQueryExtent of its navigation data #UE4
#rb Lukasz.Furman
Change 2756243 on 2015/11/05 by Mieszko.Zielinski
Fixed AI perception sight's "auto-visibility" mechanism totally skipping distance and vision cone checks #UE4
The old way was resulting in false positives when for example observer teleported somewhere far
#rb Lukasz.Furman
#codereview John.Abercrombie
Change 2756280 on 2015/11/05 by Mieszko.Zielinski
Minor VLog code cleanup and dumb-fixing visual logger accessing timer manager off of game thread #UE4
#rb Lukasz.Furman
Change 2756500 on 2015/11/05 by Mieszko.Zielinski
Added sanity-checking to BlueprintNodeHelpers::HasBlueprintFunction and cleaned up its usage #UE4
Also, refactored its parameters into references over pointers.
#rb Lukasz.Furman
Change 2757041 on 2015/11/06 by Thomas.Sarkanen
Removed check() in UAnimInstance::GetProxyOnAnyThread()
The check was no longer needed as if we are on the game thread we block until tasks are completed below, and if we are on any other thread we are 'safe' anyway.
#rb James.Golding
Change 2757207 on 2015/11/06 by Ori.Cohen
Fix incorrect root body cache which causes a single frame "freak out" when simulating physics from an animation
#rb Lina.Halper
Change 2757238 on 2015/11/06 by Marc.Audy
Force compiler generated functions to be generated for FHierarchicalSimplification in WorldSettings.h so that they are generated while the deprecation warnings are disabled.
#rb Mike.Fricker
Change 2757284 on 2015/11/06 by Stan.Melax
tapered capsule drawing
cloth collision happens with spheres and for the hull or tapered capsule goemetry between any specified pair of spheres.
(this was already code reviewed before, but missed the check-in window before streamtime)
#rb ori.cohen
Change 2757743 on 2015/11/06 by Lukasz.Furman
fixed node memory allocations for injected behavior tree decorators
#ue4 UE-22783
#rb Mieszko.Zielinski
Change 2757772 on 2015/11/06 by Lukasz.Furman
added setters for crowd avoidance
#ue4 UE-22785
#rb Mieszko.Zielinski
Change 2758422 on 2015/11/07 by Lina.Halper
Potential fix for invalid root bone index input
#jira :/UE-23086
#code review: Ori.Cohen
Change 2758429 on 2015/11/07 by Mieszko.Zielinski
Reimplemented a fix for AI Sight's "auto seeing" mechanics in a more flexible way #UE4
#jira UE-23089
Change 2758571 on 2015/11/08 by Mieszko.Zielinski
Modified ensure condition in UAIPerceptionComponent::OnRegister so it doesn't go off when BP does it's magic when components are being added to a BP actor class #UE4
#jira UE-23080
Change 2758821 on 2015/11/09 by Thomas.Sarkanen
Fixed animations no longer playing when using a dedicated server.
Uses correct logic to determine whether we are running as a server or not.
#rb Martin.Wilson
Change 2758920 on 2015/11/09 by Marc.Audy
Don't dereference weak object pointers repeatedly in FBoneContainer::Initialize
#rb Lina.Halper
Change 2758944 on 2015/11/09 by Ori.Cohen
Fix crash when stats are only on one thread and budget mode is used
Change 2758967 on 2015/11/09 by Benn.Gallagher
Fix for crash undoing notify socket changes in Persona, needed to recache the notify track data after the transaction had reserialized the sequence.
#jira UE-22963
Change 2758973 on 2015/11/09 by Benn.Gallagher
Added new 'Random Player' node for anim graphs allowing the user to play a selection of animations in a random order with certain randomised paramers. Also allows 'Shuffle Mode' to act more like a playlist in that it will play everything on the list before repeating.
#rb Bruce.Nesbit
Change 2759219 on 2015/11/09 by Ori.Cohen
Character perf test is now looking at stats directly and sending to analytics
#RB Ben.Salem
Change 2759398 on 2015/11/09 by Lina.Halper
Fix issue where placed montages are not playing.
- the issue is that IsPlaying does not consider montage, but SetPlaying does. It is asymmetry, so I made it same. However, there are other functions that need to be re-looked at wr.t. montage
#code review: Thomas.Sarkanen
#RB: Marc.Audy
Change 2759491 on 2015/11/09 by Lina.Halper
#Anim: Fix not getting input correctly for Copy Pose node
#RB: Marc.Audy
Change 2759602 on 2015/11/09 by Marc.Audy
Fix imporperly named struct
Change 2759795 on 2015/11/09 by Aaron.McLeran
UE-23145 Adding a Priority value to USoundBase to use in concurrency evaluation and sorting wave instances for voice stealing.
#rb zak.middleton
Change 2760081 on 2015/11/09 by Aaron.McLeran
UE-23091 Adding more logging for NaN checks and fixing one source of NaNs for audio.
OmniDirectional Math Explanation:
For XAudio2, because we do our own distance-attenuation calculations, we use the X3dAudio2 API to simply compute a speaker-map for spatialization and force the listener to be at the origin and the emitter to be on the unit-circle. Thus, from XAudio2's perspective, all distances for every listener-emitter pair will be 1.0.
So in order to use the InnerRadius blending feature, we need to trick it into doing a an inner radius blend relative to a distance of 1.0. For example, if OmniRadius and Distance are the same, then the "NormalizedOmniRadius" is 1.0 and XAudio2 will begin its "blend" of the sound to an omni-directional speaker map.
If Emitter-listener distance is less than the OmniRadius, we'll want to do more blending to an omni-directional speaker map, but we need to set the InnerRadius to something greater than 1.0 (i.e. so that the normalized distance of 1.0 will be treated as less than the InnerRadius). To do "full" omni-directional blending, the emitter-listener distance will be 0 or close to zero, and the NormalizedOmniRadius will be very large (i.e. close to infiinity).
The previous math just set the NormalizedOmniRadius to FLT_MAX which is fine but that number is eventually squared before making the API call. FLT_MAX squared is INF.
Note: I do not think we need to square the OmniRadius in:
Emitter.InnerRadius = OmniRadius*OmniRadius;
But I am keeping it t here because of legacy content which depends on that behavior.
#rb zak.middleton
hange 2760401 on 2015/11/10 by Thomas.Sarkanen@Thomas.Sarkanen-Dev-Framework
Re-instated deleted protected functions in UAnimInstance.
Fixed access of UAnimInstance in FAnimNode_StateMachine.
#rb Martin.Wilson
Change 2760407 on 2015/11/10 by Jurre.deBaare
Construct raw meshes for spline meshes now uses the render data instead of original model data (preserves tangents/normals)
Change 2760468 on 2015/11/10 by Benn.Gallagher
Anim Dynamics optimizations, cached iteration independant data to reduce footprint of iteration on limits.
#rb Graeme.Thornton
Change 2760613 on 2015/11/10 by Jeff.Farris
Fixed async collision completion delegate potentially firing repeatedly. (UE-23149)
#cr marc.audy
#codereview lina.halper
Change 2760795 on 2015/11/10 by Marc.Audy
Don't compile in pointless AddReferencedObjects when with editoronly data not defined
Minor coding standard cleanup (NULL and auto)
Change 2760848 on 2015/11/10 by Benn.Gallagher
Fix to anim instance proxy to not rely on state machine initialization to bind native delegates as nested state machines are not guaranteed to be initialized. This was fixed in UAnimInstance originally but broken again by the proxy instance code.
#jira UE-23164
#rb Martin.Wilson
Change 2760866 on 2015/11/10 by Marc.Audy
Manage transient visualization components for camera component in the same way that sprite component for other actor components are
#rb Mike.Beach
Change 2760963 on 2015/11/10 by Marc.Audy
Since construction script can cause actors to be spawned don't use a ranged for to iterate
#jira UE-22639
#rb Jeff.Farris
#codereview Dmitriy.Dyomin
Change 2762297 on 2015/11/11 by James.Golding
UE-23086 Don't ensure in SetRootBodyIndex when Bodies array is empty (ie no physics state created)
#rb martin.wilson
#codereview ori.cohen, lina.halper
Change 2763566 on 2015/11/11 by Lina.Halper
FAnimNode_CopyPoseFromMesh::Evaluate - was accessing skeleton joint, not mesh joint.
#RB: Laurent.Delayen
Change 2763926 on 2015/11/12 by Thomas.Sarkanen
Fix anim notifies not firing from single anim instances
UE-23248 - Anim Notifies are not working for Animation Sequences
UE-23249 - Anim Notifies using Sound Cues do not work
#rb James.Golding
Change 2764039 on 2015/11/12 by Jurre.deBaare
Fix for issue with incorrect material indices after reducing a skeletal mesh with non LOD0 mesh as BaseLOD (OR-9243) #rb Lina.Halper
Change 2764307 on 2015/11/12 by Jurre.deBaare
VS2015 SSF library
Change 2764314 on 2015/11/12 by Stan.Melax
crashfix was putting bad bodies to sleep at start
Fatal error!
Unhandled Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00000000
UE4Editor-Engine.dll!USkeletalMeshComponent::InitArticulated() [...\\engine\\source\\runtime\\engine\\private\\skeletalmeshcomponentphysics.cpp:875]
On some skeletalmeshcomponent, some bodies aren't getting created correctly. Trying to force them to sleep was causing a crash - it expected instantiated physx bodies. Seems that all the rest of the code is able to tolerate bad bodies.
Added check to ensure physx body exists before trying to force it to sleep.
not sure if bad bodies are the norm or if this fix is just more "kicking the can down the road".
#codereview ori.cohen
Change 2764343 on 2015/11/12 by Jurre.deBaare
- Fixed crash when building a LOD with SubActors.Num < 2
- Force HLOD level slider is now always enabled, however won't show complete image if not all HLODs are build
- LODActor tree view item now scrolls into view if selected in the world
- Set bAllowCullDistanceVolume to false for LODActor's static mesh components by default
- Added 7zip files
- Fixed issue with WinINet complaining about http-request without 'http://' prefix
- Changed % reduced or original triangles display string, now uses float instead of int (for < 1% reductions)
- Override texture sizes and automatic texture bias
- Fixed issue with incorrect material merging, not picking up it required mesh-data during baking. Added extra conditions for rendering with mesh-data.
- Now incorporate static meshes with opague materials into HLOD merging
- Fixed issue with incorrect normals after merging meshes who's owning components had been negatively scaled
- Fixed issue with incorrect texture size being set from MergeActor window (was only changing .X component)
- Fixed issue with material merging when meshes with multiple LODs are merged, right now only merges LOD0's together if we are also merging the materials (otherwise, merge each LOD)
- Added ENUM for texture scaling/resizing type that has to be applied while merging the materials
- Added detail customization class for FMaterialProxySettings
#rb James.Golding
[CL 2765024 by Marc Audy in Main branch]
Specifies platforms more explicitly, making things easier when an "unexpected" host platform is passed.
#codereview Kellan.Carr
[CL 2286780 by Dmitry Rekman in Main branch]