Commit Graph

141585 Commits

Author SHA1 Message Date
RPG3D
b65e7beea4 Ignore empty AAR directories on Android (contributed by RPG3D)
#jira UE-88492
#PR #6676
#ue4
#android
#rb trivial

[CL 11520899 by Chris Babcock in 4.25 branch]
2020-02-18 16:46:54 -05:00
Brandon Schaefer
0bb46f9ba0 Clean up UDeviceProfileManager handle before Module starts exiting as that single will have its delegate deleted from under it
#jira UE-88677
#rb Frank.Fella

[CL 11520513 by Brandon Schaefer in 4.25 branch]
2020-02-18 16:43:48 -05:00
David Lesage
919c80b62e #jira UE-88893
The problem was a post process of the meta data to remove unprintable characteres. Process that removed the end character from the string...
So configurations of the parts became different for each instance of part...
#rb johan.duparc

[CL 11519600 by David Lesage in 4.25 branch]
2020-02-18 16:34:14 -05:00
steve smith
40aab30f39 Speculative fix for Ovr Avatar shutdown crash. Crash in question always occurs during shutdown, disabling the gaze target, and it always happens in the delay load helper functionality triggering an exception thrown if the module has been unloaded. Adding this check should catch this shut-down ordering case.
#jira UE-78960
#rb jeff.fisher

[CL 11519272 by steve smith in 4.25 branch]
2020-02-18 16:32:01 -05:00
Brandon Schaefer
f63c92ea03 Rebuild Alembic again with new visibility flags
#jira UE-88795
#rb none
#fyi Will.Damon

[CL 11518105 by Brandon Schaefer in 4.25 branch]
2020-02-18 16:25:37 -05:00
john hable
cddb5b69c8 Fixing NaNs in Burley SSS texture kernel generation.
#fyi bob.tellez
#rb none
#jira ue-89045

[CL 11516919 by john hable in 4.25 branch]
2020-02-18 16:17:52 -05:00
Patrick Laflamme
75b36ad299 #jira UE-85967 - UnrealDisasterRecoveryService character length is long and can easily max out path length
#jira UE-88070 - UnrealDisasterRecoveryService paths are too long
  - Renamed UnrealDisasterRecoveryService as UnrealRecoverySvc
  - Set a ConcertSyncServer ShortName as "CncrtSyncSvr" to ensure shorter build path.

The change saves 29 characters on the offending path. The path before vs the path after:

Engine\Plugins\Developer\Concert\ConcertSync\ConcertSyncServer\Intermediate\Build\Win64\UnrealDisasterRecoveryService\Development\ConcertSyncServer\UnrealDisasterRecoveryService-ConcertSyncServer.lib (Before, 199 chars)
Engine\Plugins\Developer\Concert\ConcertSync\ConcertSyncServer\Intermediate\Build\Win64\UnrealRecoverySvc\Development\CncrtSyncSvr\UnrealRecoverySvc-ConcertSyncServer.lib (After, 170 chars)

#rb Jamie.Dale

Edigrated 11281991 from Dev-VirtualProduction

[CL 11516806 by Patrick Laflamme in 4.25 branch]
2020-02-18 16:17:00 -05:00
jon nabozny
02d39a902f Fix regression in UEnum Net Serialization
#jira UE-88913
[at]Mattias.Hornlund, [at]Ryan.Gerleve
#lockdown james.golding
#rb Ryan.Gerleve

#ROBOMERGE-SOURCE: CL 11516651 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Release-4.25) (v654-11333218)

[CL 11516725 by jon nabozny in 4.25 branch]
2020-02-18 16:16:32 -05:00
daniel coelho
78683b94f5 USD: Base-level error handling; Unify logging
#jira UE-87852
#rb JeanMichel.Dignard

[CL 11515955 by daniel coelho in 4.25 branch]
2020-02-18 15:59:27 -05:00
braeden shosa
9b66e80ab1 Added missing Source.GatherDebugData to FAnimNode_Inertialization::GatherDebugData
#rb Laurent.Delayen
#jira none

[CL 11515945 by braeden shosa in 4.25 branch]
2020-02-18 15:58:04 -05:00
Patrick Laflamme
276bd1b2b3 #jira UE-87927 - Disaster Recovery doesn't restore a crash from a restored session
- Fixed concert server to restore a session (by creating a new one) in the 'default repository' as expected rather than the creating it in the repository containing the archived session.

#rb Jamie.Dale

Edigrated 11252374 from Dev-VirtualProduction.

[CL 11515813 by Patrick Laflamme in 4.25 branch]
2020-02-18 15:52:56 -05:00
Ben Ingram
085a2aab27 #jira none
Freeze-related fixes for several niagara DI, and change name of virtual function to make future mistakes of this type into compile errors
#rb none

[CL 11515526 by Ben Ingram in 4.25 branch]
2020-02-18 15:50:35 -05:00
Patrick Laflamme
47044a7f9a #jira UE-87900 - Disaster Recover stops recording transactions if the UDP transport layer restarts or auto-repair
- Fixed disaster recovery remote endpoint timeout set to zero, preventing it from re-registering with MessageBus when an error occurred (like the socket disconnected).

#jira UE-87899 - Disaster recovery prevents showing the crash reporting UI in a timely manner if the session is large
  - Fixed the crash reporter app to display the UI (asking the user to send the bug report) before shutting down the recovery service.

- Renamed the field FDisasterRecoveryInfo::Version into FDisasterRecoveryInfo::Revision because revision is more accurate for the field.

#rb Jamie.Dale

Edigrated 11250824 from Dev-VirtualProduction.

[CL 11515425 by Patrick Laflamme in 4.25 branch]
2020-02-18 15:49:59 -05:00
Patrick Laflamme
444da0bd40 #jira UE-88801 - CrashReporterClientEditor crashes if the bug report windows in closed before the callstack appears
- Prevented CrashReportClient::FinalizeDiagnoseReportWorker() function to called after the CrashReportClient instance was deleted.

Details:

The FDiagnoseReportWorker asynchronous task created an extra asynchronous tasks (calling back CrashReportClient instance) that could fire after the targetted CrashReportClient instance was deleted. The solutions moves the logic to 'finilize' the report in the tick function that is expected to run in the game thread and make 'Close Without Sending' flows  like 'Send and Close'/'Send and Restart' but without sending anything.

#rb Francis.Hurteau
#lockdown cristina.riveron

Edigated 11462889 from 4.24

[CL 11512537 by Patrick Laflamme in 4.25 branch]
2020-02-18 15:30:18 -05:00
zach bethel
ec74888ccb Fix for bloom being sampled incorrectly in tonemap pass.
#rb trivial
#jira UE-88444

[CL 11512116 by zach bethel in 4.25 branch]
2020-02-18 15:13:26 -05:00
Patrick Laflamme
c05f507c5e #jira UE-88250 - Crash Report Client doesn't emits EditorSummaryEvent with proper AppId/AppVersion/SessionId/UserId
- Added AppId, AppVersion and UserId as FEditorAnalyticSession members and updated FEditorSessionSummaryWriter to write them.
  - Changed FEngineAnalytics::GetProvider() to return IAnalyticsProviderET rather than IAnalyticsProvider.
  - Updated FEditorSessionSummarySender to embed the AppId/AppVersion/UserId as attribute when sending the summary event and also configured the AnalyticsProvider to use the SessionID/AppID/AppVersion/UserID of the event rather than the current one.
  - Added a function to return the current IAnalyticProviderET configuration.

#rb Wes.Hunt

Edigrated 11445334 and 11459406.

[CL 11512055 by Patrick Laflamme in 4.25 branch]
2020-02-18 15:12:36 -05:00
Shaun Kime
730bf2e064 Fixed: if multiple instances of a DI were used in a script, the HLSL translator produced all function combinations for each instance.
DataInterfaceRegisteredFunctions accumulated all registered functions from all the instances, then the generator iterated over it for each instance, which was incorrect. The information was already available per instance in FNiagaraScriptDataInterfaceCompileInfo.RegisteredFunctions, so we can just use that and remove DataInterfaceRegisteredFunctions entirely.

Already submitted this once as 11386264, but that introduced a new bug, because RegisteredFunctions can contain duplicates. Did it properly this time, so that GetFunctionHLSL is called once per unique function instance.

#jira none
#rb nicholas.goldstein
#fyi mihnea.balta

[CL 11511993 by Shaun Kime in 4.25 branch]
2020-02-18 15:10:02 -05:00
Jamie Dale
b4ee398d06 Ensure we clean-up the gather process after it's completed
#jira UE-88891
#rb none
#rnx

[CL 11511880 by Jamie Dale in 4.25 branch]
2020-02-18 15:05:41 -05:00
Lauren Barnes
2fd8cf97fe Adding default value for ForceShowEngineContent
#rb Jamie.Dale
#jira UE-89005

[CL 11511666 by Lauren Barnes in 4.25 branch]
2020-02-18 15:00:58 -05:00
Ben Ingram
35c94634d2 #jira FORT-250816
Remove warning message when display name for material attribute changes, triggered when loading UMaterialExpressionGetMaterialAttributes
#rb none
#fyi cody.albert

[CL 11511574 by Ben Ingram in 4.25 branch]
2020-02-18 14:57:47 -05:00
Patrick Laflamme
038532623e #jira UE-88517 - Concert Log Spam - (ConcertKeepAlive) discarded.
- Defaulted the Concert debug log level to 'Error' to avoid spamming the log when a remote endpoint disconnect.

#rb Jamie.Dale

Edigrated from 11445411.

[CL 11510926 by Patrick Laflamme in 4.25 branch]
2020-02-18 14:46:14 -05:00
Patrick Boutot
c44cc32971 Remove reference to marketplace for AJA and Blackmagic plugin. They are now shipped with the engine.
#jira UE-88993
#fyi simon.therriault
#rb none

[CL 11510537 by Patrick Boutot in 4.25 branch]
2020-02-18 14:40:28 -05:00
Patrick Laflamme
6d150df57a #jira UE-88769 - CLONE - Analytic reports are not sent by crash report client editor until the 'Send usage Data' is toggled in Editor preferences
- Edigrated 11250215 from Dev-VirtualProduction.

#rb none

[CL 11510068 by Patrick Laflamme in 4.25 branch]
2020-02-18 14:32:10 -05:00
benoit deschenes
d2f4be2b86 Integrating CL# 11509121 from Dev-Enterprise
Fixing datasmith light template not applied on reimport

#jira UE-81213
#review-11508046 JeanMichel.Dignard
#rb JeanMichel.Dignard

[CL 11510007 by benoit deschenes in 4.25 branch]
2020-02-18 14:30:51 -05:00
benoit deschenes
5c646fe7a9 Integrating CL# 11464638 from Dev-Enterprise
Fixing UCX Chaos Collision meshes not being exported

#jira UE-88563
#rb Alexis.Matte

[CL 11509867 by benoit deschenes in 4.25 branch]
2020-02-18 14:29:14 -05:00