Move GlobalCollection to GameInstance subsystem.
Rename category from MVVM to Viewmodel.
#preflight 63d5e0bcba4fadeef09bdfc2
[CL 23927160 by patrick boutot in ue5-main branch]
#rb dan.oconnor
#preflight 63d83f963656ea96dc2a0a4c
#jira UE-173747
"Crash occurs when scrolling down through files in Review Changelist window upon loading of asset"
- certain widget blueprints were crashing the review tool because we were working around the inability to diff against nullptr by constructing temprorary empty objects. This approach circumvents that problem entirely
#jira UE-173231
"Changelist Review tool allows diffing against previous revision for Deletion changes"
- while this jira suggests that the ability to diff deletion changes is a bug, it was actually an intended feature. The real bug was that it would crash or fail to work in many cases. This has been fixed by either asset diffing against nullptr or text diffing against an empty file (depending on circumstance)
#jira UE-174610
"Reviewing Changelist with Deletion Changes results in LogLinker warnings & LoadErrors"
- deletion changes were trying to load the new revision of files but obviously it doesn't exist because it's a deletion. Fixed by only loading the previous revision
note: since the review tool is going to be "Production Ready" in 5.2, these changes are neccesary for stability
[CL 23924072 by jordan hoffmann in ue5-main branch]
* Ran IWYU on ~170 plugins to remove includes not needed. Public api still keep old includes inside #if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2
#preflight 63d09351574ab9cae4670216
#rb none
[CL 23844750 by henrik karlsson in ue5-main branch]
- One Time / One Way
- One Time / One Way to Source
- One Time / Two Way
[REVIEW] sebastian.nordgren
[CL 23747997 by patrick boutot in ue5-main branch]
Non-boolean function parameters now have a dark background. Booleans are displayed as checkboxes and don't scale to the minimum width, so adding the background for them looks bad.
Tested in Bindings view with a conversion function: bind to viewmodel property, toggle binding off, toggle binding back on again. Observe that the viewmodel property is still bound.
[REVIEW] [at]patrick.boutot
#preflight 63c1519d70575f890029a3a6
[CL 23741270 by sebastian nordgren in ue5-main branch]
* Updated public headers for ~170 engine plugins using iwyu to remove includes not needed. Removed includes are still available behind UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2
#preflight 63c08f4a2a6acaf1622bcc73
#rb none
[CL 23674775 by henrik karlsson in ue5-main branch]
* Removed more includes using iwyu and marked up includes that is removed because of bugs in iwyu.
#preflight 63bfc8696c4f5668eb3a3cbd
#rb none
[CL 23666746 by henrik karlsson in ue5-main branch]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn
#preflight 63bf8d8b577437afe607dc72
#rb none
[CL 23659643 by henrik karlsson in ue5-main branch]
It was erroneously not clearing if FixedSource wasn't set (ie. a widget field), but the intent was to clear only the path when editing a widget property, and the entire path when editing anything else.
[REVIEW] [at]patrick.boutot
#rnx
#preflight 637df1bdfa348e8480298a71
[CL 23247747 by sebastian nordgren in ue5-main branch]
It is possible to show only the last field in a path when space is limited.
[REVIEW] [at]patrick.boutot
#rnx
#preflight 63611c20731604696a0f4e3a
[CL 22919758 by sebastian nordgren in ue5-main branch]
