Commit Graph

16625 Commits

Author SHA1 Message Date
Martin Ridgers
8980e6a81c Reject traces without well-formed metadata blobs
#rnx
#preflight none
(git:37fcb57 - Martin Ridgers - 2022-11-22 15:21:48 +0100)

[CL 23246589 by Martin Ridgers in ue5-main branch]
2022-11-23 03:53:33 -05:00
Martin Ridgers
96cab46eee Also fail on unexpected metadata sizes too
#rnx
#preflight none
(git:b9bd36e - Martin Ridgers - 2022-11-22 15:19:11 +0100)

[CL 23246583 by Martin Ridgers in ue5-main branch]
2022-11-23 03:52:58 -05:00
Martin Ridgers
d469026c31 Removed unused function
#rnx
#preflight none
(git:7905ddc - Martin Ridgers - 2022-11-22 11:14:26 +0100)

[CL 23246575 by Martin Ridgers in ue5-main branch]
2022-11-23 03:52:27 -05:00
Martin Ridgers
7ade61a8a1 Only create traces with the store when valid trace data has been detected.
Prior to this change, a trace was registered with the store component before creating the relay that receives data over the socket and writes it to a file. While the relay does check the preamble of the data received, and rejects anything that is not a trace, it does not clean up the store. Now no trace is created until the relay has determined it has a trace to receive data for. This stops zero-sized traces littering a users disk which can happen if the machine is port scanned by their IT department.

#rb im
#rnx
#preflight none

[CL 23246554 by Martin Ridgers in ue5-main branch]
2022-11-23 03:48:46 -05:00
Martin Ridgers
62fdab785b Sanitise received payload size to within sensible limits.
Any random data that might be received by the CBOR server could cause it to allocate a lot of memory, or suffer a signed overflow and collapse. This can happen for example if a machine is port scanned by an IT department. To guard against this, the input is checked to ensure it is within a suitable before use.

#rb im
#rnx
#preflight none

[CL 23246365 by Martin Ridgers in ue5-main branch]
2022-11-23 02:31:52 -05:00
josh adams
2bb7de64da - Added a new callback to staging that allow for finalization of staged files
- Added a default implementation of GetCookPlatform, which allows BuildCookRun to run without needing any platform-specific automation DLLs (cook and staging can happen, but running/packaging would still need the platform automation dlls)
#rb graeme.thornton
#preflight 637d2ed8f514e1ded91d417b

[CL 23244387 by josh adams in ue5-main branch]
2022-11-22 20:17:39 -05:00
jerome delattre
fcdbeaf5a5 Provide executable target name for CookedEditor build
+ Match the whole name of the application when identifying build source

#jira UE-169026
#rnx
#preflight 6363d22f882365b8594bb9d0
#rb Eric.Knapik

[CL 23243948 by jerome delattre in ue5-main branch]
2022-11-22 19:57:54 -05:00
roman dzieciol
3ce3813f96 Fix typo in ld arguments for edge case Android libs that don't start with "lib".
The intention was:
/some/path/libfoo.a -->
AdditionalLibs.Add(libfoo.a) -> -lfoo
AdditionalLibraryPaths.Add(/some/path) -> -L/some/path
/some/path/bar.a -->
AdditionalLibs.Add(/some/path/bar.a) -> /some/path/bar.a

#rb Josh.Adams
#jira none
#preflight none
(Copy from 4.27+)

[CL 23243817 by roman dzieciol in ue5-main branch]
2022-11-22 19:51:10 -05:00
tim smith
af6c57ed1f Fixed C# UHT to generate a circular dependency error when an include file includes itself.
#rb self
#preflight 637ce133815e4b9b75554492

[CL 23243802 by tim smith in ue5-main branch]
2022-11-22 19:50:10 -05:00
Wojciech Krywult
0d6fe82a54 Build: Symbol Server: Downgraded a warning about a PDB being larger than 4GB to an information log.
This message should really be a warning, but given we have no way of fixing it (it's a limitation of pdbstr.exe tool from Windows SDK) there's not much use of having it as it just prevents our build machines from being green.

#preflight 637cefac8b12eb83a7cb824c
#rb none
#rnx

[CL 23237341 by Wojciech Krywult in ue5-main branch]
2022-11-22 11:56:08 -05:00
vincent robert
38d299f4a5 Fix Triangle Sphere Overlap
#preflight 637be9522a05dabce91c397a
#rb jaco.vandyk

[CL 23235034 by vincent robert in ue5-main branch]
2022-11-22 09:52:49 -05:00
dan elksnitis
92c56f938f [ShaderCompileWorker] minor fixes:
- allow 0 TimeToLive to be specified explicitly on commandline (useful when debugging single-job debug worker input files, without this it keeps running the same job repeatedly) and modify single job worker input commandline txt file to use this instead of 0.5f
- change config-conditional behaviour serializing to memory instead of file on disk to be conditional on an optional cmdline argument instead, and move file copy into the block that does the file writing (otherwise it repeatedly tries and fails to copy the nonexistent file)

#preflight 6377fed033774509008c42c6
#rb Jason.Nadro

[CL 23234934 by dan elksnitis in ue5-main branch]
2022-11-22 09:42:02 -05:00
Martin Ridgers
d4af074fe0 Removed OpStart for clarity
#preflight none
#rnx
(git:06eb61a - Martin Ridgers - 2022-11-22 11:08:02 +0100)

[CL 23233913 by Martin Ridgers in ue5-main branch]
2022-11-22 08:15:55 -05:00
Martin Ridgers
4ae563d2a3 Split parsing of .utrace magic into its own method
#rnx
#preflight none
(git:31963c2 - Martin Ridgers - 2022-11-22 11:03:03 +0100)

[CL 23233767 by Martin Ridgers in ue5-main branch]
2022-11-22 08:02:11 -05:00
Martin Ridgers
63c40dc2a4 Have the recorder relay create the trace itself
#rnx
#preflight none
(git:e317541 - Martin Ridgers - 2022-11-22 09:39:12 +0100)

[CL 23233602 by Martin Ridgers in ue5-main branch]
2022-11-22 07:39:38 -05:00
Martin Ridgers
b063c16470 Split op IDs across multiple lines
#preflight none
#rnx
(git:2ca2101 - Martin Ridgers - 2022-11-22 09:29:54 +0100)

[CL 23233591 by Martin Ridgers in ue5-main branch]
2022-11-22 07:39:15 -05:00
Martin Ridgers
c97877ca57 Moved socket keep-alive modification into the relay as it is the socket owner
#preflight none
#rnx
(git:8f63330 - Martin Ridgers - 2022-11-21 10:03:07 +0100)

[CL 23233583 by Martin Ridgers in ue5-main branch]
2022-11-22 07:38:47 -05:00
paul chipchase
c9735099a8 UnrealVirtualizationTool can now be given the path of a package or the path of a directory of packages to virtualize in addition to previous functionality. NOTE that all existing functionality should continue to work but using -Mode=Changelist or -Mode=Packagelist will result in a warning prompting the future use of the new versions for those commands.
#rb Per.Larsson
#jira UE-170657, UE-160396
#rnx
#preflight 637c9232fa348e8480bdc7e2

- When the rehydration functionality was added it started to look like more functionality would be added to the tool than originally thought so I started to add the new functionality via a command system. This change now moves the older legacy functionality to the coommand system as well.
- Added a new FVirtualizeCommand which can accept package paths, directory paths, packagelist files or changelists as the input.
-- Unlike the legacy commands, virtualizing via changelist does not require the client spec to be provided on the commandline, although doing so will avoid several perforce commands and speed up the call. It is expected that people calling the tool on the commandline will probably opt to not supply a clientspec and let the tool workout which workspace a changelist is under, where as calls from other tools (such as P4VUtils) can provide it if already known to speed things up.
-- FVirtualizeLegacyChangeListCommand replicates the functionality of the old -Mode=Changelist command.
-- FVirtualizeLegacyPackageListCommand replicates the functionality of the old -Mode=Packagelist command.
-- The new command will only try to submit the results if a changelist was provided as the input and even then it will not do so by default. The tool now requires people to opt into submitting the changelist via the command line option -submit. NOTE: Other versions of the command maybe allow submission in the future but the virtualization process needs to be improved so that it can check out package files before this really makes sense.
- The rehydration command no longer requires a clientspec on the command line, it wasn't using the value anyway.
- Moved the source control code from the app code files to CommandBase. If we add more commands in the future we might want to factor this out to its own base class so commands can opt into source control functionality.
- In the future we should probably move the package -> project sorting code (FUnrealVirtualizationToolApp::TrySortFilesByProject) into the command base code as well.

[CL 23233456 by paul chipchase in ue5-main branch]
2022-11-22 07:23:08 -05:00
chris caulfield
6bab3880ea Chaos - various gather optimizations
- collision solver manifold points now allocated separately (previously there was a fixed array of 4 manifold points)
- no default initialization of low-level solver structs
- remove SolverBodyAdapter and CollisionSolverAdapter (now have simple C-style gather methods)
- seprarate collision results from friction anchors
- add over-allocating array growth policy to solvers
- add prefetch to collision gather
- reduce size of SolverBody slightly (V and W in floats)
- move collision activation to run in parallel
- optimize search for friction anchor (AssignSavedManifoldPoints)
- clean up material property resetting following contact modification
- begin deprecation of FParticleUtilities (WIP)

#rb jaco.vandyk, vincent.robert, benn.gallagher
#preflight 63782333170bc34a938bacec
#preflight 637c25c3170bc34a93551f7e

[CL 23232043 by chris caulfield in ue5-main branch]
2022-11-22 02:00:17 -05:00
calvin zheng
6e8536c5b4 5.1 QFE
This QFE addresses multiple issues with Mac builds in UE 5.1:

* Removed Apple Silicon from default build architectures if installed from Epic Games Launcher, as it is not yet supported in UE 5.1 as a default option.
   * Apple Silicon native build will be available in UE 5.1 through Epic Games Launcher at a later time, but for now please build from GitHub (URL for linking here - https://github.com/EpicGames/UnrealEngine/tree/5.1)
* Fixed a Mobile Preview crash on Mac when Mobile Deferred is enabled and Preview Rendering Level set to iOS Shader 3.1
* Fixed issue that was preventing movable lights from properly casting light on Mac

#jira n/a
#preflight n/a
#rb Ryan.Hummer, Rolando.Caloca

[CL 23230900 by calvin zheng in ue5-main branch]
2022-11-21 20:38:48 -05:00
tim smith
d86795f60a Fixed performance issue with shadow detection and symbol lookup.
#rb self
#preflight 637bcb3acc307d6fa56f99d9

[CL 23228048 by tim smith in ue5-main branch]
2022-11-21 17:19:05 -05:00
Ben Marsh
e2efc4b1f3 Horde: Allow configuring OIDC tokens to be set via the agent type.
#preflight none
#fyi Joakim.Lindqvist

[CL 23222670 by Ben Marsh in ue5-main branch]
2022-11-21 12:08:34 -05:00
carl bystrom
6bf3b1f95a EpicGames.Perforce.Managed: Add tests for syncing without have-table and cache files
Also add stricter verification of digests after sync
#preflight 637b9365f514e1ded98f4921

[CL 23220725 by carl bystrom in ue5-main branch]
2022-11-21 10:07:07 -05:00
carl bystrom
236d80afa3 Horde: Ensure instance data is copied in tests to avoid leaking state
#preflight none

[CL 23220500 by carl bystrom in ue5-main branch]
2022-11-21 09:50:34 -05:00
Ben Marsh
c6ac15444f Horde: Fix NamespaceId parameters no longer being validated correctly.
#preflight none
#fyi Joakim.Lindqvist

[CL 23220253 by Ben Marsh in ue5-main branch]
2022-11-21 09:21:32 -05:00