Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).
Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.
Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.
Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)
#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9
[CL 22878911 by Thomas Sarkanen in ue5-main branch]
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.
#jira
#preflight 631e283bec5b0c765fc0ffdb
[CL 21960084 by bryan sefcik in ue5-main branch]
This change also added a delegate to FPersonaToolkitArgs with reference to a IDetailBuilderLayout so assets can customize the Preview Scene Settings.
#JIRA https://jira.it.epicgames.com/browse/UE-148894
#rb halfdan.ingvarsson
#preflight
#preflight 631b7a00967ffc68fb262e06
[CL 21924418 by kiaran ritchie in ue5-main branch]
- Enable users to view and edit the parent and child frame transforms of constraints in the PhAT details panel
- Constraint transforms are represented as a position and a rotator in the details panel (internally they are represented as a position and a pair of orthonormal vectors)
- Constraint transforms can optionally be displayed in the frame of the assocaited bone OR relative to the default (snapped) transforms
- Allow parent / child transform position / orientation componenets to be 'snapped' to defaults individually
- Support using modifier keys to manipulate only the child frame transform via a viewport widget
#jira UE-119744
#jira UE-119741
#rb [at]Thomas.Sarkanen, [at]sebastian.nordgren
#preflight 62f13b9a23003b62a3d4c277
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 21282618 via CL 21282632 via CL 21282638
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21283069 by nick brett in ue5-main branch]
In FN, the workflow for creating physics assets for vehicles often involves importing at least one static mesh and copying collision shapes from it. It's currently really challenging to copy individual shapes between static and skeletal mesh body setups. With the added shape copy/paste commands, we get a lot more flexibility out of SM editor and PHAT, and a somewhat simpler workflow.
If we have physics assets A and B and we want to add one shape (or a specific subset of shapes) from a body in A to a body in B, this change is needed to do that. Since I'm trying to do this all the time while editing physics assets for vehicles, I use this shelf locally.
#rb benn.gallagher, nick.brett, satchit.subramanian
#ROBOMERGE-AUTHOR: steven.barnett
#ROBOMERGE-SOURCE: CL 20861874 via CL 20861887 via CL 20861898
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)
[CL 20876607 by steven barnett in ue5-main branch]
- Added menu options for setting shapes to QueryAndProbe and ProbeOnly
- Added PHAT actions for selecting shapes in a body based on collision type (useful for complex physics setups)
This change depends on 20366101, which adds the QueryAndProbe and ProbeOnly CollisionEnabled settings going in first.
#rb nick.brett
#ROBOMERGE-AUTHOR: steven.barnett
#ROBOMERGE-SOURCE: CL 20797066 via CL 20799858 via CL 20801530
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)
[CL 20803683 by steven barnett in ue5-main branch]
* Removed deprecated or dead code paths
* Simplified build system setup for physics support
* Deprecated build system flags and unsupported macros
#jira none
#rb Chris.Caulfield, Kriss.Gossart
#preflight 62963ec0fe779f23c8ea0c5e
[CL 20450744 by Benn Gallagher in ue5-main branch]
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
This appears to have already been implemented, but had 2 bugs.
PhysicsAssetEditor::FShapeData needs all data to represent a unique shape, but did not include primitive type. Primitive index is the index into the list of primitives of a type, not into the full list of primitives, so primitive type needed to be added to this struct.
FPhysicsAssetEditor::HandleViewportSelectionChanged was looking for shapes within the list of selected constraints rather than the list of selected bodies. This change adds code to check the body selection for shapes _as well as_ the constraint selection. I left the constraint selection bit in there in case we want selecting a constraint to select the shapes it's attached to.
[FYI] benn.gallagher, chris.caulfield, gates.aldridge, satchit.subramanian
#ROBOMERGE-AUTHOR: steven.barnett
#ROBOMERGE-SOURCE: CL 20341171 via CL 20341211 via CL 20341235
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)
[CL 20341859 by steven barnett in ue5-main branch]
- Added a Floor Collision Enabled Checkbox to the 3-dots options menu attached to
the Simulate Tool bar button in PhAT.
#rb [at]Cedric.Caillaud
#preflight 626bdfcf7272eba608628667
#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 20022773 via CL 20022869 via CL 20022876
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
[CL 20023223 by nick brett in ue5-main branch]
- Added Debug Visualization of physics bodies and constraints for RBAN nodes in AnimBP editor
- Added checkboxes to filter debug Visualization to Phat skeleton tree
- Created a new PhysicsAssetRenderSettings class that incorporates the debug rendering and filtering settings from Phat
- Created a new PhysicsAssetRenderUtilities namespace that incorporates the debug rendering and filtering code from Phat
- Synchronize debug visualization of physics bodies and constraints between Phat and AnimBP editors
oringinaly submitted as cl-19242421 but failed on non-unity build so backed out
#rb [at]Chris.Caulfield, [at]Thomas.Sarkanen, [at]Cedric.Caillaud
#preflight 6221e57d335298c3145112d1
#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 19283727 via CL 19295417 via CL 19304854 via CL 19304870
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)
[CL 19347122 by nick brett in ue5-main branch]
- Refresh physics asset editor hierachy when pasting bodies from clipboard
- Copy of only constraints now works
- Change wording of the copy a/ paste commands to reflect teh body constraint dulaity
- Fix duplicate menu entry for constraint context menu
#rb none
#jira UE-126847, FORT-425181, FORT-425179, FORT-425180
#preflight 61f0cfb0e12e3fcf9b077ba8
#ROBOMERGE-AUTHOR: cedric.caillaud
#ROBOMERGE-SOURCE: CL 18732730 in //UE5/Release-5.0/... via CL 18732731 via CL 18732779
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)
[CL 18732783 by cedric caillaud in ue5-main branch]
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971
[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]