Commit Graph

1373 Commits

Author SHA1 Message Date
arturo coloradogarin
2c65e210b6 Ability to restrict what characters can be used in a text property editor.
#rb [at]jamie.dale [at]lewis.farrell

[CL 25546012 by arturo coloradogarin in ue5-main branch]
2023-05-19 12:03:19 -04:00
aditya ravichandran
3313c4a833 Fix a crash in the property matrix when you navigated to the root while having cells selected
#rb trivial

[CL 25536096 by aditya ravichandran in ue5-main branch]
2023-05-18 18:51:43 -04:00
jordan hoffmann
cb523ba72c [BugFix] Details splitter doesn't highlight certain diffed properties and scrolling isn't synced with those rows
#rb trivial
#preflight 64655795fa4cf416517c3313

[CL 25531733 by jordan hoffmann in ue5-main branch]
2023-05-18 15:30:14 -04:00
aditya ravichandran
dd36f87106 Non-unity fix in PropertyTableCellPresenter
[CL 25508174 by aditya ravichandran in ue5-main branch]
2023-05-17 11:32:56 -04:00
aditya ravichandran
07f12688e4 Property Matrix Reskin
#rb JeanMichel.Dignard
#preflight 646413f5fa4cf41651def1a5

[CL 25507370 by aditya ravichandran in ue5-main branch]
2023-05-17 10:49:51 -04:00
mikko mononen
2c677cc679 Require property nodes directly on a structure node to validate their data.
This fixes the case that the address pointed by a structure provider changes outside the usual editor functionality.

#preflight 646492952d446eac96a704e3

[CL 25504258 by mikko mononen in ue5-main branch]
2023-05-17 06:10:46 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
George Rolfe
fc38e5165b Added templated overloads to DetailLayoutBuilder
#jira none
#rb jason.walter
#preflight 642a24d8ce01db47ac397674

[CL 25465286 by George Rolfe in ue5-main branch]
2023-05-13 03:53:57 -04:00
marc audy
20303348c4 Remove (the never should have been exposed) direct access to the private PropertyNode via the PropertyHandle
[CL 25458606 by marc audy in ue5-main branch]
2023-05-12 16:01:47 -04:00
jamie dale
d54218add0 Allow the "browse to" button in SPropertyEditorAsset to be enabled even if the rest of the widget is disabled
#rb Rex.Hill
#rnx

[CL 25438556 by jamie dale in ue5-main branch]
2023-05-11 19:33:24 -04:00
bryan sefcik
91c57d395e Removed redundant module includes.
#preflight 645d4bf3aa3c584c0b5b3a67

[CL 25435653 by bryan sefcik in ue5-main branch]
2023-05-11 16:48:21 -04:00
benjamin fox
622319a742 Fix EditInlineNew property editor class picker not closing when class is picked by reverting the change 24927105
#rb ben.hoffman
#preflight skip

[CL 25413723 by benjamin fox in ue5-main branch]
2023-05-10 15:21:42 -04:00
aditya ravichandran
2fdc7aced1 Make the property matrix respect the property editor permission list
#jira UE-181931
#rb chris.gagnon, rex.hill
#preflight 6452d8ef0722d4f6a20b02e7

[CL 25373170 by aditya ravichandran in ue5-main branch]
2023-05-08 13:35:18 -04:00
robb surridge
5c1cee7880 Update tooltips for property editor combo boxes when the properties are reset to default.
#jira UE-182217
#rb karen.jirak
#preflight 64555400ed7ffaa0f5d3bbf0

[CL 25373079 by robb surridge in ue5-main branch]
2023-05-08 13:32:58 -04:00
mikko mononen
410e700e79 Added EnsureDataIsValid() for structure property node
- Extended  the EnsureDataIsValid() to

#preflight 645356cbd863ba2621614cca

[CL 25331981 by mikko mononen in ue5-main branch]
2023-05-04 04:47:23 -04:00
jamie dale
1219471e56 Added support for overriding enum value display names on a per-property basis
This can be specified by the EnumValueDisplayNameOverrides meta-data, and is a semi-colon separated list of Name=DisplayName pairs where the DisplayName can be a raw string or a NS/LOCTEXT style localized value.

#preflight 64525920d863ba2621179ac2
#rb Rex.Hill

[CL 25323006 by jamie dale in ue5-main branch]
2023-05-03 15:27:50 -04:00
Cody Albert
cee7b7fad5 Added OpenComboBox function to SObjectPropertyEntryBox widget
#rb Karen.Jirak
#preflight 64529d60634f5d9cd47d9fcd

[CL 25320956 by Cody Albert in ue5-main branch]
2023-05-03 14:04:45 -04:00
tom noonan
3a2ffb4b70 Fix for instances of verse classes inserted into an array through the editor not getting correctly initialized. Very similar to the 'add element' fix made in CL21322034
[REVIEW] [at]michael.nicolella
#preflight 645235150722d4f6a2d6d2b2

[CL 25319276 by tom noonan in ue5-main branch]
2023-05-03 12:48:31 -04:00
robb surridge
7ef85949aa Disable the Copy Display Name menu option in the Details panel when the property has no display name that can be copied.
#jira UE-184850
#rb aditya.ravichandran
#preflight 6451389d4d593c0b42adc7b5

[CL 25309507 by robb surridge in ue5-main branch]
2023-05-02 18:18:07 -04:00
yohann dossantos
8cb2e71dea - Fixed drag n drop issue with rows having expanded items.
=> code from CL 17423372 was disabling it explicitely, but I couldn't find any reason or have any repro. The comment talk about disabling between an item and its child, while with a EItemDropZone::BelowItem, it correspond to the bottom part of an item, and not the bottom item, so having the child item expanded or not won't change the drag n drop behavior.
- Fixed drag n drop issue for Input Mapping Context, where drag n dropping could give deterministic but incorrect result when more than 1 mapping exists for a group.
=> the reordering algorithm used requires that the content of the array is ordered by group, while it was not necessarily the case. Starting from this CL, it will (slower but safer algorithm).
- Prevent the drag n drop for Input Mapping Context between rows that are not part of the same parent node.


Tests:
-opened various Input Mapping Context from QA Game, like /Maps/Framework/EnhancedInput/EI_HelperAssets/Controls_3rdPerson/IMC_3rdPerson_Controls.uasset, that was failing 100% on some actions. Drag n dropped groups (collapsed or expanded), even on the last one, and on individual entries with 100% success. Did a lot of drag n drop test (between close elements, first and last, last and first, first and middle,...)
-tried to drag n drop across entries from different parent => it was blocked as expected.
-undo/redo after those operations.
-used drag n drop in other contexts (media play list, data table), no regression noticed when drag n dropping elements.

#jira UE-157906
#rb nate.strohmyer, karen.jirak
#preflight 644fd08e1c2846595c454ffa

[CL 25284259 by yohann dossantos in ue5-main branch]
2023-05-01 11:11:21 -04:00
Michael Galetzka
0947e3f4d0 Fixed a bug where the details view would not properly show rows with changed visibility after a tree refresh
#jira none
#rb karen.jirak
#preflight 6446934027014596f3709a8f

[CL 25230338 by Michael Galetzka in ue5-main branch]
2023-04-28 07:02:52 -04:00
jordan hoffmann
ac0ef9c038 [BugFix] No clear way to unhiglight a property
CL 22279933 introduced a regression to SDetailsViewBase::HighlightProperty that made it impossible to unhighlight properties.
udn: https://epicgames.lightning.force.com/lightning/r/Case/5004z00001nziOiAAI/view

#jira none
#rb none
#preflight trivial

[CL 25222768 by jordan hoffmann in ue5-main branch]
2023-04-27 16:15:13 -04:00
mikko mononen
03afbfd05a Improved standalone structure property node handling
- Added IStructureProvider which allows to edit multiple instances of structs at a time
- Improved default value handling in standalone structure nodes
- Fixed bug where expanded nodes did not retain their expansion state when structure nodes were rebuild (e.g. when editing a component)
- Removed caching from Instanced struct customization

#jira UE-172047
#rb Jamie.Dale, Adrien.Logut
#preflight 644a48360f12404fb77173f6

[CL 25214019 by mikko mononen in ue5-main branch]
2023-04-27 10:06:33 -04:00
jordan hoffmann
b017402ae1 [Bug Fix] Map element properties were being handled incorrectly causing garbage memory reads
#rb dan.oconnor, steve.robb
#preflight 644983360f12404fb72d120a

[CL 25208645 by jordan hoffmann in ue5-main branch]
2023-04-26 18:28:53 -04:00
jordan hoffmann
43721a4e90 [CrashFix] Crash when reviewing CL 25127136 when comparing property map keys
#rb dan.oconnor
#preflag 6441dbed0206a6e20fe227b0

[CL 25150885 by jordan hoffmann in ue5-main branch]
2023-04-21 14:54:50 -04:00