Don't mark the package as dirty when doing fixup from code in PostInitProperties.
Make UpdateMaterialExpressionGuid calls consistent with the UpdateParameterGuid calls.
Fixes non-determinism in cooked asset registries since the runtime asset registry skips update on load for dirty packages.
Fixes issue with ResavePackages -OnlySaveDirtyPackages that will save the same package over and over again.
[FYI] daniel.wright
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: pj.kack
#ROBOMERGE-SOURCE: CL 6457287 via CL 6468554 via CL 6468779
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6516363 by pj kack in Dev-VR branch]
Live++ reads object files at startup for game modules, and assigns unique ids to each compiland (used to disambiguate static variables). When compiling the patch, these compilands are modified to reference a unique id for the unity blob, causing the variables to be reconstructed.
Solution is to generate a JSON file to each output directory containing object files containing the mapping, and to use that to assign compiland ids at startup.
#rb none
#jira UE-74036
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 6455253 in //UE4/Release-4.22/... via CL 6455273
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6512984 by ben marsh in Dev-VR branch]
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: michael.trepka
#ROBOMERGE-SOURCE: CL 6451674 via CL 6451677 via CL 6452836 via CL 6452921
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6511495 by michael trepka in Dev-VR branch]
- Not require content to be checked in to use
- New cvar to toggle enabling binaural spat on all sources (where available) so we can set in project and/or live
#rb Ethan.Geller
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 6451618 via CL 6452819 via CL 6452902
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6511192 by aaron mcleran in Dev-VR branch]
Results:
ULevel::PreSave down from ~18.5 seconds to ~0.5 seconds (VTune user-mode sampling cpu time) on a full cook saving ~183 000 packages.
[FYI] marc.audy,daniel.wright
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: pj.kack
#ROBOMERGE-SOURCE: CL 6451300 via CL 6452098 via CL 6452223
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6510665 by pj kack in Dev-VR branch]
Removed global locks when logging through FOutputDeviceRedirector to avoid hangs when logging crashes.
+ ~10% Logging performance increase (tested by multiple attempts at logging 1M lines of text):
before: 365984ms (min)
after: 324901ms (max)
#rb none
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 6451256 via CL 6451902 via CL 6452038
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6510630 by robert manuszewski in Dev-VR branch]