Commit Graph

13931 Commits

Author SHA1 Message Date
devin doucette
8e1e6dea73 DDC: Added cancellation support to FHttpCacheStoreRequestQueue
#rb Steve.Robb
#rnx

[CL 28413356 by devin doucette in ue5-main branch]
2023-10-03 10:23:20 -04:00
dan thompson
8c011f8fde Pack the plugin jsons in to one file to avoid nuking network file protocols.
#rb fabian.giesen

[CL 28396458 by dan thompson in ue5-main branch]
2023-10-02 17:34:41 -04:00
jamie hayes
bdeb6ed96b Add a check to the mesh simplifier to avoid collapsing an edge if it is shared by all triangles, thus causing all triangles in the cluster to be degenerate
This fixes asserts that have been seen in the wild.

NOTE: This is a resubmission, with an additional fix to an assert the original change inadvertently caused.

#rb brian.karis
#jira UE-193405

[CL 28391367 by jamie hayes in ue5-main branch]
2023-10-02 15:58:57 -04:00
joe kirchoff
73351e628e UnrealBuildTool: Remove VS2019 as a supported source code access ide
#jira UE-190039

[CL 28384888 by joe kirchoff in ue5-main branch]
2023-10-02 13:37:03 -04:00
rafa lecina
92ff150bd2 Improve logs for LowLeveltests by including captured/scoped info data when assertions are triggered
#jira UE-192858
[REVIEW] [at]Stephen.Ma, [at]Chris.Constantinescu, [at]Michael.Kirzinger

[CL 28378083 by rafa lecina in ue5-main branch]
2023-10-02 10:51:26 -04:00
mattias hornlund
f80497cf74 Network insights
- Fixed aggregate display in PacketView

#rb Peter.Engstrom

[CL 28374863 by mattias hornlund in ue5-main branch]
2023-10-02 09:13:14 -04:00
christopher waters
c1487a0042 Adding typedef support to ShaderMinifier.
- Before this, every typedef and the code using them was being included in the final source.
- This was primarily affecting Bindless Resources where all bindless resources were included in the minified code even if they weren't used.

#rb yuriy.odonnell

[CL 28365749 by christopher waters in ue5-main branch]
2023-09-30 11:10:06 -04:00
jamie hayes
a05a20507c [Backout] - CL28327793
[FYI] jamie.hayes
Original CL Desc
-----------------------------------------------------------------
Add a check to the mesh simplifier to avoid collapsing an edge if it is shared by all triangles, thus causing all triangles in the cluster to be degenerate.
This fixes asserts that have been seen in the wild.

#rb brian.karis
#jira UE-193405

[CL 28359965 by jamie hayes in ue5-main branch]
2023-09-29 18:55:04 -04:00
zousar shaker
2a2910744f Downgrade messages from ZenCacheStore from Warning to Display as they can be expected to come up due to network conditions or temporary outages and do not break functionality.
#rb devin.doucette

[CL 28357691 by zousar shaker in ue5-main branch]
2023-09-29 17:36:33 -04:00
ionut matasaru
ed269bdc8e Another fix for "implicit conversion" errors in Profiler module.
#rnx

[CL 28346949 by ionut matasaru in ue5-main branch]
2023-09-29 13:14:54 -04:00
steve robb
a84e22104b Replaced GET_VARARGS* macros with GET_TYPED_VARARGS*.
#rb james.hopkin
#jira UE-194628

[CL 28346416 by steve robb in ue5-main branch]
2023-09-29 13:00:07 -04:00
ionut matasaru
d5f2f2ae8b Fixed more "implicit conversion" errors in Profiler module.
#rnx

[CL 28346117 by ionut matasaru in ue5-main branch]
2023-09-29 12:53:57 -04:00
ionut matasaru
f779325956 Fixed "implicit conversion" errors in Profiler module.
#rnx

[CL 28343869 by ionut matasaru in ue5-main branch]
2023-09-29 11:36:18 -04:00
ionut matasaru
b2fbebf9b7 Enabled UnsafeTypeCast warnings as errors in Profiler, ProfilerClient, PerfCounters modules.
#rb Catalin.Dragoiu

[CL 28342235 by ionut matasaru in ue5-main branch]
2023-09-29 10:32:44 -04:00
ionut matasaru
119dbc1a08 Enabled UnsafeTypeCast warnings as errors in Trace/Insights related modules (UnrealInsights, TraceAnalysis, TraceServices, TraceDataFiltering, TraceUtilities, EditorTraceUtilities).
Fixed conversion warnings in TraceAnalysis and in TraceServices modules.

#rb Catalin.Dragoiu

[CL 28339045 by ionut matasaru in ue5-main branch]
2023-09-29 07:22:52 -04:00
keith yerex
1391e09639 Enable visual logger rewind debugger integration
#rb Samuele.Rigamonti

[CL 28330456 by keith yerex in ue5-main branch]
2023-09-28 17:58:11 -04:00
jamie hayes
e967254bcf Add a check to the mesh simplifier to avoid collapsing an edge if it is shared by all triangles, thus causing all triangles in the cluster to be degenerate.
This fixes asserts that have been seen in the wild.

#rb brian.karis
#jira UE-193405

[CL 28327825 by jamie hayes in ue5-main branch]
2023-09-28 16:30:49 -04:00
ionut matasaru
1c1a00ca7c Enabled UnsafeTypeCast warnings as errors in the TraceInsights module.
Fixed conversion warnings.

#rb Catalin.Dragoiu

[CL 28314550 by ionut matasaru in ue5-main branch]
2023-09-28 08:01:12 -04:00
ionut matasaru
afcb88a1fc [Insights] Fixed trimming of 64bit numbers to 32bit when displayed as hex (i.e. %x was used instead of %llx for uint64 numbers). This includes truncation of address displayed in Memory Insights when callstack resolving is not completed.
#rb Catalin.Dragoiu
[FYI] Martins.Mozeiko

[CL 28314477 by ionut matasaru in ue5-main branch]
2023-09-28 07:58:19 -04:00
jason hoerner
6f67025ccc Shader Compiler: Optimized version of CleanupUniformBufferCode, called during preprocessing. New version is 3.8x faster, producing a 19% overall speedup in ConditionalPreprocessShader. Processes the shader in a single pass, scanning for potential compound identifiers (symbol tokens connected by dots and optional whitespace), then checking if they match known uniform buffer members. A few optimizations improve the speed of checking if an identifier matches, including an early out based on identifier length and start character, followed by organizing uniform buffers and their members by length, requiring only a small subset of members to be tested. Parsing uniform buffer definitions was also optimized to avoid memory allocation.
Doesn't produce bit identical preprocessed output, as it compacts whitespace from compound identifiers before testing them, whereas the original implementation compacts whitespace after matching.  Compacting first makes testing more efficient and simpler, since it doesn't need to take into account whitespace.  For A/B validation, I did add temporary debug code that stored and reverted un-matched identifiers, mimicking the old behavior, and it was identical across the board.

#rnx
#rb dan.elksnitis chris.waters jason.nadro

[CL 28313553 by jason hoerner in ue5-main branch]
2023-09-28 07:08:47 -04:00
christopher waters
cf3272d4e6 Bumping the SM6 version to force all D3D RT shaders to rebuild.
#jira UE-196567

[CL 28313514 by christopher waters in ue5-main branch]
2023-09-28 07:08:10 -04:00
chris constantinescu
1aeb7faa75 LLT: Pre-analyse dependency graph of low level test targets before setting compilation flags for UE components
Use -Mode=Test by default for all LLT Project to enable pre-analysis of dependency graph.
#jira UE-193632
#rb Sean.Sweeney

[CL 28313218 by chris constantinescu in ue5-main branch]
2023-09-28 06:52:15 -04:00
DuncanRare
0b2cf01d8a Adding flag to toggle whether or not garbage collection should be delayed, by default they are. Added property to show in the Editor Details panel for the Functional Test in the Advanced section.
PR # 10898
#commit 10898
#jira UE-195842

[CL 28294665 by DuncanRare in ue5-main branch]
2023-09-27 17:26:59 -04:00
derek truong
c137ace85e Fixing missing header guard in DialogUtils header file (added in CL 28276965)
#rnx

[CL 28290380 by derek truong in ue5-main branch]
2023-09-27 16:23:37 -04:00
nick edwards
220ccc4b3e FIoDirectoryIndexReader::IterateDirectoryIndex: Use FStringViews and TStringBuilders instead of FStrings to avoid potentially unnecessary heap allocations
FPakPlatformFile::ForeachPackageInIostoreWhile: Update usage of IterateDirectoryIndex, and use overload of TryConvertFilenameToLongPackageName using string views and builders to avoid allocations

#rb elias.lozadabenavent
#rb anton.dunchev

[CL 28282945 by nick edwards in ue5-main branch]
2023-09-27 14:10:02 -04:00