Commit Graph

297 Commits

Author SHA1 Message Date
patrick enfedaque
6d2522df6a WorldPartition: Make sure LastLoadedRegion FBox are valid
- Fixes new Empty Open World saving a invalid LastLoadedRegion
- Spatial loader adapters created with invalid bounds will not load any actors and ensure on creation

#rb jeanfrancois.dube
#rnx

[CL 25926702 by patrick enfedaque in ue5-main branch]
2023-06-12 08:28:46 -04:00
jeanfrancois dube
09aeb755d4 World Partition HLODs:
- Convert HLODLayer.ParentLayer to an object reference instead of a soft object pointer.
- Detect circular HLOD layer parent references now that the entire parent chain is loaded.
- Initial per runtime partition HLODs layer setup for RuntimeHashSet: detect HLOD layer setup changes and update internal partition layers.

#rb sebastien.lussier

[CL 25841413 by jeanfrancois dube in ue5-main branch]
2023-06-07 07:18:47 -04:00
scott nelson
15371dad4c Fix entity delete and right click save on level assets not generating UEFN Playsets
#rb Dave.Belanger
#preflight 6441bc6f641e2c3cb462a5bf

[CL 25175438 by scott nelson in ue5-main branch]
2023-04-24 23:20:03 -04:00
mark lintott
e63c334048 EpicStudioAnalytics plugin rewrite
High Level Vision:
https://docs.google.com/document/d/13R4nJ2UNMJZlf6JCjYssFMSY-5CrURazE4tqxW77yBw/edit#heading=h.bpycydduomgi

Details of changes:
Removed "most" references to FStudioAnalytics from Engine code.
Deprecated use of FStudioAnalytics::FireEvent_Loading(), will deprecate FStudioAnalytics in due course.
Added FAnalyticsFlowTracker to the engine code base based on the flow system used in UEFN.
Added explicit DDC Resource and DDC Summary events to track DDC usage by resource type.
Moved common Editor analytics callbacks into EpicStudioAnalytics plugin
Added a variety of delegates to the engine code to so that analytics capture can be defined in the plugin code or within the game code instead of the engine code ( eg. load map, editor initialization, cooking, slow task )
Added JSON serializer for analytics events to provide facility to capture analytics in restriced environments ( eg. UEFN CookWorker ). Though this fetaure is not enabled yet.
This will temporarily break Loading and Cooking analytics for Lyra, ShooterGame, CitySample but not Fortnite or UEFN. The remainder will need to be "fixed up" in UE5/Main once the changes have propogated (stakeholders have been notified)

[FYI] zousar.shaker, devin.doucette, eric.knapik, francis.hurteau
#rb wes.hunt
#preflight 643e45150a5a4b944e603be8

[CL 25083739 by mark lintott in ue5-main branch]
2023-04-18 07:16:36 -04:00
jamie dale
933348f856 Use the FMessageDialog overloads that pass the optional title by-value
#jira
#rb none
#rnx

[CL 25062589 by jamie dale in ue5-main branch]
2023-04-15 19:49:32 -04:00
richard malo
ca4979c65c Don't call ResetLoaders on newly created world packages as this will prevent future loading of external actor packages to work propertly
#jira UE-180635
#rb patrick.enfedaque, jeanfrancois.dube
#preflight 641b295bec01de16643ca8c8

[CL 24756459 by richard malo in ue5-main branch]
2023-03-22 19:45:05 -04:00
patrick enfedaque
caa09df09a Fix Regression causing SaveWorld to always save external actors without checking dirty flag (24511115)
#rb rex.hill, jeanfrancois.dube
[FYI] jamie.dale
#preflight skip

[CL 24663456 by patrick enfedaque in ue5-main branch]
2023-03-15 18:02:13 -04:00
wouter burgers
e2faaadb58 SourceControl: Removed the status update queueing for files that have been made writable as it's causing random crashes and without a solid repro rolling back the change is the way to go for now.
[FYI] manuel.lang, brooke.hubert

[CL 24589513 by wouter burgers in ue5-main branch]
2023-03-10 06:22:56 -05:00
wouter burgers
7ce11d6cde Undo changelist 24537190.
[FYI] manuel.lang
#preflight none

[CL 24543547 by wouter burgers in ue5-main branch]
2023-03-07 12:59:47 -05:00
wouter burgers
e32e11ee55 SourceControl: Replaced 'external' string checks with actual checks.
#preflight none

[CL 24537466 by wouter burgers in ue5-main branch]
2023-03-07 04:59:00 -05:00
jamie dale
efe22536c5 Save the main map before any external actors in SaveMap
This updates SaveMap to use the same order as SaveCurrentLevel, which seems to address some issues where external actors could be left with invalid references after copying a map (and its actors) via advanced copy.

#preflight 640216d9a726961ed9bdf678

[CL 24511952 by jamie dale in ue5-main branch]
2023-03-03 20:48:37 -05:00
wouter burgers
3e41f75007 SourceControl: Fixed crash LongPackageNameToFilename failed to convert ''.
The `QueueStatusUpdate` call happened after a possible `RevertAndReloadPackages` call, which could have invalidated the raw UPackage pointers.

#preflight none

[CL 24499775 by wouter burgers in ue5-main branch]
2023-03-03 11:24:56 -05:00
jared cotton
84a5ebded4 SOL-4203 - User can load a project with Validaiton errors without being forced to accept risk of data-loss first
FORT-570648 - Closing the 'compile errors' dialog leaves you unable to interact with editor

Editor team related changes:
- added 'OnPreMapOpen' delegate to Editor.h, used in FEditorFileUtils::LoadMap to trigger a build check if it is bound. If it returns false we don't open the map

Validation changes:
- Moved build errors check to trigger on 'OnMapLoad' instead of just on project open as this consolidates validation code into the same module and is more reliable (We want to validate devices as close to when they are loaded into memory and offer users a chance to fix)
- Added dialog for validation triggered by 'OnMapLoad' which offers user option to recompile which now fixes issues and is faster than the previous option of reloading the entire project.

- If either dialog chooses to 'cancel' the map is not loaded. The project is opened and the user can attempt to open the level/map again after fixing errors. This seems better than the previous behaviour of closing the project and being forced back to the project open menu.

Minor Changes:
- All related dialog's had their 'close' buttons removed
- This fixes error reported by Phillip Kavan in which a cached 'last successful open' of a project lead to skipping these warning dialogs

#rnx
#rb yiliang.siew
#rb dave.belanger
#rb rex.hill
#rb conan.reis
[FYI] marcus.wassmer
#preflight 63fffd80f43e53f681756e99

[CL 24486810 by jared cotton in ue5-main branch]
2023-03-02 14:05:15 -05:00
jeanfrancois dube
ab1d13f9ff FEditorFileUtils::IsMapPackageAsset will now return true for external actor packages in plugin mount points.
#rb richard.malo
#preflight none

[CL 24469529 by jeanfrancois dube in ue5-main branch]
2023-03-01 15:43:31 -05:00
wouter burgers
9fec4988d5 SourceControl: Fixed 'rename' operation (and possibly others) still showing the 'Checkout Dialog' which should no longer be used in 'automatic checkout flow'. See #24299010 for original changelist.
[REVIEW]
#preflight none

[CL 24404820 by wouter burgers in ue5-main branch]
2023-02-24 13:42:19 -05:00
wouter burgers
832ac04e5a SourceControl: Writable (modified) file status is not automatically updated in the Revision Control column (Outliner).
If the packages were made writable, instead of FCheckOut, the SourceControlStateChanged event is not broadcasted because the SourceControlProvider was never involved. After saving to disk though, the files have become modified which will be picked up by SourceControl providers like Git or Skein if an FUpdateStatus is performed on them, even if SourceControl is offline (Skein stores the original hashes in a local database, Git does probably something similar).

#preflight none

[CL 24335892 by wouter burgers in ue5-main branch]
2023-02-21 04:00:18 -05:00
wouter burgers
1df368c74c SourceControl: Fixed text conflict from NSLOCTEXT macro.
[FYI] manuel.lang
#preflight none

[CL 24307573 by wouter burgers in ue5-main branch]
2023-02-19 11:21:47 -05:00
wouter burgers
ea73facd46 SourceControl / Skein: Automatically attempt to check out files when a save occurs and provide the user a relevant error in the case of a conflict.
#preflight 63f0d573e832ea950adc2afa

[CL 24299166 by wouter burgers in ue5-main branch]
2023-02-18 10:44:55 -05:00
scott nelson
b825a0d05c Update FileHelpers PrepareWorldsForExplicitSave to occur after final save list has been confirmed
#rb Dave.Belanger, Rex.Hill
#preflight 63ea83b896073a3e1969a1a3

[CL 24200230 by scott nelson in ue5-main branch]
2023-02-13 21:22:44 -05:00
alexis matte
a20c1131ce Change asset tools import extension support to FNamePermissionList instead of FString. This allow to control the permissions like all the other permission.
#rb jeanluc.corenthin
#preflight 63e24fad07207b2570b72285

[CL 24049361 by alexis matte in ue5-main branch]
2023-02-07 10:49:14 -05:00
Robb Surridge
1fa137e9cc Improve the notification when a save is requested but no files need to be saved.
#jira none
#rb aditya.ravichandran
#preflight 63dd2e7c4d25c400b7b7d813

[CL 23991318 by Robb Surridge in ue5-main branch]
2023-02-03 11:14:25 -05:00
alexis matte
b93fee971d Create a system to control which extension importer should support.
#rb jeanluc.corenthin
#rnx
#preflight 63d7eb4cba4fadeef006c7d7

[CL 23923306 by alexis matte in ue5-main branch]
2023-01-31 01:12:25 -05:00
scott nelson
1cc68bf860 Add PrepareWorldsForExplicitSave Flow
#rb Dave.Belanger, Rex.Hill
#preflight 63cf03d7976daa618c322013

[CL 23825473 by scott nelson in ue5-main branch]
2023-01-23 20:03:18 -05:00
jeanfrancois dube
c2a91ca73d Fix wrong IsValidChecked usage.
#rb none
#preflight none

[CL 23734962 by jeanfrancois dube in ue5-main branch]
2023-01-16 22:01:48 -05:00
mark lintott
8bad2c0365 Removed the callback system from core Analytics system. Fixed up analytics gathering in DerivedDataCache, Virtualization and HttpCacheStore
#rb wes.hunt
#preflight 63be95bd68068a8bd6a4438e

[CL 23651011 by mark lintott in ue5-main branch]
2023-01-11 14:28:01 -05:00