Remove CreateIfNotFound parameter to FConfigCacheIni::Find.
This was creating thousands of fstat calls peeking for the existence of Saved/Config/WindowsEditor/GameplayTagsEditorState.ini when opening the Project Settings dialog. This we make frequent calls (in a recursive manner) into the config system, but no file or config is created (where false is passed), and we keep statting it thousands of times
Callers that pass false for this fail to land on any config properties because they don't exist to begin with.
Callers that pass true for this still basically get what they want. Since we did not stub the file out upon Find(), there is no disk state difference between Find() and config system shutdown (where dirty config files are saved to disk). So saving is still manual, and there is no implication from
CreateIfNotFound communicated to the FConfigFile about whether it is meant to be saved or not. So by and large this semantic is meaningless except with the existence of the new config file of the config file map (which creates the optimization of skipping the subsequent stats).
SSettingsEditor::ReloadCategories before: 2290ms
SSettingsEditor::ReloadCategories after: 1669ms
Tested with a BuildCookRun of ShooterGame, and running with it in Editor for a few days.
#jira UE-95853
[CL 14258235 by geoff evans in ue5-main branch]
#rb none
#rnx
#ROBOMERGE-SOURCE: CL 13075320 via CL 13075326 via CL 13075328
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v686-13045012)
[CL 13075331 by rob gay in Main branch]
#jira UE-91899 UE-91896
#rb none
#rnx
#ROBOMERGE-SOURCE: CL 12758606 via CL 12758850 via CL 12758997
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v678-12743200)
[CL 12759070 by rob gay in Main branch]
- Add classes to allow modulation of effect parameters
- Remove cruft from first attempt at adding generic modulators
Minor-ish:
- Clean-up headers
- Rename AudioModulationImpl --> AudioModulationSystem
- Remove dead generic code
#rb jimmy.smith
#ROBOMERGE-SOURCE: CL 12732445 via CL 12732449 via CL 12732451
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v676-12543919)
[CL 12732457 by rob gay in Main branch]
Fixing FModulatorBusMixChannelProxy not being marked as friend of FAudioModulationImpl in shipped builds
#jira UE-90145
#rnx
#rb none
[CL 11942822 by Rob Gay in 4.25 branch]
Fix Mod mixes not reactivating correctly due to original channel settings not being passed when calling 'SetEnabled' on mix. Fixed by moving 'Init' logic to SetEnabled and making public for AudioModulationImpl to call when reactivating a stopping mix.
- Pass modulation implementation to proxies to ensure version in charge of creation is that used for initialization/modification where necessary
- Fix leak and make ref counting safer on modulation proxies by moving inc/dec ref out of factory creaters/getters
#review-11849604
#rb ethan.geller aaron.mcleran
#jira UE-90145 UE-89911
#rnx
[CL 11941082 by Rob Gay in 4.25 branch]
