Commit Graph

727 Commits

Author SHA1 Message Date
steve robb
fd2a0b1e20 Removal of TEXT literal concatenations, which doesn't work in UTF-8 mode.
#rb devin.doucette
#jira UE-132142
#preflight 62a8748fa76c84377748036b

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20647443 via CL 20648283 via CL 20648315
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20651786 by steve robb in ue5-main branch]
2022-06-14 12:46:34 -04:00
jordan cristiano
be7e5f467c Auto enable "stat namedevents" when a razor or trace capture is in progress.
Functionality is controlled by stats.AutoEnableNamedEventsWhenProfiling, default disabled in engine. Enabled in fort.

#rb evgenii.babinets, andrew.ladenberger
[FYI] will.fissler, ethan.edwards, ben.woodhouse

#ROBOMERGE-OWNER: jordan.cristiano
#ROBOMERGE-AUTHOR: jordan.cristiano
#ROBOMERGE-SOURCE: CL 20460932 via CL 20460963 via CL 20461526 via CL 20461540
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20463233 by jordan cristiano in ue5-main branch]
2022-06-01 20:37:17 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
ben woodhouse
4e7b5d80ff Use the local player to exec csvexeccmds if available, falling back to GEngine->Exec if we don't have one. This allows us to execute commands which require a player, such as HideHUDElement
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 20429825 via CL 20429839 via CL 20429846
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20430257 by ben woodhouse in ue5-main branch]
2022-05-30 08:36:08 -04:00
devin doucette
b2a07ea03e DDC: Merge from UE5/Main
#preflight 6288ff678828ea88c8af7034
#preflight 628ab5d93246d5019db76ed2
#rb none
#rnx

#ROBOMERGE-OWNER: devin.doucette
#ROBOMERGE-AUTHOR: Devin.Doucette
#ROBOMERGE-SOURCE: CL 20353148 via CL 20353832 via CL 20353839
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20355348 by devin doucette in ue5-main branch]
2022-05-24 16:40:25 -04:00
ionut matasaru
7a9c217ab6 Improved scoped cpu timers for FEngineLoop (add cpu timers for FEngineLoop::Tick, HeartBeat, TickHotfixables and TickRenderingTickables). Also added a scoped cpu timer for FStats::AdvanceFrame.
#rb Johan.Berg
#preflight 62874a80c057ee6e23f18437

[CL 20292398 by ionut matasaru in ue5-main branch]
2022-05-20 06:11:55 -04:00
Devin Doucette
3045e3c75f Logging: Changed CanBeUsedOnPanicThread() to return false by default
The previous default of CanBeUsedOnAnyThread() proved unsafe since some output devices can safely be used on any thread but cannot safely be used during a crash. CanBeUsedOnAnyThread() was used pre-5.1 to control serialization to an output device during a crash, but optimizations in 5.1 have uncovered that some of these were never safe.

#preflight 62856506614041edb7a6de4b
#rb Zousar.Shaker
#rnx

[CL 20280354 by Devin Doucette in ue5-main branch]
2022-05-19 10:39:18 -04:00
paul chipchase
324c190691 Make sure that the virtualization system is shutdown before the modules are shutdown or we might end up with dangling pointers
#rb trivial
#rnx
#preflight 628604997a2503cd8987f0ab

- Originally I was trying to add a notification from the default virtualization module to inform the system when it's module was being torn down and invoke the shutdown at that point, but we end up with a lot of dependencies.
- Since initialization is hard coded into the engine loop we might as well hard code the shutdown as well.

[CL 20277529 by paul chipchase in ue5-main branch]
2022-05-19 05:06:26 -04:00
david harvey
0e5d779438 Added a new query to determine whether the install bundle manager can handle early startup patching.
- will eventually be replaced with a better system

#jira UE-146398
#rb Justin.Marcus
#rnx

#ROBOMERGE-AUTHOR: david.harvey
#ROBOMERGE-SOURCE: CL 20258363 via CL 20258366 via CL 20258372
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20262878 by david harvey in ue5-main branch]
2022-05-18 12:51:35 -04:00
Josh Adams
c2b6817353 - Cleaned up old FConfigCacheIni stuff and new FConfigContext, getting rid of duplicated functions, and moving some stuff into FConfigContext and the new UE::ConfigUtilities namespace
- Deprecated some global functions now in ConfigUtilities
- Deleted a couple of old deprecated stuff from 3.24

#rb chris.waters
#preflight 628415e1ba3597a030b3b900

[CL 20259749 by Josh Adams in ue5-main branch]
2022-05-18 08:59:31 -04:00
evgenii babinets
1bf9d7bb91 Unifying how we modify GCycleStatsShouldEmitNamedEvents so that we guarantee it won't drop below zero (should never happen, but just in case so that we can change checks to be != 0).
#rb jordan.cristiano

#ROBOMERGE-AUTHOR: evgenii.babinets
#ROBOMERGE-SOURCE: CL 20190641 via CL 20190656 via CL 20190671
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20192726 by evgenii babinets in ue5-main branch]
2022-05-13 20:46:55 -04:00
michael sartain
020de0221b Only make minimal RHICmdList Begin/EndFrame calls in Begin/EndFrameRenderThread when can't render
#rnx
#rb Arciel.Rekman, Brandon.Schaefer
[FYI] Ilya.Loshchinin
#preflight trivial

#ROBOMERGE-AUTHOR: michael.sartain
#ROBOMERGE-SOURCE: CL 20074267 via CL 20074270 via CL 20074271
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20105933 by michael sartain in ue5-main branch]
2022-05-09 13:37:45 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
brian bekich
a9ae3c74e2 Restoring previous fix, now with more compiling:
Fixes for tick.DoAsyncEndOfFrameTasks.ValidateReplicatedProperties
DiffProperties skips empty layouts
FGuidReferences copy constructor to deep copy container references, needed by FFastArraySerializer properties using delta structs
Update the validation to occur around the slate tick and not during the async recording

#jira UE-142550
#rb ryan.gerleve

#ROBOMERGE-AUTHOR: brian.bekich
#ROBOMERGE-SOURCE: CL 19843364 via CL 19843433 via CL 19852406 via CL 19861535 via CL 19861613
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19870884 by brian bekich in ue5-main branch]
2022-04-22 15:50:49 -04:00
brian bekich
68c8e0a0c9 [Backout] - CL19838285
#jira UE-142550

#ROBOMERGE-OWNER: brian.bekich
#ROBOMERGE-AUTHOR: brian.bekich
#ROBOMERGE-SOURCE: CL 19839033 via CL 19839388 via CL 19843762 via CL 19859314 via CL 19859320
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19869382 by brian bekich in ue5-main branch]
2022-04-22 14:57:35 -04:00
brian bekich
c621085f8c Fixes for tick.DoAsyncEndOfFrameTasks.ValidateReplicatedProperties
- DiffProperties skips empty layouts
- FGuidReferences copy constructor to deep copy container references, needed by FFastArraySerializer properties using delta structs
- Update the validation to occur around the slate tick and not during the async recording

#jira UE-142550
#rb ryan.gerleve

#ROBOMERGE-OWNER: brian.bekich
#ROBOMERGE-AUTHOR: brian.bekich
#ROBOMERGE-SOURCE: CL 19838285 via CL 19838713 via CL 19843726 via CL 19859239 via CL 19859288
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19869366 by brian bekich in ue5-main branch]
2022-04-22 14:57:06 -04:00
Matt Peters
eabebce9c9 Remove accidentally submitted PRAGMA_DISABLE_OPTIMIZATION.
#rb None, trivial
#rnx
#preflight None, trivial

[CL 19726608 by Matt Peters in ue5-main branch]
2022-04-12 15:16:06 -04:00
Matt Peters
6457300943 LaunchEngineLoop: Move PRIVATE_GIsRunningCookCommandlet assignment earlier so that UE::AssetDataGather::Private::FPreloader can use it early on to start preloading.
Reduce duplication in LaunchEngineLoop of the assignment of the related variable PRIVATE_GIsRunningCommandlet, so that it is easier to verify that PRIVATE_GIsRunningCookCommandlet is set correctly.
#rb Josh.Adams
#rnx
#preflight 62559088cd5ed4dd0916725f

[CL 19721177 by Matt Peters in ue5-main branch]
2022-04-12 10:51:35 -04:00
serge bernier
cd78edb64a Fix InputLatency csv stats on some consoles. On certain platforms, cycle is 32 bits and gets shifted to avoid precision loss. If stats is using the 64 bits version, all other conversions must use the 64 bits version.
#rb mickael.gilabert

#ROBOMERGE-OWNER: serge.bernier
#ROBOMERGE-AUTHOR: serge.bernier
#ROBOMERGE-SOURCE: CL 19691434 via CL 19691454 via CL 19691529 via CL 19691544
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19694117 by serge bernier in ue5-main branch]
2022-04-08 16:27:51 -04:00
bob tellez
261cdbb217 [Backout] - CL19513265. No needed in modern UE5 code
[FYI] bob.tellez
Original CL Desc
-----------------------------------------------------------------
#UE Fix missing module in commandlets when loading assets referencing WorldPartitionHLODUtilities. This is fixed in a different way in UE5Main, so this is just a temp fix until we get newer code


#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 19513128 via CL 19564226 via CL 19564252
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19566409 by bob tellez in ue5-main branch]
2022-03-30 19:03:23 -04:00
bob tellez
6f72ad8202 #UE Fix missing module in commandlets when loading assets referencing WorldPartitionHLODUtilities. This is fixed in a different way in UE5Main, so this is just a temp fix until we get newer code
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 19513128 via CL 19513265 via CL 19513451
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19515868 by bob tellez in ue5-main branch]
2022-03-25 13:47:34 -04:00
PJ Kack
68e874156f LaunchEngineLoop: Fix deadlock on exit when launching the game or editor with the parameter -testexit=ExitPhrase.
Request a deferred engine shutdown instead of forcing it from the logging code which will deadlock on most or all platforms.
-testexit is used when BuildCookRun is launched with both -run and -unattended.

#jira none
#rb carlmagnus.nordin
#rnx
#preflight 6239c9930820efd0949884b9

[CL 19465645 by PJ Kack in ue5-main branch]
2022-03-22 09:10:24 -04:00
Devin Doucette
01274b17c8 Logging: Added a dedicated master thread for logging
#preflight 622fb0eca709bd110fea0da5
#rb Zousar.Shaker

[CL 19387540 by Devin Doucette in ue5-main branch]
2022-03-15 12:31:55 -04:00
robomerge
e2fb673af2 Fixed crashes on launch of experimental device-specific mobile preview
#jira UE-142245
#rb Florin.Pascu
#preflight 621f781637049be517278a73
#lockdown jack.porter


#ROBOMERGE-AUTHOR: jack.porter
#ROBOMERGE-SOURCE: CL 19221437 via CL 19221489 via CL 19221493 via CL 19221512 via CL 19224753
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19229264 by robomerge in ue5-main branch]
2022-03-02 16:12:40 -05:00
steve robb
288f3de432 Fixes for the implicit conversion of ints and chars to TCHARs in UTF-8 mode.
#rb trivial
#preflight 621ed0b4e15c51d8c5e5d081

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 19219816 via CL 19220283 via CL 19220288 via CL 19223679
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19227684 by steve robb in ue5-main branch]
2022-03-02 15:30:50 -05:00