Commit Graph

41 Commits

Author SHA1 Message Date
charles bloom
593fab6f69 Clamp F16 in valid range for BC6H in ISPC and ASTC, also set A to 1
even though ASTC could encode other values of A, still clamp as if it was BC6H for consistency
now all compressed HDR formats should clamp the same way that Oodle Texture currently does

#preflight 6296556c452ffe576a816993
#rb fabian.giesen

[CL 20440882 by charles bloom in ue5-main branch]
2022-05-31 15:49:40 -04:00
charles bloom
578f1d4048 Add TSF_R32F single channel float texture source format
#preflight 6272ecc3e73769b67fe88db9
#rb dan.thompson,fabian.giesen

[CL 20064522 by charles bloom in ue5-main branch]
2022-05-05 16:58:24 -04:00
charles bloom
be238dee17 fix failures on texture import of rare cases
fix RHI upload of textures that are multiple of 4 in top mip but not in lower mips
dont pad CompressedImage sizes, store true size
clean up Texture size limits and VT conditions
better default settings for texture import
clean up initialization order of TextureFormatManagerModule

#preflight 6250814a11261bc7b23d8f4b
#rb fabian.giesen,julien.stjean

[CL 19693287 by charles bloom in ue5-main branch]
2022-04-08 16:06:54 -04:00
charles bloom
cd1fd835b4 ImageCore.cpp fix asserting DestImage.GammaSpace
temp disable check

#preflight none
#rb none

[CL 19547080 by charles bloom in ue5-main branch]
2022-03-29 15:07:24 -04:00
charles bloom
d5b7476357 make image copying to Pow22 gamma a warning and prevent callers from doing so
pow22 should old be used as a source gamma
dest gamma should always be srgb or linear

#preflight 62432a61df7d23dbfeeb57bc
#rb none

[CL 19543713 by charles bloom in ue5-main branch]
2022-03-29 12:16:51 -04:00
charles bloom
349a2035bf new DDSFile DDS import and export
supports 2d,cube,cube array,volume
supports many dxgi pixel formats

#preflight 623c8ea0ca34ffd7bf8c6d07
#rb fabian.giesen

[CL 19501289 by charles bloom in ue5-main branch]
2022-03-24 15:40:53 -04:00
fabian giesen
44b81d0e43 FLinearColor conversion optimizations and some fixes.
FLinearColor ctor from FColor is mainly three table lookups, make it inline and move to the header.
Quantize, QuantizeFloor, QuantizeRound are similarly trivial, now inline.
Move Clamp01 to FColor as static method so it's namespaced; rename to Clamp01NansTo0 to explain why it's not just FMath::Clamp to [0,1]
SSE2-ified FLinearColor::ToFColorSRGB for x86 targets, bitwise exact same results as before for all input floats (tested exhaustively, test included)
Don't want to make ToFColorSRGB inline, it's a bit large for that, but make an array version that does multiple at once. Mainly try to avoid doing a cross-DLL call per pixel for large batches.
Switch ImageCore Linear->sRGB conv to use array version.
FLinearColor R,G,B,A members union'd with "deprecated" RGBA[] array, Component() updated to use it (matching recent fix for FVector)
ImageCore vector loads from FLinearColors updated to use &Component(0) which gives &RGBA[0], pointer to a 4-elem array
Add tests to UnrealMathTest.cpp to verify that sRGB<->Linear and UNORM<->Linear conversions behave as expected, plus the separate ColorConversionHeavy test that does the exhaustive equivalence check between the SSE2 ToFColorSRGB() and reference (warning: takes a while)

#rb danny.couture, martins.mozeiko
#preflight 6238c86f04769ab493469a3f

[CL 19456245 by fabian giesen in ue5-main branch]
2022-03-21 15:07:04 -04:00
fabian giesen
d0472685e2 Fix FLinearColor::ToFColorSRGB handling of large A, Quantize handling of large R/G/B/A.
For large enough floats x (e.g. 1e+7f), x*255 is too large to convert to int. On x86 this turns into INT_MIN which then gets clamped to 0, on ARM it gets saturated and turns into INT_MAX which gets clamped to 255.

Fix it so that over-large values result in 255 (which is the more natural behavior) everywhere and note the conversion rules used for both the sRGB and the linear channels while I'm here. Also update ImageCore optimized kernels to include the QuantizeRound fix.

Confirmed to produce bitwise identical results for textures on AncientGame (i.e. nop on typical content).

#jira  UE-146294
#preflight 6234ffcc48746817f14025dc
#rb martins.mozeiko

[CL 19442181 by fabian giesen in ue5-main branch]
2022-03-18 18:24:46 -04:00
charles bloom
0213e43bbf rename DDSFile namespace to UE::DDS
#rb none
#preflight none

[CL 19414224 by charles bloom in ue5-main branch]
2022-03-16 18:26:52 -04:00
charles bloom
c9433c2752 move DDSFile from TFO to ImageCore
#rb none
#preflight 62325d07ef5d0f0e8ff1bd35

[CL 19413753 by charles bloom in ue5-main branch]
2022-03-16 18:01:49 -04:00
charles bloom
04ffabc485 ImageWrapper and import/export refactor
FImage is now the standard preferred type for a bag of pixels
FImageView can point at pixels without owning an allocation
ERawImageFormat (FImage) converts to ETextureSourceFormat
FImageUtils provides generic load/save and get/set from FImage
major cleanup in the ImageWrappers
new preferred API is through ImageWrapperModule Compress/Decompress
SetRaw/GetRaw functions cleaned up to not have undefined behavior on unexpected formats
ImageWrapper output added for HDR,BMP,TGA
RGBA32F format added and supported throughout import/export
EditorFactories import/export made more generic, most image types handled the same way using FImage now
Deprecate old TSF RGBA order pixel formats
Fix many crashes or bad handling of unusual pixel formats
Pixel access functions should be used instead of switches on pixel type

#preflight 6230ade7e65a7e65d68a187c
#rb julien.stjean,martins.mozeiko,dan.thompson,fabian.giesen

[CL 19397199 by charles bloom in ue5-main branch]
2022-03-15 18:29:37 -04:00
eric renaudhoude
ed6d144ab2 ColorManagement: Removing custom coordinate type to replace it with the now available FVector2d.
#jira none
#rb rod.bogart
#preflight 6221134a6a33f9b416b42d3d

[CL 19250048 by eric renaudhoude in ue5-main branch]
2022-03-03 14:32:54 -05:00
martins mozeiko
73a3d6fd78 Avoid texture conversion to RGBA32F linear color space when unnecessary.
Adds faster code paths for common CopyImage conversions.

#rb charles.bloom
#preflight none

[CL 19235453 by martins mozeiko in ue5-main branch]
2022-03-02 20:13:48 -05:00
danny couture
6d12f86bba Fix editor crash in -nothreading mode
#rb none
#fyi Charles.Bloom
#preflight none

[CL 19196998 by danny couture in ue5-main branch]
2022-03-01 08:04:09 -05:00
charles bloom
84576c31d8 ImageCore NOP comment about strange and slow behavior in Linearize
#rb none
#preflight none

[CL 19119824 by charles bloom in ue5-main branch]
2022-02-24 13:51:36 -05:00
martins mozeiko
2f6746f064 Fix ParallelFor usage in CopyImage, all conversion loops now use JobIndex properly.
Remove TArrayView64 to avoid per-pixel bounds checks in conversion loops.

#rb charles.bloom
#preflight none

[CL 19053594 by martins mozeiko in ue5-main branch]
2022-02-18 14:07:46 -05:00
charles bloom
183b22c547 prepare ApplyCompositeTexture and GenerateTopMip for change
verified nop no change in behavior
prefix scopes with Texture.

#rb dan.thompson,fabian.giesen
#preflight none

[CL 19042123 by charles bloom in ue5-main branch]
2022-02-17 16:20:55 -05:00
charles bloom
67ef10a399 mark up most of the ParallelFors used in cook with named scopes for Insights
#rb arne.schober
#preflight none

[CL 18966875 by charles bloom in ue5-main branch]
2022-02-11 19:32:06 -05:00
charles bloom
b6c85ccee4 Improve Texture Cook ParallelFors
add Insights markup
factor out job count comptutation and ensure it doesn't make tiny jobs
make VT tiles non-parallel because they are already parallel at the tile level

#rb fabian.giesen,arne.schober
#preflight none

[CL 18918813 by charles bloom in ue5-main branch]
2022-02-09 11:27:22 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
eric renaudhoude
262fa16f9f Color Management: Adding (advanced) source encodings for textures.
#rb rod.bogart
#jira none
#preflight 6143e5484778fa00017df627

#ROBOMERGE-AUTHOR: eric.renaudhoude
#ROBOMERGE-SOURCE: CL 17547199 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17547204 by eric renaudhoude in ue5-release-engine-test branch]
2021-09-16 22:14:03 -04:00
charles bloom
05b4b19678 Float16Color use VectorStoreHalf/VectorLoadHalf
add SSE2 half conversions

#rb alexander.suvorov
#fyi rod.bogart

[CL 16135278 by charles bloom in ue5-main branch]
2021-04-27 20:41:39 -04:00
charles bloom
f4c3995c77 fix some more image color quantization conventions
#rb alexander.suvorov
#fyi rod.bogart

[CL 16130215 by charles bloom in ue5-main branch]
2021-04-27 14:36:38 -04:00
charles bloom
87b26ac2e6 fix gamma correction to pow22 doesn't and shouldn't exist
#rb rod.bogart

[CL 15379378 by charles bloom in ue5-main branch]
2021-02-10 16:13:51 -04:00