Commit Graph

214 Commits

Author SHA1 Message Date
Johan Berg
8a92cd22e4 Fix on-connection strings having different type ids.
Since there were two different events for declaring strings and FNames, one regular and one no-sync version used in on-connection callback, references would not be correctly resolved. We remove the no sync version and use only one version. In order to solve the synchronizing we defer resolving the strings in analysis.
#preflight 62a9c8932a1103ff5fb784ae
#robomerge EngineMerge

[CL 20668219 by Johan Berg in ue5-main branch]
2022-06-15 08:03:24 -04:00
Catalin Dragoiu
24f5bb2f6c Improve tracking of the LoadTime value in CookProfiler
#rb Matt.Peters Francis.Hurteau
#preflight 62a8b512136e62bef1cec185

[CL 20653168 by Catalin Dragoiu in ue5-main branch]
2022-06-14 13:45:02 -04:00
Johan Berg
486e82c649 Remove accidental debug code and added comment.
#rb none
#preflight 62a32ba5cc30ea8a287ab71c

[CL 20593542 by Johan Berg in ue5-main branch]
2022-06-10 07:47:23 -04:00
Johan Berg
c8a8270308 String tracing
Adds a tracing subsystem to trace deduplicated strings and FNames.

#rb ionut.matasaru, johan.torp
#preflight 62a2f06b54169bd8aa25a97b

[CL 20591319 by Johan Berg in ue5-main branch]
2022-06-10 03:38:35 -04:00
evgenii babinets
e8189b1fd8 Fixed Insights scopes no longer reporting file/line information.
#jira UE-155735
#rb jordan.cristiano
[FYI] ionut.matasaru
#preflight 629a4b82551457c8dde7b666

#ROBOMERGE-AUTHOR: evgenii.babinets
#ROBOMERGE-SOURCE: CL 20490826 via CL 20490839 via CL 20490846 via CL 20491981 via CL 20492140
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20495596 by evgenii babinets in ue5-main branch]
2022-06-03 19:15:17 -04:00
Ben Marsh
3a38979892 Non-unity build fix.
#fyi Johan.Berg
#preflight none

[CL 20479013 by Ben Marsh in ue5-main branch]
2022-06-02 20:10:44 -04:00
Johan Berg
281488e2aa [TraceLog] Add OnConnection callback
Adds a callback which is issued from Trace whenever a new connection is established. Any event emitted inside the callback are collected separately and written to the trace stream after important events, but before events collected in the tail buffer. In the engine layer the callback is exposed as static delegate on TraceAuxiliary.

#rb martin.ridgers, ionut.matasaru
#preflight 6298bbad63529f84faeab10b

[CL 20468957 by Johan Berg in ue5-main branch]
2022-06-02 10:01:45 -04:00
Johan Berg
a86afcb0fd Memory tracing refactorings
As the memory tracing implementation grew and callstack tracing was extracted it became clear that alot of the code which was implemented as platform specific should really be platform independent. This changelist moves all MemoryTrace_* methods except the MemoryTrace_Initialize to a platform independent layer. This also allows for internalizing the "do-not-allocate-while-tracing-an-allocation" flag. Also took the oportunity to rename MemoryTrace.cpp in Microsoft folder to better reflect platform specific file.

#rb ionut.matasaru
#preflight 6290df2d3c05bea8bfd3ed82
#preflight 6290eb90b83292836e074fff

[CL 20394897 by Johan Berg in ue5-main branch]
2022-05-27 12:39:27 -04:00
Catalin Dragoiu
fa1e5b2bc7 Trace screenshots from the Shot and HighResShot commands when the Screenshot channel is on.
#rb Ionut.Matasaru
#preflight 628c9cdd6f6741ae31578ea9

[CL 20346623 by Catalin Dragoiu in ue5-main branch]
2022-05-24 08:13:55 -04:00
Catalin Dragoiu
0b478d5694 Cooking Profiler Prototype
#rb Ionut.Matasaru  Matt Peters
#preflight 628b8690693c5e1de2773a39

[CL 20327158 by Catalin Dragoiu in ue5-main branch]
2022-05-23 10:13:54 -04:00
geoff evans
0988a55b0a Trace Snapshot to File
### Features
We can now write tailing memory to a utrace file. Snapshotting while tracing to a file or socket is supported.
This change introduces a new console command: Trace.SnapshotFile. It writes the profiling data from memory into an optionally specified a utrace file.

### Testing
Run Editor with -tracefile
Run Editor with -trace, connect live with insights
Run Editor without -trace (this does generate a very small utrace since there is memory and data in the tail even though default channels are not enabled)

#rb johan.berg
#jira UE-150302,UE-150292
#preflight 6272a3213e1f2a9d3a88ee3d

#ROBOMERGE-OWNER: geoff.evans
#ROBOMERGE-AUTHOR: geoff.evans
#ROBOMERGE-SOURCE: CL 20124258 via CL 20125717 via CL 20126082
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20129506 by geoff evans in ue5-main branch]
2022-05-10 17:03:04 -04:00
David Harvey
3997a1ff0c fix platform file trace for modular builds.
#jira UE-151231
#rnx
#rb trivial
#preflight 6278febdf34e710b6de75a71

[CL 20101167 by David Harvey in ue5-main branch]
2022-05-09 07:49:16 -04:00
nuno leiria
e285a188a9 Misc changes required to build consoles as modules
#rb trivial
#preflight 626a8f0e631e64c0b9021363

[CL 19960219 by nuno leiria in ue5-main branch]
2022-04-28 09:16:32 -04:00
geoff evans
1981b2f5f3 StallDetector support for Linux
### Features

This change enables the StallDetector watchdog in Editor to submit reports to crashreporter about threads violating instrumented deadlines in the source code. This feature was available prior on Windows, and this change adds Linux support.

### Notes

New APIs:
ReportStall()
CaptureThreadPortableCallStack()

Many APIs are updated from purely "Ensure" naming to more general naming. Stalls are more like Ensures than crashes, and so the appropriate renames to make the code readable and clear have been made. In some places Ensure is replaced with the clearer: Continuable Event nomenclature.

### Testing

I synthesized an ensure on Linux, and did the same for a stall. I then compared crash report XML file to make sure they contain accurate data in the callstack, portable callstack, and other fields in the report. I also noted that the stall information was showing as expected in the crash reporter.

#rb brandon.schaefer, francis.hurteau
#jira UETOOL-3336
#preflight 625e20d2804460ab0fea3277

[CL 19911608 by geoff evans in ue5-main branch]
2022-04-25 19:19:04 -04:00
john huelin
362d3dc7c8 Fix compilation of nonunity build
#rb mickael.gilabert
#rnx

#ROBOMERGE-OWNER: hilda.cruz
#ROBOMERGE-AUTHOR: john.huelin
#ROBOMERGE-SOURCE: CL 19742953 via CL 19743504 via CL 19744060 via CL 19744380 via CL 19744561
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19801681 by john huelin in ue5-main branch]
2022-04-18 23:22:39 -04:00
john huelin
7332066e27 Fix 2 Insights callstack tracing crashes when capturing on some platforms.
First one because due to RTC in EOS not having frame pointers causing a crash when walking down the stack. Limiting callstack tracing with a scope.

The second one because of limited stack size (4k) in a Curl Helper thread, causing a crash when walking down the stack because the callstack walker was allocating 4k on the stack. Doing it inplace to allocate only 2k.

[REVIEW] [at]johan.berg
[FYI] pavel.punsky
#rnx

#ROBOMERGE-OWNER: john.huelin
#ROBOMERGE-AUTHOR: john.huelin
#ROBOMERGE-SOURCE: CL 19739450 via CL 19739526 via CL 19739543 via CL 19739742 via CL 19739765
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19741582 by john huelin in ue5-main branch]
2022-04-13 12:50:15 -04:00
Sebastian Thomeczek
53ad72b2e5 FTraceAuxiliary: Added GetTraceDestination, IsConnected and GetActiveChannelsString to public interface.
#rb Johan.Berg
#preflight none

[CL 19667767 by Sebastian Thomeczek in ue5-main branch]
2022-04-07 09:18:58 -04:00
Johan Berg
3962277bdd Add a way to express fallback tag in Memory Trace
Manual memory tracking in LLM has a feature for defining a "fallback tag" for the allocation if no tag is currently set. This change adds a new scope type which allows us to express this behaviour in memory tracing as well.

#jira UE-142692
#rb ionut.matasaru
#preflight 624ed4e9bd5b36eec338a937

[CL 19667413 by Johan Berg in ue5-main branch]
2022-04-07 08:48:22 -04:00
Arne Schober
e2a4b02ddf M - Support for Unreal Insights to allow Suspend/Resume of Scope stacks which is Used by Coroutines.
#preflight 624c70b27d2eea4e18e0ad62

[CL 19639870 by Arne Schober in ue5-main branch]
2022-04-05 22:30:11 -04:00
ionut matasaru
47ed4fbd6b Improved struct packing for TCounter (32 --> 20 bytes) and FScopedDetailTickStats (32 --> 24 bytes).
#rb Catalin.Dragoiu
#preflight 624c03dee434babd8a407f74

[CL 19622034 by ionut matasaru in ue5-main branch]
2022-04-05 05:17:08 -04:00
Catalin Dragoiu
642b61b238 Fix compile error in TraceScreenshot.cpp
#rb trivial
#preflight 623a051810251d53d5742e5b

[CL 19469125 by Catalin Dragoiu in ue5-main branch]
2022-03-22 13:55:52 -04:00
Catalin Dragoiu
e0475b1694 Screenshot tracing initial implementation
#rb Ionut.Matasaru Johan.Berg
#preflight 6239f65abc1cf2803864a90c

[CL 19467957 by Catalin Dragoiu in ue5-main branch]
2022-03-22 12:35:42 -04:00
Johan Berg
24596d30fd [Insights] Set default parameter value for channels in Start
#rb ionut.matasaru
#preflight 6229f366377a9e55bacbdf94

[CL 19334657 by Johan Berg in ue5-main branch]
2022-03-10 07:52:14 -05:00
robert millar
b4bfddef0a MallocBinned2 fork support.
Clear caches and update a canary value across the fork boundary to avoid touching pages that were allocated pre-fork to minimize unnecessary duplication of shared pages.
Savings depend on pre-fork fragmentation/slack and number of concurrent child processes.

#rb louisphilippe.seguin, johan.torp, arciel.rekman

#ROBOMERGE-OWNER: robert.millar
#ROBOMERGE-AUTHOR: robert.millar
#ROBOMERGE-SOURCE: CL 19057122 via CL 19057644 via CL 19057693 via CL 19057718 via CL 19057737 via CL 19059617
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19066314 by robert millar in ue5-main branch]
2022-02-21 02:04:42 -05:00
evgenii babinets
56c7c2c121 Fixed compile errors on FN servers where trace events were not enabled. Needed to update the CPUPROFILERTRACE_ENABLED 0 macros as well.
#rb jordan.cristiano

#ROBOMERGE-OWNER: aurel.cordonnier
#ROBOMERGE-AUTHOR: evgenii.babinets
#ROBOMERGE-COMMAND: _robomerge UE5-Main
#ROBOMERGE-SOURCE: CL 19018687 via CL 19018740 via CL 19018773 via CL 19028082
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v917-18934589)

[CL 19028102 by evgenii babinets in ue5-main branch]
2022-02-16 20:15:57 -05:00