Commit Graph

49 Commits

Author SHA1 Message Date
ben hoffman
d74fbc326d Notify the level editor that a subobject has been changed when adding or deleting a subobject. This ensures that if there is a selected actor instance in the level that it will have it's subobjects properly updated
#jira UE-116645
#rb justin.hare
#rnx
#preflight 60cba56378c3b0000138e856

#ROBOMERGE-SOURCE: CL 16711849 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16711863 by ben hoffman in ue5-release-engine-test branch]
2021-06-17 17:12:05 -04:00
ben hoffman
213c184db6 Attach a dupliucated component to the source's parent instead of the source directly
#jira UE-118043
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 16709163 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16709191 by ben hoffman in ue5-release-engine-test branch]
2021-06-17 15:07:28 -04:00
ben hoffman
2dce1f4261 Check if a subobject is allowed to be deleted before allowing the subsystem to delete it. This solves the problem where a BP script may not be doing the same validation when calling DeleteSubobjects that the Subobject Editor does.
Add logging when a subobject can't be deleted

#jira UE-117853
#rb michael.noland
#rnx

#preflight 60c8def586ce760001d8de51

#ROBOMERGE-SOURCE: CL 16678061 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16678066 by ben hoffman in ue5-release-engine-test branch]
2021-06-15 15:39:25 -04:00
ben hoffman
a08747af65 Added logging when a blueprint component cannot be deleted when called from blueprints
#jira UE-117855
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 16665192 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v834-16658389)

[CL 16665199 by ben hoffman in ue5-release-engine-test branch]
2021-06-14 17:50:24 -04:00
ben hoffman
c711ab34a0 Remove an unnecessary check from the deletion of subobjects. This check was originally there to confirm that the SCS node being deleted is from the current subobject tree, but is not a valid check anymore when you can call this function from Blueprints as well.
#jira UE-117836
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 16661733 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v834-16658389)

[CL 16661742 by ben hoffman in ue5-release-engine-test branch]
2021-06-14 14:36:11 -04:00
ben hoffman
6f18c928f9 Automatically select a new component for rename upon duplication.
#jira UE-117759
#rb phillip.kavan
#rnx
#preflight 60c2bc6c1264df0001bc76ee

#ROBOMERGE-SOURCE: CL 16635347 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v831-16623017)

[CL 16635367 by ben hoffman in ue5-release-engine-test branch]
2021-06-10 22:29:06 -04:00
ben hoffman
f8486e74cd Fix duplication of an inherited blueprint variables in the subobject instance editor by using the correct ComponentInstanceInActor instead of the SCS node
#jira UE-117371
#rb marc.audy
#rnx

#ROBOMERGE-SOURCE: CL 16625879 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v831-16623017)

[CL 16625900 by ben hoffman in ue5-release-engine-test branch]
2021-06-10 13:53:48 -04:00
ben hoffman
e4df683178 Fix SA warning with NewSCSNode in PasteSubobjects
#jira none
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 16623623 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v831-16623017)

[CL 16623629 by ben hoffman in ue5-release-engine-test branch]
2021-06-10 11:06:46 -04:00
ben hoffman
ed0d9c2a50 Add clearer logging when creating a new BP component
#jira UE-117725
#rb trivial
#rnx
#preflight 60c161b8b68c700001b51b83

#ROBOMERGE-SOURCE: CL 16617905 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16617910 by ben hoffman in ue5-release-engine-test branch]
2021-06-09 22:02:54 -04:00
ben hoffman
ce0d3ad893 Fix a crash when deleteing instances of subobjects if the component template is null
#jira UE-117672
[RN] trivial
#rnx

#ROBOMERGE-SOURCE: CL 16615637 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16615660 by ben hoffman in ue5-release-engine-test branch]
2021-06-09 19:26:38 -04:00
ben hoffman
11ad173ce7 Fix a crash when pasting subobjects into the blueprint editor. This will ensure that a valid attachment target is selected for the subobject, and correctly create a subobject data handle based off of the SCSnode instead of the SCSNode's component template, which was causing the crash.
#jira UE-116864
#rb phillip.kavan
#rnx
#preflight 60c115d6c6126400019f921b

#ROBOMERGE-SOURCE: CL 16613714 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16613723 by ben hoffman in ue5-release-engine-test branch]
2021-06-09 17:47:44 -04:00
ben hoffman
fc6e61fec0 Remove unused parent class filter from Subobject Data Subsystem
#rb trivial
#rnx
#jira none
#preflight 60bfe2a31ab03100015ac15d

#ROBOMERGE-SOURCE: CL 16597093 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16597100 by ben hoffman in ue5-release-engine-test branch]
2021-06-08 19:59:11 -04:00
ben hoffman
4b3aa3e563 Make DeleteSubobject functions for an instance and blueprint seperate for better context menu searches
#jira none
#rb trivial
#rnx

#preflight 60be2392884c63000171ad30

[CL 16572253 by ben hoffman in ue5-main branch]
2021-06-07 12:17:06 -04:00
ben hoffman
5c81d43585 Change how the old root component gets deleted to correctly handle the promotion of its children
#jira UE-117184
#rb trivial
#rnx
#preflight 60b942e615b2f10001aade6e

[CL 16555185 by ben hoffman in ue5-main branch]
2021-06-03 19:21:20 -04:00
ben hoffman
fd1fe7595b Subobject Data Subsystem:
- Do not create a new blueprint component via the Subobject Data subsystem if the given class is not a blueprint type.
- Check for existing classes with that have the same name when creating a BP class to prevent the user from creating invalid packages.
- Add logging to show the user a reason for failure when the given class name is invalid.

#rb phillip.kavan

#jira UE-116746
#jira UE-116749
#jira UE-117000

#preflight 60b8e5f78e7ee10001f44220

[CL 16549867 by ben hoffman in ue5-main branch]
2021-06-03 13:44:44 -04:00
ben hoffman
0267dce005 When adding to instance inhertied subobjects, if the actor instance cannot be initalliy found walk up the heirarchy until we find one.
#jira UE-115687
#rb marc.audy
#preflight 60a6ad227370d300018b3ad5

[CL 16408716 by ben hoffman in ue5-main branch]
2021-05-20 15:59:06 -04:00
ben hoffman
f521548a94 Sort blueprint subobjects by their type to ensure that non-scene components show up on the bottom. When adding a new subobject parent non-scene components to the actor instead of the default scene root.
#jira UE-116086
#rb marc.audy
#preflight 60a5604aa5fa6d0001321600

[CL 16391076 by ben hoffman in ue5-main branch]
2021-05-19 15:51:34 -04:00
ben hoffman
cace383786 Fix a case where an ensure could be triggered when adding a new component to a blueprint with BP inherited components
#jira none
#rb
#rnx
#preflight 60a42f4a7d6b060001e8d724

[CL 16377852 by ben hoffman in ue5-main branch]
2021-05-18 18:36:56 -04:00
ben hoffman
ccc7b1af25 Remove unnecessary check in SubobjectDataSubsystem
#jira UE-74439
#rb trivial
#rnx

[CL 16376065 by ben hoffman in ue5-main branch]
2021-05-18 17:02:55 -04:00
ben hoffman
f3116b5fe4 Fix a bug where the hierarchy would all be attached to the default scene root for native blueprints.
Correctly sort non-scene components to the bottom of the component tree.
This is some logic that was missed during the SCS editor refactor and is known to work already.

#jira UE-115776
#rb trivial
#rnx
#preflight 60a40b42292e32000148e10b

[CL 16374996 by ben hoffman in ue5-main branch]
2021-05-18 16:15:05 -04:00
ben hoffman
1d83ed6981 Only set a newly created component as the default scene root if it can be reparented. This stops the incorrect ordering of native components in the heirarchy after a new component has been added
#jira none
#rb me
#rnx

[CL 16358428 by ben hoffman in ue5-main branch]
2021-05-17 16:25:26 -04:00
ben hoffman
db3a6d7413 Fix PVS CIS issues
#jira none
#rb trivial
#rnx

[CL 16145593 by ben hoffman in ue5-main branch]
2021-04-28 12:51:53 -04:00
Marc Audy
3cfedaade8 Fix PVS warning V502 when comparing against NAME_None in a trinary
[CL 16137741 by Marc Audy in ue5-main branch]
2021-04-28 01:58:36 -04:00
ben hoffman
61908bed8a Create the Subobject Data interface module. This provides an API that can be used to manipulate Subobjects such as adding/removing components, reparenting, and changing the scene heirarchy.
The SubobjectDataSubsystem is how users can manipulate a given object within Blueprints or Python scripting. Given a Uobject instance in a level or a UBlueprint asset, you can use GatherSubobjectData to get get an array of handles that you can use to manipulate that subobject.

This is what the new SubobjectEditor (Previously the SCS editor) will be using instead of having all its logic within slate code.

#rb marc.audy
#jira UE-64131
#preflight 6082ce4f8de3a60001cf6af8
#preflight 6082d84a92d7e700019f53e0

[CL 16104548 by ben hoffman in ue5-main branch]
2021-04-23 11:01:15 -04:00