Commit Graph

114 Commits

Author SHA1 Message Date
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
sebastian nordgren
8eafe4f70e Editor configs now correctly diff against the CDO when serializing.
Previously, I had assumed that FProperty::InitializeValue() would initialize a simple member (eg. a float) to the correct value, but this appears not to be the case, rather values are zero-initialized and the CDO stores the correct default values. In the case of structs, InitializeStruct() does in fact initialize correctly.

However, this means that we can't use GetMutableDefault() to get an instance of the UObject, since then we're changing what we're diffing against and serialize no values. Changed the usages of this pattern to use singletons instead.

#jira UE-141150
#review-19900014 @lauren.barnes, @aditya.ravichandran
#preflight 6267fa44a021c91a50f26a65

[CL 19919719 by sebastian nordgren in ue5-main branch]
2022-04-26 10:20:56 -04:00
sebastian nordgren
03c8e7c243 Details view's IsPropertyReadOnly delegate is now evaluated every frame instead of only when refreshing the tree, similar to how IsPropertyVisible now works.
IsPropertyReadOnly and IsPropertyVisible removed from update args, because they were only evaluated in conjunction with a full refresh.

#review @michael.noland
#preflight 621cf1bf6e5ae46efd48a323

[CL 19174367 by sebastian nordgren in ue5-main branch]
2022-02-28 11:11:53 -05:00
sebastian nordgren
2bb8c0f18a Scrolling a row outside of the Details view now commits any changes that were being made to that row.
#jira UE-134865
#rb matt.kuhlenschmidt
#preflight 620cb57701253d2e19fe9efa

[CL 19011614 by sebastian nordgren in ue5-main branch]
2022-02-16 03:42:24 -05:00
daren cheng
284c0a0eec Add shift click copy / paste to details panel
#jira UE-134754
#rb sebastian.nordgren
#preflight 61952207b32bbfdc5007c419
#robomerge[BOT4] 5.0
#robomerge[BOT1] Main

[CL 18229597 by daren cheng in ue5-main branch]
2021-11-17 17:02:14 -05:00
sebastian nordgren
1131b138d5 Moved FDetailColumnSizeData to its own file.
#rb paul.chipchase
#preflight 617c0f47c44dc500016a989d

[CL 18017897 by sebastian nordgren in ue5-main branch]
2021-11-02 09:22:12 -04:00
aurel cordonnier
34f55d3a4a Merge from Release-Engine-Test @ 17946149 to UE5/Main
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17949667 by aurel cordonnier in ue5-main branch]
2021-10-27 15:14:40 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
sebastian nordgren
6c9dfc8c35 Details views now dynamically resize the right column when the sequencer is enabled.
SSplitter slots now use a TAttribute for their MinSize, allowing it to be changed dynamically.

#preflight 614aed2d4cff6900016d08d7
#preflight 6153075b80eba00001a4224f

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 17644847 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v875-17642767)

[CL 17644853 by sebastian nordgren in ue5-release-engine-test branch]
2021-09-28 09:03:42 -04:00
sebastian nordgren
bf3cddefc8 Details view style refresh:
- rows are now 26 pixels high
- right column is narrower unless the Sequencer is invoked
- padding has been removed to make more rows fit on the screen at once
- Advanced dropdown is now styled like a normal group and thus the bottom node is gone

[at]editor-ux
#preflight 6140652a9dc6c8000144500a

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 17537602 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17537624 by sebastian nordgren in ue5-release-engine-test branch]
2021-09-16 08:34:39 -04:00
aurel cordonnier
dc4bf61540 Merge from Release-Engine-Staging @ 17030559 to Release-Engine-Test
This represents UE4/Main @ 17030256 and Dev-PerfTest @ 17030553

[CL 17031509 by aurel cordonnier in ue5-release-engine-test branch]
2021-08-03 11:56:47 -04:00
phillip kavan
1b6914ca4b Extends the class viewer module to support multiple custom class filters along with an optional associated view option flag.
Additional changes:
- Deprecates the previous method for specifying a singular custom class viewer filter and updates all existing occurrences of this pattern in engine code.
- Extends the property editor utilities interface to expose custom class filter(s) that can be applied to the class picker widget used for editing class property values.
- Adds an implementation of this interface to SDetailsView such that additional class filter(s) can now be configured to be applied to all underlying class property nodes.

#jira UE-108316
#rb Lauren.Barnes
#preflight 60c2102e8ae8960001110d50

#ROBOMERGE-OWNER: phillip.kavan
#ROBOMERGE-AUTHOR: phillip.kavan
#ROBOMERGE-SOURCE: CL 16623084 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v831-16623017)
#ROBOMERGE-CONFLICT from-shelf

[CL 16623246 by phillip kavan in ue5-release-engine-test branch]
2021-06-10 10:40:50 -04:00
aurel cordonnier
25a11deeac Merge from Release-Engine-Staging @ 16579919
This represents UE4/Main @ 16579691 and Dev-PerfTest @ 16579576

[CL 16581170 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-07 20:09:45 -04:00
sebastian nordgren
bb9ac331d5 Removed bShowOnlyWhitelistedProperties from details config. If the value was serialized, it would likely be nonsensical without the list of whitelisted properties, which are currently always set programmatically (by the diff tool, for example) and not by the user.
#review-16483499 @lauren.barnes
#preflight 60afa09e1db8a70001f3e6f9

[CL 16484336 by sebastian nordgren in ue5-main branch]
2021-05-27 10:32:27 -04:00
sebastian nordgren
394e3fcc62 Added FDetailsViewConfig to store various details view settings, using the new EditorConfig system.
Renamed FDetailFilter properties to be consistent with one another.

#review-16449481 @lauren.barnes

[CL 16468647 by sebastian nordgren in ue5-main branch]
2021-05-26 09:46:13 -04:00
sebastian nordgren
96a0d9f568 Moved items in a details view array now have their expansion state restored after being moved.
[at]lauren.barnes
#preflight 60ace54358f02e0001a57434

#ROBOMERGE-SOURCE: CL 16446667 in //UE5/Main/... via CL 16446668
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Release-Engine-Staging) (v816-16445697)

[CL 16446669 by sebastian nordgren in ue5-release-engine-staging branch]
2021-05-25 08:59:54 -04:00
sebastian nordgren
d3f04cfb76 Moved items in a details view array now have their expansion state restored after being moved.
#review-16446209 @lauren.barnes
#preflight 60ace54358f02e0001a57434

[CL 16446667 by sebastian nordgren in ue5-main branch]
2021-05-25 08:59:30 -04:00
sebastian nordgren
039605ce82 Renamed bShowOnlyDiffering to bShowOnlyWhitelisted - that it's only used for diffing is a detail that the details view shouldn't know about.
#rb paul.chipchase

[CL 16073432 by sebastian nordgren in ue5-main branch]
2021-04-21 10:40:13 -04:00
sebastian nordgren
a7739c5df1 Added SetIsCustomRowReadOnlyDelegate to enable customizing the read-only state of custom rows en-masse.
Removed SetIsCustomRowVisibilityFilteredDelegate, because it was unused and needlessly complex since the delegate that you pass into SetIsCustomRowVisibleDelegate can run the same logic and early out.

Category and property filtering through Properties To Show and Categories to Show now works properly.The problem was that visiblity was only considered once on creation and then never again.

#jira UE-88178
#review-15797106 @lauren.barnes
#preflight 605b2381c77fb000015e6a30

[CL 15797104 by sebastian nordgren in ue5-main branch]
2021-03-24 08:16:16 -04:00
sebastian nordgren
eba54425f5 Padding fixes for left alignment in the details panel.
Splitter line now always visible, and splitter column width ratio adjusted to be closer to 50/50.

Favorites hint text now renders with a more subdued style.

[at]lauren.barnes

#ROBOMERGE-SOURCE: CL 15355944 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15360308 by sebastian nordgren in ue5-main branch]
2021-02-08 17:05:10 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
Matt Kuhlenschmidt
24fd139385 Fixed up locations making one off thumbnail pools and converted them to use the shared thumbnail pool.
[CL 15211295 by Matt Kuhlenschmidt in ue5-main branch]
2021-01-26 17:21:08 -04:00
sebastian nordgren
560ed14eb0 Added EditorMetadataOverrides subsystem and enabled its usage for details view favourites.
The Favorites category is now always visible, and displays a note about how to add properties there when empty.

#rb chris.gagnon
#jira UETOOL-2769

[CL 15208242 by sebastian nordgren in ue5-main branch]
2021-01-26 11:51:28 -04:00
Marc Audy
bc88b73a29 Merge Release-Engine-Staging to Main @ CL# 15151250
Represents UE4/Main @ 15133763

[CL 15158774 by Marc Audy in ue5-main branch]
2021-01-21 16:22:06 -04:00
sebastian nordgren
09e38a136c SDetailsViewBase now allows deferred actions to call EnqueueDeferredAction. These additional deferred actions are then immediately processed in the same frame.
This manifested as an ensure in a details customization calling EnqueueDeferredAction from within CustomizeChildren when a UCurveTable was added to an array.

Since programmers may not understand that it can be called from a deferred action, this restriction would be very hard for programmers to grasp until the assertion triggers.

#jira UE-104844
#rb matt.kuhlenschmidt

[CL 15010356 by sebastian nordgren in ue5-main branch]
2021-01-07 11:39:18 -04:00