Commit Graph

728 Commits

Author SHA1 Message Date
jordan hoffmann
927a75a885 [BugFix] Crash using blueprint Diff view without a selected diff item
- This was the result of a merge error. I removed the duplicate/incorrect code

#jira UE-156396
#jira UE-156396

[BugFix] Selected diff Pins aren't highlighted in blueprints with more than one graph
- FocusedDiffResult attribute returned the index of the diff result in a list of all diff results when it needed to return the index of a subset array that only includes results diffs between the currently rendered graph
#preflight 62a7d093045c9fe61ee09c19

[CL 20638583 by jordan hoffmann in ue5-main branch]
2022-06-13 20:11:07 -04:00
thomas tedemalm
9a88eea99f Fixed an issue where an uninitialized flag would cause some graph connections to be faded out.
#rb none
#preflight 62a71cac5a44fbc40278a187
#fyi jordan.hoffmann

[CL 20625012 by thomas tedemalm in ue5-main branch]
2022-06-13 07:24:43 -04:00
jordan hoffmann
6b0807f33f [BugFix] Crash using blueprint Diff view on complex blueprints
+ also added in Pin_DiffHighlight brush that never got committed
#preflight 62a3acd42558795127e5341c
#rb ben.zeigler

[CL 20602390 by jordan hoffmann in ue5-main branch]
2022-06-10 16:58:41 -04:00
jordan hoffmann
490bccda39 [Feature] blueprint diff node outlines colored by diff state
#jira UE-150555
#rb aditya.ravichandran
#preflight 62a38ead2558795127e232d0

[CL 20600224 by jordan hoffmann in ue5-main branch]
2022-06-10 14:52:59 -04:00
jordan hoffmann
ff6648b05f [BugFix] BP_Diff data flow changes
- because the graphs were being diffed in two different ways - once to generate the list and once to determine how to render the nodes, there were some differences in the diff behavior that caused certain nodes to not render as diffed even though they showed up in the list. this change uses the same diff list for both now so there shouldn't be any differences anymore

- This also solves an issue that caused highlighted pins from Blueprint Diff to persist to the blueprint itself. Now all visual modifications made by the diff viewer only appear in the diff panels rather than the main graph
#jira UE-93061
#preflight 62a256ef2469f462fdd9c693
#rb daren.cheng

This change sets up for future style changes allowing for us to render nodes in the diff graph based on their diff type. There are no style changes in this CL however.

[CL 20584624 by jordan hoffmann in ue5-main branch]
2022-06-09 16:44:27 -04:00
halfdan ingvarsson
c04cc6ee97 Optimus: Add pin grouping.
#jira none
#preflight 62a17f65f73a01bd9810b439
#rnx

[CL 20571271 by halfdan ingvarsson in ue5-main branch]
2022-06-09 01:11:58 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
justin hare
3ffeff5ead Fixes crash when closing BP graph editor windows that haven't been moved or manipulated in certain ways
#jira UE-153271
#fyi jordan.hoffman
#rb none (trivial)
#preflight none (trivial)
#rnx

[CL 20293577 by justin hare in ue5-main branch]
2022-05-20 09:35:15 -04:00
jordan hoffmann
c976ed5a3a [Bug Fix]: Clicking an Add or Removed entry in the blueprint diff tool only moves one of the views.
- The SNodePanel deferrs some of it's panning to future frames which was causing locked graphs in the diff tool to become out of sync. To solve this, I wait until the SNodePanel has finished finding it's target before setting locked graphs on the same trajectory

#jira UE-150557
#rb Marc.Audy, Brooke.Hubert, Lauren.Barnes, Vincent.Gauthier
#preflight 6286cc16cf5ac7317c47235d

[CL 20288942 by jordan hoffmann in ue5-main branch]
2022-05-19 19:12:34 -04:00
Josie Yang
d0374027d4 Move SGraphPinVector4.cpp from NiagaraPins folder to KismetPins folder
#preflight 627e317034434190054b12d8

[CL 20179042 by Josie Yang in ue5-main branch]
2022-05-13 06:29:36 -04:00
Josie Yang
af65e53764 Inline edit support to material expression inputs
- Inline edit support for UPROPERTY of type float, int32, uint32, uint8, enum, bool.
- Editable UPROPERTYs with "OverridingInputProperty" metadata are created as inline widgets next to their corresponding inputs.
- Rest of the editable UPROPERTYs may specify "ShowAsInputPin" metadata to become inline edit pins, with 2 choices: "Primary" - show in primary view, "Advanced" - show in in advanced view.
- Update a bunch of material expressions to reflect the changes, rest of the expressions still need to be worked through.

#jira UE-145276
#rb kevin.Ortegren
#preflight 627a3cc8937a047d62282ba7

[CL 20122451 by Josie Yang in ue5-main branch]
2022-05-10 09:53:13 -04:00
lauren barnes
5f7006fb53 Fixing EditorStyle->AppStyle merge errors
#rb trivial

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20073150 via CL 20073151
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20105751 by lauren barnes in ue5-main branch]
2022-05-09 13:31:58 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
louise rasmussen
fd51dd72b6 ReferenceViewer Enhancements Part 1
- Updates the header style (UE5, emphasizes type)
- Shows nodes that may show up in more than one place (duplicates)
- Separates Depth control into Referencer Depth and Dependency Depth
- Comments with Package Path have been removed entirely (the tooltip remains)
- Rewritten algorithms to generate graph nodes that remove code duplication and will make adding new features easier
- Consolidates filters within the GetSortedLinks function
- adds temporary CVar that enables the ability to toggle between the old and new reference node layout algorithms.  The depricated algorithms and CVar will be removed once the rest of phase one is completed and the new layout has undergone more testing.

#JIRA  UE-148313, UE-148316, UE-148318
#rb Lauren.Barnes
#preflight 6272eb29dc3613022751c308

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20051603 via CL 20054172 via CL 20054231 via CL 20054249
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20060933 by louise rasmussen in ue5-main branch]
2022-05-05 14:04:26 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
julien lheureux
d59f4548e8 Fixed typo found by static analysis
#rb trivial
#preflight none
#rnx
#ue UE-150237

[CL 19919437 by julien lheureux in ue5-main branch]
2022-04-26 09:56:25 -04:00
julien lheureux
c6e5b5d7a7 Improved behavior on links in graphs that support multiple links per pin.
Fixes issues with highlighting and alt-click delete on a link.

#rb lauren.barnes
#preflight 62631588bc24759dc755101a

[CL 19900843 by julien lheureux in ue5-main branch]
2022-04-25 08:49:05 -04:00
dave jones2
1d36b62d36 UE-148463 - Update cumulative time tracking Engine variables to doubles
As a part of the LWC work, this change primarily focues on updating FGameTime and UWorld to use doubles for accumulated time. Note that time deltas will remain as floats.

Additionally:

* A few time-related BP functions were updated to use doubles where appropriate. as well as the FRenderThreadUpdateContext struct for the Slate renderer.
* Some compilation errors were also fixed due to the change.
* Minor changes of float literals to drop the 'f' suffix.

#rb andrew.davidson
#jira UE-148463
#preflight 62603748e30cb43e8cbf2aa7

[CL 19866207 by dave jones2 in ue5-main branch]
2022-04-22 11:57:28 -04:00
Helge Mathee
87702d5a3a Control Rig: Fix crashes during upgrade / unresolve
#rb sara.schvartzman
#jira UE-147165 UE-147543
#preflight https://horde.devtools.epicgames.com/job/6246b0af3a5a4c1622de9384

[CL 19585555 by Helge Mathee in ue5-main branch]
2022-04-01 04:37:48 -04:00
Ben Ingram
9f80c7620f Track both input/output types for material graph connections
Pins are now color-coded by type in addition to wires
#rb none
#preflight 62322c52e2541b4ff3b46c72
#jira UE-145274

[CL 19409438 by Ben Ingram in ue5-main branch]
2022-03-16 14:53:30 -04:00
Ben Ingram
3fcb3a0749 Material editor colors wires based on data type when using new HLSL generator
#rb none
#preflight 622ba22f0a614dcb0c034713
#jira UE-145274

[CL 19359292 by Ben Ingram in ue5-main branch]
2022-03-11 14:39:57 -05:00
sara schvartzman
0db1c97d53 Shift+LeftClick to duplicate drag a pin connection
#jira na
#rb lauren.barnes
#preflight https://horde.devtools.epicgames.com/job/6229f3ab313be30406724f16

[CL 19335196 by sara schvartzman in ue5-main branch]
2022-03-10 09:31:03 -05:00
Helge Mathee
fe5886fb9a EdGraph: Keep soft handles to pins and nodes during link
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6229c190d271eeb462e1d0ad

[CL 19334348 by Helge Mathee in ue5-main branch]
2022-03-10 06:25:01 -05:00
daren cheng
5d1a1f3d8f Fix pin tooltip not dismissing when pin destroyed if tooltip hovered.
#jira UE-144506 UE-144712
#preflight 6222864a335298c3146d71d4
#rb Vincent.Gauthier
#lockdown simon.tourangeau

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 19284905 in //UE5/Release-5.0/... via CL 19285657
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19291608 by daren cheng in ue5-main branch]
2022-03-07 15:52:55 -05:00
daren cheng
ed63759613 Remove pin tooltips on pin destruction, preventing stale tooltip crashes.
#jira UE-144506
#preflight 62210cd87b383ac2989e690b
#rb Vincent.Gauthier
#lockdown JeanMichel.Dignard

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 19249172 in //UE5/Release-5.0/... via CL 19251784
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263234 by daren cheng in ue5-main branch]
2022-03-04 03:25:54 -05:00