#rnx
#rb none
#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870586 by ryan durand in Main branch]
#jira UE-65570
#rb lauren.ridge
#ROBOMERGE-SOURCE: CL 4495428 in //UE4/Release-4.21/...
#ROBOMERGE-BOT: RELEASE (Release-4.21 -> Release-Staging-4.21)
[CL 4495429 by rex hill in Staging-4.21 branch]
#lockdown Nick.Penwarden
#rb none
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3760710 by Thomas.Sarkanen
Fix crash deleting primitives in PhAT
Crash in tooltip generation for shapes. Tree items still exist in the frame before the tree gets regenerated (as the widget defers their destruction a frame), so they can end up pointing at out of date data.
#jira UE-52404 - Crash deleting bodies
#tests deleted primitives in PhAT
Change 3760798 by Martin.Wilson
Initialize PosesToEvaluate so that we don't get stale data crashes after reinitializing
#Jira UE-52343
Change 3761312 by Martin.Wilson
Fix for infrequent crash on module start up
Change 3761333 by Danny.Bouimad
Fixed the Cable actor test correctly, shouldn't fail on cooked platforms any more!
Change 3761550 by Aaron.McLeran
Engine changes requested by oculus for spatializer interface
Change 3761728 by Martin.Wilson
Fix crash when undoing a change on a skeletal mesh that uses virtual bones
#Jira UE-52475
Change 3762032 by Ethan.Geller
#jira UE-49076 Implement PR for VOIP bug fix on Mac
Change 3762109 by Aaron.McLeran
Enabling bAllowAnyoneToDestroyMe on audio components
Change 3762125 by Aaron.McLeran
Checking in missing file
Change 3762568 by Aaron.McLeran
Fixing ogg vorbis 5.1 channel ordering channel maps in audio mixer
Fix is to create separate 5.1 channel maps for various output channel counts and pull those channel maps if the source file was decoded from vorbis. This pattern is copied from old xaudio2source code which handles 5.1 channel mapping seperately. Alternative solution would be to swizzle vorbis channels during cook, but this would break backward compatibility. We'll consider that solution in the future once we remove the old audio engine code.
Change 3762571 by Aaron.McLeran
Adding multichannel file support.
- Spoofing the multi-channel file importer tool by allowing a single multichannel file to generate data in the same way
- Moved the wave serializer code from audio capture plugin to audio.h/.cpp for general use
Change 3762626 by Aaron.McLeran
Adding ability to automatically tag ambisonics files.
Change 3762627 by Aaron.McLeran
Fixing up source buses to be more useful
- Added pre and post source effect bus sends types.
- Adjusted where in the source generation pipeline distance-based filtering is applied to a source. Source audio is sent to source buses immediately after source effect chain generation and before per-source distance-based filters are applied and distance attenuation.
Change 3762652 by Aaron.McLeran
Fix for device hot swap
Change 3762725 by Ethan.Geller
Fixing multichannel indices so that it matches the multichannel cook
Change 3762738 by Ethan.Geller
Add ambisonics plugin support
Change 3762739 by Ethan.Geller
Updating oculus audio plugin
- Base implementation by Peter Sterling at Oculus
- Ambisonics decoding using Oculus API implemented by Ethan
Change 3763687 by Martin.Wilson
Fix bug in GUID customization that leaves editor in an active transaction + Expose core property set code so other guid customizations can reuse it
#Jira UE-52510
Change 3764412 by Ethan.Geller
Fix the incremental build, pt 2
Change 3764721 by Ethan.Geller
Fix the build, take 3
Change 3764767 by Martin.Wilson
Rebuild array children properties when an item is added. Solves missing item crash if the user immediately tries to set the value of the new item
#Jira UE-52537
Change 3764845 by Aaron.McLeran
Making audio devices call flush after update and before endplay is called to ensure flush is called on audio devices.
Prevents hang on releasing sound wave procedural references in GC.
Change 3766047 by Thomas.Sarkanen
Pinnable command list widget
Added a new "pinnable command list" widget. Shift-clicking a menu option in either the skeleton tree filter or the viewport menus will 'pin' the command outside of the menu. This allows for easier access to commands that are frequently used.
Minor Slate change - added virtual(s) to FUICommandList so commands can be forwarded when executed.
#jira UE-51807 - Add 'quick filter' and visualization toggles UI to PhAT
Change 3766111 by Thomas.Sarkanen
CIS fix
Change 3766273 by Lina.Halper
Rename PostBlendPhysics to FinalizeAnimationUpdate
Change 3768507 by Thomas.Sarkanen
CIS fix
Change 3768637 by James.Golding
Add 'GetSectionFromProceduralMesh' util function
#jira UE-49262
Change 3768649 by Lina.Halper
Moved the automation test to tests folder
#jira:UE-46250
Change 3768675 by Benn.Gallagher
Fixed incorrect deprecated angular velocity accessor.
Change 3768776 by Benn.Gallagher
Fix for skeletal mesh editor crash importing more than 5 LODs
#jira UE-52263
Change 3768804 by Martin.Wilson
Live Link Virtual subjects
Virtuals subjects are created within the client and contain the bones of multiple real subjects
Change 3768874 by Martin.Wilson
UAnimSequenceBase is now entirely exported with ENGINE_API
#Jira UE-48020
Change 3769318 by Lina.Halper
- Animation system owns previous bone transform with revision number, so that it can send to renderer when render recreated.
- Framenumber still exists because clothing system uses it, and I'm planning to talk to Benn about it next week when he comes back
#jira: UEAP-272
Change 3769714 by Lina.Halper
Fix CIS
Change 3770672 by James.Golding
Expose API for changing 'Use CCD' flag at runtime
#jira UE-50332
Change 3770675 by James.Golding
Add test map for 'Set Use CCD' function
Change 3770711 by Thomas.Sarkanen
Multi viewports and bone-locked cameras in animation editor viewports
All animation-related editors now have the ability to open up to 4 seperate viewports onto the same scene, each with their own settings.
Fixed up bounds following to actually work correctly (now follows without lag).
Added the ability to follow (and orbit) a specified bone as well.
#jira UE-47127 - Add the Ability to Open Multiple Viewports on the Same Scene.
#jira UE-49690 - "Camera Follow" in Persona Editor cannot be enabled
Change 3770786 by Lina.Halper
Support curve in copy pose node
#jira: UE-50182
Change 3770943 by James.Golding
Fix 'NODEBUG' option for PVD CONNECT console command (should only send profile data)
Fix from Kier at NVIDIA
#jira UE-52444
Change 3771145 by Benn.Gallagher
Added ability to control whether or not a post process instance runs on a skeletal mesh component. Exposed both to blueprints and anim editor suite
#jira UE-49747
Change 3772262 by Benn.Gallagher
Defaulted the clothing create menu to use the skeletal mesh physics asset
#jira UE-51607
Change 3772389 by Thomas.Sarkanen
Added a keyboard shortcut to toggle between body and constraint selection
Shortcut is Ctrl+T by default.
#jira UE-51804 - Add a quick switch between selected constraints and bodies
Change 3772393 by Thomas.Sarkanen
Constraints are now displayed only once in the physics asset editor tree view
User constraints are still displayed twice, however.
#jira UE-51808 - Constraints in PhAT should only be displayed once in the tree
Change 3772404 by James.Golding
Fix Modify Curve AnimNode not calling CacheBones on source pose
#jira UE-52129
Change 3772418 by Benn.Gallagher
Allowed clothing visualizations to be enabled while clothing paint mode is active.
Fixed crash attempting to visualize backstops when the clothing data has no backstops.
#jira UE-47042
Change 3772964 by Thomas.Sarkanen
Expose sequence recording settings in Persona editors
Added layout extender to Persona module, so external tabs can now be added to all Persona-based editors easily.
Added a structure details view to edit the default animation settings.
Hooked default animation settings up to Persona animation recording.
#jira UE-48416 - Set Frame Rate and Length of Recordings in Persona in Editor
Change 3772967 by Martin.Wilson
Add NativeBeginPlay function to AnimInstance
#jira UE-51351
PR #4135: Add NativeBeginPlay to AnimInstance (Contributed by Vaei)
Change 3772986 by Thomas.Sarkanen
Added "Show Only Selected Constraints" to the physics asset editor
#jira UE-51805 - Add 'show only selected constraints' option to PhAT
Change 3773012 by Benn.Gallagher
Added facility to debug skel mesh component to extend the viewport text seen in skeletal mesh editor and added lines for current cloth value
#jira UE-42354
Change 3773132 by Martin.Wilson
Added Uncheck all unconnected pins for BreakStruct nodes
#jira UE-51136
PR #4110: Uncheck all unconnected pins from BreakStruct node... (Contributed by projectgheist)
Change 3773158 by Benn.Gallagher
Added auto-range feature to cloth view ranges, and a way for tools to extend those ranges when necessary
#jira UE-48109
Change 3773895 by Jurre.deBaare
Move material baking out of experimental
#fix Removed experimental settings gating around Material Baking functionality
#jira UE-52685
Change 3773898 by Jurre.deBaare
Change log message wording when Simplygon fails to initialise to ensure it does not block CIS (error triggers a CIS error and will halt the build)
Change 3773899 by Jurre.deBaare
Add keybind for switching between paint / erase color while mesh painting
#fix Added new command for switching fore and background colors in the mesh painter (defaults to X as shortcut)
#jira UE-52197
Change 3773900 by Jurre.deBaare
Hotkey to enable and disable post processing in the preview scene settings
#fix Added hotkey and command for toggling Post Processing in Preview Scenes
#jira UE-48111
Change 3773933 by Martin.Wilson
Add missing file (for live link monolithic build failure)
Change 3773949 by Jurre.deBaare
Right click add selected to HLOD cluster / create cluster
#fix Partially implemented the request, added context menu to HLOD level nodes in the HLOD outliner treeview to allow creating a new cluster from the current level viewport selection
#jira UE-48334
Change 3773950 by Jurre.deBaare
HLOD cluster drawing should not use AHLODSelectionActor but regular in-viewport drawing
#fix removed old behaviour using a spawned actor to represent a selected HLOD cluster, and replaced it will simple debug drawing (this is a lot less bug prone and much cleaner)
#jira UE-49094
Change 3773964 by James.Golding
Mark FBodyInstance::ResponseToChannels_DEPRECATED as 'WITH_EDITORONLY_DATA'
#jira UE-52545
Change 3773978 by Thomas.Sarkanen
Allow edits to physics sim options to be undone/redone
Added RF_Transactional to the object
#jira UE-48046 - Undo/redo does not work in Physics Asset Editor's Physics/Details menu
Change 3773982 by Martin.Wilson
Add pre and post conversion callbacks to root motion conversion in character movement component
#jira UE-51966
Change 3773988 by Thomas.Sarkanen
Duplicating CL 3773896 from Fortnite:
Push non-rendered anim updates back onto the worker thread
Now when meshes are set to EMeshComponentUpdateFlag::AlwaysTickPose, we optionally kick of a task to perform parallel update only (no evaluation).
#jira UE-46710 - Animation updates run on the main thread when Evaluation task doesnt run
Change 3773999 by Martin.Wilson
Fix incorrect merge
Change 3774030 by Thomas.Sarkanen
Renamed "Create Joints" to "Create Constraints"
#jira UE-50861 - New Physics Asset window reads "Joints" instead of "Constraint"
Change 3774031 by Thomas.Sarkanen
Fixed typo in comment
#jira UE-50841 - Typo in Vertex Weighting Type setting when creating new Physics Asset
Change 3774200 by Lina.Halper
Fix crash with empty element in the constraint setup
#jira: UE-52686
Change 3774236 by Ori.Cohen
Fix crash when destructible component doesn't mark its killed actors as IgnoreActiveActors
#jira UE-52320
Change 3774284 by James.Golding
Fix constructor order CIS error in AudioMicerSubmix.cpp
Change 3774511 by James.Golding
Fix up removed RevisionNumber param
Change 3774724 by Lina.Halper
Fix of motion blur change of previous bone transform
Change 3775493 by Thomas.Sarkanen
Duplicating CL 3775488 from Fortnite:
Prevented skeletal meshes that are not being ticked due to URO from dispatching tick tasks
#jira FORT-61157 - Run anim update on worker, even if not visible
Change 3775508 by James.Golding
Fix compilation without PhysX, move DeferredReleaseCallback outside WITH_PHYSX block
Change 3775538 by James.Golding
Fix Mac CIS due to missing virtual destructor in IDeferredReleaseCallback
Change 3775921 by Ori.Cohen
Better fix for destructible crash (also fix CIS)
#jira UE-52762
Change 3776054 by Benn.Gallagher
Fixed crash deleting max distance mask from a clothing data entry.
#jira UE-52723
Change 3776063 by Thomas.Sarkanen
Fix static analysis warning
Change 3776331 by Jurre.deBaare
Hierarchical LOD Outliner scrollbar doesn't appear
#fix removed AutoHeight from parent vertical box around HLOD outliner details view
#jira UE-52756
Change 3776704 by Martin.Wilson
Fix array properties not always refreshing when new items are added
#UE-52760
Change 3776755 by Thomas.Sarkanen
Duplicating CL 3776656 from Fortnite:
Fix notifies not getting fired in cases where AlwaysTickPose was set on skeletal mesh components
This was causing AIs to get stuck in montage playback in some circumstances
#jira FORT-61324, FORT-60558
Change 3777385 by Aaron.McLeran
#jira UE-52786 Fix for broken spatialization on xaudio2, old audio engine.
Change 3778233 by Lina.Halper
Removed android from oculus audio platform
Change 3778714 by Ethan.Geller
#jira UE-52818 remove Android from Oculus Audio platforms
Change 3779004 by Lina.Halper
Include "Features/IModularFeatures.h" to cpp
Fix build error
Change 3780324 by Thomas.Sarkanen
Duplicating CL 3778679 from Fortnite-Main:
Fix 100% Linux server crash - dont attempt to run threaded work in a single-threaded environment
We dont attempt to run animation update work multi-threaded in the same conditions that we didnt attempt to run animation eval work previously.
#jira FORT-61548
Change 3763999 by Ethan.Geller
remove space from ambisonics mixer name, fix build
Change 3774470 by James.Golding
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ 3774039
[CL 3780967 by Thomas Sarkanen in Main branch]
#lockdown Nick.Penwarden
#rb none
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3582363 by Marc.Audy
Make ComponentToWorld fully private and remove deprecation informing of this
#jira UE-46286
Change 3582885 by Ben.Zeigler
#jira UE-47642 Add ToString for SoftObjectReference/SoftClassReference/PrimaryAssetId/PrimaryAssetType to use for debugging. The other direction is not provided because the type validation cannot be done at runtime
Change 3584468 by Ben.Zeigler
#jira UE-48301 Avoid infinite recursion crash when cooking client/server only component blueprints
Change 3584596 by Marc.Audy
(4.17) Ensure that old user defined structs have their members properly marked as blueprint visible
#jira UE-48346
Change 3586057 by Ben.Zeigler
#jira UE-48413 Fix issue where running a dedicated server with a fixed framerate could cause a time crash because the "last time" was out of sync. Clarified code to indicate which times are real and which are logical. This manifested as a crash in EngineTest but could happen in any game with a fixed framerate
Change 3588211 by Marc.Audy
PR #3889: Added BLUEPRINTGRAPH_API module specifier to the input nodes. (Contributed by karanseqwb)
#jira UE-48318
Change 3588826 by Marc.Audy
Don't ensure when connecting the output pin of a create delegate node to a wildcard input
#jira UE-48157
Change 3588827 by Marc.Audy
Always throw error when unable to validate a link connection instead of allowing totally broken content to compile
Change 3588872 by Ben.Zeigler
#jira UE-48457 Add Export To CSV to content browser/asset audit windows that are in the column view. This is useful for preparing memory/disk usage reports
Change 3589134 by Dan.Oconnor
Mirror 3585244 from Release 4.17
Run actor construction via UBlueprint::BroadcastCompiled after reinstancing, matching non-compilation manager behavior
#jira UE-48189
Change 3589140 by Dan.Oconnor
Mirror 3588406 from Release-4.17
Set "WorldContext" metadata earlier in the compilation process, so that it can be used reliably in other blueprints. This fixes occasionally 'None' WorldContext references
#jira UE-48464
Change 3589141 by Dan.Oconnor
Mirror 3588681 from Release-4.17
Set Default values and CallInEditor meta data for event nodes
#jira UE-48386
Change 3590690 by Ben.Zeigler
#jira UE-48509 Fix crash in incremental cook when a file in the incremental cook was deleted from p4
Change 3590909 by Ben.Zeigler
#jira UE-48509 Fix crash in incremental cooker when DDC data is not built for a package that is skipped for rebuilding. The cached data would not be checked for completness, but would assert becuase it was not complete.
WillNeverCacheCookedPlatformDataAgain no longer does anything other than assert, so remove it.
Change 3591386 by Marc.Audy
Split pins are now correctly handled when expanding macros and functions.
#jira UE-47747
Change 3591939 by Dan.Oconnor
Mirror 3591923 from Release-4.17
Split ReplaceInstancesOfClass_Inner into two passes, one for objects and one for actors because actor reconstruction needs all components to be of final class type (e.g. not REINST_ or HOT_RELOAD_)
#jira UE-48250
Change 3593243 by Marc.Audy
PR #3910: Add FQuat initialization from FString (Contributed by cneumann)
#jira UE-48534
Change 3593407 by Marc.Audy
Properly expose Lex::To/FromString for FName
Change 3593648 by Marc.Audy
Refactor AActor::PostEditUndo to have a single implementation to avoid incosistent fixes
Change 3593917 by Marc.Audy
Improved comment
Change 3594501 by Marc.Audy
Fix biased shuffle algorithm
#jira UE-48432
Change 3594699 by Ben.Zeigler
#jira UE-48555 Fix crash where async loading flush update callback was happening in the async loading thread, it's supposed to be a game delegate
Fix InstancedStaticMesh to not ensure when loaded via the async loading thread
Change 3595327 by Phillip.Kavan
#jira UE-16485 - Add an option to host global Blueprint searches in a dockable tab that's not tied to any Blueprint editor context.
Change summary:
- Added a few additional Slate editor style descriptors specifically for the Find Results tab.
- Added a private dependency on the 'WorkspaceMenuStructure' module to the 'Kismet' editor module.
- Added a new Blueprint Editor settings option to the "Workflow" section to toggle the feature on/off (now set to 'on' by default).
- Added a UBluepriintEditorSettings::PostEditChangeProperty() implementation to reset FiB state upon changing the experimental toggle switch.
- Modified the FFindResultsSummoner ctor to use an alternate tooltip when the feature is turned on. In that case the "local" Find Results tab will always search only the local BP context.
- Modified FBlueprintEditor::OnRequestClose() to additionally find and close the local Find Results tab if the feature is turned on and we're not in a full BP editor context. This ensures that the local Find Results tab context will be reset to hidden if the option is toggled while a defaults-only BP editor context is active.
- Modified FBlueprintEditor::SummonSearchUI() to invoke the global Find Results tab if the feature is turned on and 'bSetFindWithinBlueprint' is true.
- Simplified FBlueprintEditor::FindInBlueprint_Clicked() and FBlueprintEditor::FindInBlueprints_OnClicked() to call SummonSearchUI().
- Moved the FFindInBlueprintsResult declaration into FindInBlueprintManager.h. Also relocated the ExpandAllChildren API out of this class and into the localized FindInBlueprintsHelpers util class.
- Added new FFindInBlueprintSearchManager public APIs - GetGlobalFindResults() and CloseAllGlobalResults(). Also added a delegate for handling cleanup after a global Find Results tab is closed.
- When the feature is turned on, global Find Results tabs will be named "Find in Blueprints" to correlate to the menu command that's bound to CTRL-SHIFT-F. An index will be appended to the tab name if more than one context is active.
- Extended FFindInBlueprintSearchManager to support spawning and maintaining up to 4 global Find Results widget contexts. These are registered and spawned as "nomad" tabs, but they don't currently auto-insert into the menu. Instead, they are invoked internally by the GetGlobalFindResults() API as needed, in response to the BP editor's "Find in Blueprints" command.
- Extended the SFindInBlueprints widget to support a "locked" state and allow users to toggle it via an SButton. This is visible only in the global Find Results context.
- Extended the SFindInBlueprints widget to support an additional "Find in All Blueprints" button on the local Find Results context. Clicking the button will invoke an unlocked global Find Results tab and initiate a global search with the text taken from the local context. This is visible only in the local Find Results context.
- Removed the "Find in Current Blueprint only" checkbox from the local Find Results context when the feature is enabled. Global searches are instead redirected to the global Find Results tab.
Change 3596499 by Marc.Audy
Fix non-editor CIS error
Change 3596653 by Marc.Audy
When a transaction is cancelled the previous redo buffer will now be restored instead of lost
#jira UE-48513
Change 3598187 by Ben.Zeigler
Add ability for automation command line to run as remote session with Automation StartRemoteSession (SessionGuid). In this mode it waits for external clients to be ready
Fix functional tests to work in editor builds with -game by forcing an asset registry scan
Change 3598193 by Ben.Zeigler
Add support for -TcpMessagingListen=IP:port and TcpMessagingConnect=IP:Port command line options to the TCP messaging layer, this is used by automation to connect a specific device to an editor coordinator.
Change 3600168 by Marc.Audy
(4.17.2) Protect against crash when ParentClass has become null for unknown reasons
#jira UE-47467
Change 3600457 by Ben.Zeigler
Fix issue where nonblocking BSD sockets on some platforms may return EINPROGRESS on initial connect, which should not be treated as an error
Change 3600462 by Ben.Zeigler
Remove platform whitelist from TcpMessaging plugin, this was effectively blocking it on all other platforms
Change 3600685 by Marc.Audy
(4.17.2) ParentClass is known to be able to be null if a class has been deleted without redirector. Allow the class to be marked deprecated under this circumstance.
#jira UE-47467
Change 3600859 by Marc.Audy
(4.17.2) Prevent error pop ups about failing to save world due to save on compile of blueprints
#jira UE-48672
Change 3600918 by Marc.Audy
Transient child actor components should create transient child actors.
#jira UE-48605
Change 3601012 by Ben.Zeigler
Fix TCP Messaging system to work better on non desktop by sleeping for some real time during the thread tick.
Add verbose logs and fix warning spam about thread stats being duplicated by renaming the thread per connection.
Change 3602595 by Marc.Audy
(4.17.2) PR #3930: Fix compiler error for PS4 if a nativized blueprint invokes a method of its own through interface (Contributed by hillin)
#jira UE-48684
Change 3602644 by Ben.Zeigler
Add game game thread asserts to streamable manager to track down possible async loading thread issues
Change 3602745 by Ben.Zeigler
Add Tolerance parameters to AssertEqual_Rotator and Transform, Vector and Float already had them
Change 3602807 by Phillip.Kavan
#jira UE-48426
- Fix runtime crash in a nativized child Blueprint that includes a parent function call node in a replicated function implementation.
Change summary:
- Modified FBlueprintCompilerCppBackend::EmitCallStatmentInner() to append the "_Implementation" postfix to parent RPC calls in a child class RPC implementation.
Change 3602856 by Ben.Zeigler
Fix fixed frame rate to be more stable by computing delta time as doubles, to avoid rounding issues
Change 3602903 by Marc.Audy
Allow Scale to be set on an AnimNotify as well as the spawn emitter gameplay statics
#jira UE-39362
Change 3602963 by Marc.Audy
PR #3762: DisableHaptics disables haptics properly (Contributed by projectgheist)
#jira UE-46960
Change 3603249 by Marc.Audy
Prevent compilation of a blueprint containing a child actor component to mark the blueprint the child actor's class dirty
#jira UE-43328
Change 3603311 by Ben.Zeigler
Add -nocodesign option to disable code signing during staging
Change 3603504 by Ben.Zeigler
#jira UE-27124 Fix crash during PIE by ensuring the world package PIE flag is always set, even if it's loaded via redirector
Change 3604790 by Marc.Audy
Fix inability to undo Add Pin via context menu to make container nodes.
#jira UE-48751
Change 3605079 by mason.seay
Renamed component from Cube to Cylinder, because it's actually a Cylinder
Change 3605113 by Mieszko.Zielinski
PR #3927: Fixed issue of behavior if setting InfiniteLoopTimeoutTime variable (Contributed by yhase7)
Change 3605276 by mason.seay
Fixed comment error in level bp
Change 3605706 by Zak.Middleton
#ue4 - Fix redundant GetDefault<>.
#jira none
Change 3605850 by Zak.Middleton
#ue4 - Fix client assert when trying to send RPCs while connection is pending closure due to queued bunches. ChIndex is -1 during this time, though the channel is not actually closed. Added ensure when calling SendBunch() under this condition to catch future cases like this.
(Mirror CL 3602849 in Fortnite)
#jira FORT-51215, UT-6139
Change 3607677 by Dan.Oconnor
Mirror 3597636 from Release-4.17
Don't clear UClass CDO until after we've duplicated the class, in case class duplication wants to read from the CDO (e.g. when duplicating a class that has ChildActorComponents)
#jira UE-48524
Change 3607704 by Dan.Oconnor
Back out changelist 3607677 - want to obliterate integration record
Change 3607727 by Dan.Oconnor
Mirror 3597636 from Release-4.17 - now with integrations converted to edits
Don't clear UClass CDO until after we've duplicated the class, in case class duplication wants to read from the CDO (e.g. when duplicating a class that has ChildActorComponents)
#jira UE-48524
Change 3607735 by Dan.Oconnor
Mirror 3606248 from Release-4.17
When copying data from old archetypes to new archetypes we want to use delta's from the old instances, but only when reliable (e.g. not CDO)
#jira UE-48697, UE-48465
Change 3607919 by Ben.Zeigler
#jira UE- 48815
Fix issue where StreamableHandle CompletedDelegate wasn't being reset after being called. If this had a payload pointing to the handle the handle would then be kept alive forever due to the reference counting, causing bad memory leaks
Copy of CL #3607743
Change 3608447 by mason.seay
Fixing deprecated node
Change 3608779 by Ben.Zeigler
#jira UE-48762 Do not rename a PIE world in place if it was loaded by redirector, this corrupts the redirector and later crashes if used again
Change 3609860 by Marc.Audy
Allow uint8:1 properties to be used as expose on spawn
#jira FORT-52043
Change 3609877 by Marc.Audy
Reduce size of UProperty and UWidgetBlueprintGeneratedClass by 8 bytes
Reduce size UBlueprintGeneratedClass by 32 bytes
#jira FORT-52043
Change 3609944 by Marc.Audy
Remove unused per instance physics create/destroyed delegates from UActorComponent (reduce size by 224 bytes)
Change 3610009 by mason.seay
Moving assets to another folder for organization
Change 3610840 by Ben.Zeigler
#jira UE-47351 Fix multiple launch ons inside the editor to correctly detect changed source files by refreshing the asset registry each time.
Packages are now always saved to disk before launch on so we just need to load the data off disk and then refresh the registry generators.
Change 3610961 by Ben.Zeigler
Fix it so when a test times out it writes out the full report with a proper error
Fix typo with ErrorCount
Change 3611183 by Marc.Audy
(4.17.2) Don't crash clicking the variable of a deleted component
#jira UE-47678
Change 3611262 by Ben.Zeigler
#jira UE-41412 Fix Delegate ImportText to check the outer chain for owning object before searching all packages, this fixes several issues with copy-pasting actors that have bound delegates
Change 3611667 by Phillip.Kavan
#jira UE-48450
- Fix UHT C++ codegen compile error (regression) after choosing to package with Blueprint nativization enabled if the project includes a converted User-Defined Structure asset.
Change 3612641 by Marc.Audy
Private StaticMesh, remove deprecation warning
Change 3612990 by Marc.Audy
Reduce memory footprint of UClass
Change 3613137 by Ben.Zeigler
#jira UE-44570 Fix issue with GUID struct customization where it would generate a post edit after modifying only the first element in the GUID, which caused the property handle to get invalidated
Change 3613161 by Ben.Zeigler
#jira UE-48372 Add InRange (Int) for Blueprints, and cleanup KismetMathLibrary.h comments
PR #3899
Change 3613192 by Ben.Zeigler
#jira UE-48366 PR #3895 Fix missing small icons within the blueprint Merge and diff tools
Change 3613320 by Mason.Seay
Submitting deleted redirectors
Change 3613321 by Marc.Audy
Shrink AActor 32 bytes
Change 3613326 by Marc.Audy
Move Serialize to be editoronly
Change 3613358 by Phillip.Kavan
#jira UE-48525 - Fix non-native script interface property value initialization for nativized Blueprint class default objects.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to special-case interface property values when emitting initialization code for converted class subobjects.
Change 3613827 by Marc.Audy
Combine material parameter caches of UMeshComponent in to a single sorted map instead of 3 independent maps (saves ~224 bytes)
Change 3613841 by Ben.Zeigler
#jira UE-48800 Fix crash with undoing blueprint changes while blueprint differ is open, it now listens for blueprint changes
Change 3614031 by Marc.Audy
Fix initialization order
Change 3614033 by Marc.Audy
Use Reset instead of Empty in get functions
Change 3615211 by Ben.Zeigler
Fix CIS warning
Change 3615386 by Ben.Zeigler
#jira UE-48976 Fix crash compiling user struct when out of date nodes point to it
Change 3615571 by Ben.Zeigler
#jira UE-48974 Fix crash trying to reconnect blueprint pins with null connections
Change 3615844 by Marc.Audy
(4.17.2) Reexpose WeightedBlendables/Post Process Materials to blueprints
#jira UE-48977
Change 3615887 by Marc.Audy
(4.17.2) Don't crash getting context menu actions if the variable get doesn't have a value pin
#jira UE-48970
Change 3615965 by Dan.Oconnor
Make sure that depedent blueprints are bytecode recompiled (e.g. child blueprints that are also dependent must also be bytecode recompiled), also no longer call RefreshNodes on dependent blueprints of interfaces, as this is no longer needed and can result in incoherent skeleton class hierarchies
#jira UE-48429, UE-48433, UE-48437, UE-48445, UE-48692
Change 3616149 by mason.seay
Updated BP for more thorough Find in BP testing
Change 3616261 by Dan.Oconnor
Mirror 3594264 and 3594798 from Release-4.17
Fix crash after compiling a blueprint that has an invalid ParentClass
#jira UE-48430, UE-48903
Change 3616816 by Zak.Middleton
#ue4 - Add GetTargetRotation() to SpringArmComponent, which returns the rotation target based on the combination of various rotation setting flags (bUsePawnControlRotation, bInheritPitch, bInheritYaw, bInheritRoll, absolute rotation flags).
#jira UE-48351
Change 3616934 by Phillip.Kavan
#jira UE-48877 - Close a disabled new-style global find tab if docked after restoring a previously-saved Blueprint editor layout.
Change summary:
- Modified FBlueprintEditor::PostLayoutBlueprintEditorInitialization() to close any active global tabs after restoring from a saved layout if the option is disabled.
Change 3616946 by Phillip.Kavan
#jira UE-48595 - Global FiB Results are now accessible through the main Window menu.
Change 3618007 by Marc.Audy
(4.17.2) Ensure that RootComponent is correct after undo/redo
#jira UE-48995
Change 3618014 by Phillip.Kavan
#jira UE-49025 - Fix global FiB menu item names.
Change 3618206 by Dan.Oconnor
Make sure instances in the same package as a UBlueprintGeneratedClass are properly created after the CDO
#jira UE-47991, UE-47726
Change 3618211 by Dan.Oconnor
Fix 'bad' USE_DEFERRED_DEPENDENCY_CHECK_VERIFICATION_TEST - this is only broken until we get the fix from core that restores CLASS_Intrinsic
Change 3618299 by Zak.Middleton
#ue4 - Fix comment in GetComponents (UActorComponent version)
#jira none
Change 3618409 by Marc.Audy
Make linker placeholder properly support map and set properties
#jira UE-48925
Change 3618436 by Marc.Audy
Fix shadow variable
Change 3618682 by Ben.Zeigler
Fix issue where pressing escape or losing focus while using a SpinBox would leave the UI in a state where the SpinBox could never be used again, caused by CL #3173966. Also fix the initial value to be correct the first time it is dragged
Change 3618783 by Ben.Zeigler
Fix several issues with the Component Transform details UI
#jira UE-48959 Fix it so the world/relative transform type bools are correctly propagated to inherited components when modified via editor customizations
#jira UE-48963 Refactor Transform customization to handle paste and reset to default as atomic operations, allowing them to work properly on blueprint component instances
#jira UE-48960 Correctly notify blueprint system when component transforms are changed
#jira UE-4311 Preserve exact rotation typed into component rotation field in most cases
Fix the "Reset to Defaults" icon to be correct in transform details
Change 3618904 by Ben.Zeigler
#jira UE-489999 Fix blueprint breakpoint crash when breakpoint data is out of date with UI
Change 3618984 by Zak.Middleton
#ue4 - Reduce memory churn/allocations when duplicating for PIE.
#jira none
Change 3619895 by Marc.Audy
Very minor cleanup
Change 3620129 by Marc.Audy
PR #3958: Exposing GetOwningPlayerController and GetOwningPawn as public in AHUD. (Contributed by ill)
#jira UE-49083
Change 3620350 by Lukasz.Furman
restored intended behavior of path following's acceptance radius: additive with goal and agent radii (included when FAIMoveRequest flags allow it)
copy of CL# 3618825, 3618828
#ue4
Change 3620628 by Zak.Middleton
#ue4 - Moved hardcoded limits on FCollisionShape extents to a static value and refactored external code to reference that instead.
Fixed Capsules where axis length (half-height - radius) < 1 were clamped to a new capsule with axis length of 1. Changed the clamp threshold to 1e-4 and changed FPhysXShapeAdaptor to use a Sphere instead when Radius >= HalfHeight.
This would cause sweeps using the capsule params to use a capsule of a different size, up to 1 UU different along the axis.
#jira UE-49035
Change 3620700 by Lukasz.Furman
moved blackboard decortator's version of requesting abort to parent class, so all decorators can use it with external events
#ue4
Change 3620716 by mason.seay
Test map for flow control save issue
Change 3620723 by mason.seay
Minor improvement
Change 3620792 by Ben.Zeigler
Clang doesn't like template specializations in classes, switch to an overload instead to fix CIS
Change 3621084 by Marc.Audy
Fix NegateInt/Float in StandardMacros
#jira UE-36242
#jira UE-36470
Change 3621152 by Marc.Audy
Fix backwards compatibility on FEdGraphPinType for particularly old blueprints.
#jira UE-49111
Change 3621246 by mason.seay
Test BP for UE-48800
Change 3621257 by Michael.Noland
Animation: Corrected a comment on the LegIK node
Change 3621480 by Zak.Middleton
#ue4 - Added FTransform::TransformRotation(FQuat) and FTransform::InverseTransformRotation(FQuat). Added matching Blueprint library functions taking FRotator.
#jira UE-39088
#github PR 2985 (modified)
Change 3621685 by Phillip.Kavan
#jira UE-49024 - Add/remove global FiB menu items from the Main Menu when the global FiB option is enabled/disabled.
Change summary:
- Added FFindInBlueprintSearchManager::EnableGlobalFindResults(). Now using this API to enable/disable both the Main menu items as well as the global FiB workflow change within the BP editor context.
- Renamed FFindInBlueprintSearchManager::CloseAllGlobalResults() to CloseOrphanedGlobalFindResultsTabs(). This is now being called to clean up any orphaned global FiB tabs when opening the BP editor context.
Change 3622629 by Marc.Audy
Reduce memory footprint of UMG/Slate classes: UWidget, UBorder, UImage, UUserWidget, SWidget, SButton, SOverlay, SBoxPanel, SInlineEditableTextBlock, FSlateFontInfo, EVisibility, FSlateBrush, FCheckBoxStyle, FButtonStyle, FComboBoxStyle
Change 3622779 by Zak.Middleton
#ue4 - Rename USceneComponent::bWorldToComponentUpdated to bComponentToWorldUpdated (since the transform is called ComponentToWorld).
#jira none
Change 3623020 by Marc.Audy
Fix initialization order
Change 3623021 by Marc.Audy
Reorganize USceneComponent to improve cache coherency
Change 3623261 by Ben.Zeigler
#jira UE-48555: Fix for corruption of shared pointers by the async loading thread. It is unsafe to copy delegates by value on the async loading threads because they may have shared pointers on them that are being used by the main thread. Instead of copying by value, we now allocate once on the game thread and copy by TUniquePtr.
Change 3623294 by Marc.Audy
Realign UActorComponent to avoid members crossing cache lines
Change 3623383 by Marc.Audy
Compress UParticleSystemComponent and fix up cases of members crossing cache lines
Change 3623492 by Marc.Audy
(4.17.2) Fix pin values on function nodes not correctly carrying the value between reloads/refreshes
#jira UE-49189
#jira UE-49196
Change 3623573 by Ben.Zeigler
#jira UE-49223 Fix crash when undoing changes to actors that have been recompiled. We need to skip most of PostEditUndo when the class is out of date and this got broken in a recent refactor
Change 3623642 by Dan.Oconnor
Make sure we don't attempt to defer exports that rely on CDOs that have been regenerated
#jira UE-49211
Change 3623719 by Marc.Audy
PR #3387: Added new Swap method (blueprint KismetArrayLibrary). (Contributed by RChehowski)
#jira UE-42970
Change 3624191 by Marc.Audy
Cache GetWorld()
Change 3624232 by Marc.Audy
Remove accidentally checked in change
Change 3624688 by Marc.Audy
PR #3491: Client play force feedback can now ignore time dilation. (Contributed by miracle7)
Force feedback component can also ignore time dilation
#jira UE-44155
Change 3624880 by Marc.Audy
PR #3970: SpawnObject not checking for a nullptr causing an editor crash
Change 3625740 by Mason.Seay
Check in the correct file this time...
Change 3625806 by Ben.Zeigler
#jira UE-48555 Code review fix for async loading thread fixes, disable an assert when cancel is called in non-EDL, and add comment + assert if Cancel is re-enabled for EDL in the future
Change 3626128 by Marc.Audy
Fix dragging off component tree in to graph showing an error message
#jira UE-49114
Change 3626655 by Ben.Zeigler
#jira OR-43846 Fix asset import objects to correctly load off disk again. They aren't marked as SubObjects so the special case code to add the NeedsLoad flag wasn't getting hit. Change it so in the editor it marks all unloaded subobjects as needs load, need to talk to Core about rather this fix should be editor specific or not
Change 3626740 by Marc.Audy
Fix compile errors when nativizing when a property references a sub object of a dervied type with modified default properties
#jira UE-49276
Change 3626831 by Marc.Audy
Remove BOM
Change 3627162 by Phillip.Kavan
#jira UE-49239 - Fix an invalid cast emitted to nativized codegen for converted AnimBP types.
- Regression introduced in CL# 3613358.
Change 3628051 by Marc.Audy
Fix spelling of redundant
#jira UE-49343
Change 3596437 by Marc.Audy
Don't copy metadata unnecessarily
Change 3613302 by Marc.Audy
Reduce size of UStaticMeshComponent by 224 bytes (cumulative, 56 bytes exclusive)
Reduce size of UPrimitiveComponent by 176 bytes (cumulative, 64 bytes exclusive).
Reduce size of USceneComponent by 112 bytes.
Reduce size of FLightingChannels from 3 bytes to 1.
Reduce size of FBodyInstance by 16 bytes.
Change 3620363 by Lukasz.Furman
split UBTTask_MoveTo.bStopOnOverlap flag to separate goal & agent parts to match actual parameters of AI move request, added simple versioning for behavior tree nodes
copy of CL# 3620248
#ue4
Change 3622569 by Marc.Audy
Remove unnecessarily deprecated visibility member and use redirect instead
Change 3624879 by Marc.Audy
Add a deprecated version of ClientPlayForceFeedback for backwards compatibility.
Adjust existing game calls to ClientPlayrForceFeedback to use new API
[CL 3628687 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
Please note that file comments had no purpose in nearly all cases and just added visual clutter. The two files that had meaningful file comments had their comments moved into the corresponding classes. There are still hundreds of file comments left in other files that will be removed over time.
Also cleaned up some random stuff along the way:
- relative paths to public headers within the same module are no longer necessary (automatically discovered by UBT now)
- header guards are deprecated, use #pragma once instead (all compilers support it now)
- space between multiple template brackets is no longer required (all compilers support >> now)
- NULL to nullptr, OVERRIDE to override
- spelling errors, whitespace, line breaks
[CL 2104067 by Max Preussner in Main branch]
Matt Kuhlenschmidt
JeanMichel Dignard
ryan durand
Cody Albert
Chris Gagnon
Ben Marsh
rex hill
Thomas Sarkanen
Marc Audy
Matthew Griffin
Max Preussner
Tim Sweeney