Commit Graph

51 Commits

Author SHA1 Message Date
ben hoffman
8488e2d403 Fix a crash when you connect a wildcard pin that has no owning node on it to a promotable operator Equals node. The function would hit a "Check" inside of the "GetOwningNode" function when dragging off of an "Enum Select" node.
Also added an ensure to make sure that the function doesn't crash when evaluating pin changes. This wasn't happening,  but it is preventative just in case.


#jira UE-146547
#rb phillip.kavan
#preflight 6239e3e0ec68595f3b85d4f5
#rnx

[CL 19467076 by ben hoffman in ue5-main branch]
2022-03-22 11:31:01 -04:00
leon huang
0193ffe8d3 Fix for CIS warnings for localization duplicate keys. Fixes simply involve changing one of the colliding localization keys.
#rnx
	#rb: Vincent.Gauthier
	#jira: UE-143620
	#preflight: 6222489d2f7d78332e121416
	#lockdown Mitchell.Wilson

#ROBOMERGE-AUTHOR: leon.huang
#ROBOMERGE-SOURCE: CL 19272838 in //UE5/Release-5.0/... via CL 19273134
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19275063 by leon huang in ue5-main branch]
2022-03-04 16:10:23 -05:00
dave jones2
a5311ebc31 UE-142401 - Dragging off a pin and adding a Real operator can break links to other nodes
We need to relax the rules for breaking pins when real numbers are used. We should maintain their connections since we implicitly perform casts between floats and doubles.

#jira UE-142401
#preflight 6215482730639b44d2fcf2a4
#rb ben.hoffman
#lockdown julien.marchand


#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 19093393 via CL 19093953 via CL 19094642 via CL 19096133 via CL 19105369
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146675 by dave jones2 in ue5-main branch]
2022-02-25 09:44:01 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
ben hoffman
07c6cf2596 Update connection message to clarify that a type is blacklisted from type promotion
#jira UE-123522
#rb phillip.kavan
#rnx

#ROBOMERGE-AUTHOR: ben.hoffman
#ROBOMERGE-SOURCE: CL 17559106 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17559111 by ben hoffman in ue5-release-engine-test branch]
2021-09-17 17:51:07 -04:00
ben hoffman
bc7c168058 During compilation of an Anim BP, if this node gets pruned then the outer will be the /Engine/Transient/ package, which will result in this node not having a valid SelfContext, so there is no need to set any further information based on this function as it will not be used.
This prevents an Ensure being hit in UK2Node_CallFunction::SetFromFunction which will cause cook failures.

#jira UE-116112
#rb phillip.kavan
#rnx
#preflight 60a579d3a5fa6d00013a749b

#ROBOMERGE-SOURCE: CL 16394619 in //UE5/Private-Frosty/...
#ROBOMERGE-BOT: STARSHIP (Private-Frosty -> Main) (v804-16311228)

[CL 16399667 by ben hoffman in ue5-main branch]
2021-05-20 03:38:47 -04:00
ben hoffman
83b70d39d7 Update comments about disallowing containers for promotable operators
#jira none
#rnx
#rb me

[CL 16193989 by ben hoffman in ue5-main branch]
2021-05-04 11:03:15 -04:00
ben hoffman
1196a92afd Only compare the pin category, subcategory, and subcategory object when considering connections to break. This stops the member reference being different causing a break
#jira UE-112716
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 15903632 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15907204 by ben hoffman in ue5-main branch]
2021-04-02 20:18:12 -04:00
ben hoffman
b4eac425d5 Fix "ctrl + drag" shortcut on promotable operators with multiple connections
Instead of always breaking the links witha promotable connection at the schema level, only break links if the most recent connection is a different type then before. This stops incorrect breaking of valid connections when there are multiple at a time while keeping a good UX.

#jira UE-109809
#rb phillip.kavan
#rnx
#preflight 6063773d4bf1970001c9b871

#ROBOMERGE-SOURCE: CL 15867103 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15867122 by ben hoffman in ue5-main branch]
2021-03-30 16:00:00 -04:00
ben hoffman
6ade1d9e15 Consider pins even if they have a non-modified default value. This allows for a more coherent pin conversion experience so that you do not have to enter a default value before converting a second pin.
#jira UE-109336
#rb me
#rnx

#ROBOMERGE-SOURCE: CL 15530991 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15530993 by ben hoffman in ue5-main branch]
2021-02-25 14:04:06 -04:00
ben hoffman
06c8ebd8ce Set the tolerance pin to hidden if necessary when converting pin types
#jira UE-109215
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 15507923 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15507937 by ben hoffman in ue5-main branch]
2021-02-23 17:51:47 -04:00
ben hoffman
f9cb896b4b Allow conversions on pins that are not wildcards
#jira UE-108863
#rb marc.audy
#rnx

#ROBOMERGE-SOURCE: CL 15493011 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15493012 by ben hoffman in ue5-main branch]
2021-02-22 15:43:31 -04:00
ben hoffman
43bf04be4f Fix invalid access exception when upgrading a regular math node to a promotable operator
#jira UE-107990
#rb trivial
#rnx

#ROBOMERGE-SOURCE: CL 15356363 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15360320 by ben hoffman in ue5-main branch]
2021-02-08 17:05:40 -04:00
ben hoffman
0fc3fe132a Do not break connection to boolean outputs when resetting nodes to wildcard
#jira UE-107610
#rb marc.audy
#rnx

#ROBOMERGE-SOURCE: CL 15340312 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15340524 by ben hoffman in ue5-main branch]
2021-02-05 15:06:50 -04:00
ben hoffman
1c85d99712 Do not display the Right Click + Convert pin type menu on comparison operator output pins, because the output is always a boolean and cannot be changed.
#jira UE-107616
#rb justin.hare
#rnx

#ROBOMERGE-SOURCE: CL 15320973 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15321295 by ben hoffman in ue5-main branch]
2021-02-04 15:10:41 -04:00
ben hoffman
dbce6a26b6 Type Promotion: Add a conversion option for promotable operators when they are in a wildcard state.
#jira UE-107516
#rb marc.audy
#rnx

[CL 15276861 by ben hoffman in ue5-main branch]
2021-02-01 19:47:28 -04:00
ben hoffman
a38ef7294e Make sure that comparison operators with only a bool connection refresh correctly
#rb trivial
#jira UE-107097
#rnx

[CL 15262474 by ben hoffman in ue5-main branch]
2021-01-29 16:08:52 -04:00
ben hoffman
11b0eb0429 Ensure that comparison operator's input pins are reset when an all inputs are discocnnected, but still allow the bool output to be connected.
#jira UE-107097
#rb fred.kimberley
#rnx

[CL 15211643 by ben hoffman in ue5-main branch]
2021-01-26 17:48:50 -04:00
ben hoffman
2be7a6492e Blueprints: Improve compiler messaging when an invalid operator is created via type promotion
#jira UE-106452
#rb phillip.kavan
#rnx

[CL 15211102 by ben hoffman in ue5-main branch]
2021-01-26 16:55:11 -04:00
ben hoffman
fcd04901be Blueprints type promo: Only search for a new function upon expansion if we need to, otherwise the function will have already been identified upon node consturciton. This is a small optimization and a bug fix for when int + float + int are given as inputs.
Add an early out when finding the best matching function where if none of the pins you are searching have a struct, then we will immedidately skip a UFunction with a struct param because it can't possibly be a match. This will help to avoid any mis-matches with complex struct types like quats and vectors.

#jira UE-104045
#rb trivial
#rnx

[CL 15077207 by ben hoffman in ue5-main branch]
2021-01-13 21:01:37 -04:00
ben hoffman
6ee13141f2 Remove unused conversion logic in the promotable operator node
#jira none
#rb me
#rnx

[CL 14947638 by ben hoffman in ue5-main branch]
2020-12-17 12:35:58 -04:00
ben hoffman
1075bccfed Blueprints: Do not allow enums to be connected to a promotable operator node, instead force the user to make a converision node to the type they want it to be considered as. This is similar to how you treat enums in C++ when doing operations on them, as you have to case an enum to another type in order to have them treated as numbers.
#jira UE-102544
#rb phillip.kavan
#rnx

[CL 14935394 by ben hoffman in ue5-main branch]
2020-12-15 17:53:40 -04:00
ben hoffman
58a5bf20c5 Blueprints: Do not allow connections to a promotable operator node if there is no existing function that would come of it
#jira UE-102484
#jira UE-103269
#jira UE-104176

#rb phillip.kavan
#rnx

[CL 14899212 by ben hoffman in ue5-main branch]
2020-12-10 13:39:52 -04:00
ben hoffman
4abe2efc60 Check the subobject type on struct pins to ensure that the they conform on promotable operator nodes
#jira UE-104199
#rnx
#rb me

[CL 14882308 by ben hoffman in ue5-main branch]
2020-12-08 16:35:52 -04:00