Commit Graph

437 Commits

Author SHA1 Message Date
Marc Audy
e2dd041c0f Fix static analysis warnings
#codereview Helge.Mathee
#rnx
#preflight

[CL 20618311 by Marc Audy in ue5-main branch]
2022-06-11 22:32:15 -04:00
Helge Mathee
f340a4f6ad Control Rig: Fix to run backwards compat code
#rb sara.schvartzman
#jira UE-155436
#preflight https://horde.devtools.epicgames.com/job/62a34936ec7332a25c9597a0

[CL 20594878 by Helge Mathee in ue5-main branch]
2022-06-10 10:03:01 -04:00
Helge Mathee
d76c4506cc RigVM: Maintain pin state during unresolve for pins that didn't change type
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/62a3059d2e1cc34f11d3b6c8

[CL 20593736 by Helge Mathee in ue5-main branch]
2022-06-10 08:18:43 -04:00
Helge Mathee
80dd846962 RigVM: Change order of arguments / pins to be based on super -> child struct
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/62a1fb0ae025a4126b6282ef

[CL 20591381 by Helge Mathee in ue5-main branch]
2022-06-10 03:42:15 -04:00
Helge Mathee
36d23803d4 RigVM: Allow access to custom widget also on template pins + use quotes correctly for template default arguments
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/62a1a7542875eb3c61751609

[CL 20573126 by Helge Mathee in ue5-main branch]
2022-06-09 05:58:28 -04:00
sara schvartzman
e66a608202 Control Rig: Fix wildcard pin errors when opening rig
#jira UE-156049
#rb helge.mathee
#preflight 62a08f6f232daff7b3d8f085

[CL 20555384 by sara schvartzman in ue5-main branch]
2022-06-08 09:14:51 -04:00
sara schvartzman
4f7e433c98 Control Rig: Change FRigVMTemplate to USTRUCT
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629f59a2233ae0a8f8f6bc99

[CL 20538399 by sara schvartzman in ue5-main branch]
2022-06-07 11:01:59 -04:00
sara schvartzman
d56d1f11b5 Control Rig: Fix unit test with undo/redo not passing
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629f56e085333f26644b81da

[CL 20537746 by sara schvartzman in ue5-main branch]
2022-06-07 10:33:38 -04:00
sara schvartzman
8759985e82 Control Rig: Fix undo deletion of template node not working
#jira UE-155296
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629e3b34ed51827842318c6b

[CL 20534600 by sara schvartzman in ue5-main branch]
2022-06-07 04:52:58 -04:00
sara schvartzman
566694cdc0 Control Rig: Fix crash when there are links between subpins and resolving to a different type
#jira UE-155292
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629dfaa541542e8cf66c84ed

[CL 20534552 by sara schvartzman in ue5-main branch]
2022-06-07 04:46:46 -04:00
sara schvartzman
936679001d Control Rig: Fix some templates not resolving
#jira UE-155584 UE-155585
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629e151d5d78bd7cf191426b

[CL 20534522 by sara schvartzman in ue5-main branch]
2022-06-07 04:43:09 -04:00
Helge Mathee
8695493f34 Control Rig: Allow events to be invoked from top toolbar and context menu
#rb benoit.gadreau
#jira UE-155696
#preflight https://horde.devtools.epicgames.com/job/6299ce559e55f868a0824819

[CL 20484545 by Helge Mathee in ue5-main branch]
2022-06-03 05:50:33 -04:00
benoit gadreau
22b49b4dd3 fixed discrepancy between struct subpins's value within the full struct default value and the subpin's real default value
Here is a simple example we could encounter (using FRigUnit_AimItem_Target)

the struct default's value looked like this "(Weight=1.000000,Axis=(X=1.000000,Y=0.000000,Z=0.000000),Target=(X=1.000000,Y=0.000000,Z=0.000000),Kind=Location,Space="")"
setting the Space default value to "" whereas the Space default value is an empty string.
Using "" as a default value would fail later in URigVMController::SetPinDefaultValue


#jira UE-152486
#rb helge.mathee
#preflight 6298b0051941378d7c6809b5

[CL 20468367 by benoit gadreau in ue5-main branch]
2022-06-02 08:58:42 -04:00
Helge Mathee
9c189267d5 ControlRig: user defined events and event invocation
#rb sara.schvartzman
#jira UE-153498 UE-153499
#preflight https://horde.devtools.epicgames.com/job/62975ffb2c618ddc66bb49a4

[CL 20453170 by Helge Mathee in ue5-main branch]
2022-06-01 11:28:01 -04:00
Helge Mathee
0edf08d7f8 RigVM: Invoke Entry functionality for the model
#rb benoit.gadreau
#jira UE-153498
#preflight https://horde.devtools.epicgames.com/job/629733a2ed7762ca42de8245

[CL 20450402 by Helge Mathee in ue5-main branch]
2022-06-01 05:56:08 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Marc Audy
1b70e12969 Fix non-unity
#preflight
#rnx

[CL 20442673 by Marc Audy in ue5-main branch]
2022-05-31 17:12:58 -04:00
Helge Mathee
40dbac202b RigVM: Restructure entry invocation for nativized VMs
#rb sara.schvartzman
#jira UE-153498
#preflight https://horde.devtools.epicgames.com/job/62962b08fe779f23c8e4d093

[CL 20441428 by Helge Mathee in ue5-main branch]
2022-05-31 16:18:09 -04:00
Helge Mathee
6520c809a9 Control Rig: backend work for support for multi graph
#rb benoit.gadreau
#jira UE-153497
#preflight https://horde.devtools.epicgames.com/job/6294be4e2e34c2e487b13394

[CL 20434781 by Helge Mathee in ue5-main branch]
2022-05-31 04:27:20 -04:00
Helge Mathee
d4934bf859 Control Rig: Allow change pin types on wildcard pins
#rb na
#jira na
#preflight skip

[CL 20430758 by Helge Mathee in ue5-main branch]
2022-05-30 10:01:57 -04:00
semion piskarev
b09efbe2a6 Fix link errors caused by RigVMPythonUtils.
#rb Helge.Mathee
#preflight 628d0285710271c31823419c

#ROBOMERGE-AUTHOR: semion.piskarev
#ROBOMERGE-SOURCE: CL 20351003 via CL 20351380 via CL 20351574
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20353622 by semion piskarev in ue5-main branch]
2022-05-24 15:20:08 -04:00
sara schvartzman
0937ada054 Control Rig: Fix select nodes not supporting arrays of arrays
#jira na
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/6287aa2e5b568e5761f505cc

[CL 20294487 by sara schvartzman in ue5-main branch]
2022-05-20 11:00:38 -04:00
sara schvartzman
38c72b07e2 Control Rig: Fix load of pre-template assets
#jira UE-153247
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6287664b1e478b95c7fbc926

[CL 20293516 by sara schvartzman in ue5-main branch]
2022-05-20 09:28:06 -04:00
sara schvartzman
6a719c2fcc Control Rig: Fix crash when undo/redo upgrade nodes
#jira UE-147278
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/628524452a7df8ed9f9e1424

[CL 20277521 by sara schvartzman in ue5-main branch]
2022-05-19 05:05:24 -04:00
sara schvartzman
47d4498fd6 Control Rig: Fix loading template nodes with wildcard pins
#jira UE-152862
#rb bob.tellez
#preflight https://horde.devtools.epicgames.com/job/628577d3890768f0e93e68b4

#ROBOMERGE-OWNER: bob.tellez
#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-COMMAND: _robomerge[bot4] UE5-MAIN
#ROBOMERGE-SOURCE: CL 20271485 via CL 20271505
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20271643 by sara schvartzman in ue5-main branch]
2022-05-18 19:49:22 -04:00