Commit Graph

29 Commits

Author SHA1 Message Date
Alexis Matte
a02efd7bfe Remove original reduction data. Use the source data and the build instead.
#jira UE-123770
#rb richard.talbotwatkin, danny.couture
#rnx
#preflight 614a2277b4b2fb0001a3e833

[CL 17587301 by Alexis Matte in ue5-main branch]
2021-09-21 16:04:32 -04:00
Josie Yang
a62f714a51 Morph target engine modifications for 3rd party plugin
#fyi alexis.matte, brian.white, christopher.waters, mihnea.balta, rolando.caloca, will.damon, halfdan.ingvarsson, kevin.ortegren

[CL 17444191 by Josie Yang in ue5-main branch]
2021-09-07 09:55:32 -04:00
alexis matte
b3c7cf086a Fix a collect garbage issue when loading skeletalmesh DDC. The repro step are simple but not repro easily, The issue happen when we load a map which load all asset and then unload the current map which trig a GC. At this point its possible all async SK cache not done.
#rb danny.couture
#preflight 6101a2cf0bf6fc0001387791


#ROBOMERGE-SOURCE: CL 16986908
#ROBOMERGE-BOT: (v838-16927207)

[CL 16987928 by alexis matte in ue5-main branch]
2021-07-28 17:22:22 -04:00
Andrew Davidson
3ddc3a4da3 Merge up from //UE5/Dev-LargeWorldCoordinates
#rb none

[CL 16211417 by Andrew Davidson in ue5-main branch]
2021-05-05 15:07:25 -04:00
Marc Audy
0cbbc781ca Merge UE5/Release-Engine-Staging @ 15740152 to UE5/Main
This represents UE4/Main @ 15709114

[CL 15740605 by Marc Audy in ue5-main branch]
2021-03-18 15:20:03 -04:00
danny couture
6929adbfaa Skeletal Mesh Async Compilation Framework (Phase 1)
Phase 1 adds the async compilation without introducing any higher-level awareness.
  This step provides the biggest performance improvements by allowing skeletal mesh to be compiled in
  multiple threads but stalls are expected to occur before the level has finished loading as soon as
  properties of skeletal meshes are accessed by the game-thread.

  - Make skeletal mesh reduction and renderdata building thread-safe where needed
  - Add protection on all USkeletalMesh accessors so the game-thread can wait on data still being built if needed
  - Modify both PostLoad and Build to be async when the feature is enabled
  - Make FRawSkeletalMeshBulkData::LoadRawMesh thread-safe
  - Fix some PropertyChangedEvent name comparison to use strongly typed GET_MEMBER_NAME_CHECKED
  - Add an experimental setting options to enable the feature (disabled by default for now)

DEBUGGING
 - Can be forcibly enabled/disabled through command-line via -asyncskeletalmeshcompilation=[off, on, paused]
 - Can pause skeletal mesh compilation using Editor.AsyncSkeletalMeshCompilation = 2 or -asyncskeletalmeshcompilation=paused
 - Can manually resume a specified amount of paused compilation using Editor.AsyncSkeletalMeshCompilationResume [Num]
 - Can forcibly wait on all compilation using Editor.AsyncSkeletalMeshCompilationFlushAll

BENCHMARKS
  Tested on AMD TR 3970X with 256GB RAM
  - 6m50s to 2m58s for loading P_Construct with a local-only DDC that doesn't contains any prebuilt skeletal mesh
  - 3m10s to 39s for importing 299 SK with the Interchange framework

TESTS
 - Opened all 5769 SK from FortniteGame to exercise all legacy conversion code paths
 - Opened all 102 SK from QAGame
 - Opened P_Construct, Apollo_Terrain, LumenTest, P_World
 - Imported 299 SK with and without Interchange activated
 - Ensure no new regression introduced in any of the 70 SK related tests from EngineTest
 - Run all FBX import test in EngineTest
 - Cook / Run ShooterGame Client

#rb Alexis.Matte

[CL 15452895 by danny couture in ue5-main branch]
2021-02-18 11:19:19 -04:00
Alexis Matte
cb0bb41e64 If migration is not able to reconnect a skeletalmesh skeleton, the engine will crash when loading the skeletalmesh and the user will not be able to re-assign the proper skeleton.
#jira none
#rb laurent.delayen

[CL 15397499 by Alexis Matte in ue5-main branch]
2021-02-12 10:15:20 -04:00
danny couture
4797b6f721 Add Insights tag in Skeleton Simplifier
#rb Alexis.Matte

[CL 14815856 by danny couture in ue5-main branch]
2020-11-26 10:04:22 -04:00
Alexis Matte
73d83c6a38 To protect the skeletalmesh when using async operations like build or re-import we deprecate all public member variables of USkeletalMesh class and create the necessary getter and setter. Those member will stay public but will be move to private in a future release.
Adding a public member to USkeletalMesh class is now prohibed since it can break asynchronous operations that will be added next to this submit.

#rb danny.couture
#jira UEENT-3936
#rnx

[CL 14812920 by Alexis Matte in ue5-main branch]
2020-11-25 11:17:08 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
alexis matte
c6e54bec17 Fix custom LOD workflow, the insert LOD into the base mesh function was not updated to work with the skeletalmesh refactor
#rb Benoit.deschenes
#jira UE-89848

#ROBOMERGE-SOURCE: CL 11825745 in //UE4/Release-4.25/... via CL 11825831
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v656-11643781)

[CL 11825857 by alexis matte in Main branch]
2020-03-02 11:26:42 -05:00
alexis matte
fe12264686 when building skeletalmesh, force the tangent and normal options to true if the source data do not have the tangents or normals data.
#jira UE-89567
#rb none

#ROBOMERGE-SOURCE: CL 11635503 in //UE4/Release-4.25/... via CL 11635506
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v655-11596533)

[CL 11635517 by alexis matte in Main branch]
2020-02-26 12:40:59 -05:00
Chris Gagnon
c3f9a18841 Merge from Main in prep for Dev-Tools-Staging Copy up
#rb none

[CL 11221539 by Chris Gagnon in Dev-Tools-Staging branch]
2020-02-04 17:00:31 -05:00
Alexis Matte
8f79f334db Fix ensure in CIS anti cheat build
#jira UE-87768
#rb none
#rnx

[CL 11200491 by Alexis Matte in Main branch]
2020-01-31 16:27:58 -05:00
JeanMichel Dignard
84facd6d15 Copy from dev-enterprise cl 11097196
#rb none
#rnx

[CL 11099277 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-23 16:28:59 -05:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
Chris Gagnon
346a4b05ea Copy up from Dev-Editor @10681378
#rb none

[CL 10837446 by Chris Gagnon in Dev-Tools-Staging branch]
2019-12-19 18:07:47 -05:00
alexis matte
d82e44b6ef Fix a crash when importing a skeletal mesh with no UVs
#rb none
#rnx


#ROBOMERGE-SOURCE: CL 10811603 via CL 10811607 via CL 10811615
#ROBOMERGE-BOT: (v610-10636431)

[CL 10811617 by alexis matte in Main branch]
2019-12-19 12:15:34 -05:00
alexis matte
a2cc56429b Fix asset build issue with faces material remap, in case there is no material into the imported fbx
#jira UE-85920
#rb benoit.deschenes
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 10809273 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v610-10636431)

[CL 10809277 by alexis matte in Main branch]
2019-12-19 09:54:39 -05:00
alexis matte
577af25417 Back out changelist 10765941
4.24.2 is not ready to receive submit
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 10766086 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v610-10636431)

[CL 10767321 by alexis matte in Main branch]
2019-12-17 13:13:27 -05:00
johan duparc
36be6588f6 Fix asset build issue with faces material remap, in case there is no material into the imported fbx
#jira UE-85920
#rb benoit.deschenes

#ROBOMERGE-OWNER: johan.duparc
#ROBOMERGE-AUTHOR: alexis.matte
#ROBOMERGE-SOURCE: CL 10765941 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v610-10636431)

[CL 10767305 by johan duparc in Main branch]
2019-12-17 13:12:55 -05:00
alexis matte
5f83395b23 Fix old asset build issue with faces material remap, in case there is some data missing
[FYI] bob.tellez


#ROBOMERGE-SOURCE: CL 10736131 via CL 10736209
#ROBOMERGE-BOT: (v610-10636431)

[CL 10736222 by alexis matte in Main branch]
2019-12-16 11:21:54 -05:00
bob tellez
9cfe60b745 #UE4 Quick fix for crash in content validation
[FYI] Alexis.Matte


#ROBOMERGE-SOURCE: CL 10728904 via CL 10728905
#ROBOMERGE-BOT: (v610-10636431)

[CL 10728906 by bob tellez in Main branch]
2019-12-15 23:58:44 -05:00