Commit Graph

213 Commits

Author SHA1 Message Date
jason stasik
2f70f25f8b Remove Create menu's "Blendables" category
#rb none
#preflight skip

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 20562597 via CL 20562617 via CL 20562632 via CL 20564119 via CL 20564319
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20567314 by jason stasik in ue5-main branch]
2022-06-08 19:06:39 -04:00
benoit deschenes
9e1786b97b Fixing ImportAssetTasks() not properly adding imported asset tot the FAssetImportTask results.
#rb Alexis.Matte
#review Alexis.Matte
#preflight 62a0aea1232daff7b3e149e3

[CL 20556590 by benoit deschenes in ue5-main branch]
2022-06-08 10:46:26 -04:00
robert manuszewski
f0e7ba910a Fixing up places that use FPathPermissionList with class paths. Added an optional EPathPermissionListType constructor param to catch places that pass short path names to FPathPermissionList when it's being used to store class path names
#rb Rex.Hill, Chris.Gagnon
#preflight 629a11d2474d2b43fca6b5c9

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20491615 via CL 20491621 via CL 20491633 via CL 20492092 via CL 20492224
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20495608 by robert manuszewski in ue5-main branch]
2022-06-03 19:15:26 -04:00
jason stasik
d238bcf377 Add global name filter across editor for asset paths
#rb dave.belanger
#preflight 6296ad96545b9a93abbddd73

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 20454648 via CL 20454680 via CL 20454686 via CL 20454689
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v952-20449836)

[CL 20460837 by jason stasik in ue5-main branch]
2022-06-01 18:12:39 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
jeanfrancois dube
ac948d0f28 World Partition: added support for advanced copy of partitioned worlds, but only when streaming is disabled.
#rb patrick.enfedaque
#preflight 62912a7fb83292836e14aab9

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 20398279 via CL 20400352 via CL 20400364 via CL 20400371
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20401642 by jeanfrancois dube in ue5-main branch]
2022-05-27 19:44:56 -04:00
tom noonan
f174a13ea8 Fixed Instances of a script in the world copied from a template will continue to use the template's version of the class
Originally prepared by markus.breyer with some additional fixes for some issues I was seeing while testing

[REVIEW] [at]markus.breyer, [at]robert.manuszewski

#ROBOMERGE-AUTHOR: tom.noonan
#ROBOMERGE-SOURCE: CL 20277717 via CL 20277723 via CL 20277728 via CL 20277731
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20278380 by tom noonan in ue5-main branch]
2022-05-19 07:41:50 -04:00
patrick enfedaque
01c2ef582d Rework 13645015:
- Only call FAssetRegistryModule::AssetCreated if necessary
- Call FAssetRegistryModule::AssetCreated before save so that saved packages doesn't end up with PKG_NewlyCreated flag

#rb bob.tellez
#preflight 627bf0630a5817c9d9525434

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 20146875 via CL 20147079 via CL 20147762
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20149912 by patrick enfedaque in ue5-main branch]
2022-05-11 16:55:57 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
jason stasik
3ce9c775a2 Allow separate permission lists for viewing and creating assets
#rb rex.hill
#preflight 62574684667d4516642224fa

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19760664 via CL 19762141 via CL 19762160 via CL 19762168
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19802156 by jason stasik in ue5-main branch]
2022-04-18 23:31:34 -04:00
johan torp
5c2624134d Optimize AssetTools AdvancedCopyPackages and add batch versions of ForceReplaceReferences and ConsolidateObjects
331s -> 0.28s to consolidate objects when cloning a small shooting range map

#rb Robert.Manuszewski,Chris.Gagnon,Francis.Hurteau,Jamie.Dale,JeanLuc.Corenthin,Phillip.Kavan

#ROBOMERGE-AUTHOR: johan.torp
#ROBOMERGE-SOURCE: CL 19507095 via CL 19507103 via CL 19507108 via CL 19507110
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19514683 by johan torp in ue5-main branch]
2022-03-25 12:41:16 -04:00
scott nelson
d33b4a0d71 Update create and duplicate behavior in Content Browser for Public/Private state
- API to control default behavior of whether newly created content is made public or private on creation
- Ensure duplication copies original's Public/Private state

#rb Francis.Hurteau
#preflight 623b6f07da56b5683a0b56a4

#ROBOMERGE-OWNER: scott.nelson
#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19485709 via CL 19487498 via CL 19498786 via CL 19498791
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v936-19480137)

[CL 19501393 by scott nelson in ue5-main branch]
2022-03-24 15:44:12 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00
philippe deseve
8218e80ef1 UDataLayer deprecated in favor of UDataLayerInstance & UDataLayerAsset
UDeprecatedDataLayerInstance allows to boot level using deprecated UDataLayers
Worlds using DataLayer can run the DataLayerToAssetCommandlet to transition their existing DataLayers
FActorDataLayer interface is deprecated.
DataLayers Blueprint referencers should now use DataLayerAsset to retrieve DataLayerInstances.
DataLayer Code referencers should now use DataLayerAssets or DataLayerInstance FName to retrieve DataLayerInstances.
DataLayerLabels now only used for display/UI purpose
Relabeling DataLayers is not permitted anymore on new DataLayerInstances (allowed on UDeprecatedDataLayerInstance)
Added Changelist Validation for DataLayers
Added a column to the datalayer outliner showing any data layer errors.

#rb richard.mal jeanfrancois.dube
#preflight 623098c2050dc69468b6a297 (errors only related to lyra, which do not exist in this stream)

#ROBOMERGE-OWNER: philippe.deseve
#ROBOMERGE-AUTHOR: philippe.deseve
#ROBOMERGE-SOURCE: CL 19385808 via CL 19387392
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19389077 by philippe deseve in ue5-main branch]
2022-03-15 13:52:28 -04:00
charles bloom
07d079e290 fix multiple asset importers registered at same priority creates random inconsistency
ImgMedia and normal texture import both registered for EXR
would randomly import one or the other on different runs of Editor
adjust priorities so they are not ambiguous
also add detection and logging to prevent this

#rb Julien.StJean
#preflight 622f441c6131e07703a04ed5

[CL 19373316 by charles bloom in ue5-main branch]
2022-03-14 11:34:50 -04:00
michael noland
674afabc53 Editor: Added a fixup redirectors option that *doesn't* delete the redirectors afterwards, which can be useful for cleaning up a project while others are still actively working and might have created new references to the renamed object
#jira UE-143408
#rb lauren.barnes
#lockdown julien.marchand
#preflight 62215f872c722ee170e2ac96

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 19258824 in //UE5/Release-5.0/... via CL 19259128
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263827 by michael noland in ue5-main branch]
2022-03-04 04:10:21 -05:00
geoff evans
bd2a5c3af2 Detect broken Blueprint assets and abort Migration if they are included.
The condition here mimics the condition we use when we advise caution about opening the Blueprint Editor on the same assets.

Use Force Delete to null out references and unload assets so we can delete the package files that Migrate generated.

#rnx
#rb steve.robb
#jira UE-142833
#preflight 62100735eb1ea1b2cce404d1

[CL 19103703 by geoff evans in ue5-main branch]
2022-02-23 17:53:45 -05:00
geoff evans
1f87d3a2fd Second pass on SlowTask dialogs for Migrate.
Move LoadAssets to after the UI prompts for the UX benefit.

#rnx
#rb trivial
#preflight 620e84137d6fd1dfc4525eae
#jira UE-142832

[CL 19036708 by geoff evans in ue5-main branch]
2022-02-17 12:31:56 -05:00
geoff evans
f2a3a563a1 Treat Engine content more intelligently when Migrating/Consolidating assets.
### AssetTools
Check each package's mount point and fold that against each Plugin's LoadedFrom (Project or Engine)
If Engine content is visible in the Content Browser, show but do not schedule Engine Plugin content for Migration
Add support for sending in "ShouldMigratePackage" state to SPackageReportDialog

### SPackageReportDialog
Remove "Active" state -> this dialog used to associate Disabled tree item state with the state of not Migrating a package. Just rely on the check state to dictate if a package will be Migrated
Add support for indeterminate checkbox state for folders within the dialog when some, but not all, children being selected for migration
Add logic for initial check/indeterminate/unchecked state and when check state changes on an item
Propagate check state up the hierarchy from the check change event item

#rnx
#rb rex.hill
#jira UE-142543
#preflight 620d6a3926435e00d2de7d3f

[CL 19023118 by geoff evans in ue5-main branch]
2022-02-16 16:36:47 -05:00
geoff evans
9dce602b34 Add SlowTask dialogs, Fix cleaning up temp assets
#rnx
#rb trivial
#preflight 620c232a565043444cacf7a4
#jira UE-142832, UE-142833

[CL 19005530 by geoff evans in ue5-main branch]
2022-02-15 17:37:11 -05:00
geoff evans
3026b21079 Migrate: Fix flattening of assets into the target folder during consolidate
DuplicateObjects takes the destination path very literally, flattening objects to a single folder. Instead, loop over all the objects, calculate the correct relative path, and duplicate the objects one-by-one.

#rnx
#rb rex.hill
#preflight 620be74c475fb819ddc7c756
#jira UE-142545

[CL 18999816 by geoff evans in ue5-main branch]
2022-02-15 13:50:24 -05:00
Alexis Matte
5a6a855dcd Scene node will now only serialize the local transform, all SetGlobalTransform functions has been removed.
Fix scene import when there is no specified factory
The scene node specialtype attribute can now be a "Transform" type. This allow the generic scene pipeline to found group transform node.

#jira none
#rb jeanmichel.dignard, richard.talbotwatkin
#rnx
#preflight 62066e4054003c49ad37c388

[CL 18951547 by Alexis Matte in ue5-main branch]
2022-02-11 09:16:05 -05:00
JeanMichel Dignard
0a111a1b4e Interchange
- Interchange now adds its supported extensions to the import and import into level file pickers.
- Added a GetSupportedFormats on the Interchange Translators.
- UInterchangeTranslatorBase::CanImportSource now defaults to checking the file extension and matching it against the supported formats.
- Added a translator type on the translators to indicate what type of data they can translate (assets or actors for now). This is used by the file pickers to indicate which extensions they want to gather.
#preflight 6203eaca174d2620c3c11d9b

[CL 18919107 by JeanMichel Dignard in ue5-main branch]
2022-02-09 11:43:32 -05:00
geoff evans
1358c3138b Support for migrating selected assets and their dependencies that are inter-referential across content roots.
Assets spread across content roots are migrated into the corresponding content root in the destination, if it exists. If any don't exist, migrate the selection and dependencies to temporary packages into a folder that is migrated to the destination.

== Notes ==

AssetTools.h/cpp
* Remove OriginalRoot filtering down reference gathering to objects in the selected object package's content root (opens up the routine to migrating plugin content)
* Trawl the set of objects to migrate and compare their content root against the available content roots in the destination project's plugin directory hierarchy
* If some plugins are missing from the destination, prompt the user to consolidate everything into a temporary folder
* If the user selects to consolidate we duplicate objects and fixup references to those duplicates, and save those packages to a folder named by the user
* If necessary copy those temporary packages to the destination content root
* Tidy up any temporary packages saved into the source project

[FYI] michael.noland
#rb francis.hurteau
#jira UE-115684
#preflight 61f4720f6b5aea38e5c653e5

#ROBOMERGE-AUTHOR: geoff.evans
#ROBOMERGE-SOURCE: CL 18779963 in //UE5/Release-5.0/... via CL 18780829 via CL 18781338
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18781642 by geoff evans in ue5-main branch]
2022-01-28 19:47:50 -05:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00