Commit Graph

71 Commits

Author SHA1 Message Date
Matt Chapman
cd4cfcd8d0 Static analysis issue with Engine/Plugins/VirtualProduction/RemoteControl/Source/WebRemoteControl/Private/WebSocketMessageHandler.cpp
#jira UE-156841
#rb Simon.Therriault
#preflight 62ab41eb5c69124c40841018
#preflight 62ab41eb5c69124c40841018

[CL 20687951 by Matt Chapman in ue5-main branch]
2022-06-16 11:32:10 -04:00
Matt Chapman
f891d6366e Update to allow remote control presets to exist within other assets and toolkit hosts (not level editor.)
#jira none
#rb jeremie.roy
#preflight 62aa4871da0af39a475a0b65

[CL 20677397 by Matt Chapman in ue5-main branch]
2022-06-15 17:50:19 -04:00
Denys Dubinin
9f5ce23bde [UE-156705] Quality of Life upgrades for Logic UI
Featuring:

* Rename Controller [UE-156717] - Provides ability to rename Controllers via API support and Rename UI command.

* Controllers Table - header & resizing support

~~~

[Rename Controller]

Functional notes:
* Provides rename via F2 key (UI command). Rename via RMB Context Menu wiill be part of a subsequent CL.
* Web API has been updated in this CL to support using the user-friendly Controller name (renamed by users as desired) rather than the internal proprety name (which is currently immutable, see impl notes below)

Impl notes:
* Added a new property DisplayName to VirtualProperty class to support specifiying user frienedly Controller Names.
* I deemed this preferrable to modifying the underlying PropertyBag description because that approach will reallocate memory for all the Controllers each time the user tries to rename even just one. This is due to the way PropertyBag is designed (each collection of properties is conidered as a unique type with a specific hash value.The entire set is reallocated if any modification is made to the property bag).

[Controllers Table]
* Used Header Rows for automatic resizing
* Preferred over using manual splitter (as in EP list), no issues noted thusfar
#preflight 62a9e27962552c58ff1a3401

[CL 20669482 by Denys Dubinin in ue5-main branch]
2022-06-15 10:11:39 -04:00
Elliot Colp
1d4f299a33 [WebRemoteControl] WebSocket API for generating DisplayCluster previews
#jira: UE-141883
#rb: Alejandro.Arango
#preflight 62a0e5f7593ebacf17dd4053

[CL 20562205 by Elliot Colp in ue5-main branch]
2022-06-08 15:11:48 -04:00
Denys Dubinin
44f104bcb7 ~ Remote Control Logic Web API ~
UE-155855

For manipulating Controllers through HTTP requests

The following routes have been added:

1. SetPresetController - Set the value of a Controller (on a Remote Control Preset asset).
  HTTP Parameters: Preset Name, Controller Name, Body: JSON;
   Example:
  (PUT) http://127.0.0.1:30010/remote/preset/PresetNameParam/controller/SomeBoolController
  Body (raw JSON):  { "PropertyValue": false}

2. GetPresetController - Fetch the value of a Controller (on a Remote Control Preset asset).
  HTTP Parameters: Preset Name, Controller Name, Body: None
   Example:
  (GET) http://127.0.0.1:30010/remote/preset/PresetNameParam/controller/SomeBoolController
  HTTP Response:  { "PropertyValue": false}

Interception support has been provided as well by adding an nDispaly cluster implementation.

Pending work:
Unit tests for new route handlers to be added to RemoteControlIntereceptionTest.cpp. Review will be updated with this.
#preflight 62a0cca0232daff7b3f55c21

[CL 20559126 by Denys Dubinin in ue5-main branch]
2022-06-08 12:57:13 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Marc Audy
f9445fed38 Initialize TransactionIds
#jira UE-153291
#codreview Elliot.Colp
#rnx
#preflight

[CL 20376151 by Marc Audy in ue5-main branch]
2022-05-26 00:50:44 -04:00
Elliot Colp
5dd755610e [WebRemoteControl] Move manual transaction timeout to a CVar
#jira: UE-151340
#rb: Alejandro.Arango
#preflight 6288165a7e018d20dc195123

[CL 20304652 by Elliot Colp in ue5-main branch]
2022-05-20 18:44:31 -04:00
Elliot Colp
e0a67fef06 [WebRemoteControl] Don't mix together struct fields when sending property updates
#jira: UE-151340
#rb: Alejandro.Arango, Jeremie.Roy
#preflight 6287ca731e478b95c729b852

[CL 20299104 by Elliot Colp in ue5-main branch]
2022-05-20 14:04:44 -04:00
Elliot Colp
39825987c5 [WebRemoteControl] Add WebSocket routes to control when transactions are created
#jira: UE-151340
#rb: Alejandro.Arango
#preflight 6286d359cf5ac7317c494b5a

[CL 20289121 by Elliot Colp in ue5-main branch]
2022-05-19 19:41:12 -04:00
Elliot Colp
9d7db4bdb1 [WebRemoteControl] Send property update messages for the same type as a single batch
Remove tracked actors when world is destroyed and ignore tracking for actors outside the current editor world
#jira: UE-151340
#rb: Alejandro.Arango, Jeremie.Roy
#preflight 62853fac882a1e5cd78f6ee3

[CL 20266375 by Elliot Colp in ue5-main branch]
2022-05-18 15:18:41 -04:00
Elliot Colp
eef6986449 [EpicStageApp] Control lightcard color from app
#jira: UE-141884
#rb: Alejandro.Arango
#preflight 62697595d575958d55350727

[CL 19943049 by Elliot Colp in ue5-main branch]
2022-04-27 13:46:15 -04:00
Elliot Colp
138f63687c [EpicStageApp][WebRemoteControl] Automatically clean up transient preset when stage app disconnects
#jira: UE-141884
#rb: Alejandro.Arango
#preflight 6262daa1e87284a93cd65fa1

[CL 19867119 by Elliot Colp in ue5-main branch]
2022-04-22 12:53:44 -04:00
Elliot Colp
6a41fa5551 [WebRemoteControl] Fix sequence number in property change events always being -1
#jira: UE-141884
#preflight 62589125946114248dc6fdce

[CL 19763967 by Elliot Colp in ue5-main branch]
2022-04-14 17:42:35 -04:00
Elliot Colp
f4cb1d3797 [WebRemoteControl] WebSocket routes to set preset properties and batch messages.
Added sequence numbers to preset property update messages. Clients can send a sequence number when changing a property via WebSocket, and the property updates will include the latest received number for the corresponding client.
#jira: UE-141884
#preflight 62576fc7d606fd159eaac78e
#preflight 625773d6e00a35b48f4f5b30

[CL 19749452 by Elliot Colp in ue5-main branch]
2022-04-13 21:26:03 -04:00
Elliot Colp
bfa4d1b1f2 [WebRemoteControl] Wait until WebSocket server is initialized to bind routes
#preflight 624f92a17255d8c1695ceffc

[CL 19683496 by Elliot Colp in ue5-main branch]
2022-04-07 21:56:18 -04:00
Elliot Colp
72f79eacaa [WebRemoteControl] Add transient presets, routes to expose/unexpose preset properties, and delta API for presets
#jira: UE-141884
#preflight 62477538637925b5d3e45145

[CL 19596663 by Elliot Colp in ue5-main branch]
2022-04-01 18:09:12 -04:00
Patrick Gross
1d51127065 Add: Loginpage Throwback
#jira UE-145117
#rb simon.therriault
#rb amir.keren
#preflight 624709e9b6084b983257bf31

[CL 19588475 by Patrick Gross in ue5-main branch]
2022-04-01 10:49:53 -04:00
Elliot Colp
7250b42b48 [WebRemoteControl] Change actor websocket subscription to split events by subscribed class
#jira: UE-141880
#preflight 6245d434b33098a72dcca377

[CL 19574336 by Elliot Colp in ue5-main branch]
2022-03-31 12:35:37 -04:00
Elliot Colp
fe37304550 Epic Stage App: Increase TTL for discovery socket and reopen if closed. Add magic number to beacon. Lock to landscape orientation.
#rb: Alejandro.Arango
#preflight 623cc56b9f11d3c73945b56f

[CL 19501582 by Elliot Colp in ue5-main branch]
2022-03-24 15:51:45 -04:00
Alejandro Arango
bdc236dde6 RemoteControl: Have the multicast beacon listener join the multicast group on all interfaces instead of just the default interface (0.0.0.0).
With this, Unreal instances running on PCs with multiple interfaces, including VPNs, can receive the multicast beacon packet from the tablet device when the default interface is not in the corresponding subnet.

#fyi elliot.colp
#jira
#rb none
#preflight 6234ebb0b43f22036e144784

[CL 19441102 by Alejandro Arango in ue5-main branch]
2022-03-18 16:49:46 -04:00
Elliot Colp
faa98fb9b3 Add websocket route for subscribing/unsubscribing to actor add/delete/rename events
#jira: UE-141886
#preflight 623399e2e12e0da4a532646a

[CL 19426603 by Elliot Colp in ue5-main branch]
2022-03-17 16:33:39 -04:00
patrick gross
09f3bc958f Fix Initialization Issue
#jira UE-145120
#rb simon.therriault
#preflight 6228af84695c94f981cf8777
#lockdown simon.tourangeau
#rnx

#ROBOMERGE-AUTHOR: patrick.gross
#ROBOMERGE-SOURCE: CL 19320188 in //UE5/Release-5.0/... via CL 19320951
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19348007 by patrick gross in ue5-main branch]
2022-03-10 21:49:42 -05:00
Patrick Gross
47717024e8 Taking Fix from Initialization Error in Release-5.0
#jira UE-145120
#rb simon.therriault
#preflight 6228c99a695c94f981d364e9

[CL 19320599 by Patrick Gross in ue5-main branch]
2022-03-09 10:58:34 -05:00
simon therriault
2e288b6fe8 Potential Security Issue, Login Screen
Have addeda a FHttpRequestHandler as a RequestPreprocessor which checks whether or not an Requests Header has a corresponding ApiKey to allow the execution, using MD5 hashing to obscure it a bit.
This affects Http Calls and Websocket Calls. Changes Wrapped RCWebsocketRequest to allow holding hashed ApiKeys from the outside. Mainly hooked as an additional Handler in WebRemoteControl.

#jira UE-139210
#rb simon.therriault, amir.keren
#preflight 622113f2c7262e0e538118cf
#lockdown alejandro.arango

#ROBOMERGE-OWNER: simon.therriault
#ROBOMERGE-AUTHOR: patrick.gross
#ROBOMERGE-SOURCE: CL 19252881 in //UE5/Release-5.0/... via CL 19257182
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263496 by simon therriault in ue5-main branch]
2022-03-04 03:45:11 -05:00