Featuring:
* Rename Controller [UE-156717] - Provides ability to rename Controllers via API support and Rename UI command.
* Controllers Table - header & resizing support
~~~
[Rename Controller]
Functional notes:
* Provides rename via F2 key (UI command). Rename via RMB Context Menu wiill be part of a subsequent CL.
* Web API has been updated in this CL to support using the user-friendly Controller name (renamed by users as desired) rather than the internal proprety name (which is currently immutable, see impl notes below)
Impl notes:
* Added a new property DisplayName to VirtualProperty class to support specifiying user frienedly Controller Names.
* I deemed this preferrable to modifying the underlying PropertyBag description because that approach will reallocate memory for all the Controllers each time the user tries to rename even just one. This is due to the way PropertyBag is designed (each collection of properties is conidered as a unique type with a specific hash value.The entire set is reallocated if any modification is made to the property bag).
[Controllers Table]
* Used Header Rows for automatic resizing
* Preferred over using manual splitter (as in EP list), no issues noted thusfar
#preflight 62a9e27962552c58ff1a3401
[CL 20669482 by Denys Dubinin in ue5-main branch]
UE-155855
For manipulating Controllers through HTTP requests
The following routes have been added:
1. SetPresetController - Set the value of a Controller (on a Remote Control Preset asset).
HTTP Parameters: Preset Name, Controller Name, Body: JSON;
Example:
(PUT) http://127.0.0.1:30010/remote/preset/PresetNameParam/controller/SomeBoolController
Body (raw JSON): { "PropertyValue": false}
2. GetPresetController - Fetch the value of a Controller (on a Remote Control Preset asset).
HTTP Parameters: Preset Name, Controller Name, Body: None
Example:
(GET) http://127.0.0.1:30010/remote/preset/PresetNameParam/controller/SomeBoolController
HTTP Response: { "PropertyValue": false}
Interception support has been provided as well by adding an nDispaly cluster implementation.
Pending work:
Unit tests for new route handlers to be added to RemoteControlIntereceptionTest.cpp. Review will be updated with this.
#preflight 62a0cca0232daff7b3f55c21
[CL 20559126 by Denys Dubinin in ue5-main branch]
A recent engine change deprecating the ANY_PACKAGE requires that we use the fully qualified path to the Enum class while using FindObject.
#preflight 62a0c65efc5ffe569a620570
[CL 20558260 by Denys Dubinin in ue5-main branch]
#jira UE-155440
* Base implementation of UI for Controllers, Behavior, Actions
* Additional changes for UI Conformance to Figma
* Further revisions will bring implementation of any UI functionality missing or incomplete in the original prototype.
#preflight 6297a7819907cbadba985a17
[CL 20455574 by Denys Dubinin in ue5-main branch]
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]
#jira UE-146247
Added new function to URCVirtualPropertyBase class:
* CopyCompleteValue - Provides support for copying the controller value onto a given FProperty. This will be used the RC Web API's GetPresetController route.
#preflight 628bd9d2183c1e134645e40a
[CL 20335117 by Denys Dubinin in ue5-main branch]
