Commit Graph

238 Commits

Author SHA1 Message Date
helen yang
730b1615b1 Various MetaSound Editor UX improvements for member defaults and selection
- Add Metasound editor setting for default input widget type
- Change member default type from bool to float
- Make widgets only available for inputs (no longer for variables)
- Automatically select/focus newly added/promoted nodes
- Selecting a single node selects the corresponding member in the graph member list if applicable

#jira UE-156767
#jira UE-156772
#rb rob.gay
#preflight 62aa1a77da0af39a474e8975

[CL 20688866 by helen yang in ue5-main branch]
2022-06-16 12:30:27 -04:00
helen yang
d6db6c9a5b Fix null MetaSound output literal on graph synchronization
#jira UE-156020
#rb rob.gay
#preflight 62a8ec38db45e64426994b0d

[CL 20656548 by helen yang in ue5-main branch]
2022-06-14 16:28:46 -04:00
helen yang
c89bb29047 Update MetaSound presets when an interface is deleted from the original MetaSound
#jira UE-156249
#rb rob.gay
#preflight 62a232981a21ec565ca23e88

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 20585969 in //UE5/Release-5.0/... via CL 20586638
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20588092 by helen yang in ue5-main branch]
2022-06-09 20:28:06 -04:00
helen yang
8a4ffabb2e Fix MetaSound connection splines not visible for new connections while playing when using animated connections
#jira UE-155953
#rb rob.gay
#preflight 629e821b580328634327edc2

[CL 20578969 by helen yang in ue5-main branch]
2022-06-09 12:29:32 -04:00
robert manuszewski
146ed02930 Fixing crash when selecting Wave Asset combo box/dropdown menu of Wave Player node (ANY_PACKAGE removal fallout)
#jira UE-155759
#rb none
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20552834 via CL 20552836 via CL 20552843 via CL 20552848 via CL 20552850
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20553108 by robert manuszewski in ue5-main branch]
2022-06-08 03:36:45 -04:00
alfaroh corneyiii
a529a60f27 Replace short asset name from DisabledClasses set with Top Level Path Name
#jira UE-155759
#rb helen.yang rob.gay
#preflight 629e6d216e36d50d05222fd4

[CL 20528204 by alfaroh corneyiii in ue5-main branch]
2022-06-06 17:22:51 -04:00
helen yang
e1212fd424 Update all MetaSound Frontend class input properties when adding a input node
#rb phil.popp
#jira UE-155825
#preflight 629a9012551457c8ddf5ee2c

[CL 20495167 by helen yang in ue5-main branch]
2022-06-03 19:06:14 -04:00
phil popp
c49dfb1c4d MetaSound: Add constructor inputs / outputs to frontend nodes
#rb Helen.Yang
#jira UE-151659, UE-151662
#p4v-preflight-copy 20381225
#preflight 6298ca1eb72f596b0fcb2f07

[CL 20469618 by phil popp in ue5-main branch]
2022-06-02 10:50:07 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Rob Gay
b3b1847b7f MetaSound animated connection optimizations/minor improvements
- Don't copy point array, just add wrapped accessor for simple FloatWindow
- Move to drawing lines instead of a bunch of bubble images
- Add max number of draw segments
- Add cvars for tweaking
- Split out numeric & envelope thickness options
#rb helen.yang
#jira UE-153987
#rnx
#preflight 62967f0a9d75300f41bdb820

[CL 20444237 by Rob Gay in ue5-main branch]
2022-05-31 19:05:10 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
jimmy smith
2093834e8d Fixed up TObjectPtr for Metasounds as I had warnings as errors on
#rb rob.gay
#jira none
#preflight 628fc3ff74630984fd46f137

[CL 20383257 by jimmy smith in ue5-main branch]
2022-05-26 15:06:53 -04:00
helen yang
bfeda1bb29 Fix MetaSound editor meter channel count being incorrect resulting in incorrect meter values for mono sources
#jira UE-153872
#rb rob.gay
#preflight 628d0a79710271c31824286e

[CL 20356800 by helen yang in ue5-main branch]
2022-05-24 17:55:21 -04:00
alfaroh corneyiii
b17e186979 "Using Native Audio" Telemetry
#jira UE-151075
#rb rob.gay helen.yang
#preflight 628c08e4183c1e1346577d5a

[CL 20341003 by alfaroh corneyiii in ue5-main branch]
2022-05-23 18:58:53 -04:00
helen yang
1a31dac048 Properly update MetaSound node positions when nodes are moved with comment nodes or by alignment actions
#jira UE-147971
#rb rob.gay
#preflight 6287e90a7e018d20dc0de915

[CL 20334468 by helen yang in ue5-main branch]
2022-05-23 14:56:04 -04:00
Rob Gay
3ab1010fde Fix for implicit bool cast with MetaSound boolean connection animation throwing build warnings
#rb trivial
#jira UE-153318
#rnx
#preflight 6287efa88828ea88c87d1448

[CL 20302347 by Rob Gay in ue5-main branch]
2022-05-20 16:29:01 -04:00
Rob Gay
ca643f250e MetaSound Editor Analyzer Checkpoint
#rb helen.yang
#jira UE-147027
#rnx
#preflight 62855a90614041edb7a54d23

[CL 20285298 by Rob Gay in ue5-main branch]
2022-05-19 15:24:49 -04:00
lauren barnes
4b82e918fa Replacing legacy EditorStyle calls with AppStyle
#rb header and class name replacement

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20078276 via CL 20078825
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106316 by lauren barnes in ue5-main branch]
2022-05-09 13:51:26 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
helen yang
b981fe0d20 Non unity fix in SMetasoundGraphPin
#rb trivial
#preflight 62683ede853fdb6fddc4b33e
#jira UE-150252
#rnx

[CL 19926906 by helen yang in ue5-main branch]
2022-04-26 15:38:48 -04:00
phil popp
b0380ec246 Metasound Frontend Search Engine Memory Improvements
- Split out search engine into Core functionality and EditorOnly functionality
- Removed some ISearchEngine integration in the INodeController
- Fixed up callsites that were relying on EditorOnly ISearchEngine functionality on non-editor builds.
#jira UE-147632
#rb Aaron.McLeran
#preflight 626709dc0231ca6c0d8d892e

[CL 19908865 by phil popp in ue5-main branch]
2022-04-25 16:59:41 -04:00
helen yang
8795e3fedb Add type colors + icons to Metasound member list and stub in editor side for constructor pins
- Fix color for Time:Array type

#jira UE-148269
#jira UE-148862
#rb rob.gay
#preflight 62631545006fa20b683e7a91

[CL 19905171 by helen yang in ue5-main branch]
2022-04-25 13:29:29 -04:00
rob gay
36046a26c9 Fix crash when attempting to synchronize a MetaSound that has yet to be initialized/missing a graph reference.
#jira https://jira.it.epicgames.com/browse/UE-149182
#rb helen.yang
#preflight 6262cd49bc24759dc73b02c5

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19867459 in //UE5/Release-5.0/... via CL 19872455
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19875442 by rob gay in ue5-main branch]
2022-04-22 18:16:24 -04:00
phil popp
50012d952e Fix for MetaSound ensure loading CitySample
#jira UE-148531
#rb Maxwell.Hayes
#preflight 625f07d99c09ef439d9f53f7

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 19818787 in //UE5/Release-5.0/... via CL 19820506
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19827829 by phil popp in ue5-main branch]
2022-04-20 08:17:42 -04:00