Commit Graph

708 Commits

Author SHA1 Message Date
helen yang
730b1615b1 Various MetaSound Editor UX improvements for member defaults and selection
- Add Metasound editor setting for default input widget type
- Change member default type from bool to float
- Make widgets only available for inputs (no longer for variables)
- Automatically select/focus newly added/promoted nodes
- Selecting a single node selects the corresponding member in the graph member list if applicable

#jira UE-156767
#jira UE-156772
#rb rob.gay
#preflight 62aa1a77da0af39a474e8975

[CL 20688866 by helen yang in ue5-main branch]
2022-06-16 12:30:27 -04:00
alfaroh corneyiii
e255fd13b4 Fix Compressor Node's Wet/Dry Functionality
#jira UE-156405
#rb aaron.mcleran phil.popp
#preflight 62aa8834f77a5c078588a738

[CL 20680195 by alfaroh corneyiii in ue5-main branch]
2022-06-15 21:53:48 -04:00
Marc Audy
7653e6cf37 Fix non-unity issues in light of CL# 20648535
#fyi Phil.Popp
#rnx
#preflight

[CL 20665802 by Marc Audy in ue5-main branch]
2022-06-15 01:43:38 -04:00
helen yang
d6db6c9a5b Fix null MetaSound output literal on graph synchronization
#jira UE-156020
#rb rob.gay
#preflight 62a8ec38db45e64426994b0d

[CL 20656548 by helen yang in ue5-main branch]
2022-06-14 16:28:46 -04:00
phil popp
2fadfa51ec Audio signal processing cleanup
- Removing need for alignment in audio DSP.
- Decreased header dependencies across codebase to improve build times
- Fixed improper `using namespace` issues.
#jira UE-147590
#rb Helen.Yang, Alfaroh.Corneyiii
#preflight 62a789bd2c521c9c6dac7bb6

[CL 20648535 by phil popp in ue5-main branch]
2022-06-14 10:44:07 -04:00
helen yang
c89bb29047 Update MetaSound presets when an interface is deleted from the original MetaSound
#jira UE-156249
#rb rob.gay
#preflight 62a232981a21ec565ca23e88

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 20585969 in //UE5/Release-5.0/... via CL 20586638
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20588092 by helen yang in ue5-main branch]
2022-06-09 20:28:06 -04:00
helen yang
8a4ffabb2e Fix MetaSound connection splines not visible for new connections while playing when using animated connections
#jira UE-155953
#rb rob.gay
#preflight 629e821b580328634327edc2

[CL 20578969 by helen yang in ue5-main branch]
2022-06-09 12:29:32 -04:00
robert manuszewski
146ed02930 Fixing crash when selecting Wave Asset combo box/dropdown menu of Wave Player node (ANY_PACKAGE removal fallout)
#jira UE-155759
#rb none
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20552834 via CL 20552836 via CL 20552843 via CL 20552848 via CL 20552850
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20553108 by robert manuszewski in ue5-main branch]
2022-06-08 03:36:45 -04:00
alfaroh corneyiii
a529a60f27 Replace short asset name from DisabledClasses set with Top Level Path Name
#jira UE-155759
#rb helen.yang rob.gay
#preflight 629e6d216e36d50d05222fd4

[CL 20528204 by alfaroh corneyiii in ue5-main branch]
2022-06-06 17:22:51 -04:00
Rob Gay
57c51888f0 Fix string format for warning
#rb trivial
#jira UE-147220
#fyi sondra.moyls
#preflight skip

[CL 20526615 by Rob Gay in ue5-main branch]
2022-06-06 16:02:11 -04:00
helen yang
e1212fd424 Update all MetaSound Frontend class input properties when adding a input node
#rb phil.popp
#jira UE-155825
#preflight 629a9012551457c8ddf5ee2c

[CL 20495167 by helen yang in ue5-main branch]
2022-06-03 19:06:14 -04:00
phil popp
c49dfb1c4d MetaSound: Add constructor inputs / outputs to frontend nodes
#rb Helen.Yang
#jira UE-151659, UE-151662
#p4v-preflight-copy 20381225
#preflight 6298ca1eb72f596b0fcb2f07

[CL 20469618 by phil popp in ue5-main branch]
2022-06-02 10:50:07 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Rob Gay
7ecfe9175e Fix for missing enum ensure through second missed ctor
#rnx
#jira UE-147220
#rb trivial
#preflight 629681bb5238916c514b3b97

[CL 20444298 by Rob Gay in ue5-main branch]
2022-05-31 19:10:07 -04:00
Rob Gay
b3b1847b7f MetaSound animated connection optimizations/minor improvements
- Don't copy point array, just add wrapped accessor for simple FloatWindow
- Move to drawing lines instead of a bunch of bubble images
- Add max number of draw segments
- Add cvars for tweaking
- Split out numeric & envelope thickness options
#rb helen.yang
#jira UE-153987
#rnx
#preflight 62967f0a9d75300f41bdb820

[CL 20444237 by Rob Gay in ue5-main branch]
2022-05-31 19:05:10 -04:00
Aaron McLeran
75d30b02e5 Fixing tooltip loctext namespace
#rb none
#jira none
#preflight none

[CL 20444203 by Aaron McLeran in ue5-main branch]
2022-05-31 19:00:48 -04:00
Aaron McLeran
0c4b32c059 Changing display name of PitchShift node to "delay pitch shift"
#rb none
#jira none
#preflight none

[CL 20443100 by Aaron McLeran in ue5-main branch]
2022-05-31 17:50:00 -04:00
Aaron McLeran
ae9ca7c01f Grain Delay Node
- Fix for compressor for limiter case (removed unncessarily clamp on detector output)

#jira UE-150598
#rb Dan.Reynolds, Maxwell.Hayes, Jimmy.Smith
#preflight 6291227bbc1213abd7dc43bd

[CL 20442694 by Aaron McLeran in ue5-main branch]
2022-05-31 17:14:23 -04:00
anna lantz
f01df4a3ab Fix for generator nodes behaving incorrectly when given negative frequencies
#jira UE-152354
#rb phil.popp
#preflight 62853718614041edb79f8bb0
#p4v-cherrypick 20265411
#preflight 628eceb7a3384b0a96b92c64

#ROBOMERGE-AUTHOR: anna.lantz
#ROBOMERGE-SOURCE: CL 20404406 in //UE5/Release-5.0/... via CL 20406514
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20406985 by anna lantz in ue5-main branch]
2022-05-28 07:36:47 -04:00
aaron mcleran
9f6bbe1698 Trigger route fix
#jira UE-146466, UE-153239
#rb Maxwell.Hayes
#preflight 6290f6166c4b4192f2a1bb9e

#ROBOMERGE-OWNER: aaron.mcleran
#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 20395550 in //UE5/Release-5.0/... via CL 20398380
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20401217 by aaron mcleran in ue5-main branch]
2022-05-27 19:30:23 -04:00
Aaron McLeran
d2bc4d3555 Trigger route fix part 2
- Better fix, CL 20297675 introduced

#jira UE-146466, UE-153239
#rb Maxwell.Hayes
#preflight 6290f6166c4b4192f2a1bb9e

[CL 20395031 by Aaron McLeran in ue5-main branch]
2022-05-27 12:53:21 -04:00
phil popp
8efec09fb3 MetaSound: Add vertex access type to frontend document in order to support constructor pins.
#jira UE-151659
#preflight 628ff53e8c077c0d6628377b

[CL 20386454 by phil popp in ue5-main branch]
2022-05-26 17:59:27 -04:00
jimmy smith
b987fbbe0e Fix for Cook warning/content validation
#preflight none

[CL 20384864 by jimmy smith in ue5-main branch]
2022-05-26 16:32:38 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
jimmy smith
2093834e8d Fixed up TObjectPtr for Metasounds as I had warnings as errors on
#rb rob.gay
#jira none
#preflight 628fc3ff74630984fd46f137

[CL 20383257 by jimmy smith in ue5-main branch]
2022-05-26 15:06:53 -04:00