Commit Graph

117 Commits

Author SHA1 Message Date
robomerge
6ca47eae1d GFP State machine
- Only do a GC in Deactivating or Unloading states if the final destination state is the same as the state they are transitioning to, otherwise do all GC in Unregistering state.
- When a transition requires a GC, the transition now waits until the GC is complete.
[REVIEW] [at]Bob.Tellez [at]Michael.Noland [at]Graeme.Thornton
#preflight https://horde.devtools.epicgames.com/job/62549441845ab4b0b4a825ed

#ROBOMERGE-AUTHOR: justin.marcus
#ROBOMERGE-SOURCE: CL 19719368 via CL 19720296 via CL 19720305 via CL 19720325
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19721931 by robomerge in ue5-main branch]
2022-04-12 11:30:30 -04:00
justin marcus
c2248089fc Minor GFP stuff:
Reduce boiler-plate when adding GFP states.
EGameFeaturePluginState no longer must be cast to int when accessing state array.
Fix private header GameFeaturePluginStateMachine.h being directly included by other modules.
[REVIEW] [at]Bob.Telez
#preflight 62542e69f4122c9e9af0a698

#ROBOMERGE-OWNER: justin.marcus
#ROBOMERGE-AUTHOR: justin.marcus
#ROBOMERGE-SOURCE: CL 19706165 via CL 19707821 via CL 19707964 via CL 19707978
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19708767 by justin marcus in ue5-main branch]
2022-04-11 13:33:21 -04:00
dave belanger
d117af116b Game feature system reads optional GameFeaturePluginURL json field on uplugin dependencies prior to defaulting to a file protocol URL
#rb Bob.Tellez
#preflight skip

#ROBOMERGE-OWNER: dave.belanger
#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 19653840 via CL 19655007 via CL 19656686 via CL 19656701
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19658832 by dave belanger in ue5-main branch]
2022-04-06 19:22:24 -04:00
ben zeigler
ace797f72f Add support for preloading data registries and sources in the editor when a game feature is registered instead of waiting for full activation, this will show the valid keys in the picker UI but can result in false positives for accesses in PIE
This is currently opt-in with PreloadInEditor on the game feature action
A more advanced version of this would be to add a completely separate editor preview registration mode, but it is currently difficult to separate editor accesses from PIE ones
#jira UE-131533
#rb Aidan.McInerny
#preflight 624618fdb6084b98324dce2e

#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 19580233 via CL 19580248 via CL 19580250
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19580846 by ben zeigler in ue5-main branch]
2022-03-31 19:32:30 -04:00
dave belanger
592baefedc GameFeaturesSubsystem
- Add IsGameFeaturePluginRegistered
- Remove unimplemented GetPluginFilenameFromPluginName
#rb Josh.May
#preflight skip

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 19575770 via CL 19577903 via CL 19578893 via CL 19579170
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19580671 by dave belanger in ue5-main branch]
2022-03-31 19:26:30 -04:00
robomerge
121bb9bbc4 Fix UGameFeaturesSubsystem::LoadGameFeatureData when the specified asset exists but isn't a GameFeatureData
#rb Matt.Peters
#preflight 62421277637925b5d39b4b31

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 19542243 via CL 19542253 via CL 19542259 via CL 19542269
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19544207 by robomerge in ue5-main branch]
2022-03-29 12:44:31 -04:00
wouter burgers
3217b35e31 Fixed 'files(s) -> file(s)' typo's in code and comments.
#jira none
#review-19507050
#preflight 623dbe0b9f11d3c739504676

[CL 19524850 by wouter burgers in ue5-main branch]
2022-03-28 05:50:13 -04:00
bob tellez
b595f7eaf8 Merging CL#19387281
#UE AddCheats now soft references its extension classes. They can be either sync or async loaded at activation time

#jira nojira
#rb Michael.Noland

#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 19373453 in //Fortnite/Release-20.10/... via CL 19373488 via CL 19387360
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19388398 by bob tellez in ue5-main branch]
2022-03-15 13:17:08 -04:00
mic rooney
864415d8bb Fixing crash on editor shutdown in GameFeaturesEditorModule
[REVIEW] [at]Rex.Hill

#ROBOMERGE-AUTHOR: mic.rooney
#ROBOMERGE-SOURCE: CL 19180525 via CL 19182030 via CL 19182915 via CL 19184919
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19206848 by mic rooney in ue5-main branch]
2022-03-01 16:36:54 -05:00
josh may
d72ef8c2c0 Updated GameFeatureStateChangeObserver callbacks to more consistently include a PluginURL parameter.
[REVIEW] [at]cory.kolek [at]justin.marcus [at]aidan.mcinerny [at]nathan.green
#preflight 620e8576242ff267d476e7ce

#ROBOMERGE-OWNER: josh.may
#ROBOMERGE-AUTHOR: josh.may
#ROBOMERGE-SOURCE: CL 19093998 via CL 19095194 via CL 19100402 via CL 19101468 via CL 19109910
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147252 by josh may in ue5-main branch]
2022-02-25 10:11:05 -05:00
michael noland
9bc6fcdfa5 Added support for game feature plugins being created in extension directories
- Missing file from fix for UE-142358
#jira UE-142830
#rb bob.tellez
#preflight 620c0d16475fb819ddcbeea6
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 19058900 in //UE5/Release-5.0/... via CL 19074378
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076507 by michael noland in ue5-main branch]
2022-02-22 13:48:41 -05:00
dave belanger
e6e332160a Add UGameFeaturesSubsystem::IsGameFeaturePluginLoaded
#rb Bob.Tellez
#preflight skip

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 19003273 via CL 19005075 via CL 19005904 via CL 19006347 via CL 19008132 via CL 19008741
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 19009916 by dave belanger in ue5-main branch]
2022-02-15 22:32:14 -05:00
michael noland
1c4be102f5 Added support for game feature plugins being found or created in extension directories
#jira UE-142358
#rb bob.tellez
#preflight 6206b383c663666c89ad78aa
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18958246 in //UE5/Release-5.0/... via CL 18958861 via CL 18959965
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18960287 by michael noland in ue5-main branch]
2022-02-11 15:38:36 -05:00
michael noland
6c41af9c64 Made game feature plugins created via the plugin wizard set EnabledByDefault=false, since the game feature subsystem will manage when they are enabled or not
#jira UE-142050
#preflight 62046703e54ab7c24b98c99b
#rb bob.tellez
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18945322 in //UE5/Release-5.0/... via CL 18946220 via CL 18946582
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18946584 by michael noland in ue5-main branch]
2022-02-10 18:49:16 -05:00
michael noland
5a1fc7f1aa Prevent a crash on shutdown if the UObject system has already been torn down by the time we shut down the game features editor
#jira UE-140123
#preflight none

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18750550 in //UE5/Release-5.0/... via CL 18750557 via CL 18750694
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18750697 by michael noland in ue5-main branch]
2022-01-27 00:48:29 -05:00
richard wallis
eae678f228 Use plugin name or override name not the GameFeature name. Was changed in CL 18653855. IAssetTools::CreateAsset() [UAssetToolsImpl::CreateAsset()] expects the first parameter to be a name not feature type description.
#jira UE-139835
[REVIEW] [at]mic.rooney,  [at]will.damon
#rb mic.rooney,  will.damon
#preflight 61f14b1cfc74f46b563a0de2

#ROBOMERGE-AUTHOR: richard.wallis
#ROBOMERGE-SOURCE: CL 18734738 in //UE5/Release-5.0/... via CL 18734752 via CL 18734840
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18734848 by richard wallis in ue5-main branch]
2022-01-26 09:03:01 -05:00
ben zeigler
b4014ece49 Second checkin of CL 18679680 now that the bad data is fixed:
Redo fix to allow game features to load both absolute and plugin-relative paths for asset manager types
Reimplementation of CL 15419795 which got lost in a merge, was pointed out by a licensee
#rb michael.noland
#jira none
#preflight 61eb03d0c557ec20018bbe7d

#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 18693936 in //UE5/Release-5.0/... via CL 18693978 via CL 18694021
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18694050 by ben zeigler in ue5-main branch]
2022-01-21 14:42:09 -05:00
mark lintott
2e1a7cc25b Undo //UE5/Release-5.0/Engine/Plugins/Experimental/GameFeatures/Source/GameFeatures/Private/... changelist 18679680
Backout for Lyra Cook failure. Now results in a warning instead..
#rb none
[FYI] ben.zeigler
#jira none
#preflight 61ea8862445cebac10bd9c3f

#ROBOMERGE-AUTHOR: mark.lintott
#ROBOMERGE-SOURCE: CL 18687690 in //UE5/Release-5.0/... via CL 18687899 via CL 18687932
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18687977 by mark lintott in ue5-main branch]
2022-01-21 06:48:28 -05:00
ben zeigler
7d696b138a Redo fix to allow game features to load both absolute and plugin-relative paths for asset manager types
Reimplementation of CL 15419795 which got lost in a merge, was pointed out by a licensee
[FYI] michael.noland
#jira none
#preflight 61e9c17b8876205adc236de6

#ROBOMERGE-AUTHOR: ben.zeigler
#ROBOMERGE-SOURCE: CL 18679680 in //UE5/Release-5.0/... via CL 18679890 via CL 18680437
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18680772 by ben zeigler in ue5-main branch]
2022-01-20 16:01:20 -05:00
eric knapik
c110bffb7f #jira: none
content worker compiler fix.

#preflight skip

#ROBOMERGE-OWNER: eric.knapik
#ROBOMERGE-AUTHOR: eric.knapik
#ROBOMERGE-SOURCE: CL 18653588 via CL 18664596 via CL 18665576 via CL 18665887 via CL 18666343 via CL 18666359 via CL 18668071
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v901-18665521)

[CL 18668225 by eric knapik in ue5-main branch]
2022-01-19 18:24:06 -05:00
mic rooney
fe33411371 Missed pragma once in header declaration.
#ROBOMERGE-AUTHOR: mic.rooney
#ROBOMERGE-SOURCE: CL 18659944 via CL 18662873 via CL 18664324 via CL 18664736 via CL 18665105 via CL 18666001 via CL 18666093 via CL 18666139
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v901-18665521)

[CL 18666214 by mic rooney in ue5-main branch]
2022-01-19 16:32:34 -05:00
mic rooney
9291145754 Missed copyright header in a new file.
[FYI] [at]Eric.knapik

#ROBOMERGE-AUTHOR: mic.rooney
#ROBOMERGE-SOURCE: CL 18643260 via CL 18643507 via CL 18646362 via CL 18646832 via CL 18647192 via CL 18653882 via CL 18653923 via CL 18653964
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18653997 by mic rooney in ue5-main branch]
2022-01-18 20:59:15 -05:00
mic rooney
926ad2358a Work to re-enable the plugin browser for fortnite.
* Adding config option to disable the enable/disable checkbox for plugins in the plugin browser.
* Updating plugin templates to be driven from data
* Adding new plugin templates for fortnite

[REVIEW] [at]Bob.Tellez, [at]Michael.Noland, [at]Eric.Knapik, [at]Bill.Colby, [at]Josh.Andersen



#preflight 61e76c4d843acf1b24115b55

#ROBOMERGE-OWNER: mic.rooney
#ROBOMERGE-AUTHOR: mic.rooney
#ROBOMERGE-SOURCE: CL 18642505 via CL 18642948 via CL 18646266 via CL 18646667 via CL 18646685 via CL 18653855 via CL 18653861 via CL 18653865
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18653872 by mic rooney in ue5-main branch]
2022-01-18 20:54:39 -05:00
michael noland
7d50609260 Game Features: Changed the user facing display name for GameFeaturesManagerClassName to "Game Feature Project Policy Class"
#jira UE-113383
#preflight none (comment only change)

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18528946 in //UE5/Release-5.0/... via CL 18528956
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18528958 by michael noland in ue5-release-engine-test branch]
2022-01-06 01:32:16 -05:00
bob tellez
63010301fc #UE Reduce log spam. Made game feature state machine log messages verbose, and made the "load complete" message include the ending state.
[FYI] Michael.Noland

#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 18524918 via CL 18525358 via CL 18526374 via CL 18526505 via CL 18526675 via CL 18526970 via CL 18526981
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18526994 by bob tellez in ue5-release-engine-test branch]
2022-01-05 19:17:51 -05:00