Commit Graph

45 Commits

Author SHA1 Message Date
ben hoffman
52fbdae067 Add SlateUserIndex to the platform devices debug command
#jira none
#rb trivial
#rnx
#preflight 62a9f58bf878f9423ee0b57b

[CL 20670953 by ben hoffman in ue5-main branch]
2022-06-15 11:48:31 -04:00
ben hoffman
224d70fecf Do a pass on the alignment/padding of properties for Enhanced Input types.
UInputMappingContext -- No padding improvements, but the alignment will be better as the "Mappings" array will fill up to the 64 byte boundry

UInputAction -- Move the "Triggers" array up to the top to align at the 64 byte boundary, with the FText after it. In shipping builds, FText's are 24 bytes. This will actually result in more padding, but have it still be the same size. That means we have more room for any extra flags in the future!

FInputActionInstance -- Remove the two deprecated properties that are not in use anywhere. Seeing as we are coming out of experiemental, we should cut as much as we can now to save people from mucking stuff up in the production version. Went from 136 bytes to 96!!

FEnhancedActionKeyMapping -- Went from 144 bytes to 136 bytes. FKey is 80 bytes?! Ouch. Cut the amount of padding in half from 14 to 7

#jira UE-155097
#rb justin.hare
#rnx
#preflight 62a2dba72e1cc34f11c8aad5

[CL 20630324 by ben hoffman in ue5-main branch]
2022-06-13 13:38:15 -04:00
ben hoffman
fb68de191a Add a missing super call to the PlayerMappableInputConfig constructor. Update comment on the deprecated property.
#jira none
#preflight 62a2dbb08b67b148f294efb9
#rnx
#rb trivial
#preflight 62a2dbb08b67b148f294efb9

[CL 20590293 by ben hoffman in ue5-main branch]
2022-06-10 02:00:10 -04:00
ben hoffman
6914cadaa2 Remove the warnings on unsupported input triggers because they are inconsistent and have a confusing UX. I am putting these behind a default-off CVar for now, until we can decide on a better route for determining when to warn.
#jira none
#rb me
#rnx
#preflight 62a119eb232daff7b309ecf8
#preflight 62a119eb232daff7b309ecf8

[CL 20565765 by ben hoffman in ue5-main branch]
2022-06-08 17:59:05 -04:00
ben hoffman
02484d1ab6 Fix LOCTEXT namespacing dup
#jira none
#rb trivial
#rnx
#preflight skip

[CL 20554857 by ben hoffman in ue5-main branch]
2022-06-08 08:14:55 -04:00
ben hoffman
1cfd429b17 Fix the display name on Player Mappable Configs in their asset creation factory. Now its consistent with the asset dipslay name.
#jira none
#rb trivial
#rnx
#preflight skip

[CL 20554489 by ben hoffman in ue5-main branch]
2022-06-08 07:20:11 -04:00
ben hoffman
3a4f3ddf3b Export UInputTriggerChordAction and UInputTriggerTimedBase with the ENHANCEDINPUT_API.
#jira none
#rb me
#preflight 629a2f59b4282076941bdf3f

[CL 20487749 by ben hoffman in ue5-main branch]
2022-06-03 12:13:36 -04:00
ben hoffman
f63f3bd1b7 Change category of the EI platform settings to Enhanced Input instead of just input
#jira none
#rb trivial
#rnx
#preflight skip

[CL 20458346 by ben hoffman in ue5-main branch]
2022-06-01 16:35:23 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
ben hoffman
39f8ee0c4b Exclude blueprint assets that have been marked for deletion in the content browser when we are building the enhanced input trigger defaults panel.
#jira UE-93458
#rb trivial
#preflight 62967495db7419b82988fed0
#rnx

[CL 20443183 by ben hoffman in ue5-main branch]
2022-05-31 17:56:10 -04:00
ben hoffman
390306e278 Fix cook error that was happening because the ActionDescription is built from a FString, and thus did not have a null FText namespace key.
#jira none
#rnx
#rb trivial
#preflight skip

[CL 20396995 by ben hoffman in ue5-main branch]
2022-05-27 15:04:52 -04:00
ben hoffman
48c2464350 For Input Action instance data that is flagged to trigger with "StartedAndTriggered" (i.e. started and triggered happen within the same frame) ensure that the "Started" delegate will always get called before the "Triggered" delegate. Before, "Triggered" was happening first because of the "TriggeredDelegates.Add(Binding->Clone())" logic, which would always put the "Started" event at the end of the array.
#jira UE-154115
#rb justin.hare
#preflight 628febb974630984fd50d947

[CL 20396192 by ben hoffman in ue5-main branch]
2022-05-27 14:09:39 -04:00
ben hoffman
d6421692ef Add an FText action description to UInputAction. Default the value to the name of the action with the common "IA_" prefix removed, and underscores replaced with white spaces. Change the category of the Input Mapping Context description field to be consistent with the input action's.
#jira none
#rb jules.blok
#preflight 62910255183e241099cbe25c

[CL 20395371 by ben hoffman in ue5-main branch]
2022-05-27 13:17:55 -04:00
ben hoffman
9ac12530cf Add display names to the Enhanced Input developer settings and the EI editor settings
#jira none
#preflight 628d4259347b7778b6d1a3fb
#rnx
#rb trivial

[CL 20356481 by ben hoffman in ue5-main branch]
2022-05-24 17:39:54 -04:00
ben hoffman
151a4ef653 Add a "Scale by delta time" input modifier. This can be useful for if you wanted to have your look input or something in here, and then you don't need to add an additional " * deltatime " call in your input code every time.
#jira none
#rb andy.davidson
#preflight 628adfa46278bd4e1e1e4671

[CL 20347974 by ben hoffman in ue5-main branch]
2022-05-24 10:23:48 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
ben hoffman
cfab426af9 Add a style set for Enhanced Input so that the asset types have custom icons.
#jira UE-148432
#rb benjamin.fox
#preflight 6286c320045aba22797a5687

[CL 20296433 by ben hoffman in ue5-main branch]
2022-05-20 12:13:19 -04:00
ben hoffman
76ed907f03 Enhanced Input: Add a "MetaData" pointer on the player mappable options. This will be really usefuil for devs if they wanted to define random stuff for each key mapping, like icons, maybe an ability asset, whatever you want.
#jira none
#rb trivial
#rnx
#preflight 6286649115019f647745be08

[CL 20283091 by ben hoffman in ue5-main branch]
2022-05-19 13:19:43 -04:00
ben hoffman
e423243c88 [Enhanced Input] Deprecated UInputMappingContext::UnmapAction because the name is a bit confusing. Create a new "UnmapAllKeysFromAction" function instead to be more explicit.
#jira UE-97032
#rb trivial
#preflight 627bf1b12d678960301a00b6

[CL 20145607 by ben hoffman in ue5-main branch]
2022-05-11 14:19:51 -04:00
lauren barnes
00c86da7f5 Adding AppStyle.h includes
#rb trivial

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20072361 via CL 20072577 via CL 20072706
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20105734 by lauren barnes in ue5-main branch]
2022-05-09 13:31:23 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
ben hoffman
c2768da7a2 First pass at a "showdebug Devices" command that will display debug info about all current platform users and their connected input devices. This will display some basic information on the screen that will be really useful while testing all this on different platforms.
Note: For now this lives with Enhanced Input, but should probably go somewhere else as it doesn't actually depend on anything related to Enhanced Input. Ideally I think it should live in InputCore, but it cant because InputCore cannot depend on the "Engine" module which is where all the debug helpers are.

#jira UE-147805
#rb andy.davidson
#preflight 6275531bd8373707f21bcf76

[CL 20102045 by ben hoffman in ue5-main branch]
2022-05-09 09:53:40 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
ben hoffman
6a44e8145d Create accessors on the Enhaced Player input for the currently applied mapping contexts and mappings.
These functions will make it easier for people to extend this class, while still keeping the AppliedInputContext and EnhancedActionMappings properties const and non-mutable.

#jira none
#rb trivial
#preflight 626fe786264f78f46f766589

[CL 20008700 by ben hoffman in ue5-main branch]
2022-05-02 10:55:12 -04:00
ben hoffman
a46003c9e8 Add a missing 'ENHANCEDINPUT_API' to the Enhanced Input editor subsystem so that it can be used outside of the module
#jira none
#rb trivial
#rnx
#preflight 624dfe294c5db57ae60aad42

[CL 19656295 by ben hoffman in ue5-main branch]
2022-04-06 17:31:07 -04:00