Commit Graph

23 Commits

Author SHA1 Message Date
marc audy
621df74b6c [Backout] - CL20544648
#fyi Jared.Therriault, Jason.Walter
Original CL Desc
-----------------------------------------------------------------
Console Variables Editor:

-Move ConsoleVariablesAsset from UncookedOnly module to separate Runtime module
-Make Console Variable Asset functions mostly BlueprintCallable or BlueprintPure
-Add option to execute all commands in an asset from context click in content browser

#rb Jason.Walter

#jira UE-155812

#preflight https://horde.devtools.epicgames.com/job/629ad131c80cbaebe507d024

[CL 20546379 by marc audy in ue5-main branch]
2022-06-07 17:58:59 -04:00
Jared Therriault
fa03f82ac4 Console Variables Editor:
-Move ConsoleVariablesAsset from UncookedOnly module to separate Runtime module
-Make Console Variable Asset functions mostly BlueprintCallable or BlueprintPure
-Add option to execute all commands in an asset from context click in content browser

#rb Jason.Walter

#jira UE-155812

#preflight https://horde.devtools.epicgames.com/job/629ad131c80cbaebe507d024

[CL 20544648 by Jared Therriault in ue5-main branch]
2022-06-07 16:22:39 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Jared Therriault
a4d4390a3c //UE5/Main - Cook QAVirtualProduction Win64 - Ensure condition failed: IPluginManager::Get().LoadModulesForEnabledPlugins(ELoadingPhase::PostEngineInit)
#rb None

#jira UE-151200

#preflight https://horde.devtools.epicgames.com/job/627c01eb332e182a58be0b69
#preflight https://horde.devtools.epicgames.com/job/627c02c1b60dee4a43b7dbbe

[CL 20149956 by Jared Therriault in ue5-main branch]
2022-05-11 16:56:57 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Jared Therriault
e87891f3df Console Variables Editor:
-Update all instances of FEditorStyle to FAppStyle

#jira UE-151230
#rb Jason.Walter

#preflight https://horde.devtools.epicgames.com/job/627451b5c97e95294ce58bab

[CL 20082435 by Jared Therriault in ue5-main branch]
2022-05-06 15:25:25 -04:00
Jared Therriault
68f031a681 //UE5/Main - Cook QAVirtualProduction Win64 - Ensure condition failed: IPluginManager::Get().LoadModulesForEnabledPlugins(ELoadingPhase::PostEngineInit)
#rb None

#jira UE-151200

#preflight https://horde.devtools.epicgames.com/job/627433d54a2e9340486d635b

[CL 20064330 by Jared Therriault in ue5-main branch]
2022-05-05 16:46:54 -04:00
Jared Therriault
cba1c35e8f Console Variables Editor:
-Add custom handler for pressing spacebar when adding a cvar

#jira UE-150343
#rb None

#preflight https://horde.devtools.epicgames.com/job/6269b9b5f97c319bebc92d09

[CL 19948757 by Jared Therriault in ue5-main branch]
2022-04-27 18:13:41 -04:00
jason walter
6121e0ef30 Fix CIS issue with pragma once.
#jira UE-150255
#fyi jared.therriault
#rb none, trivial
#preflight none, trivial

[CL 19929144 by jason walter in ue5-main branch]
2022-04-26 17:20:07 -04:00
Jared Therriault
64ddf8eb1b Console Variables Editor:
-Fix Multi-User Icon

#jira UE-150189
#rb None

#preflight https://horde.devtools.epicgames.com/job/62673b31df6676d7e0cfa295

[CL 19913574 by Jared Therriault in ue5-main branch]
2022-04-25 20:53:16 -04:00
Jared Therriault
79ae0a4efe Console Variables Editor:
-Cvars cannot be added by clicking in the dynamic list

#rb None
#jira UE-140256

#preflight https://horde.devtools.epicgames.com/job/62673685ae7d89946728a417

[CL 19912962 by Jared Therriault in ue5-main branch]
2022-04-25 20:22:19 -04:00
Jared Therriault
9e936a45a6 //UE5/Main - NonUnity Compile LyraEditor Win64 - ConsoleVariablesEditorFunctionLibrary.cpp error: cannot convert argument 1 from 'const UConsoleVariablesAsset *' to 'const FAssetData &'
#jira UE-149971
#rb None
#preflight https://horde.devtools.epicgames.com/job/626706047e06ec7505c117e3

[CL 19908835 by Jared Therriault in ue5-main branch]
2022-04-25 16:58:05 -04:00
Jared Therriault
a3338619f4 //UE5/Main - NonUnity Compile LyraEditor Win64 - SConsoleVariablesEditorMainPanel.cpp error: 'FPropertyEditorModule': undeclared identifier
#jira UE-149974
#rb None

#preflight https://horde.devtools.epicgames.com/job/6266f9f3494d3f729c6d339d

[CL 19908819 by Jared Therriault in ue5-main branch]
2022-04-25 16:57:05 -04:00
jared therriault
9a9ecc1555 Console Variables Editor:
-Fix for: nDisplay nodes/viewports shift position when rendering with MRQ

#jira UE-147449

#rb Jason.Walter

#lockdown Alejandro.Arango

#preflight 625f76559c09ef439db6b631

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 19840077 in //UE5/Release-5.0/... via CL 19843963
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19844305 by jared therriault in ue5-main branch]
2022-04-21 00:16:10 -04:00
Jared Therriault
72ef3c9c9d Console Variables Editor:
-Fix for: Ensure and multiple entries when setting r.Shadow.Virtual.Enable 0
-Fix for: Variables not transacting when set from blueprint function library or when unchecking a row in CVE

#jira UE-145071
#jira UE-145532

#rb Jason.Walter

#preflight 625f62b9fd255ad9e2faad20

[CL 19838087 by Jared Therriault in ue5-main branch]
2022-04-20 17:02:01 -04:00
Jared Therriault
890a384301 Console Variables Editor:
-Remove unnecessary include (needed change for external files to include Asset header)

nDisplay Launch:

-Initial Commit

#jira UE-146947
#jira UE-146948
#jira UE-146953
#jira UE-146954

#rb Jason.Walter

#preflight 624dd6a58d1db441a9246adf

[CL 19671122 by Jared Therriault in ue5-main branch]
2022-04-07 12:15:18 -04:00
jared therriault
f03b5e6e58 Console Variables Editor:
-Change out single line if-init statements for nested if statements
-Fix for: Insufficient Multiuser Button Selection Padding
-Fix for: Console Variables Editor is not setting edited cvars as Session source

#rb Zach.Brockway
#lockdown Alejandro.Arango

#jira UE-144561
#jira UE-144584
#jira UE-144675

#preflight 622116babf662715a8c676e4

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 19255173 in //UE5/Release-5.0/... via CL 19258171
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263557 by jared therriault in ue5-main branch]
2022-03-04 03:50:59 -05:00
jared therriault
db76492ef3 Console Variables Editor:
-Plugin icon update
-Adjust no list text for when there are no variables with no filter in preset mode
-Treat same commands with separate parameters before value as separate commands in list
-Fix caching for value commands which were being reset when returning from global search
-Fix: Engine cVars should become "Session" cVars when modified
-Fix: Show Option "Show Only Current Preset" not working
-Add Show Option "Only Variables"
-Add Show Option "Only Commands"
-Update Show Options to use EConsoleVariableFlags instead of text matching

#rb Zach.Brockway
#lockdown Alejandro.Arango

#jira UE-142436
#jira UE-142252
#jira UETOOL-4360
#jira UE-134740
#jira UE-144512
#jira UE-144511
#jira UE-144514

#preflight 621ff97a943787f1d218f2c9

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 19233495 in //UE5/Release-5.0/... via CL 19233831
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19234694 by jared therriault in ue5-main branch]
2022-03-02 19:51:12 -05:00
jared therriault
f4cda208b0 Console Variables Editor:
-Logging verbosity pass
-Fix for MU implementation sending variables back and forth in a feedback loop
-Fix for Global Search does not crawl help text or source

#rb Jason.Walter

#lockdown Alejandro.Arango

#jira UE-141801
#jira UE-141843
#jira UE-142034

#preflight 6202e704e85c7a08bbfb423e

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 18925268 in //UE5/Release-5.0/... via CL 18931051 via CL 18931187
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18931211 by jared therriault in ue5-main branch]
2022-02-09 22:44:16 -05:00
jared therriault
7e40980281 Console Variables Editor:
Fixes for:
-Duplicated keys for localization - UE - Virtual Production

#rb Jason.Walter

#lockdown Alejandro.Arango

#jira UE-141553

#preflight 62017f8b62420bfd04927444

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 18893801 in //UE5/Release-5.0/... via CL 18893941 via CL 18894354
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18894390 by jared therriault in ue5-main branch]
2022-02-07 17:09:48 -05:00
jared therriault
a667407ee3 Console Variables Editor:
Fixes for:
-Search form is too tall (~4px on a 1920x1080 monitor), ensure it is the same height as the search form in the Outliner.
-"Search All" button is too tall (~5px on a 1920x1080 monitor), ensure it is the same height as the "+ Console Variable" button.
-The checkbox in the column header does not align with the checkboxes in the rows (header is slightly to the right).
-Improvements to No Results copy
-Add more default fill width to Sort Column
-Crash Creating Preset in Content Browser

#rb Jason.Walter

#lockdown Alejandro.Arango

#jira UE-138441
#jira UE-140704
#jira UE-141271

#preflight 61fda6d0e65336d14553fbdd

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 18875930 in //UE5/Release-5.0/... via CL 18876132 via CL 18876500
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18876516 by jared therriault in ue5-main branch]
2022-02-04 18:18:15 -05:00
jared therriault
cb9378151f Console Variables Editor:
-Have 'no results' copy be the same when filtering preset or global search

#rb None
#[fyi] Jason.Walter

#jira UE-140704

#preflight 61f89dcc537702981c2d9a9e

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 18804747 in //UE5/Release-5.0/... via CL 18807916 via CL 18821725
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822095 by jared therriault in ue5-main branch]
2022-02-02 02:17:58 -05:00
jared therriault
4ec20cef0f Move ConsoleVariablesEditor from Plugins/Experimental to Plugins/Editor
#rb None
#[fyi] Jason.Walter

#jira UE-140700

#preflight 61f835995a026d2d19b2cb5a

#ROBOMERGE-AUTHOR: jared.therriault
#ROBOMERGE-SOURCE: CL 18795070 in //UE5/Release-5.0/... via CL 18795461 via CL 18796426
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18796758 by jared therriault in ue5-main branch]
2022-01-31 15:56:23 -05:00