Commit Graph

188 Commits

Author SHA1 Message Date
benoit gadreau
786eeaff04 follow up to CL19360468 and CL19387103: update bPropagateToChildren default value for some nodes saved in previous versions
the "Space" element type is changed to "Null" after we apply the PropagateToChildren patch thus leaving old tranform nodes using a bPropagateToChildren to false.

#jira MH-6790
#rb helge.mathee
#preflight 62a9efb6634e82e5d1e9b02c

#ROBOMERGE-AUTHOR: benoit.gadreau
#ROBOMERGE-SOURCE: CL 20672738 in //UE5/Release-5.0/... via CL 20674321
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20676077 by benoit gadreau in ue5-main branch]
2022-06-15 16:00:03 -04:00
Helge Mathee
f340a4f6ad Control Rig: Fix to run backwards compat code
#rb sara.schvartzman
#jira UE-155436
#preflight https://horde.devtools.epicgames.com/job/62a34936ec7332a25c9597a0

[CL 20594878 by Helge Mathee in ue5-main branch]
2022-06-10 10:03:01 -04:00
Helge Mathee
6650e35ddb Control Rig: Animation Channels Refactoring
#rb sara.schvartzman
#jira UE-155820
#preflight https://horde.devtools.epicgames.com/job/62a31f16152bfb33d33a4140

[CL 20594470 by Helge Mathee in ue5-main branch]
2022-06-10 09:35:29 -04:00
Helge Mathee
d109ff0b88 RigVM: Performance improvement: Convert debug breakpoints from TSharedPtr to guid based struct
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/62a1ec88ba2f7b307823570b

[CL 20575238 by Helge Mathee in ue5-main branch]
2022-06-09 09:38:29 -04:00
sara schvartzman
aa4f6f9713 Control Rig: Fix reroute not available when dragging execute context pin
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/629e20126e36d50d05f46a4a

[CL 20534560 by sara schvartzman in ue5-main branch]
2022-06-07 04:47:42 -04:00
Helge Mathee
2a04ccc6f5 Control Rig: Show events in Action Palette
#rb benoit.gadreau
#jira na
#preflight https://horde.devtools.epicgames.com/job/6299f65ddd53521c2cb03285

[CL 20485005 by Helge Mathee in ue5-main branch]
2022-06-03 08:26:07 -04:00
Helge Mathee
8695493f34 Control Rig: Allow events to be invoked from top toolbar and context menu
#rb benoit.gadreau
#jira UE-155696
#preflight https://horde.devtools.epicgames.com/job/6299ce559e55f868a0824819

[CL 20484545 by Helge Mathee in ue5-main branch]
2022-06-03 05:50:33 -04:00
benoit gadreau
0a6c48471c Fix use of IsChildOf with possible nullptr (cf. CL 20439034)
#jira none
#rb halfdan.ingvarsson
#fyi brandon.schaefer
#preflight 6297c940915b3c3dafb4745a

[CL 20458225 by benoit gadreau in ue5-main branch]
2022-06-01 16:30:52 -04:00
benoit gadreau
c64c1bf314 Fix use of IsChildOf with possible nullptr (cf. CL 20439034)
todo: check for all use of IsChildOf within ControlRig to avoid future issues

#jira UE-155523 UE-155505
#rb halfdan.ingvarsson
#fyi brandon.schaefer
#preflight 6297bd5be809e387be23e44c

[CL 20457493 by benoit gadreau in ue5-main branch]
2022-06-01 15:51:46 -04:00
Helge Mathee
9c189267d5 ControlRig: user defined events and event invocation
#rb sara.schvartzman
#jira UE-153498 UE-153499
#preflight https://horde.devtools.epicgames.com/job/62975ffb2c618ddc66bb49a4

[CL 20453170 by Helge Mathee in ue5-main branch]
2022-06-01 11:28:01 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
jack cai
e8f38eb3ea ControlRig: Reverted a previous change that parented rigvm memory objects to the ControlRigBP asset object because the engine no longer supports uobject as uclass outer, only upackage can be the outer of an uclass.
Also added UControlRigBlueprint::GetPreloadDependencies to ensure memory classes are loaded before ControlRigBP during cooking.

#jira UE-152546
#rb helge.mathee sara.schvartzman halfdan.ingvarsson
#fyi benoit.gadreau
#preflight https://horde.devtools.epicgames.com/job/62945fd71154108e88cc4c35

[CL 20442350 by jack cai in ue5-main branch]
2022-05-31 16:55:43 -04:00
Helge Mathee
6520c809a9 Control Rig: backend work for support for multi graph
#rb benoit.gadreau
#jira UE-153497
#preflight https://horde.devtools.epicgames.com/job/6294be4e2e34c2e487b13394

[CL 20434781 by Helge Mathee in ue5-main branch]
2022-05-31 04:27:20 -04:00
sara schvartzman
0937ada054 Control Rig: Fix select nodes not supporting arrays of arrays
#jira na
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/6287aa2e5b568e5761f505cc

[CL 20294487 by sara schvartzman in ue5-main branch]
2022-05-20 11:00:38 -04:00
sara schvartzman
38c72b07e2 Control Rig: Fix load of pre-template assets
#jira UE-153247
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6287664b1e478b95c7fbc926

[CL 20293516 by sara schvartzman in ue5-main branch]
2022-05-20 09:28:06 -04:00
sara schvartzman
cc32bcfbe4 Control Rig: Fix crash when upgrading sequence node
#jira UE-151719
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/628673b415019f6477482bd5

[CL 20292184 by sara schvartzman in ue5-main branch]
2022-05-20 04:43:05 -04:00
Helge Mathee
0c6e7369ea Control Rig: Blueprint handlepackage load to engage in -game even if the package isn't known yet
#rb sara.schvartzman
#jira UE-152812
#preflight https://horde.devtools.epicgames.com/job/6286249c9701e2d2b2f33742

[CL 20278485 by Helge Mathee in ue5-main branch]
2022-05-19 08:04:52 -04:00
Helge Mathee
07ed471091 Control Rig: Disable errors during backwards compat code for variables
#rb sara.schvartzman
#jira UE-149281
#preflight https://horde.devtools.epicgames.com/job/62861d3b614041edb7e9267c

[CL 20278050 by Helge Mathee in ue5-main branch]
2022-05-19 06:49:41 -04:00
sara schvartzman
bf80edbc4f Control Rig: Fix some pins not resolving on load
#jira UE-152862
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/62855c54ce2518860fec8fbf

[CL 20268237 by sara schvartzman in ue5-main branch]
2022-05-18 16:54:34 -04:00
jack cai
f208525adb ControlRig: Reparent rig vm mem class to the asset obj instead of the package because asset related operation assumes that each package only contains one asset object and actions like rename only acts on that one object and skips other objects in the same package
#jira UE-152546
#rb helge.mathee, sara.schvartzman, halfdan.ingvarsson
#preflight https://horde.devtools.epicgames.com/job/628492ce5a354a55523d2153

[CL 20266543 by jack cai in ue5-main branch]
2022-05-18 15:28:05 -04:00
sara schvartzman
6c0d38da89 Control Rig: Performance improvements on template nodes
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6283a58a730e8423d1256bf5

[CL 20258899 by sara schvartzman in ue5-main branch]
2022-05-18 06:43:26 -04:00
Helge Mathee
79506075b5 RigVMDeveloper: Centralize pythonize for enum values
#rb sara.schvartzman
#jira UE-151724
#preflight https://horde.devtools.epicgames.com/job/627e298434434190054ad8c8

[CL 20178877 by Helge Mathee in ue5-main branch]
2022-05-13 05:53:36 -04:00
Helge Mathee
7c6bf8d066 ControlRig: Only remove rig_unit variables for very-old assets
#rb sara.schvartzman
#jira UE-149281
#preflight https://horde.devtools.epicgames.com/job/627cd338ce4192efbe25865a

[CL 20162527 by Helge Mathee in ue5-main branch]
2022-05-12 05:52:59 -04:00
Helge Mathee
af4d3cb9e3 Control Rig: Proxy control support
#preflight https://horde.devtools.epicgames.com/job/627b92c10a5817c9d93f5da6
#jira na
#rb sara.schvartzman benoit.gadreau

[CL 20136941 by Helge Mathee in ue5-main branch]
2022-05-11 08:12:21 -04:00
sara schvartzman
71eb93c798 Control Rig: Fix crash when changing variable type to rotator
#jira UE-151605
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627ba08ba85e625d6f6169b3

[CL 20136557 by sara schvartzman in ue5-main branch]
2022-05-11 07:51:44 -04:00