Commit Graph

33 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Brendan Mulcahy
9ad019e427 MLAdapter: Add filepath & timestamp options to local data collection session
#jira UE-147224
#rb @Mieszko.Zielinski
#rnx
#preflight 6241d8314976f93c2beae25f

[CL 19528556 by Brendan Mulcahy in ue5-main branch]
2022-03-28 11:53:47 -04:00
Brendan Mulcahy
10c245bece MLAdapter: Shorten log name to LogMLAdapter
#rb @Mieszko.Zielinski
#rnx
#preflight 623b4f6fc3399da95332af52

[CL 19481316 by Brendan Mulcahy in ue5-main branch]
2022-03-23 13:05:51 -04:00
Brendan Mulcahy
07527636e3 MLAdapter: simplify world filtering in PIE
#review-19426794 @Mieszko.Zielinski
#rnx
#preflight 623b482704769ab4937ad95b

[CL 19480839 by Brendan Mulcahy in ue5-main branch]
2022-03-23 12:40:04 -04:00
Brendan Mulcahy
6c039f7118 MLAdapter: Fix passing none in Python code
#rb trivial
#rnx

[CL 19373147 by Brendan Mulcahy in ue5-main branch]
2022-03-14 11:21:36 -04:00
Brendan Mulcahy
019b2815a8 MLAdapter: Convert param looping to Find calls
#rb @Mieszko.Zielinski
#rnx
#preflight 6228cbaad773d6497b0053ce

[CL 19320634 by Brendan Mulcahy in ue5-main branch]
2022-03-09 10:59:46 -05:00
Brendan Mulcahy
8731563293 MLAdapter: Enhanced Input Actuator - Clear Action On Use
#review-19223051 @Mieszko.Zielinski
#rnx
#preflight 6228c703d773d6497bffef84

[CL 19320354 by Brendan Mulcahy in ue5-main branch]
2022-03-09 10:39:23 -05:00
eric mcdaniel
b33ada9f2b Reconsidering fixes from RES to Main for explicit Vector constructor fixes
#fyi marc.audy
#preflight skipped

Fix FVector/FVector3f implicit conversions
[CODEREVIEW] Fred.Kimberley
#rnx

#ROBOMERGE-OWNER: eric.mcdaniel
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 19262447 in //UE5/Release-Engine-Staging/...
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19265306 by eric mcdaniel in ue5-main branch]
2022-03-04 08:46:15 -05:00
fred kimberley
81b706b1b5 Fix build errors from removing implict conversion to FVector.
#rb Michael.Noland

#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 19260414 in //UE5/Release-Engine-Staging/...
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19264049 by fred kimberley in ue5-main branch]
2022-03-04 04:25:49 -05:00
Brendan Mulcahy
bcf8ef0cd4 MLAdapter: New Action Duration Option & Related Changes
#rb @Mieszko.Zielinski
#rnx
#preflight 621f9c7d37049be5172a942c

[CL 19222916 by Brendan Mulcahy in ue5-main branch]
2022-03-02 11:45:40 -05:00
Brendan Mulcahy
9f5acb9c87 MLAdapter: Add debug option and fixed_time_step option to runner.py
#rb @Mieszko.Zielinski
#rnx

[CL 19221492 by Brendan Mulcahy in ue5-main branch]
2022-03-02 09:51:32 -05:00
Brendan Mulcahy
3be91b423f MLAdapter: LWC fixes
#review-19051799 @Mieszko.Zielinski
#rnx
#preflight 6215064d141b500e17e79e57

[CL 19073637 by Brendan Mulcahy in ue5-main branch]
2022-02-22 11:12:48 -05:00
Brendan Mulcahy
14e798cc5b MLAdapter: fix bug in EnhancedInput actuator
#rb @Mieszko.Zielinski
#rnx
#preflight 61fd494f51378325c33f44a5

[CL 18863817 by Brendan Mulcahy in ue5-main branch]
2022-02-04 10:46:39 -05:00
Brendan Mulcahy
9bbf7d3be0 MLAdapter: fix manual tick mode reset not working
#rb @Mieszko.Zielinski
#rnx
#preflight 61fd493b0a43b689e1791e1f

[CL 18863774 by Brendan Mulcahy in ue5-main branch]
2022-02-04 10:45:15 -05:00
Brendan Mulcahy
c018be4e68 MLAdapter: Add API Reference comments to most public members & small amounts of clean-up.
#review-18763577 @Mieszko.Zielinski
#rnx
#preflight 61f97603c54b18c42dd8e87d

[CL 18811396 by Brendan Mulcahy in ue5-main branch]
2022-02-01 13:18:43 -05:00
Brendan Mulcahy
f9e2da8f1e MLAdapter: target Linux platform instead of Unix
#rb trivial
#rnx
#preflight 61f8538a114ec25fe0b485c8

[CL 18797826 by Brendan Mulcahy in ue5-main branch]
2022-01-31 16:37:29 -05:00
Brendan Mulcahy
0b66507f0f MLAdapter: replace rpclib with vcpkg version and make buildable on Linux and Mac. Tested on windows and mac, but not Linux
[FYI] Mieszko.Zielinski

#8745
#review @Joe.Kirchoff
#rnx
#preflight 61f80582d07695194b15703b

[CL 18790610 by Brendan Mulcahy in ue5-main branch]
2022-01-31 11:06:16 -05:00
Brendan Mulcahy
ceef6d536e MLAdapter: rename plural filenames to be consistent with header files
#rb trivial
#rnx
#preflight 61f1b1a6e12e3fcf9b239b36

[CL 18743767 by Brendan Mulcahy in ue5-main branch]
2022-01-26 15:55:27 -05:00
Brendan Mulcahy
bb31a5da3e MLAdapter: add missing include Pawn.h to Sensor_EnhancedInput
#rnx
#preflight 61eb5ef9c557ec20019859fa

[CL 18700827 by Brendan Mulcahy in ue5-main branch]
2022-01-21 20:48:14 -05:00
Brendan Mulcahy
cd1e308dba MLAdapter: EnhancedInput Sensor/Actuator, support for blueprints and misc. clean-up. Delete MLAdapterInference
#rb @Mieszko.Zielinski
#rnx
#preflight 61eaded6731e3b408892312f

[CL 18690666 by Brendan Mulcahy in ue5-main branch]
2022-01-21 11:47:23 -05:00
Brendan Mulcahy
5b0e58575a MLAdapter: Add new manager and session to make data collection on the client easier
#review @Mieszko.Zielinski
#rnx
#preflight 61d45ae02e0e436c725e3b3b

[CL 18507531 by Brendan Mulcahy in ue5-main branch]
2022-01-04 09:44:14 -05:00
Brendan Mulcahy
386e7fd8ba MLAdapter: Moving Managers and Sessions into their own folders
#rb @Mieszko.Zielinski
#rnx
#preflight 61b787c0dd0e83c861a7d6b8

[CL 18445045 by Brendan Mulcahy in ue5-main branch]
2021-12-13 13:23:31 -05:00
Brendan Mulcahy
89a3a3827a MLAdapter Plugin: settings can be changed without needed to reboot the editor
#review-18345087 @Mieszko.Zielinski
#rnx
#preflight 61a8e8298015016c7e3ecbb9

[CL 18352886 by Brendan Mulcahy in ue5-main branch]
2021-12-02 11:25:59 -05:00
Brendan Mulcahy
ad9ce389c6 Create new MLAdapterInference Plugin to combine MLAdapter and NNI
#rb @Mieszko.Zielinski
#rnx
#preflight 61a7b3cf0263140fa831294d

[CL 18341878 by Brendan Mulcahy in ue5-main branch]
2021-12-01 13:21:55 -05:00