Commit Graph

9402 Commits

Author SHA1 Message Date
michael dupuis
556ecafe12 When SetParentEditorOnly is called we no longer recompute shader in most case as we will call UpdateStaticPermutation that will do so.
Add Procedural Layer support for Weightmaps, including Brush support that affect Weightmap and/or Heightmap.

#jira UE-61718:
#rb Jack.Porter
[FYI] Jeremy.Moore, Richard.Malo

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: michael.dupuis
#ROBOMERGE-SOURCE: CL 5433816 via CL 5437700 via CL 5437807
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5440742 by michael dupuis in Dev-Networking branch]
2019-03-18 21:01:59 -04:00
nick darnell
c8b78269a7 Adding a lot more logging when tearing down a world, and when adding and removing UI from the viewport so that we can better trace of what the engine is doing when preloading and loading worlds.
#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5430467 via CL 5430470 via CL 5431124 via CL 5437649 via CL 5437709
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5440524 by nick darnell in Dev-Networking branch]
2019-03-18 21:00:37 -04:00
fred kimberley
2b390cc208 Keep a list of all of the previously seen objects when debugging blueprints in FKismetDebugUtilities::FindDebuggingData and check against the list before recursing.
Potential crash fix.

#jira UE-62491
#rb Marc.Audy

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 5434085 in //UE4/Release-4.22/... via CL 5434088
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5436733 by fred kimberley in Dev-Networking branch]
2019-03-18 17:14:43 -04:00
phillip kavan
a268b6b98f Fix for an async load issue that occasionally led to an ensure() and falling back to use the slow path when optimized dynamic BP component instancing is enabled.
Change summary:
- Modified UBlueprintGeneratedClass::GetDefaultObjectPreloadDependencies() to include non-inherited SCS node objects as a preload dependency. This ensures that the reference they hold to the associated component template object will be serialized prior to the point at which we need to use it to generate the runtime data that's needed to support the fast path.
- Modified UBlueprintGeneratedClass::SerializeDefaultObject() to better handle the state in which we cannot generate runtime data to support the fast path when cooked data is present (i.e. emit a warning and fall back to the slow path). Previously we'd end up in a state where an ensure() was later triggered at instancing time when cooked data is present (which I've been using to catch unexpected cook results). Leaving the ensure() in place for now, but it should no longer be triggered.
- Renamed FBlueprintCookedComponentInstancingData::bIsValid for clarity (per code review).

#rb Dan.OConnor

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: phillip.kavan
#ROBOMERGE-SOURCE: CL 5430354 via CL 5430391 via CL 5433546 via CL 5433610
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5436713 by phillip kavan in Dev-Networking branch]
2019-03-18 17:14:23 -04:00
thomas sarkanen
fb58965d1e Skeletal mesh editor now opens the skeleon tree by default
#rb Jurre.deBaare

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 5424936 via CL 5432592 via CL 5432742
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5436190 by thomas sarkanen in Dev-Networking branch]
2019-03-18 17:09:45 -04:00
lauren ridge
28e9cd94b1 Adding conditionals to guard against level editor tab manager and modules not being valid during tab close.
#jira UE-71591
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: lauren.ridge
#ROBOMERGE-SOURCE: CL 5430444 in //UE4/Release-4.22/... via CL 5430445
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5436160 by lauren ridge in Dev-Networking branch]
2019-03-18 17:09:32 -04:00
max chen
3a8d02e520 Sequencer: Clear focus before setting time in case there's a key editor value selected that gets committed to a newly selected key on UserMovedFocus
#jira UE-71646
#rb andrew.rodham

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 5422542 in //UE4/Release-4.22/... via CL 5422545
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5422997 by max chen in Dev-Networking branch]
2019-03-15 20:59:28 -04:00
uriel doyon
8f83ffa014 Fixed missing shaders when enabling debug view shader modes in PIE and non cooked game.
#rb none
#jira UE-70594

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: uriel.doyon
#ROBOMERGE-SOURCE: CL 5420364 in //UE4/Release-4.22/... via CL 5420366
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5421836 by uriel doyon in Dev-Networking branch]
2019-03-15 17:07:57 -04:00
richard wallis
183639524f Speculative fix for editing material after changing Decal Blend Mode may cause editor to crash. Move my previous change in material pre-edit and place in FMaterialEditor undo / redo instead AND in graph changes. Can't repro the graph change version of the crash but I can repro the undo redo version and this change keeps that fix in place.
Reasons for the flush:
In Editor realtime rendering changing a material connection (or via undo/redo) changes what is rendered on the RT (specifically in FMeshDecalMeshProcessor::AddMeshBatch() Emmissive connection test)
before the Shader Map has been updated in PostEditChangeProperty() - Viewport render command enqueue has already happenned so we have a data race and we need to flush that before the material change.

#jira UE-70565
#rb mark.satterthwaite

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: richard.wallis
#ROBOMERGE-SOURCE: CL 5418937 in //UE4/Release-4.22/... via CL 5418940
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5421514 by richard wallis in Dev-Networking branch]
2019-03-15 17:02:42 -04:00
charles derousiers
1f4a8ff47f Fix compilation issue on Linux.
#jira none
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: charles.derousiers
#ROBOMERGE-SOURCE: CL 5408073 in //UE4/Release-4.22/... via CL 5408081
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5418743 by charles derousiers in Dev-Networking branch]
2019-03-15 13:09:42 -04:00
charles derousiers
9dee8dddfb Add option to burn in a movie sequence with path-tracer for a given number of sample per pixel.
This CL also add an internal delay per frame, allowing to wait a certain amount of time before capturing a movie frame.

#jira none
#rb juan.canada
#rb max.chen

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: charles.derousiers
#ROBOMERGE-SOURCE: CL 5405810 in //UE4/Release-4.22/... via CL 5405811
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5418598 by charles derousiers in Dev-Networking branch]
2019-03-15 13:04:45 -04:00
ben marsh
d1b5b28bc4 Fix issues related to hot-reload and LiveCoding co-existing.
* Removed code to invalidate makefiles when adding new source files. UBT should be reliable enough to make this determination itself nowadays, and ignored -invalidatemakefilesonly argument was causing modules to be recompiled.
* Fixed incorrect config section name when determining whether to allow hot reload from IDE. Now prevents hot reload from IDE when live coding is enabled.
* Added error message when trying to add a new class with Live Coding enabled.
* Added error messages when trying to start Live Coding after a hot reload has taken place.
* Added error messages when trying to hot reload with Live Coding enabled.

#jira UE-71253
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5403464 in //UE4/Release-4.22/... via CL 5403485
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5417897 by ben marsh in Dev-Networking branch]
2019-03-15 12:57:01 -04:00
robert osborne
a190e1ca01 #ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: robert.osborne
#ROBOMERGE-SOURCE: CL 5399925 via CL 5401157 via CL 5402217
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5417746 by robert osborne in Dev-Networking branch]
2019-03-15 12:54:26 -04:00
robert manuszewski
bd818fec70 Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
#rb none
#jira UE-69177

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5401696 in //UE4/Release-4.22/... via CL 5401697
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5417671 by robert manuszewski in Dev-Networking branch]
2019-03-15 12:51:17 -04:00
marc audy
2a65f2521d Fix copy paste mistake in review
#rb
#rnx
#jira

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5400051 in //UE4/Release-4.22/... via CL 5400052
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5417606 by marc audy in Dev-Networking branch]
2019-03-15 12:48:34 -04:00
marc audy
f958e62c78 Make sure that the blueprint diff window is closed if the level blueprint is being diffed when the level is closed so as to avoid crash.
#jira UE-71567
#rb Lauren.Ridge

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5399943 in //UE4/Release-4.22/... via CL 5399947
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5417603 by marc audy in Dev-Networking branch]
2019-03-15 12:48:27 -04:00
patrick boutot
d6581e8ef5 Remove the developer path to compile blueprint interactor while in VR.
#jira UE-70993
#rb lauren.ridge

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 5399613 in //UE4/Release-4.22/... via CL 5399614
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5417574 by patrick boutot in Dev-Networking branch]
2019-03-15 12:47:14 -04:00
christina tempelaarl
bfbf5a69aa Fixed Landscape Spline Tangent handles.
#rb matt.kuhlenschmidt

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: christina.tempelaarl
#ROBOMERGE-SOURCE: CL 5398472 via CL 5398856 via CL 5398863
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5417477 by christina tempelaarl in Dev-Networking branch]
2019-03-15 12:46:25 -04:00
max chen
393b5c4780 Sequencer: Fix regression caused by not setting up default tracks for a spawnable
#jira UE-71532
#rb none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 5396013 in //UE4/Release-4.22/... via CL 5396014
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5416565 by max chen in Dev-Networking branch]
2019-03-15 12:36:14 -04:00
joe conley
7ebc975021 #jira UE-69820 Motion Controller meshes do not track with Motion Controller position within VRMode
This issue was introduced by the fix that allowed MotionControllerComponents to correctly replicate in networked games.  Previously the local motion controllers overrode the remote controller's positions.  This was fixed by only updating if HasLocalNetOwner was true.  But that was returning false for VREditorAvatarActor, as it's Owner was null.
So for now, VREditorAvatarActor's HasLocalNetOwner now always returns true.  When using Multi-User with two VRMode editors, we might have to do something else here for when this is called by MotionControllerComponent::PollControllerState()

#rb Lauren.Ridge

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: joe.conley
#ROBOMERGE-SOURCE: CL 5391928 in //UE4/Release-4.22/... via CL 5391930
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5415909 by joe conley in Dev-Networking branch]
2019-03-15 12:25:20 -04:00
nick darnell
ad8d97fe61 Editor - Working with the new blutility UMG extensions, found a few improvements worth making. EditorUtilityWidgets now have ShowWorldContextPin, enabled, so that the editor widgets can make choices about what world they're interacting with, Editor or game world.
Automation - Adding more options for forcing and waiting for loading and streaming to finish and more utilities for waiting for that to happen entirely for tests.

Lauren.Ridge

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 5382989 via CL 5383481 via CL 5383540
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5415617 by nick darnell in Dev-Networking branch]
2019-03-15 12:04:08 -04:00
brian bekich
ff02288e84 Adding additional descriptive info to the debug world names shown in debugger dropdown
#rb ryan.gerleve

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: brian.bekich
#ROBOMERGE-SOURCE: CL 5371091 via CL 5371095 via CL 5375193 via CL 5378183
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5406495 by brian bekich in Dev-Networking branch]
2019-03-14 19:47:12 -04:00
wes hunt
0b45bf6ea6 Disable editor heartbeat warning when trying to send too many heartbeats in one minute. A long term fix is discussed in #jira UE-62403
#jira UE-60272

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: wes.hunt
#ROBOMERGE-SOURCE: CL 5370623 via CL 5374296 via CL 5377811
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5406407 by wes hunt in Dev-Networking branch]
2019-03-14 19:43:46 -04:00
dan oconnor
fcd9c7b4db Fixed focused widget when opening the Override Function menu in the Blueprint Editor - this allows the Override Function menu to be searched
#rb Michael.Noland
#jira UE-71409

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: dan.oconnor
#ROBOMERGE-SOURCE: CL 5365262 in //UE4/Release-4.22/... via CL 5368508
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5405892 by dan oconnor in Dev-Networking branch]
2019-03-14 19:27:01 -04:00
lauren ridge
ba75d34097 Changing blutility checks to also check for editor utility widgets
#rb dan.oconnor
#jira none

#ROBOMERGE-OWNER: ryan.gerleve
#ROBOMERGE-AUTHOR: lauren.ridge
#ROBOMERGE-SOURCE: CL 5363627 in //UE4/Release-4.22/... via CL 5368503
#ROBOMERGE-BOT: ENGINE (Main -> Dev-Networking)

[CL 5405882 by lauren ridge in Dev-Networking branch]
2019-03-14 19:26:20 -04:00