Commit Graph

789 Commits

Author SHA1 Message Date
hilda cruz
a43cbb3322 [Backout] - CL25804385 for a BH issue
#rnx
[FYI] nick.baltis
Original CL Desc
-----------------------------------------------------------------
Variable Frame Stripping
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25771279

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on NX64 and in editor of around 8mb with no noticeable visual degradation.

Works through the VariableFrameStripping object that is a member of the AnimSequence.

Fixed issue with valkyrie

[CL 25809604 by hilda cruz in ue5-main branch]
2023-06-05 22:13:54 -04:00
nick baltis
a400eefa24 Variable Frame Stripping
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25771279

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on NX64 and in editor of around 8mb with no noticeable visual degradation.

Works through the VariableFrameStripping object that is a member of the AnimSequence.

Fixed issue with valkyrie

[CL 25804411 by nick baltis in ue5-main branch]
2023-06-05 17:26:01 -04:00
rex hill
b60e183d4a [Content Browser] Fix Clear Thumbnail not working if asset not already loaded into memory.
#rb jamie.dale

[CL 25796920 by rex hill in ue5-main branch]
2023-06-05 13:25:01 -04:00
dave belanger
25e5977782 AssetTools.LogFolderPermissions command that logs the read and write folder permission lists
#rb Rex.Hill
#preflight 647a2ffa8417d79259b5c21d

[CL 25771781 by dave belanger in ue5-main branch]
2023-06-02 16:04:32 -04:00
JeanMichel Dignard
e2515d259e Fixed asset rename not updating the soft object paths for packages that were just renamed and left a redirector.
The issue was that when moving folder A and B, where A has assets that depends on assets in B, we'd ask the asset registry for the B assets referencers and it was returning to original packages which are now a redirectors. We'd then try to patch soft object paths on a redirector instead of on an actual asset.

We now force a rescan of the moved folders so that the asset registry is up-to-date throughout the move folders process.

#jira UE-187092
#rb matt.peters, julien.stjean
#preflight 64779c080d55081f54a1eca0

[CL 25710991 by JeanMichel Dignard in ue5-main branch]
2023-05-31 15:30:56 -04:00
Alexis Matte
e02363dd23 Change the AssetImportTask interchange options to use FSoftObjectPath instead of TObjectPtr to allow adding python and blueprint pipeline when filling the options.
#jira UE-171404
#rb none
#rnx
#preflight 6474b34cd36191bd261644fe

[CL 25664015 by Alexis Matte in ue5-main branch]
2023-05-29 10:34:59 -04:00
Alexis Matte
e750ec5066 Interchange: Pipeline now have an optional "asset name" property use when importing 1 asset into the content browser.
#jira UE-178095
#rb jeanluc.corenthin
#rnx
#preflight 6467a3787958f15a8b8abd4d

[CL 25546937 by Alexis Matte in ue5-main branch]
2023-05-19 12:48:58 -04:00
edwin maynard
c98b625c8e [Backout] - CL25515851 (backed out due to cis issues)
[FYI] nick.baltis
Original CL Desc
-----------------------------------------------------------------
Due to Backout files marked for add could not show latest revision forcing me to submit this change directly though p4v.
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25450246

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on Nx64 and in editor of around 8mb with no noticeable visual degradation.
Origional Cvar ssytem replaced with VariableFrameStrippingSettings Oject which is a member of AnimSequence. It contains PerPlatform variables for enableing the system and its rate.
The move to a member object wrapping around these settings were two fold. First to better mas change anim sequences by platform while also allowing for varried settings for edge cases. Second becuase due to the fact this affects objects in the cook, gateing it behind a cvar provides no hot fix saftey while hurting useability.

[CL 25521647 by edwin maynard in ue5-main branch]
2023-05-18 00:54:19 -04:00
nick baltis
91486908d5 Due to Backout files marked for add could not show latest revision forcing me to submit this change directly though p4v.
Swarm review [at] https://p4-swarm.epicgames.net/reviews/25450246

Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on Nx64 and in editor of around 8mb with no noticeable visual degradation.
Origional Cvar ssytem replaced with VariableFrameStrippingSettings Oject which is a member of AnimSequence. It contains PerPlatform variables for enableing the system and its rate.
The move to a member object wrapping around these settings were two fold. First to better mas change anim sequences by platform while also allowing for varried settings for edge cases. Second becuase due to the fact this affects objects in the cook, gateing it behind a cvar provides no hot fix saftey while hurting useability.

[CL 25518666 by nick baltis in ue5-main branch]
2023-05-17 19:09:50 -04:00
logan buchy
8cb8cff1ba Feedback changes to Collections telemetry
* Moved workflow tracking of collection manipulations up one level to target user interaction only
* Added create/destroy collection workflows
* Remove hand-holding utilities aimed to ease verbosity of telemetry event generation

#rb wes.hunt
#jira UE-155132
#preflight 6463b34f063e77985c259c71

[CL 25492328 by logan buchy in ue5-main branch]
2023-05-16 13:02:13 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
bob tellez
ff7f38f59e #UE Internal, in-UE-root, gamefeatureplugins no longer pad their GameName to 20 characters to prevent filepath length limits from being exceeded. This rule was added to allow plugins to be used in other projects that may have a longer name, but GameFeaturePlugins cannot be used in other projects, since they depend in /Game/ and project-level modules
[CL 25461958 by bob tellez in ue5-main branch]
2023-05-12 19:27:07 -04:00
bob tellez
d10ce6ed57 #UE Update internal buildmachine root path in cooking filepath length calculation
[CL 25458637 by bob tellez in ue5-main branch]
2023-05-12 16:02:39 -04:00
bryan sefcik
d205101cc8 Removed unnecessary private include modules.
#preflight 645da640cf788a25581110bb

[CL 25451545 by bryan sefcik in ue5-main branch]
2023-05-12 12:13:52 -04:00
jamie dale
6dd21fe90c Remove the consolidation method CVar now that lazy consolidation has had time to bed in as the default
#jira
[FYI] Dave.Belanger
#rnx

[CL 25446198 by jamie dale in ue5-main branch]
2023-05-12 08:27:15 -04:00
bryan sefcik
91c57d395e Removed redundant module includes.
#preflight 645d4bf3aa3c584c0b5b3a67

[CL 25435653 by bryan sefcik in ue5-main branch]
2023-05-11 16:48:21 -04:00
keaton stewart
ca3444d858 Back out changelist 25342326 for [FN Main CIS] NonUnity Error
[FYI] Nick.Baltis

[CL 25346626 by keaton stewart in ue5-main branch]
2023-05-04 20:35:17 -04:00
nick baltis
3c30b6acb1 Variable Frame Stripping
Added functionality to strip at ratios higher 1 out of every 2. testing shows good savings at stripping 2/3 frames on switch and in editor of around 8mb with no noticeable visual degradation.

2 Cvars added "a.Compression.UseVaribleFrameStripping" & "a.Compression.VaribleFrameStrippingRatio" which enable and change the amount of variable stripping.

In addition added 3 variables to anim sequences bOverrideVariableFrameStripping, UseVariableFrameStripping& FrameStrippingRatio; which allow you to override any stripping options on a per asset basis. mainly for the purpose of the case that a particular animation is behaving badly under higher stripping you don’t have to lower the whole platforms stripping to accommodate.
#preflight 642305be803cb466e858b86e
#rb alex.nischwitz

[CL 25343990 by nick baltis in ue5-main branch]
2023-05-04 18:13:08 -04:00
will brown
aa2ce737b0 Fixing a bug that occurs when creating a new plugin from a template containing .uasset files. It's possible for the plugin to fail to register if the post copy rename is triggered while the asset registry scan is still pending. The calling code assumes that the rename is synchronous however it can defer the operation and return. This puts the plugin in a bad state.
Showing the asset discovery dialog and preventing the plugin creation until the asset discovery is complete.

#rb Rex.Hill
#preflight 645008286538e45f75c38ccb

[CL 25292941 by will brown in ue5-main branch]
2023-05-01 17:48:02 -04:00
bob tellez
76172d96d7 #UE Add CVar to allow following redirectors when importing assets
[FYI] Alexis.Matte
#rb Alexis.Matte

[CL 25184546 by bob tellez in ue5-main branch]
2023-04-25 13:54:14 -04:00
jamie dale
933348f856 Use the FMessageDialog overloads that pass the optional title by-value
#jira
#rb none
#rnx

[CL 25062589 by jamie dale in ue5-main branch]
2023-04-15 19:49:32 -04:00
Julien StJean
e9dbd9fb66 [EIS] Minor improvement to the error messaging when renaming an asset.
#jira UE-106770
#preflight 64342ff585398c090c3fc4b4
#rb lauren.barnes

[CL 25007411 by Julien StJean in ue5-main branch]
2023-04-12 10:57:26 -04:00
rex hill
4a9460be92 Add export class permission list
#preflight 643446394c3ccbbdf17e8269
#rnx
#rb dave.belanger

[CL 24994901 by rex hill in ue5-main branch]
2023-04-11 14:22:04 -04:00
brooke hubert
de61b6290c [Asset Definition] Fix an issue where an invalid FName could cause category path look up to assert
#Jira UE-169921
#preflight 642f1f4741783dc3d077b509
#rb julien.stjean

[CL 24954181 by brooke hubert in ue5-main branch]
2023-04-06 15:42:22 -04:00
mike beach
ef5a5af970 Addressing a bug with AdvancedCopy, where two asset dependencies with the same name (from different plugins) would flatten down to overwrite eachother (causing a crash).
NOTE: This could significantly lengthen advanced copy destination paths, potentially blowing past the path character limit normally enforced by UE. In it's current state, the copy will just proceed normally -- seemingly working. This is probably something to investigate more, but doesn't appear to be a high-pri issue atm. A JIRA has been logged to capture this though: UE-182280

[FYI] brooke.hubert
#rb brooke.hubert, francis.hurteau

[CL 24916196 by mike beach in ue5-main branch]
2023-04-04 15:34:25 -04:00