Commit Graph

3080 Commits

Author SHA1 Message Date
jeff newquist
5969077fc4 Added volatile keyword to WaitCompletionImpl to ensure compilers don't just optimize the check away.
#rb rune.stubbe
#jira none
#rnx

#ROBOMERGE-SOURCE: CL 13007135 in //UE4/Release-4.25/... via CL 13007150 via CL 13007159
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 13007166 by jeff newquist in Main branch]
2020-04-23 11:00:55 -04:00
robert manuszewski
ce10617ceb Fixing FFieldPath::ToString() not removing nativized BP temp package prefix after changes from 12847659
#rb trivial
#jira UE-92149

#ROBOMERGE-SOURCE: CL 13003406 via CL 13003408 via CL 13003419
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 13003431 by robert manuszewski in Main branch]
2020-04-23 06:46:03 -04:00
pj kack
5e49316bc4 AsyncLoading2: Fix incorrect check in ToPackageImport
#jira none
#rb none


#ushell-cherrypick of 12997588 by PJ.Kack

#ROBOMERGE-SOURCE: CL 12997796 in //UE4/Release-4.25Plus/... via CL 12997808
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12997823 by pj kack in Main branch]
2020-04-23 02:54:37 -04:00
jeff newquist
9fa4defb8c Fixed all size variants of IAsyncReadRequest so they correctly wait inside of WaitCompletionImpl for a callback to be completed before returning.
Normal read requests have this behavior, but size requests were not respecting this, which caused problems when the constructor launches a callback on another thread and then immediately calls WaitCompletion, such as in the callback lambda inside FFileCacheHandle::FFileCacheHandle / PushCompletedRequest.
#rb rune.stubbe
#jira none
#rnx

#ROBOMERGE-SOURCE: CL 12974187 in //UE4/Release-4.25/... via CL 12974195 via CL 12974203
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12974208 by jeff newquist in Main branch]
2020-04-22 09:27:31 -04:00
CarlMagnus Nordin
7014cf2693 Compile fix
#rnx
#rb none

[CL 12973732 by CarlMagnus Nordin in Main branch]
2020-04-22 06:34:52 -04:00
carlmagnus nordin
373fd671f7 Copying //UE4/Release-4.25Plus-Dev to Release-4.25Plus (//UE4/Release-4.25Plus)
#rnx
#jira none
#rb none

#ROBOMERGE-OWNER: carlmagnus.nordin
#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 12973630 in //UE4/Release-4.25Plus/... via CL 12973644
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12973696 by carlmagnus nordin in Main branch]
2020-04-22 06:25:12 -04:00
paul chipchase
b1647fcbe9 Fixed a bug causing duplicated non optional payloads to never be loaded if the optional pakfiles are not mounted, even though the data exists in both the .ubulk and .uptnl file.
- When checking for the existence of the optional file (.uptnl) via filenames rather then FIoChunkId we were actually checking for the non optional (.ubulk) file which would always be true.
 - Caused by using ::ConvertFilenameFromFlags which checks with the original flags, not the new flags.
- This would cause the check in BulkData to always be true so we would report to the texture streaming system that the BulkData was optional data.
- Later when it came time to stream in the mip, the BulkData system would check is the optional data existed on disk and be unable to find it as the optional pakfiles are not mounted.

- Since FBulkDataBase::ProcessDuplicateData is already special case, we can just change the file extension to BulkDataExt::Optional rather than call ::ConvertFilenameFromFlags

#rb none

#ROBOMERGE-SOURCE: CL 12949041 via CL 12949151 via CL 12949169
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12949179 by paul chipchase in Main branch]
2020-04-21 07:29:36 -04:00
dan oconnor
9a5d02ddb0 FPropertyDelegate now lists the SignatureFunction in its 'Referenced Objects', TRASHCLASS is no marked as CLASS_NewerVersionExists, reload package now checks outer chain for out of date classes
#rb Phillip.Kavan
#jira UE-92248

#ROBOMERGE-SOURCE: CL 12939652 in //UE4/Release-4.25/... via CL 12939658 via CL 12939670
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12939678 by dan oconnor in Main branch]
2020-04-20 17:27:23 -04:00
paul chipchase
1773b3a77d Fix a typo in a newly added API method (IsInSeperateFile -> IsInSeparateFile) before the 4.25 release to avoid future issues.
#jira none
#rb devin.doucette, stefan.boberg
#lockdown stefan.boberg


#ushell-cherrypick of 12918250 by paul.chipchase

#ROBOMERGE-SOURCE: CL 12919209 in //UE4/Release-4.25Plus/... via CL 12919222
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12919263 by paul chipchase in Main branch]
2020-04-20 07:36:36 -04:00
Robert Manuszewski
7adeaa35af Fixing CIS (another fallout from 12847659)
#rb Steve.Robb
#jira none

[CL 12869864 by Robert Manuszewski in Main branch]
2020-04-16 14:33:47 -04:00
robert manuszewski
e2c2ab7413 Adding deprecated support for Cast and CastChecked functions for FProperties to minimize compilation errors when upgrading to the new engine version
#jira UE-92070
#rb Steve.Robb
[at]Steve.Robb

#ROBOMERGE-SOURCE: CL 12869270 in //UE4/Release-4.25/... via CL 12869274 via CL 12869288
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12869292 by robert manuszewski in Main branch]
2020-04-16 13:38:33 -04:00
robert manuszewski
ee5c5c5cbc Chaning how FFieldPaths (TFieldPaths) are internally stored and serialized. Now instead of storing the full path (from the outermost UPackage to the innermost FProperty) FFieldPaths will store the owner UStruct reference and a short path to its property (or inner property of its property). The same applies to serialization: both the owner UStruct reference and only the short path will be serialized.
Serializing the owner reference will enable proper handling of any owner struct package renames as well as greatly increase the initial field (property) resolution performance.

#rb Steve.Robb
#tests Basic editor functionality tests related to blueprint editing, editor quick smoke tests, cooked windows client and server, cooked build bot soak tests
[REVIEW] [at]Steve.Robb

#ROBOMERGE-SOURCE: CL 12847659 via CL 12847660 via CL 12847661
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12847663 by robert manuszewski in Main branch]
2020-04-16 04:12:39 -04:00
robert manuszewski
d7ecbe4556 Creating new UObjects while Collecting Garbage will now result in an assert.
#rb trivial
#jira UE-85425

#ROBOMERGE-SOURCE: CL 12792273 in //UE4/Release-4.25/... via CL 12792275 via CL 12792277
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12792280 by robert manuszewski in Main branch]
2020-04-15 08:37:10 -04:00
johan torp
c2b9eea6ef Remove debug assert that verifies that the new optimized StaticFindObject behaves exactly the same as the old algorithm
The old algorithm would match if the outermost name ended with the supplied outermost name. The new algorithm does exact matching of the outermost name, which makes more sense and was likely the intent of the old algorithm.

[FYI] marc.audy
#jira UE-92008
#rb trivial
#lockdown stefan.boberg

#ROBOMERGE-SOURCE: CL 12791641 in //UE4/Release-4.25/... via CL 12791657 via CL 12791675
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12791692 by johan torp in Main branch]
2020-04-15 08:00:51 -04:00
matt peters
e3979ee00e Fix unguarded multithreaded access to FCoreRedirects::KnownMissing functions.
#rb Per.Larsson
#rnx

#ROBOMERGE-SOURCE: CL 12781890 via CL 12781894 via CL 12781898 via CL 12781899
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12782646 by matt peters in Main branch]
2020-04-14 13:43:37 -04:00
bob tellez
6a6f315379 Reintroduce 12676447 from FNMain, which now has a fix for a bug in the change where the packagename and classname where reversed in a call to FindImportClass
[FYI] Dan.Oconnor,Robert.Manuszewski

#ROBOMERGE-SOURCE: CL 12687021 via CL 12687035 via CL 12687039 via CL 12687044 via CL 12687050 via CL 12687054
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12687066 by bob tellez in Main branch]
2020-04-09 01:45:02 -04:00
dan oconnor
9e8f56b54a Undo changelist 12686346
#rb none
#rnx
#jira

#ROBOMERGE-SOURCE: CL 12686476 via CL 12686478 via CL 12686480 via CL 12686482 via CL 12686483 via CL 12686484
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12686486 by dan oconnor in Main branch]
2020-04-09 01:01:00 -04:00
jon nabozny
f6183ae92d Make GetNetPushIdDynamic public
#rb None
#rnx

#ROBOMERGE-SOURCE: CL 12676490 via CL 12677358 via CL 12677381 via CL 12677401
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12677448 by jon nabozny in Main branch]
2020-04-08 15:35:32 -04:00
bob tellez
9c03d8dc80 Submitted on behalf of Robert.Manuzsewski
#UE4 Fix load errors not being supressed for subclasses of BlueprintGeneratedClass


#ROBOMERGE-AUTHOR: Robert.Manuzsewski
#ROBOMERGE-SOURCE: CL 12676447 via CL 12676451 via CL 12676453
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12676455 by bob tellez in Main branch]
2020-04-08 14:53:24 -04:00
CarlMagnus Nordin
0f3ddfc883 Compile fix
#rnx
#rb none

[CL 12651612 by CarlMagnus Nordin in Main branch]
2020-04-07 05:17:52 -04:00
CarlMagnus Nordin
4461ecf3ed AsyncLoading2: Gracefully handle missing chunks and imports
#rb per.larsson
#jira UE-91368
#rnx

[CL 12651590 by CarlMagnus Nordin in Main branch]
2020-04-07 05:10:41 -04:00
carlmagnus nordin
1f16ffb0a7 Fixed static analysis warnings
#rnx
#robomerge[BOT1] Main-For-EngineMerge
#rb none
#jira UE-91433,UE-91436
#lockdown stefan.boberg

#ROBOMERGE-SOURCE: CL 12507055 in //UE4/Release-4.25Plus/... via CL 12507070
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12507091 by carlmagnus nordin in Main branch]
2020-04-01 11:48:27 -04:00
carlmagnus nordin
25e8b4dd7d Copying //UE4/Release-4.25Plus-Dev to Release-4.25Plus (//UE4/Release-4.25Plus)
#rnx
#robomerge[BOT1] Main-For-EngineMerge
#rb none
#jira none
#lockdown stefan.boberg

#ROBOMERGE-OWNER: carlmagnus.nordin
#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 12504704 in //UE4/Release-4.25Plus/... via CL 12504720
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12504759 by carlmagnus nordin in Main branch]
2020-04-01 05:00:26 -04:00
johan torp
20e2b91cf5 Fix property parsing for + and " characters
[FYI] bob.tellez
#jira UE-91349
#rb stefan.boberg

#ROBOMERGE-SOURCE: CL 12494518 via CL 12494534 via CL 12494542
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12494552 by johan torp in Main branch]
2020-03-31 06:01:25 -04:00
bob tellez
ca0e027914 #UE4 Added '+' to the list of RegularTokenChars in property parsing code. Object paths can contain a plus, so they must be able to be parsed
[FYI] Johan.Torp

#ROBOMERGE-SOURCE: CL 12491993 via CL 12491994 via CL 12491995
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12491997 by bob tellez in Main branch]
2020-03-30 19:35:41 -04:00