Commit Graph

234 Commits

Author SHA1 Message Date
patrick boutot
0d838c4210 MVVM: Filter Viewmodel context creation type per class. Use MVVMAllowedContextCreationType or MVVMDisallowedContextCreationType to allow or disallow types.
UCLASS(meta=(MVVMAllowedContextCreationType="Manual|CreateInstance"))
#jira UE-164316
#preflight 63e5ad91f15c83b793edc3c3

[CL 24119664 by patrick boutot in ue5-main branch]
2023-02-10 10:45:24 -05:00
patrick boutot
136813f938 UMG: Add setting to disable UMG binding.
#jira UE-164316
#preflight 63e455505c0ce8f11b0acb51

[CL 24106280 by patrick boutot in ue5-main branch]
2023-02-09 16:22:43 -05:00
patrick boutot
213eb80530 MVVM: Allow picking selecting an abstract class in as the viewmodal in UMG View but you are not able to create an instance.
Add a new way to select the viewmodel uses by the UMG View. User can extend the Resolver and can implement their own logic.
#jira UE-171160
#rb devan.england, sebatian.nordgren
#preflight 63e412003c44c83044e73fe4

[CL 24100372 by patrick boutot in ue5-main branch]
2023-02-09 12:14:47 -05:00
patrick boutot
f2cfd4e83f MVVM: Add setting to find conversion functions.
#jira UE-164316
#preflight 63e3a287e042058d698ba8b4

[CL 24074931 by patrick boutot in ue5-main branch]
2023-02-08 12:16:32 -05:00
patrick boutot
aa9a64a17f MVVM: Add customization for Viewmodel context. Add picker for the propertypath.
#rb sebastian.nordgren
#preflight 63e2a6ae9910415ae2016818

[CL 24061758 by patrick boutot in ue5-main branch]
2023-02-07 17:51:50 -05:00
patrick boutot
98102a7ef3 MVVM: Test the function as regular conversion function and complex to get the property type.
#jira UE-175677

[CL 24044260 by patrick boutot in ue5-main branch]
2023-02-06 21:44:10 -05:00
patrick boutot
6fa51a1ac3 MVVM: Remove the viewmodel editor from the build.
#rb yohan.dossantos
#preflight 63db87323f475e061ff89ede

[CL 24029419 by patrick boutot in ue5-main branch]
2023-02-06 09:20:10 -05:00
patrick boutot
f9a847ada3 MVVM: Remove old and unused widgets.
#preflight 63da5dc58505ea6b1ff9b8af

[CL 23948415 by patrick boutot in ue5-main branch]
2023-02-01 10:34:45 -05:00
patrick boutot
aa96bf075e MVVM: Move GlobalCollection to GameInstance subsystem.
#preflight 63d94e8b31334253e597fec0

[CL 23938784 by patrick boutot in ue5-main branch]
2023-01-31 17:03:58 -05:00
patrick boutot
eeb3c16fca MVVM: Add a allowed ExecutionMode list.
Move GlobalCollection to GameInstance subsystem.
Rename category from MVVM to Viewmodel.
#preflight 63d5e0bcba4fadeef09bdfc2

[CL 23927160 by patrick boutot in ue5-main branch]
2023-01-31 10:21:03 -05:00
jordan hoffmann
31b04b24ba [Feature/Bugfix] Support for diffing against nullptr (treated as an empty or nonexistent file)
#rb dan.oconnor
#preflight 63d83f963656ea96dc2a0a4c

#jira UE-173747
"Crash occurs when scrolling down through files in Review Changelist window upon loading of asset"
  - certain widget blueprints were crashing the review tool because we were working around the inability to diff against nullptr by constructing temprorary empty objects. This approach circumvents that problem entirely

#jira UE-173231
"Changelist Review tool allows diffing against previous revision for Deletion changes"
  - while this jira suggests that the ability to diff deletion changes is a bug, it was actually an intended feature. The real bug was that it would crash or fail to work in many cases. This has been fixed by either asset diffing against nullptr or text diffing against an empty file (depending on circumstance)

#jira UE-174610
"Reviewing Changelist with Deletion Changes results in LogLinker warnings & LoadErrors"
 - deletion changes were trying to load the new revision of files but obviously it doesn't exist because it's a deletion. Fixed by only loading the previous revision


note: since the review tool is going to be "Production Ready"  in 5.2, these changes are neccesary for stability

[CL 23924072 by jordan hoffmann in ue5-main branch]
2023-01-31 01:28:46 -05:00
henrik karlsson
9a1d5b1ad4 [Engine/Plugins]
* Ran IWYU on ~170 plugins to remove includes not needed. Public api still keep old includes inside #if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2

#preflight 63d09351574ab9cae4670216
#rb none

[CL 23844750 by henrik karlsson in ue5-main branch]
2023-01-25 02:42:36 -05:00
patrick boutot
b54ff37589 MVVM: Use the class display name in the select viewmodel menu.
[REVIEW] sebastian.nordgren

[CL 23814940 by patrick boutot in ue5-main branch]
2023-01-23 12:20:36 -05:00
sebastian nordgren
eccc28e691 Fixed static analysis warning about null Pin in SMVVMFunctionParameter.cpp.
#rb trivial
#preflight 63ce752ed83c1837b1182cc0

[CL 23809665 by sebastian nordgren in ue5-main branch]
2023-01-23 07:08:46 -05:00
patrick boutot
8b0766ff17 MVVM: Fix bad access to raw pointer.
#rb sebastian.nordgren

[CL 23774542 by patrick boutot in ue5-main branch]
2023-01-19 11:26:11 -05:00
patrick boutot
7e65cc6c27 MVVM: New binding mode SVG icons for the View Model plugin.
- One Time / One Way
- One Time / One Way to Source
- One Time / Two Way
[REVIEW] sebastian.nordgren

[CL 23747997 by patrick boutot in ue5-main branch]
2023-01-17 18:39:34 -05:00
patrick boutot
9ae72c9a26 MVVM: Change the MVVM category for Viewmodel
[FYI] shirley.man

[CL 23747985 by patrick boutot in ue5-main branch]
2023-01-17 18:39:09 -05:00
sebastian nordgren
aecc8e2db4 MVVM: Toggling the Bind button on a function parameter now restores the previously selected field instead of clearing it.
Non-boolean function parameters now have a dark background. Booleans are displayed as checkboxes and don't scale to the minimum width, so adding the background for them looks bad.

Tested in Bindings view with a conversion function: bind to viewmodel property, toggle binding off, toggle binding back on again. Observe that the viewmodel property is still bound.

[REVIEW] [at]patrick.boutot
#preflight 63c1519d70575f890029a3a6

[CL 23741270 by sebastian nordgren in ue5-main branch]
2023-01-17 13:15:03 -05:00
sebastian nordgren
b727f21732 MVVM - Removed unused GetConversionFunctionWrapperName() function.
#rb trivial
#preflight 63c1504c0b358b97d14e8a17

[CL 23677927 by sebastian nordgren in ue5-main branch]
2023-01-13 10:50:29 -05:00
henrik karlsson
3c9aacb1ad [Engine/Plugins]
* Updated public headers for ~170 engine plugins using iwyu to remove includes not needed. Removed includes are still available behind UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2

#preflight 63c08f4a2a6acaf1622bcc73
#rb none

[CL 23674775 by henrik karlsson in ue5-main branch]
2023-01-13 01:54:01 -05:00
henrik karlsson
68e1306935 [Engine/Plugins]
* Removed more includes using iwyu and marked up includes that is removed because of bugs in iwyu.

#preflight 63bfc8696c4f5668eb3a3cbd
#rb none

[CL 23666746 by henrik karlsson in ue5-main branch]
2023-01-12 13:53:03 -05:00
henrik karlsson
2f78497e67 [Engine/Plugins]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn

#preflight 63bf8d8b577437afe607dc72
#rb none

[CL 23659643 by henrik karlsson in ue5-main branch]
2023-01-12 01:48:34 -05:00
sebastian nordgren
e5621ab993 MVVM - Added new borders to Bindings view as per design.
[REVIEW] patrick.boutot
#rnx

[CL 23651687 by sebastian nordgren in ue5-main branch]
2023-01-11 14:45:52 -05:00
sebastian nordgren
ed36865aad The Bind menu is now shown even for properties that MVVM can bind to, but legacy UMG cannot.
#jira UE-170979
[REVIEW] [at]patrick.boutot
#preflight 639886642540a78d2718f3f2

[CL 23499939 by sebastian nordgren in ue5-main branch]
2022-12-13 18:20:54 -05:00
patrick boutot
d26ab4f46c MVVM: Make static function in MVVMSubsystem for faster access.
#rb sebastian.nordgren
#preflight 63973a35c709c727562393af

[CL 23499920 by patrick boutot in ue5-main branch]
2022-12-13 18:20:11 -05:00