Commit Graph

234 Commits

Author SHA1 Message Date
patrick boutot
46213fe12a MVVM: Reused the same tree and child list if they are available. The key (the sharedptr) is what is kept internally by the TreeView to know where scrolling and which widget are extended.
#rb editor-ui-systems, vincent.gauthier
#preflight 645530f6386cf3c27342589e

[CL 25386503 by patrick boutot in ue5-main branch]
2023-05-09 09:15:32 -04:00
patrick boutot
2602940722 MVVM: Add unittest for FieldNotificationDelegate. Fix bug with Remove that didn't return the correct state of the bindings.
#jira UE-180226
#preflight 644be4b5877716c87807d94e
#preflight 645222a8de5765212276ffec

[CL 25318858 by patrick boutot in ue5-main branch]
2023-05-03 12:28:04 -04:00
patrick boutot
f778be2e4a MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297
#preflight 643df3ff211b661dc4179363, 643e7f5ea35280ed4f198658, 643ea4febf1053846658cad3, 643fd0669566b61450a63e88

[CL 25108939 by patrick boutot in ue5-main branch]
2023-04-19 12:21:08 -04:00
jamie dale
933348f856 Use the FMessageDialog overloads that pass the optional title by-value
#jira
#rb none
#rnx

[CL 25062589 by jamie dale in ue5-main branch]
2023-04-15 19:49:32 -04:00
bob tellez
a974b2479b [Backout] - CL25038865
[FYI] Patrick.Boutot
Original CL Desc
-----------------------------------------------------------------
MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297
#preflight 64381b51df20983c41604681

[CL 25050244 by bob tellez in ue5-main branch]
2023-04-14 17:07:03 -04:00
patrick boutot
a4220fc5fe MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297
#preflight 64381b51df20983c41604681

[CL 25039205 by patrick boutot in ue5-main branch]
2023-04-14 09:07:11 -04:00
bob tellez
953cc7733b [Backout] - CL25027663
[FYI] Patrick.Boutot
Original CL Desc
-----------------------------------------------------------------
MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297
#preflight 64381b51df20983c41604681

[CL 25035582 by bob tellez in ue5-main branch]
2023-04-13 20:30:11 -04:00
patrick boutot
ed5cdea372 MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297

[CL 25032617 by patrick boutot in ue5-main branch]
2023-04-13 17:04:04 -04:00
patrick boutot
733a813436 MVVM: Add the Broadcast field to the INotifyFieldValudChanged. Previously the viewmodel or widget implemented the functionality. The functionality was protected just because. Since we move it to a more engine wide feature and that it will be integrated with the Blueprint compiler it needs to be visible by Blueprint.
#jira UE-130880
#rb zahra.nikbakht
#preflight 643417d8b4329f6f1aded60b, 643693d04c0cdaea093962a7

[CL 25018215 by patrick boutot in ue5-main branch]
2023-04-12 19:00:11 -04:00
marc audy
6381600309 Move UMG/FieldNotification files to the FieldNotification module.
#jira UE-130880
#rb yohann.dossantos
#preflight 64259ab69834526476306f92, 642aee5a6a37fb35e9ba9926

[CL 24905939 by marc audy in ue5-main branch]
2023-04-03 22:29:35 -04:00
patrick boutot
465776669b MVVM: Test if the property handle has a valid value before fetching the data.
#rb yohann.dossantos
#preflight 6426f49691589478cd0a2aaa

[CL 24902629 by patrick boutot in ue5-main branch]
2023-04-03 18:08:02 -04:00
patrick boutot
33b88e8374 MVVM: Fix false positive V758 error in MVVM code base. Fix bad variable initialization.
#jira UE-181105
#rnx
#rb none

[CL 24771433 by patrick boutot in ue5-main branch]
2023-03-23 20:47:14 -04:00
zahra nikbakht
f6c07441c6 Disable/enable context filtering in MVVM binding creation through project settings or a temporary checkbox
#preflight 641c89d9a86ae7cbcce4dae3
#rb patrick.boutot
#jira UE-180197

[CL 24766690 by zahra nikbakht in ue5-main branch]
2023-03-23 15:27:54 -04:00
zahra nikbakht
4ef62bb887 Commit name change in MVVM viewmodel panel when focus is lost.
#preflight 641c65b1c42c7fd1cb4b6485
#jira none
#rb patrick.boutot

[CL 24762101 by zahra nikbakht in ue5-main branch]
2023-03-23 11:08:19 -04:00
patrick boutot
427ba04371 MVVM: Remove needs to have a SourcePath for ComplexConversionFunction. The source data is inside the function itself and the fieldnotify name is already saved in the class binding.
Update GetBindingInfoFromFieldPath to support viewmodel inside another viewmodel. Add unittest for the function.
Add DoesInitializeAtConstruction on the view class. That is to support manual initialization. When the flag is false, the user is responsible for initializing the view.
Add ReevaluateSourceCreator. A source that was discovered at compile time and added to the list of SourceCreator may need to be evaluated if the path contains notify. That function is similar to SetViewModel but finds the new value from the SourceCreator.
Fix issue when a binding destination can't be evaluated at initialization. Since we only reactivate the bindings link to a source in SetViewModel, some bindings were never registered and never executed after the SetViewModel properly set the binding destination.
Update the view class ToString functions with the new flags.
Prevent adding a new binding when the editor data contains a conversion function and a regular function. That may occur when the user started with a regular binding and changed it afterward for a conversion function. We may not want to reset the binding to be non destructive.
#prefligth 6419e837bb1320be412d274d, 641b068aee0aed13479e6ea3

[CL 24750233 by patrick boutot in ue5-main branch]
2023-03-22 13:07:37 -04:00
zahra nikbakht
e206fdedb6 - Move the list of messages (errors, warnings, info) from the bindings themselves to the owning viewmodel.
- Add a border on each MVVM binding row in the list view of bindings that changes color to red/yellow if there is any error/warning for that binding
- detect if a property is bound to both a MVVM binding and a legacy binding at the same time and add a warning for it.
#jira UE-170983
#jira UE-170403
#rb patrick.boutot, vincent.gauthier
#preflight 6414c614ca2afe3ee6b1c7c8

[CL 24695764 by zahra nikbakht in ue5-main branch]
2023-03-17 16:33:42 -04:00
patrick boutot
2c2fa3761b MVVM: Add a global option to allow viewmodel setter function. This prevent the validation for object /Script/CoreUObject.Function.
Add an option to show the detail view in the binding panel. This prevent the bad memory access in the customizer used by a the binding panel.
#preflight 640b5c260e1f02786bff27f5

[CL 24603096 by patrick boutot in ue5-main branch]
2023-03-10 23:20:09 -05:00
patrick boutot
bc181cb231 MVVM: Rename MVVMBlueprintViewBinding.ViewModelPath and WidgetPath to SourePath and DestinationPath. Historicly they were named that way because it made sense to bind grom viewmodel to a widget. Now we can bind from any property to any property. We renamed to remove the confusion.
#test MVVM asset in QAGame
#rb Yohann.DosSantos
#preflight 64089d788c0039bbf73e80d8

[CL 24574634 by patrick boutot in ue5-main branch]
2023-03-09 08:41:28 -05:00
ronald koppers
6f5addd262 Renamed PropertyEditorPermissionList to PropertyPermissionList.
#preflight 63fd04f5c35a14198011368b
#rb Rex.Hill

[CL 24432348 by ronald koppers in ue5-main branch]
2023-02-27 16:27:44 -05:00
patrick boutot
1e1d7865c6 MVVM: Fix access to private UFunction with AllowPrivateAccess.
Fix the IsBindingValid error message that do not include the full property type.
Fix field picker that do not show function when there is no filter.
Support array of object binding (the same way BP does).
#jira UE-164316
#preflight 63ee4b41b5262f41ae2f7594, 63ee50a43c1eb56f052d3b64

[CL 24292264 by patrick boutot in ue5-main branch]
2023-02-17 17:10:33 -05:00
patrick boutot
6fc367cbb6 MVVM: Fix viewmodel rename from the detail panel.
[REVIEW] editor-ui-systems
#jira UE-164316
#preflight 63ee4cf652460c3a1fb03df4

[CL 24291543 by patrick boutot in ue5-main branch]
2023-02-17 16:40:54 -05:00
patrick boutot
fb31ea2d89 MVVM: Test if the properties or functions are allowed at compile time.
#jira UE-164316
#preflight 63eaf47eb91ae11c1cf4ded7, 63ece0c9514832b242a0f66b

[CL 24289488 by patrick boutot in ue5-main branch]
2023-02-17 15:28:46 -05:00
patrick boutot
22dc347766 MVVM: Fix issue with local conversion function introduced with CL24074931
#preflight 63ed059a284e76cdad2207fe

[CL 24251619 by patrick boutot in ue5-main branch]
2023-02-16 01:53:46 -05:00
patrick boutot
e8291c18bd MVVM: Veriry the allowed list when picking a property/function from the field selector.
#jira
#preflight 63e6975bf8244e55a4bab8ed

[CL 24173369 by patrick boutot in ue5-main branch]
2023-02-13 08:39:55 -05:00
patrick boutot
2758a900b9 MVVM: Rename ViewModelResolver to ViewModelContextResolver
#jira UE-171160
#preflight 63e67449bd38b4c5cbe7374e

[CL 24136977 by patrick boutot in ue5-main branch]
2023-02-11 12:38:02 -05:00