Commit Graph

213 Commits

Author SHA1 Message Date
paul chipchase
01ec9a0055 Fix a deadlock when loading the ShooterGame sample from a packaged build.
FChunkCacheWorker::ChunkRequestAvailable could have many threads waiting on it and would only wake up a single thread each time a FChunkBuffer is processed. There would be no guarantee that the correct thread would be woken up or that each thread would be woken a single time, meaning that sooner or later we would end up with the FChunkCacheWorker having no more work to process but a number of threads still idle, waiting on the event to wake them, which would never happen.

Switching to a manually reset event will cause all waiting threads to be woken each time the event is triggered and will make sure that we don't deadlock.
This issue showed up now due to changes else where in the code which resulted in more threads waiting on FChunkCacheWorker than we previously had.

#jira UE-88734
#rb graeme.thornton

[CL 11458603 by paul chipchase in 4.25 branch]
2020-02-17 01:57:02 -05:00
graeme thornton
a224a3f8dd Fix for signature checking related issues
#rb steve.robb


#ROBOMERGE-SOURCE: CL 11303014 via CL 11303031 via CL 11303037 via CL 11303042
#ROBOMERGE-BOT: (v0-11244347)

[CL 11303201 by graeme thornton in Main branch]
2020-02-10 08:11:47 -05:00
Josh Adams
aa9705149b Copying Private-LoadTimes-4.24 stream to Main. Biggest changes are in Materials/Shader memory freezing.
#rb none

[CL 11282608 by Josh Adams in Main branch]
2020-02-06 13:13:41 -05:00
Stefan Boberg
55a8b15f1f Copying //UE4/Dev-Core to Main (//UE4/Main)
#rb none

[CL 11258477 by Stefan Boberg in Main branch]
2020-02-05 14:26:36 -05:00
hongyi yu
a3c2c214a3 Fixing namings of pakchunk index and chunk id.
Name the number in pakchunk file pakchunk index and the number of a platform chunk chunk id to avoid confusion.  Also keep this naming convention consistent across all platform code.



#ROBOMERGE-SOURCE: CL 11131543 via CL 11132441 via CL 11132504
#ROBOMERGE-BOT: (v640-11091645)

[CL 11132564 by hongyi yu in Main branch]
2020-01-28 13:04:23 -05:00
PJ Kack
ef8a7b620e AUTO MERGE
Merging //UE4/Main @ 11112898 to //UE4/Dev-Core (dev-core-l0178)

#rb none

(ushell-p4-mergedown)

[CL 11113593 by PJ Kack in Dev-Core branch]
2020-01-26 11:35:42 -05:00
bob tellez
f1c85990a7 Merging CL#11107546
Partially back out changelist 11106714, only keeping intended merged code

[FYI] Dan.Phillips


#ROBOMERGE-SOURCE: CL 11107908 via CL 11107911
#ROBOMERGE-BOT: (v640-11091645)

[CL 11107914 by bob tellez in Main branch]
2020-01-24 14:39:10 -05:00
dan phillips
02a6949b4d Enable time based pak cache trimming
Allow a read request to tell the pak cache not to keep the memory after the request is completed.
Make virtual textures give up their pak cache memory immediately after loading.
[REVIEW] ben.woodhouse, steve.robb, david.harvey


#ROBOMERGE-OWNER: dan.phillips
#ROBOMERGE-AUTHOR: dan.phillips
#ROBOMERGE-SOURCE: CL 11106543 via CL 11106714 via CL 11106736 via CL 11106740
#ROBOMERGE-BOT: (v640-11091645)

[CL 11106744 by dan phillips in Main branch]
2020-01-24 13:03:34 -05:00
peter knepley
c641faa1e2 Fix crash when FChunkCacheWorker::CheckSignature and FPakPrecacher::DoSignatureCheck fail at the same time in different threads
#ROBOMERGE-SOURCE: CL 11066263 via CL 11066282 via CL 11066285
#ROBOMERGE-BOT: (v637-11041722)

[CL 11066290 by peter knepley in Main branch]
2020-01-20 14:04:52 -05:00
hongyi yu
91463c5fc8 Added public method GetPakchunkLocation(), PrioritizePakchunk() to all platform chunk install and move GetChunkLocation and PrioritizeChunk() to protected.
#rb Justin.Marcus


#ROBOMERGE-SOURCE: CL 11064634 via CL 11064641 via CL 11064653
#ROBOMERGE-BOT: (v637-11041722)

[CL 11064661 by hongyi yu in Main branch]
2020-01-20 11:48:36 -05:00
CarlMagnus Nordin
6abf1ca5c9 Create one IoDispatcher container file per pak file and let the pak file system handle mounting of IoStores
#rb per.larsson

[CL 11027862 by CarlMagnus Nordin in Dev-Core branch]
2020-01-16 06:01:45 -05:00
dan phillips
9087e02a6f Build break fix
#ROBOMERGE-SOURCE: CL 10993418 via CL 10993460 via CL 10993467
#ROBOMERGE-BOT: (v633-10983880)

[CL 10993471 by dan phillips in Main branch]
2020-01-15 11:04:40 -05:00
dan phillips
36fe2f7cab PakCache trim can be based on time
Add some more stats for detecting bad seeks between pak files and contiguous reads
[FYI] ben.woodhouse


#ROBOMERGE-SOURCE: CL 10981267 via CL 10981268 via CL 10981271
#ROBOMERGE-BOT: (v632-10940481)

[CL 10981277 by dan phillips in Main branch]
2020-01-14 09:48:07 -05:00
graeme thornton
25dbaf3292 Moved some macros around to avoid a static analyser issue
#jira UE-86394
#rnx


#ROBOMERGE-SOURCE: CL 10925126 via CL 10925127 via CL 10925128
#ROBOMERGE-BOT: (v626-10872990)

[CL 10925130 by graeme thornton in Main branch]
2020-01-09 05:08:19 -05:00
graeme thornton
7985061d9c Only create the pak platform layer in editor builds if we're in a monolithic builds. A modular build won't have any required decryption keys embedded, so this functionality will be disabled until we have a way of specifying a keychain and loading it.
[FYI] bob.tellez


#ROBOMERGE-SOURCE: CL 10903752 via CL 10903753 via CL 10903755
#ROBOMERGE-BOT: (v626-10872990)

[CL 10903757 by graeme thornton in Main branch]
2020-01-08 08:32:05 -05:00
ryan durand
0f0464a30e Updating copyright for Engine Runtime.
#rnx
#rb none


#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870549 by ryan durand in Main branch]
2019-12-26 14:45:42 -05:00
jamie dale
58c8187567 Deprecated FCoreDelegates::PakFileMountedCallback in favor of FCoreDelegates::OnPakFileMounted, which takes a second argument that specifies the chunk ID of the package (or INDEX_NONE).
#jira
#rb Graeme.Thornton


#ROBOMERGE-SOURCE: CL 10791547 via CL 10791568 via CL 10791573 via CL 10791579 via CL 10791601
#ROBOMERGE-BOT: (v610-10636431)

[CL 10791615 by jamie dale in Main branch]
2019-12-18 08:45:51 -05:00
Martin Wilson
3bd7b3ad4a Fix crash when trying to load files from PAKs in single threaded applications
#jira FORT-234330
#rb Robert.Manuszewski

[CL 10505565 by Martin Wilson in Main branch]
2019-12-04 05:35:03 -05:00
graeme thornton
06b4bd8fa3 Pak platform file changes to support mounting pak files in the editor
- Always look for pak files in the standard locations to determine whether we should create the platform layer
 - When looking up a decryption key, check the registered list for all guids, even empty ones. We want to support pak mounting in non-monolithic builds where we don't have an embedded key.
 - Remove the initialization-time check that the decryption key exists for pak files with an encrypted index. The condition to test is more complex when considering editor pak mounting, and we will get a meaningful error almost immediately afterwards anyway.



#ROBOMERGE-SOURCE: CL 10482630 via CL 10482631
#ROBOMERGE-BOT: (v606-10482310)

[CL 10482632 by graeme thornton in Main branch]
2019-12-02 09:14:45 -05:00
graeme thornton
5f705a8151 Disable filename extension exclusions when using pak files in an editor build
#ROBOMERGE-SOURCE: CL 10473037 via CL 10473041
#ROBOMERGE-BOT: (v595-10452236)

[CL 10473049 by graeme thornton in Main branch]
2019-11-27 12:15:03 -05:00
marc audy
dbcf07a558 Use new inline versions of substring functions
Fix up nearby cases where ESearchCase::CaseSensitive should have been used
#jira
#rnx
#rb

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 10309793 via CL 10309818
#ROBOMERGE-BOT: (v593-10286020)

[CL 10309932 by marc audy in Main branch]
2019-11-19 13:27:07 -05:00
Rolando Caloca
1a30325d6f Copying //UE4/Dev-RenderPlat-Staging@9551419 to //UE4/Main
#rb none
#rnx

[CL 9551447 by Rolando Caloca in Main branch]
2019-10-11 15:33:31 -04:00
Stefan Boberg
1f813eb516 Copying //UE4/Dev-Core to Main (//UE4/Main)
#rb many

[CL 9405827 by Stefan Boberg in Main branch]
2019-10-03 16:26:48 -04:00
steve robb
14cab21e0c Deprecating ARRAY_COUNT and changing it to UE_ARRAY_COUNT.
Replicated from CL# 7924370.

#rb none


#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 9279060 via CL 9279063
#ROBOMERGE-BOT: (v443-9013191)

[CL 9279836 by steve robb in Main branch]
2019-09-28 08:19:35 -04:00
joe barnes
3dc1eda473 [Switch] Updated Disk I/O tracking and analytics.
#rb mickael.gilabert


#ROBOMERGE-SOURCE: CL 9167378 via CL 9167405 via CL 9167407
#ROBOMERGE-BOT: (v443-9013191)

[CL 9167408 by joe barnes in Main branch]
2019-09-26 19:10:42 -04:00